Analysis feryardiant / container #3

Your project gitignore file should not contain user-specific files 2

Read doc
Productivity
Minor

More information: https://insight.symfony.com/what-we-analyse/git.user_specific_ignored_file

in .gitignore, line 3

# Generic
# --------------------------
Thumbs.dbThumbs.db is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.
Time to fix: about 15 minutes
Read doc
                Open Issue
             Permalink

                                    Last edited Wed, 10 Jun 2020 22:00:05 +0000 by Fery Wardiyanto
                    
Desktop.ini
.directory
.DS_Store
._*
*.cache

in .gitignore, line 33

vendor
yarn.lock
# IDE Project Configurations
# --------------------------
.idea.idea is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.
Time to fix: about 15 minutes
Read doc
                Open Issue
             Permalink

                                    Last edited Thu, 11 Jun 2020 11:54:47 +0000 by Fery Wardiyanto
                    
.settings
.vscode
.project
*.sublime-*

Interfaces names should end with "Interface"

Read doc
Productivity
Info

More information: https://insight.symfony.com/what-we-analyse/php.interface_has_no_interface_suffix

in src/Container/ContainerAware.php, line 15

 * Any class implements this interface could have instance of ContainerInterface
 * injected automtically.
 *
 * @package Projek\Container
 */
interface ContainerAwareInterface {{ name }} should be named {{ name }}Interface for better clarity.
Time to fix: about 1 hour
Read doc
                Open Issue
             Permalink

                                    Last edited Mon, 24 May 2021 13:28:14 +0000 by Fery Wardiyanto
                    
{
    /**
     * Assign a container to the instance.
     *
     * @param \Projek\Container $container