Your project should use return types 10
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.missing_return_typehint
- /**
- * Insert inline.
- * e.g.: ++text++ -> <ins>text</ins>.
- */
- protected function inlineInsert($Excerpt)
Method Cecil\Converter\Parsedown::inlineInsert() has no return type specified.
Last edited by Arnaud Ligny- {
- if (!isset($Excerpt['text'][1])) {
- return;
- }
- }
- /**
- * {@inheritdoc}
- */
- protected function inlineLink($Excerpt)
Method Cecil\Converter\Parsedown::inlineLink() has no return type specified.
Last edited by Arnaud Ligny- {
- $link = parent::inlineLink($Excerpt); // @phpstan-ignore staticMethod.notFound
- if (!isset($link)) {
- return null;
- }
- /**
- * {@inheritdoc}
- */
- protected function inlineImage($Excerpt)
Method Cecil\Converter\Parsedown::inlineImage() has no return type specified.
Last edited by Arnaud Ligny- {
- $InlineImage = parent::inlineImage($Excerpt); // @phpstan-ignore staticMethod.notFound
- if (!isset($InlineImage)) {
- return null;
- }
- }
- /**
- * Image block.
- */
- protected function blockImage($Excerpt)
Method Cecil\Converter\Parsedown::blockImage() has no return type specified.
Last edited by Arnaud Ligny- {
- if (1 !== preg_match($this->regexImage, $Excerpt['text'])) {
- return;
- }
- * **Tip:** This is an advice.
- * :::
- *
- * Code inspired by https://github.com/sixlive/parsedown-alert from TJ Miller (@sixlive).
- */
- protected function blockNote($block)
Method Cecil\Converter\Parsedown::blockNote() has no return type specified.
Last edited by Arnaud Ligny- {
- if (preg_match('/:::(.*)/', $block['text'], $matches)) {
- $block = [
- 'char' => ':',
- 'element' => [
- return $block;
- }
- }
- protected function blockNoteContinue($line, $block)
Method Cecil\Converter\Parsedown::blockNoteContinue() has no return type specified.
Last edited by Arnaud Ligny- {
- if (isset($block['complete'])) {
- return;
- }
- if (preg_match('/:::/', $line['text'])) {
- $block['element']['text'] .= $line['text'] . "\n";
- return $block;
- }
- protected function blockNoteComplete($block)
Method Cecil\Converter\Parsedown::blockNoteComplete() has no return type specified.
Last edited by Arnaud Ligny- {
- $block['element']['rawHtml'] = $this->text($block['element']['text']);
- unset($block['element']['text']);
- return $block;
- }
- /**
- * Apply Highlight to code blocks.
- */
- protected function blockFencedCodeComplete($block)
Method Cecil\Converter\Parsedown::blockFencedCodeComplete() has no return type specified.
Last edited by Arnaud Ligny- {
- if (!(bool) $this->config->get('pages.body.highlight.enabled')) {
- return $block;
- }
- if (!isset($block['element']['text']['attributes'])) {
- }
- /**
- * {@inheritdoc}
- */
- protected function parseAttributeData($attributeString)
Method Cecil\Converter\Parsedown::parseAttributeData() has no return type specified.
Last edited by Arnaud Ligny- {
- $attributes = preg_split('/[ ]+/', $attributeString, -1, PREG_SPLIT_NO_EMPTY);
- $Data = [];
- $HtmlAtt = [];
- }
- /**
- * Adds global variables.
- */
- protected function addGlobals()
Method Cecil\Step\Pages\Render::addGlobals() has no return type specified.
Last edited by Arnaud Ligny- {
- $this->builder->getRenderer()->addGlobal('cecil', [
- 'url' => \sprintf('https://cecil.app/#%s', Builder::getVersion()),
- 'version' => Builder::getVersion(),
- 'poweredby' => \sprintf('Cecil v%s', Builder::getVersion()),
Your project uses discouraged functions to kill scripts
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.use_exit_function
- if ($this->io === null) {
- $this->io = new SymfonyStyle($input, $output);
- }
- $this->io->error($e->getMessage());
- exit(1);
This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
Last edited by Arnaud Ligny- }
- }
- /**
- * Returns the working path.
Your project uses the sleep function, which could introduce timeouts
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.use_php_sleep_function
- if ($open) {
- $output->writeln('Opening web browser...');
- Util\Plateform::openBrowser(\sprintf('http://%s:%s', $host, $port));
- }
- while ($process->isRunning()) {
- sleep(1); // wait for server is ready
sleep()may create timeouts without even protecting your application.Last edited by Arnaud Ligny- if (!fsockopen($host, (int) $port)) {
- $output->writeln('<info>Server is not ready.</info>');
- return 1;
- }
Your project templates should not be too long
- Read doc
- Productivity
- Minor
More information: https://insight.symfony.com/what-we-analyse/twig.template_too_long
- resources/layouts/partials/new.css.twig is 386 lines long
- resources/…/partials/metatags.html.twig is 208 lines long
narno