ClicShopping #383

    ];
    $cli = null;
    if (function_exists('shell_exec')) {
      $out = @shell_exec('php -r ' . escapeshellarg('echo (int)extension_loaded("apcu"), ",", (int)ini_get("apc.enabled"), ",", (int)ini_get("apc.enable_cli"), ",", (int)(function_exists("apcu_enabled") && apcu_enabled());') . ' 2>/dev/null');

    
shell_exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    

                    
Time to fix: about 4 hours
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            

            

                                    Last edited Tue, 01 Sep 2026 11:23:07 +0000 by clicshopping
                    
                            
        
    
      if (is_string($out) && substr_count($out, ',') === 3) {
        [$loaded, $enabled, $enable_cli, $usable] = explode(',', trim($out));
        $cli = [
          'loaded' => (bool)$loaded,

  {
    if (!$this->isEnabled()) {
      return $this->skip($this->app->getDef('skip_module_disabled'));
    }
    if (!in_array($invoice_status, [self::STATUS_INVOICE, self::STATUS_CANCEL, self::STATUS_CREDIT_NOTE])) {

    
in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    

                    
Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            

            

                                    Last edited Wed, 02 Sep 2026 13:14:18 +0000 by clicshopping
                    
                            
        
    
      return $this->skip($this->app->getDef('skip_status_not_actionable') . ' (' . $invoice_status . ')');
    }
    if ($this->isAlreadySent($order_id)) {
      return $this->skip($this->app->getDef('skip_already_sent') . ' #' . $order_id);

      $msg = $this->app->getDef('error_oauth2_failed') . ' #' . $order_id;
      $this->writeOrderHistory($order_id, '[ERROR] ' . $msg, false);
      return $this->failure($msg);
    }
    $doc_type = in_array($invoice_status, [self::STATUS_CANCEL, self::STATUS_CREDIT_NOTE]) ? self::TYPE_CREDIT_NOTE : self::TYPE_INVOICE;

    
in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    

                    
Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            

            

                                    Last edited Wed, 02 Sep 2026 13:14:18 +0000 by clicshopping
                    
                            
        
    
    $payload = $this->buildPayload($order_id, $customer, $info, $products, $totals, $doc_type);
    if ($payload === null) {
      $msg = $this->app->getDef('error_payload_failed');
      $this->writeOrderHistory($order_id, '[ERROR] ' . $msg, false);

            } elseif ($already_sent) {
              $content .= '
                            <span class="badge bg-success">' . $this->app->getDef('badge_transmitted') . '</span>
                            &nbsp;<span class="text-success small">' . $this->app->getDef('text_transmitted_notice') . '</span>
            ';
            } elseif (!in_array($current_invoice_status_id, [EInvoiceService::STATUS_INVOICE, EInvoiceService::STATUS_CANCEL, EInvoiceService::STATUS_CREDIT_NOTE])) {

    
in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    

                    
Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            

            

                                    Last edited Thu, 03 Sep 2026 07:16:30 +0000 by clicshopping
                    
                            
        
    
            $content .= '
                            <span class="badge bg-warning text-dark">' . $this->app->getDef('badge_pending') . '</span>
                            &nbsp;<span class="text-muted small">' . $this->app->getDef('text_pending_notice') . '</span>
            ';
            } else {

    if ($this->previousInvoiceStatus() === $new_invoice_status) {
      return false;
    }
    // Only process actionable statuses
    if (!in_array($new_invoice_status, [

    
in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    

                    
Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            

            

                                    Last edited Wed, 02 Sep 2026 13:14:18 +0000 by clicshopping
                    
                            
        
    
      EInvoiceService::STATUS_INVOICE,
      EInvoiceService::STATUS_CANCEL,
      EInvoiceService::STATUS_CREDIT_NOTE,
    ])) {
      return false;