Analysis gyakutsuki / ClicShopping #380

Your project uses non-strict array lookups 5

Read doc
Reliability
Major

More information: https://insight.symfony.com/what-we-analyse/php.strict_array_lookup

in Core/ClicShopping/Apps/Configuration/ChatGpt/Sites/ClicShoppingAdmin/Pages/Home/Actions/ChatGpt/RecordFeedback.php, line 51

        exit;
      }
      
      // Validate feedback_type
      $validTypes = ['positive', 'negative', 'correction'];
      if (!in_array($input['feedback_type'], $validTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    
                    Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            
            
                                    Last edited Sun, 02 Aug 2026 07:34:40 +0000 by clicshopping
                    
                            
        
    
        echo json_encode([
          'success' => false,
          'error' => 'feedback_type must be one of: ' . implode(', ', $validTypes)
        ]);
        exit;

in Core/ClicShopping/Apps/Configuration/CompliancePolicyRules/Module/ClicShoppingAdmin/Config/CAD/CAD.php, line 84

  public function uninstall()
  {
    parent::uninstall();
    $installed = explode(';', MODULE_MODULES_COMPLIANCE_POLICY_RULES_INSTALLED);
    $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    
                    Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            
            
                                    Last edited Fri, 21 Aug 2026 15:33:21 +0000 by clicshopping
                    
                            
        
    
    if ($installed_pos !== false) {
      unset($installed[$installed_pos]);
      $this->app->saveCfgParam('MODULE_MODULES_COMPLIANCE_POLICY_RULES_INSTALLED', implode(';', $installed));

in Core/ClicShopping/Apps/Configuration/CompliancePolicyRules/Module/ClicShoppingAdmin/Config/CPR/CPR.php, line 85

  public function uninstall()
  {
    parent::uninstall();
    $installed = explode(';', MODULE_MODULES_COMPLIANCE_POLICY_RULES_INSTALLED);
    $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    
                    Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            
            
                                    Last edited Fri, 21 Aug 2026 15:33:21 +0000 by clicshopping
                    
                            
        
    
    if ($installed_pos !== false) {
      unset($installed[$installed_pos]);
      $this->app->saveCfgParam('MODULE_MODULES_COMPLIANCE_POLICY_RULES_INSTALLED', implode(';', $installed));

in Core/ClicShopping/Apps/Configuration/CompliancePolicyRules/Module/ClicShoppingAdmin/Config/FRE/FRE.php, line 84

  public function uninstall()
  {
    parent::uninstall();
    $installed = explode(';', MODULE_MODULES_COMPLIANCE_POLICY_RULES_INSTALLED);
    $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    
                    Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            
            
                                    Last edited Fri, 21 Aug 2026 15:33:21 +0000 by clicshopping
                    
                            
        
    
    if ($installed_pos !== false) {
      unset($installed[$installed_pos]);
      $this->app->saveCfgParam('MODULE_MODULES_COMPLIANCE_POLICY_RULES_INSTALLED', implode(';', $installed));

in Core/ClicShopping/Apps/Configuration/Modules/Classes/ClicShoppingAdmin/ModulesAdmin.php, line 93

    $Qcheck = $CLICSHOPPING_Db->get('configuration', 'configuration_value', ['configuration_key' => 'TEMPLATE_BLOCK_GROUPS']);
    if ($Qcheck->fetch() !== false) {
      $tbgroups_array = explode(';', $Qcheck->value('configuration_value'));
      if (!\in_array($module_type, $tbgroups_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    
                    Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            
            
                                    Last edited Mon, 17 Aug 2026 08:41:30 +0000 by clicshopping
                    
                            
        
    
        $tbgroups_array[] = $module_type;
        sort($tbgroups_array);
        $CLICSHOPPING_Db->save('configuration', [
          'configuration_value' => implode(';', $tbgroups_array),

Your project should not contain PHP files defining multiple classes

Read doc
Productivity
Info

More information: https://insight.symfony.com/what-we-analyse/php.file_contains_more_than_one_class

in sources/template/Default/modules/modules_header/he_header_multi_template.php

This file contains 2 classes. Keeping only one class per file is a standard in the PHP community, since it promotes interoperability and maintainability.

Time to fix: about 4 hours

Read doc Open Issue Permalink Copy Prompt

he_header_multi_template (defined at line 14)
explodeCategoryTree (defined at line 230)

Your project uses legacy callable syntax instead of first-class callable syntax 2

Read doc
Productivity
Info

More information: https://insight.symfony.com/what-we-analyse/php.use_first_class_callable_syntax

in Core/ClicShopping/AI/DomainsAI/Shared/Entity/EntityRegistry.php, line 311

   */
  private function deriveNameFromTable(string $tableName): string
  {
    $prefix = CLICSHOPPING::getConfig('db_table_prefix');
    return str_replace([$prefix, '_embedding'], '', $tableName);
    Use the first-class callable syntax ($this->method(...))
    
                    Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            
            
                                    Last edited Sun, 26 Jul 2026 16:26:33 +0000 by clicshopping
                    
                            
        
    
  }
  /**
   * Classify every known table as entity / satellite / system
   *

in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ResponseProcessor.php, line 334

          substr($result, 0, 100)
        ));
      }
      // Extract usage metrics. 
      $lastResponse = is_callable([$chat, 'getLastResponse']) ? $chat->getLastResponse() : null;
    Use the first-class callable syntax ($this->method(...))
    
                    Time to fix: about 15 minutes
                Read doc
                                    
                
                Open Issue
            
                 Permalink
         Copy Prompt
    

            
            
                                    Last edited Mon, 27 Jul 2026 10:16:10 +0000 by clicshopping
                    
                            
        
    
      if (!is_null($lastResponse) && isset($lastResponse['usage'])) {
        self::$lastTokenUsage = [
          'prompt_tokens' => $lastResponse['usage']['prompt_tokens'] ?? 0,
          'completion_tokens' => $lastResponse['usage']['completion_tokens'] ?? 0,

ClicShopping #380

SymfonyInsight detected 18 upgrade issues in your project.

Your project uses non-strict array lookups 5

Your project should not contain PHP files defining multiple classes

Your project uses legacy callable syntax instead of first-class callable syntax 2