Your project should not commit sensitive files to the repository

More information: https://insight.symfony.com/what-we-analyse/git.sensitive_file_committed

New rule! We've recently added this rule to Insight. Don't be surprised to see new suggestions even though the codebase didn't change.
in Core/ClicShopping/External
The sensitive file cacert.pem is committed to the repository and may expose credentials or private keys.
Time to fix: about 2 hours
Read doc Open Issue Permalink Copy Prompt
Collective
  • Core/ClicShopping/External
    • vendor
    • CommonCurrencies.json
    • PasswordHash.php
    • cacert.pem

      The sensitive file cacert.pem is committed to the repository and may expose credentials or private keys.

    • cert_key_pem_paypal.txt
    • update-cacert.sh
  • gyakutsuki

    Ignored on Wed, 22 Apr 2026 12:34:13 GMT

Your project uses dangerous command injection functions 16

More information: https://insight.symfony.com/what-we-analyse/php.use_command_injection_function

New rule! We've recently added this rule to Insight. Don't be surprised to see new suggestions even though the codebase didn't change.
in Core/ClicShopping/Apps/Tools/Backup/Classes/ClicShoppingAdmin/Backup.php, line 348 
  1.     }
  3.     if (isset($_POST['download'])) {
  4.       switch ($compress) {
  5.         case 'gzip':
  6.           exec(LOCAL_EXE_GZIP . ' ' . $backup_directory . $backup_file);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $backup_file .= '.gz';
  8.           break;
  9.         case 'zip':
  10.           exec(LOCAL_EXE_ZIP . ' -j ' . $backup_directory . $backup_file . '.zip ' . $backup_directory . $backup_file);
  11.           unlink($backup_directory . $backup_file);
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Apps/Tools/Backup/Classes/ClicShoppingAdmin/Backup.php, line 352 
  1.         case 'gzip':
  2.           exec(LOCAL_EXE_GZIP . ' ' . $backup_directory . $backup_file);
  3.           $backup_file .= '.gz';
  4.           break;
  5.         case 'zip':
  6.           exec(LOCAL_EXE_ZIP . ' -j ' . $backup_directory . $backup_file . '.zip ' . $backup_directory . $backup_file);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           unlink($backup_directory . $backup_file);
  8.           $backup_file .= '.zip';
  9.       }
  11.       header('Content-type: application/x-octet-stream');
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Apps/Tools/Backup/Classes/ClicShoppingAdmin/Backup.php, line 367 
  2.       exit;
  3.     } else {
  4.       switch ($compress) {
  5.         case 'gzip':
  6.           exec(LOCAL_EXE_GZIP . ' ' . $backup_directory . $backup_file);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           break;
  8.         case 'zip':
  9.           exec(LOCAL_EXE_ZIP . ' -j ' . $backup_directory . $backup_file . '.zip ' . $backup_directory . $backup_file);
  10.           unlink($backup_directory . $backup_file);
  11.       }
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Apps/Tools/Backup/Classes/ClicShoppingAdmin/Backup.php, line 370 
  1.       switch ($compress) {
  2.         case 'gzip':
  3.           exec(LOCAL_EXE_GZIP . ' ' . $backup_directory . $backup_file);
  4.           break;
  5.         case 'zip':
  6.           exec(LOCAL_EXE_ZIP . ' -j ' . $backup_directory . $backup_file . '.zip ' . $backup_directory . $backup_file);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           unlink($backup_directory . $backup_file);
  8.       }
  10.       $CLICSHOPPING_MessageStack->add(CLICSHOPPING::getDef('success_database_saved'), 'success');
  11.     }
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Apps/Tools/Backup/Sites/ClicShoppingAdmin/Pages/Home/Actions/Backup/RestoreNow.php, line 48 
  1.             $restore_from = $restore_file;
  2.             $remove_raw = false;
  3.             break;
  4.           case '.gz':
  5.             $restore_from = substr($restore_file, 0, -3);
  6.             exec(LOCAL_EXE_GUNZIP . ' ' . $restore_file . ' -c > ' . $restore_from);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             $remove_raw = true;
  8.             break;
  9.           case 'zip':
  10.             $restore_from = substr($restore_file, 0, -4);
  11.             exec(LOCAL_EXE_UNZIP . ' ' . $restore_file . ' -d ' . $backup_directory);
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Apps/Tools/Backup/Sites/ClicShoppingAdmin/Pages/Home/Actions/Backup/RestoreNow.php, line 53 
  1.             exec(LOCAL_EXE_GUNZIP . ' ' . $restore_file . ' -c > ' . $restore_from);
  2.             $remove_raw = true;
  3.             break;
  4.           case 'zip':
  5.             $restore_from = substr($restore_file, 0, -4);
  6.             exec(LOCAL_EXE_UNZIP . ' ' . $restore_file . ' -d ' . $backup_directory);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             $remove_raw = true;
  8.         }
  10.         if (isset($restore_from) && is_file($restore_from) && filesize($restore_from) > 15000) {
  11.           $fd = fopen($restore_from, 'rb');
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Apps/Tools/MCP/Classes/ClicShoppingAdmin/Transport/StdioTransport.php, line 126 
  1.       2 => ["pipe", "w"]   // stderr
  2.     ];
  4.     $this->logger->info('Starting MCP server process', ['command' => $command]);
  6.     $this->process = proc_open($command, $descriptorspec, $this->pipes);
    proc_open() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if (!is_resource($this->process)) {
  9.       $this->logger->error('Failed to start MCP server process', ['command' => $command]);
  10.       throw new McpConnectionException('Failed to start MCP server process');
  11.     }
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/OM/CLICSHOPPING.php, line 865 
  1.     $CLICSHOPPING_Db = Registry::get('Db');
  3.     $Qdate = $CLICSHOPPING_Db->query('select now() as datetime');
  5.     try {
  6.       [$system, $host, $kernel] = preg_split('/[\s,]+/', @exec('uname -a'), 5);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     } catch (\Throwable $e) {
  8.       $system = $host = $kernel = 'unavailable';
  9.     }
  11.     try {
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/OM/CLICSHOPPING.php, line 871 
  1.     } catch (\Throwable $e) {
  2.       $system = $host = $kernel = 'unavailable';
  3.     }
  5.     try {
  6.       $uptime = @exec('uptime');
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     } catch (\Throwable $e) {
  8.       $uptime = 'unavailable';
  9.     }
  11.     try {
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Sites/ClicShoppingAdmin/Composer.php, line 73 
  1.     if (!self::checkExecEnabled()) {
  2.       return false;
  3.     }
  5.     $cmd = 'cd ' . escapeshellarg(self::$root) . ' && composer --no-ansi --no-interaction show 2>/dev/null';
  6.     exec($cmd, $output, $return);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     return $return === 0;
  9.   }
  11.   /**
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Sites/ClicShoppingAdmin/Composer.php, line 91 
  1.   if (is_null($library) || !self::checkExecute()) {
  2.     return false;
  3.   }
  5.   $cmd = 'cd ' . escapeshellarg(self::$root) . ' && composer show ' . escapeshellarg($library) . ' 2>/dev/null';
  6.   exec($cmd, $output, $return);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.   return $return === 0;
  9. }
  10.   /**
  11.    * Verifies if the necessary conditions for executing commands are met.
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Sites/ClicShoppingAdmin/Composer.php, line 132 
  1.     if (!self::checkExecute() || is_null($library)) {
  2.       return false;
  3.     }
  5.     $cmd = 'cd ' . escapeshellarg(self::$root) . ' && composer show ' . escapeshellarg($library) . ' 2>/dev/null';
  6.     exec($cmd, $output, $return);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($return === 0 && !empty($output)) {
  9.       // Recherche la ligne contenant la version
  10.       foreach ($output as $line) {
  11.         if (str_starts_with($line, 'versions')) {
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Sites/ClicShoppingAdmin/Composer.php, line 184 
  1.   if ($library !== null) {
  2.     $cmd .= ' ' . escapeshellarg($library);
  3.   }
  4.   $cmd .= ' 2>&1';
  6.   exec($cmd, $output, $return);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.   // Retourne toute la sortie pour plus d'informations, ou une chaîne vide si rien
  9.   return !empty($output) ? implode("\n", $output) : '';
  10. }
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Sites/ClicShoppingAdmin/Composer.php, line 204 
  1.   if (!self::checkExecute() || is_null($library)) {
  2.     return false;
  3.   }
  5.   $cmd = 'cd ' . escapeshellarg(self::$root) . ' && composer require ' . escapeshellarg($library) . ' 2>&1';
  6.   exec($cmd, $output, $return);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.   return !empty($output) ? implode("\n", $output) : '';
  9. }
  11.   /**
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Sites/ClicShoppingAdmin/Composer.php, line 223 
  1.     if (!self::checkExecute() || is_null($library)) {
  2.       return '';
  3.     }
  5.     $cmd = 'cd ' . escapeshellarg(self::$root) . ' && composer remove ' . escapeshellarg($library) . ' 2>&1';
  6.     exec($cmd, $output, $return);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     return !empty($output) ? implode("\n", $output) : '';
  9.   }
  11.   /**
  • gyakutsuki

    not vulnerabilities here
in Core/ClicShopping/Sites/ClicShoppingAdmin/Composer.php, line 240 
  1.     if (!self::checkExecute()) {
  2.       return '';
  3.     }
  5.     $cmd = 'cd ' . escapeshellarg(self::$root) . ' && composer clearcache 2>&1';
  6.     exec($cmd, $output, $return);
    exec() is vulnerable to command injection attacks. Use the Symfony Process component instead.
    Time to fix: about 4 hours
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     // Retourne toute la sortie pour plus d'informations, ou une chaîne vide si rien
  9.     return !empty($output) ? implode("\n", $output) : '';
  10.   }
  11. }
  • gyakutsuki

    not vulnerabilities here

Your project uses non-strict array lookups 296

More information: https://insight.symfony.com/what-we-analyse/php.strict_array_lookup

in Core/ClicShopping/Sites/ClicShoppingAdmin/Composer.php, line 53 
  1.    */
  2.   public static function checkExecEnabled(): bool
  3.   {
  4.     $disabled = explode(', ', ini_get('disable_functions'));
  6.     return !in_array('exec', $disabled);
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  9.   /**
  10.    * Checks if Composer is installed and accessible in the current environment.
  11.    *
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/record_feedback.php, line 62 
  1.     exit;

  2.   }

  4.   // Validate feedback_type

  5.   $validTypes = ['positive', 'negative', 'correction'];

  6.   if (!in_array($input['feedback_type'], $validTypes)) {

    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     echo json_encode([

  8.       'success' => false,

  9.       'error' => 'feedback_type must be one of: ' . implode(', ', $validTypes)

  10.     ]);

  11.     exit;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 54 
  1.   $errors = [];
  3.   // ============================================================================
  4.   // 1. Reset Translation Cache
  5.   // ============================================================================
  6.   if (in_array('translations', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       $translationCache = new TranslationCache();
  10.       // Count files before
  11.       $cacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Translation/';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 102 
  1.   }
  3.   // ============================================================================
  4.   // 3. Reset Classification Cache
  5.   // ============================================================================
  6.   if (in_array('classification', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       $classificationCache = new ClassificationCache();
  10.       // Get stats before
  11.       $statsBefore = $classificationCache->getStatistics();
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 130 
  1.   }
  3.   // ============================================================================
  4.   // 3. Reset Database Query Cache
  5.   // ============================================================================
  6.   if (in_array('database', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       $db = Registry::get('Db');
  9.       $prefix = CLICSHOPPING::getConfig('db_table_prefix');
  11.       // Count entries before
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 159 
  1.   }
  3.   // ============================================================================
  4.   // 4. Reset Schema Query Cache (TASK 5 - ITEM 1)
  5.   // ============================================================================
  6.   if (in_array('schema', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       // Count schema cache files before (new location)
  9.       $schemaCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/SchemaQuery/';
  10.       $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 211 
  1.   }
  3.   // ============================================================================
  4.   // 5. Reset Intent Classification Cache (TASK 5.1.7.6)
  5.   // ============================================================================
  6.   if (in_array('intent', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       // Count intent cache files before (new location - all files)
  9.       $intentCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Intent/';
  10.       $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 263 
  1.   }
  3.   // ============================================================================
  4.   // 6. Reset Ambiguity Cache (TASK 4 - Cache Migration)
  5.   // ============================================================================
  6.   if (in_array('ambiguity', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       // Count ambiguity cache files before (new location - all files)
  9.       $ambiguityCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Ambiguity/';
  10.       $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 331 
  1.   }
  3.   // ============================================================================
  4.   // 7. Reset Translation Ambiguity Cache
  5.   // ============================================================================
  6.   if (in_array('translation_ambiguity', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       // Count translation ambiguity cache files before (new location)
  9.       $translationAmbiguityCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Translation/';
  10.       $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 383 
  1.   }
  3.   // ============================================================================
  4.   // 8. Reset Context Cache
  5.   // ============================================================================
  6.   if (in_array('context', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       // Count context cache files before (new location)
  9.       $contextCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Context/';
  10.       $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 441 
  1.   }
  3.   // ============================================================================
  4.   // 8.5. Reset Memory Cache (file-based)
  5.   // ============================================================================
  6.   if (in_array('memory', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       $memoryCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Memory/';
  9.       $filesBefore = 0;
  11.       if (is_dir($memoryCacheDir)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 469 
  1.   }
  3.   // ============================================================================
  4.   // 9. Reset Embedding Cache
  5.   // ============================================================================
  6.   if (in_array('embedding', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       // Count embedding cache files before (new location)
  9.       $embeddingCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Embedding/';
  10.       $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 534 
  1.   }
  3.   // ============================================================================
  4.   // 10. Reset EmbeddingSearch Cache
  5.   // ============================================================================
  6.   if (in_array('embedding_search', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       // Count embedding search cache files before (new location)
  9.       $embeddingSearchCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/EmbeddingSearch/';
  10.       $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 610 
  1.   }
  3.   // ============================================================================
  4.   // 11. Reset Hybrid Query Cache (TASK 8: Multi-temporal query caching)
  5.   // ============================================================================
  6.   if (in_array('hybrid', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     try {
  8.       // Count hybrid cache files before
  9.       $hybridCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Hybrid/';
  10.       $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 645 
  1.     }
  3.     // ============================================================================
  4.     // 12. Reset Semantic Query Cache (TASK 8: Multi-temporal query caching)
  5.     // ============================================================================
  6.     if (in_array('semantic', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       try {
  8.         // Count hybrid cache files before
  9.         $semanticCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Semantic/';
  10.         $filesBefore = 0;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 693 
  1.     }
  3.     // ============================================================================
  4.     // 13. Reset Embeddings Cache (PHASE 2 - NewVector cache)
  5.     // ============================================================================
  6.     if (in_array('embeddings', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       try {
  8.         $embeddingsCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Embeddings/';
  9.         $filesBefore = 0;
  11.         if (is_dir($embeddingsCacheDir)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 756 
  1.     }
  3.     // ============================================================================
  4.     // 14. Reset SQL Query Cache (PHASE 4)
  5.     // ============================================================================
  6.     if (in_array('sql', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       try {
  8.         $sqlCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/SQL/';
  9.         $filesBefore = 0;
  11.         if (is_dir($sqlCacheDir)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 781 
  1.     }
  3.     // ============================================================================
  4.     // 15. Reset Security Cache
  5.     // ============================================================================
  6.     if (in_array('security', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       try {
  8.         $securityCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Security/';
  9.         $filesBefore = 0;
  11.         if (is_dir($securityCacheDir)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 806 
  1.     }
  3.     // ============================================================================
  4.     // 16. Reset Reputation Cache
  5.     // ============================================================================
  6.     if (in_array('reputation', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       try {
  8.         $reputationCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Reputation/';
  9.         $filesBefore = 0;
  11.         if (is_dir($reputationCacheDir)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 831 
  1.     }
  3.     // ============================================================================
  4.     // 17. Reset Config Cache
  5.     // ============================================================================
  6.     if (in_array('config', $cacheTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       try {
  8.         $configCacheDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Work/Cache/Rag/Config/';
  9.         $filesBefore = 0;
  11.         if (is_dir($configCacheDir)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Memory/WorkingMemory.php, line 223 
  1.     unset($this->storage[$scopedKey]);
  2.     unset($this->metadata[$scopedKey]);
  4.     // Remove from the scope's key list
  5.     $scopeKeys = $this->scopes[$this->currentScope] ?? [];
  6.     $index = array_search($scopedKey, $scopeKeys);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($index !== false) {
  9.       array_splice($this->scopes[$this->currentScope], $index, 1);
  10.     }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubAutonomous/ConflictDetector.php, line 295 
  2.     // Use higher priority
  3.     $priorities = ['low' => 1, 'medium' => 2, 'high' => 3, 'critical' => 4];
  4.     $priority1 = $priorities[$obj1->getPriority()];
  5.     $priority2 = $priorities[$obj2->getPriority()];
  6.     $combinedPriority = array_search(max($priority1, $priority2), $priorities);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     // Estimate combined time (not just sum, as there may be synergies)
  9.     $estimatedTime = (int)(($obj1->getEstimatedCompletionTime() + $obj2->getEstimatedCompletionTime()) * 0.8);
  11.     return [
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Hybrid/Processor/ResultSynthesizer.php, line 515 
  1.   private function translateMonthName(string $monthName, string $languageCode): string
  2.   {
  3.     $englishMonths = ['January', 'February', 'March', 'April', 'May', 'June',
  4.                       'July', 'August', 'September', 'October', 'November', 'December'];
  6.     $monthIndex = array_search(ucfirst(strtolower($monthName)), $englishMonths);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     if ($monthIndex === false) {
  8.       return $monthName; // Return as-is if not found
  9.     }
  11.     $targetMonths = $this->getMonthNames($languageCode);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/AnalyticsConfig.php, line 148 
  1.         if ($field === $idColumn) {
  2.           return true;
  3.         }
  5.         // Exclude system timestamp fields
  6.         if (in_array($field, ['created_at', 'updated_at', 'deleted_at'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           return false;
  8.         }
  10.         // Get column type
  11.         $type = $columnTypes[$field] ?? 'string';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/AnalyticsConfig.php, line 156 
  2.         // Get column type
  3.         $type = $columnTypes[$field] ?? 'string';
  5.         // Include numeric columns (for aggregation)
  6.         if (in_array($type, ['int', 'bigint', 'smallint', 'decimal', 'float', 'double'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           return true;
  8.         }
  10.         // Include date/timestamp columns (for temporal analysis)
  11.         if (in_array($type, ['date', 'datetime', 'timestamp', 'time'])) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/AnalyticsConfig.php, line 161 
  1.         if (in_array($type, ['int', 'bigint', 'smallint', 'decimal', 'float', 'double'])) {
  2.           return true;
  3.         }
  5.         // Include date/timestamp columns (for temporal analysis)
  6.         if (in_array($type, ['date', 'datetime', 'timestamp', 'time'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           return true;
  8.         }
  10.         // Include text columns (for filtering and grouping)
  11.         if (in_array($type, ['varchar', 'char', 'text', 'enum'])) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/AnalyticsConfig.php, line 166 
  1.         if (in_array($type, ['date', 'datetime', 'timestamp', 'time'])) {
  2.           return true;
  3.         }
  5.         // Include text columns (for filtering and grouping)
  6.         if (in_array($type, ['varchar', 'char', 'text', 'enum'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           return true;
  8.         }
  10.         // Exclude everything else (binary, blob, json, etc.)
  11.         return false;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/CockpitAI/RecommendationEngine.php, line 193 
  1.           // Prefer 'normalized'; fall back to 'normalized_value' for forward-compat
  2.           $scoreDescription = (float) ($factor['normalized'] ?? $factor['normalized_value'] ?? 0.0);
  3.         }
  4.       }
  6.       $finalQuadrant = in_array($quadrant, ['Q1', 'Q2', 'Q3', 'Q4']) ? $quadrant : 'Q_intermediate';
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.       return [
  9.         'quadrant'          => $finalQuadrant,
  10.         'score_x'           => (float) ($scoreXResult['score'] ?? 0.0),
  11.         'score_y'           => (float) ($scoreYResult['score'] ?? 0.0),
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/EntityConfig.php, line 125 
  1.       $fields = DoctrineOrm::getTableColumns($tableName);
  3.       // Exclude only ID and system timestamp fields
  4.       return array_values(array_filter($fields, function($field) use ($idColumn) {
  5.         return $field !== $idColumn 
  6.           && !in_array($field, ['created_at', 'updated_at', 'deleted_at']);
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       }));
  9.     } catch (\Exception $e) {
  10.       return [];
  11.     }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/SEO/SeoReport.php, line 176 
  1.         $words = preg_split('/[\s,.:;!?"()]+/u', mb_strtolower($onlyText), -1, PREG_SPLIT_NO_EMPTY);
  2.         $grammar = $this->grammar();
  3.         $counts = [];
  4.         foreach ($words as $w) {
  5.           $w = preg_replace('/[^\p{L}\p{N}\-]/u', '', $w);
  6.           if (mb_strlen($w) > 2 && !in_array($w, $grammar)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $counts[$w] = ($counts[$w] ?? 0) + 1;
  8.           }
  9.         }
  10.         arsort($counts);
  11.         $report['wordcountmax'] = array_slice($counts, 0, 8, true);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/Shop/ACP/GptRetailersOpenAI.php, line 978 
  1.             $productData = $this->getProductData($productId);
  2.             if ($productData && !$productData['in_stock']) {
  3.                 $messages[] = [
  4.                     'type' => 'error',
  5.                     'code' => 'out_of_stock',
  6.                     'param' => '$.line_items[' . array_search($lineItem, $lineItems) . ']',
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                     'content_type' => 'plain',
  8.                     'content' => 'Produit ' . $productData['title'] . ' temporairement indisponible'
  9.                 ];
  10.             }
  11. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Module/ClicShoppingAdmin/Config/ACP/ACP.php, line 66 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ECOMMERCE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ECOMMERCE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Module/ClicShoppingAdmin/Config/CAI/CAI.php, line 76 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ECOMMERCE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ECOMMERCE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Module/ClicShoppingAdmin/Config/EC/EC.php, line 77 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ECOMMERCE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ECOMMERCE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Module/ClicShoppingAdmin/Config/UCP/UCP.php, line 66 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ECOMMERCE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ECOMMERCE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4. }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Archive/Module/ClicShoppingAdmin/Config/AR/AR.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_ARCHIVE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_ARCHIVE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Archive/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Categories/Classes/Common/CategoryCommon.php, line 41 
  1. // make sure no duplicate category IDs exist which could lock the server in a loop
  2.     $tmp_array = [];
  3.     $n = count($cPath_array);
  5.     for ($i = 0; $i < $n; $i++) {
  6.       if (!in_array($cPath_array[$i], $tmp_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $tmp_array[] = $cPath_array[$i];
  8.       }
  9.     }
  11.     return $tmp_array;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Categories/Classes/Shop/CategoryTree.php, line 217 
  2.         $category_name = $this->getCategoryTreeTitle($category['name']);
  4.         $categories_url = $this->getCategoryTreeUrl($category_link);
  6.         if (($this->follow_cpath === true) && in_array($category_id, $this->cpath_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $link_title = $this->cpath_start_string . $category_name . $this->cpath_end_string;
  8.         } else {
  9.           $link_title = $category_name;
  10.         }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Categories/Classes/Shop/CategoryTree.php, line 241 
  1.           $result .= $this->parent_end_string;
  2.         }
  4.         if (isset($this->_data[$category_id]) && (($this->max_level == '0') || ($this->max_level > $level + 1))) {
  5.           if ($this->follow_cpath === true) {
  6.             if (in_array($category_id, $this->cpath_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               $result .= $this->_buildBranch($category_id, $level + 1);
  8.             }
  9. } else {
  10.             $result .= $this->_buildBranch($category_id, $level + 1);
  11.           }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Categories/Module/ClicShoppingAdmin/Config/CT/CT.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_CATEGORIES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_CATEGORIES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Categories/Sites/ClicShoppingAdmin/Pages/Home/Actions/Categories/MoveConfirm.php, line 58 
  1.       $categories_id = HTML::sanitize($this->Id);
  2.       $new_parent_id = HTML::sanitize($this->moveToCategoryID);
  4.       $path = explode('_', $this->categoriesAdmin->getGeneratedCategoryPathIds($new_parent_id));
  6.       if (\in_array($this->Id, $path)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $CLICSHOPPING_MessageStack->add($this->app->getDef('error_cannot_move_directory_to_parent'), 'error');
  9.         $this->app->redirect('Categories&cPath=' . $this->cPath . '&cID=' . $categories_id);
  10.       } else {
  11.         $sql_array = [
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Categories/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Manufacturers/Module/ClicShoppingAdmin/Config/CM/CM.php, line 70 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_MANUFACTURERS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_MANUFACTURERS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Manufacturers/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Products/Module/ClicShoppingAdmin/Config/PD/PD.php, line 67 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CATALOG_PRODUCTS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CATALOG_PRODUCTS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Products/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 53 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/ProductsAttributes/Module/ClicShoppingAdmin/Config/PA/PA.php, line 51 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_ATTRIBUTES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_ATTRIBUTES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/ProductsAttributes/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Suppliers/Module/ClicShoppingAdmin/Config/CS/CS.php, line 64 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_SUPPLIERS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_SUPPLIERS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Suppliers/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/EMail/Module/ClicShoppingAdmin/Config/EM/EM.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_EMAIL_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_EMAIL_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/EMail/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/Newsletter/Module/ClicShoppingAdmin/Config/NL/NL.php, line 61 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_NEWSLETTER_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_NEWSLETTER_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/Newsletter/Module/ClicShoppingAdmin/Newsletter/ProductNotification.php, line 192 
  2.     } else {
  3.       $chosen = [];
  5.       foreach ($_POST['chosen'] as $id) {
  6.         if (is_numeric($id) && !\in_array($id, $chosen)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $chosen[] = $id;
  8.         }
  9.       }
  11.       $ids = array_map(function ($k) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/Newsletter/Module/ClicShoppingAdmin/Newsletter/ProductNotification.php, line 348 
  1.       }
  2.     } else {
  3.       $chosen = [];
  5.       foreach ($_POST['chosen'] as $id) {
  6.         if (is_numeric($id) && !\in_array($id, $chosen)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $chosen[] = $id;
  8.         }
  9.       }
  11.       $ids = array_map(function ($k) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/Newsletter/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/Newsletter/Sites/ClicShoppingAdmin/Pages/Home/Actions/Newsletter/Insert.php, line 51 
  2.     $allowed = array_map(function ($v) {
  3.       return basename($v, '.php');
  4.     }, glob(CLICSHOPPING::BASE_DIR . 'Apps/Communication/Newsletter/Module/ClicShoppingAdmin/Newsletter/*.php'));
  6.     if (!\in_array($newsletter_module, $allowed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $CLICSHOPPING_MessageStack->add($CLICSHOPPING_Newsletter->getDef('error_newsletter_module_not_exists'), 'danger');
  8.       $newsletter_error = true;
  9.     }
  11.     if ($newsletters_accept_file == 'on') {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/Newsletter/Sites/ClicShoppingAdmin/Pages/Home/Actions/Newsletter/Update.php, line 58 
  2.     $allowed = array_map(function ($v) {
  3.       return basename($v, '.php');
  4.     }, glob(CLICSHOPPING::BASE_DIR . 'Apps/Communication/Newsletter/Module/ClicShoppingAdmin/Newsletter/*.php'));
  6.     if (!\in_array($newsletter_module, $allowed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $CLICSHOPPING_MessageStack->add($CLICSHOPPING_Newsletter->getDef('error_newsletter_module_not_exists'), 'danger');
  8.       $newsletter_error = true;
  9.     }
  11.     if ($newsletters_accept_file == 'on') {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/PageManager/Module/ClicShoppingAdmin/Config/PM/PM.php, line 77 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PAGE_MANAGER_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PAGE_MANAGER_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Communication/PageManager/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4. }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Administrators/Module/ClicShoppingAdmin/Config/AD/AD.php, line 68 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ADMINISTRATORS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ADMINISTRATORS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Administrators/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Api/Classes/Shop/ApiSecurity.php, line 430 
  2.      foreach ($Qips as $allowedIp) {
  3.        $ip = $allowedIp['ip'];
  5.        if ($ip === '127.0.0.1' || $ip === 'localhost') {
  6.          if (in_array($clientIp, ['127.0.0.1', '::1'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.            self::logSecurityEvent('Localhost access granted', [
  8.              'api_id' => $api_id,
  9.              'client_ip' => $clientIp
  10.            ]);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Api/Classes/Shop/ApiSecurity.php, line 591 
  1.    */
  2.   public static function isLocalEnvironment(): bool
  3.   {
  4.     $ip = HTTP::getIpAddress();
  6.     if (in_array($ip, ['127.0.0.1', '::1'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return true;
  8.     }
  10.     $serverName = $_SERVER['SERVER_NAME'] ?? '';
  11.     $host = $_SERVER['HTTP_HOST'] ?? '';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Api/Classes/Shop/ApiShop.php, line 34 
  1.     }
  3.     $method = strtoupper($_SERVER["REQUEST_METHOD"]);
  4.     $allowedMethods = ['GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'OPTIONS'];
  6.     if (!in_array($method, $allowedMethods)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       throw new Exception("Invalid HTTP method: " . $method);
  8.     }
  10.     return $method;
  11.   }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Api/Module/ClicShoppingAdmin/Config/AI/AI.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_API_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_API_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Api/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Cache/Module/ClicShoppingAdmin/Config/CA/CA.php, line 81 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CACHE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CACHE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Cache/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 41 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ModelManager.php, line 180 
  1.     foreach ($models as $model) {
  2.       $modelId = $model['id'];
  3.       $provider = $model['provider'] ?? 'openai'; // Default to openai if missing
  5.       // Validate provider name
  6.       if (!in_array($provider, $validProviders)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         if (defined('CLICSHOPPING_APP_CHATGPT_CH_DEBUG') && CLICSHOPPING_APP_CHATGPT_CH_DEBUG === 'True') {
  8.           error_log("WARNING: Invalid provider '$provider' for model '$modelId'. Using 'openai' as default.");
  9.         }
  10.         $provider = 'openai';
  11.       }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ProviderManager.php, line 241 
  1.         'open-mistral-nemo',
  2.         'open-codestral-mamba',
  3.         'mistral-moderation-latest'
  4.       ];
  6.       if (empty($model) || !in_array($model, $valid_models)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $model = 'mistral-large-latest';
  8.       }
  10.       $config = new MistralAIChat();
  11.       $config->apiKey = $api_key;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ResponseValidator.php, line 113 
  1.     }
  3.     // Validate type is one of expected values
  4.     if (isset($response['type'])) {
  5.       $validTypes = ['analytics', 'semantic', 'web_search', 'hybrid', 'error', 'clarification'];
  6.       if (!in_array($response['type'], $validTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $warnings[] = "Unexpected type value: {$response['type']}";
  8.       }
  9.     }
  11.     return [
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/Shop/Retails/GptRetailersOpenAI.php, line 986 
  1.             if ($productData && !$productData['in_stock']) {
  2.                 $messages[] = [
  3.                     'type' => 'error',
  4.                     'code' => 'out_of_stock',
  5.                     'text' => 'Produit ' . $productData['title'] . ' temporairement indisponible',
  6.                     'path' => '$.line_items[' . array_search($lineItem, $lineItems) . ']'
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                 ];
  8.             }
  9. }
  11.         // Add promotional messages
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Module/ClicShoppingAdmin/Config/AA/AA.php, line 70 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CHATGPT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CHATGPT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Module/ClicShoppingAdmin/Config/AC/AC.php, line 68 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CHATGPT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CHATGPT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Module/ClicShoppingAdmin/Config/AD/AD.php, line 70 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CHATGPT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CHATGPT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Module/ClicShoppingAdmin/Config/ASY/ASY.php, line 74 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CHATGPT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CHATGPT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Module/ClicShoppingAdmin/Config/AT/AT.php, line 68 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CHATGPT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CHATGPT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Module/ClicShoppingAdmin/Config/CH/CH.php, line 68 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CHATGPT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CHATGPT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Module/ClicShoppingAdmin/Config/RA/RA.php, line 67 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CHATGPT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CHATGPT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Module/ClicShoppingAdmin/Config/RE/RE.php, line 66 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CHATGPT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CHATGPT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Sites/ClicShoppingAdmin/Pages/Home/Actions/ChatGpt/RecordFeedback.php, line 53 
  1.         exit;

  2.       }

  4.       // Validate feedback_type

  5.       $validTypes = ['positive', 'negative', 'correction'];

  6.       if (!in_array($input['feedback_type'], $validTypes)) {

    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         echo json_encode([

  8.           'success' => false,

  9.           'error' => 'feedback_type must be one of: ' . implode(', ', $validTypes)

  10.         ]);

  11.         exit;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Countries/Module/ClicShoppingAdmin/Config/CT/CT.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_COUNTRIES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_COUNTRIES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Countries/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Currency/Module/ClicShoppingAdmin/Config/CR/CR.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CURRENCY_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CURRENCY_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Currency/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Langues/Module/ClicShoppingAdmin/Config/LG/LG.php, line 70 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_LANGUES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_LANGUES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Langues/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Langues/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 61 
  1. }
  3. foreach (glob(CLICSHOPPING::getConfig('dir_root', 'ClicShoppingAdmin') . 'Core/languages/*', GLOB_ONLYDIR) as $dir) {
  4.   $code = basename($dir);
  6.   if (array_search($code, array_column($directories, 'id')) === false) {
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     $directories[] = ['id' => $code,
  8.       'text' => $code
  9.     ];
  10.   }
  11. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Langues/Sites/ClicShoppingAdmin/Pages/Home/templates/insert.php, line 42 
  1. }
  3. foreach (glob(CLICSHOPPING::getConfig('dir_root', 'ClicShoppingAdmin') . 'Core/languages/*', GLOB_ONLYDIR) as $dir) {
  4.   $code = basename($dir);
  6.   if (array_search($code, array_column($directories, 'id')) === false) {
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     $directories[] = ['id' => $code,
  8.       'text' => $code
  9.     ];
  10.   }
  11. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Module/ClicShoppingAdmin/Config/MO/MO.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_MODULES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_MODULES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/Actions/Modules/Install.php, line 79 
  2.       $module->install();
  4.       $modules_installed = explode(';', \constant($module_key));
  6.       if (!\in_array($class . $file_extension, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $modules_installed[] = $class . $file_extension;
  8.       }
  10.       Registry::get('Db')->save('configuration', ['configuration_value' => implode(';', $modules_installed)],
  11.         ['configuration_key' => $module_key]
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/Actions/Modules/Remove.php, line 74 
  2.       $module->remove();
  4.       $modules_installed = explode(';', \constant($module_key));
  6.       if (\in_array($class . $file_extension, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         unset($modules_installed[array_search($class . $file_extension, $modules_installed)]);
  8.       }
  10.       Registry::get('Db')->save('configuration', ['configuration_value' => implode(';', $modules_installed)],
  11.         ['configuration_key' => $module_key]
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/Actions/Modules/Remove.php, line 75 
  1.       $module->remove();
  3.       $modules_installed = explode(';', \constant($module_key));
  5.       if (\in_array($class . $file_extension, $modules_installed)) {
  6.         unset($modules_installed[array_search($class . $file_extension, $modules_installed)]);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       }
  9.       Registry::get('Db')->save('configuration', ['configuration_value' => implode(';', $modules_installed)],
  10.         ['configuration_key' => $module_key]
  11.       );
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 86 
  1.   if ($dir = @dir($module_directory)) {
  2.     while ($file = $dir->read()) {
  3.       if (!is_dir($module_directory . $file)) {
  4.         if (substr($file, strrpos($file, '.')) == $file_extension) {
  5.           if (isset($_GET['list']) && ($_GET['list'] == 'new')) {
  6.             if (!\in_array($file, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               $directory_array[] = $file;
  8.             }
  9.           } else {
  10.             if (\in_array($file, $modules_installed)) {
  11.               $directory_array[] = $file;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 90 
  1.           if (isset($_GET['list']) && ($_GET['list'] == 'new')) {
  2.             if (!\in_array($file, $modules_installed)) {
  3.               $directory_array[] = $file;
  4.             }
  5.           } else {
  6.             if (\in_array($file, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               $directory_array[] = $file;
  8.             } else {
  9.               $new_modules_counter++;
  10.             }
  11.           }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 105 
  1.   }
  3.   if (isset($appModuleType)) {
  4.     foreach (Apps::getModules($appModuleType) as $k => $v) {
  5.       if (isset($_GET['list']) && ($_GET['list'] == 'new')) {
  6.         if (!\in_array($k, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $directory_array[] = $k;
  8.         }
  9.       } else {
  10.         if (\in_array($k, $modules_installed)) {
  11.           $directory_array[] = $k;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 109 
  1.       if (isset($_GET['list']) && ($_GET['list'] == 'new')) {
  2.         if (!\in_array($k, $modules_installed)) {
  3.           $directory_array[] = $k;
  4.         }
  5.       } else {
  6.         if (\in_array($k, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $directory_array[] = $k;
  8.         } else {
  9.           $new_modules_counter++;
  10.         }
  11.       }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/modules.php, line 111 
  1.   if ($dir = @dir($module_directory)) {
  2.     while ($file = $dir->read()) {
  3.       if (!is_dir($module_directory . $file)) {
  4.         if (substr($file, strrpos($file, '.')) === $file_extension) {
  5.           if (isset($_GET['list']) && ($_GET['list'] == 'new')) {
  6.             if (!\in_array($file, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               $directory_array[] = $file;
  8.             }
  9.           } else {
  10.             if (\in_array($file, $modules_installed)) {
  11.               $directory_array[] = $file;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/modules.php, line 115 
  1.           if (isset($_GET['list']) && ($_GET['list'] == 'new')) {
  2.             if (!\in_array($file, $modules_installed)) {
  3.               $directory_array[] = $file;
  4.             }
  5.           } else {
  6.             if (\in_array($file, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               $directory_array[] = $file;
  8.             } else {
  9.               $new_modules_counter++;
  10.             }
  11.           }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/modules.php, line 130 
  1.   }
  3.   if (isset($appModuleType)) {
  4.     foreach (Apps::getModules($appModuleType) as $k => $v) {
  5.       if (isset($_GET['list']) && ($_GET['list'] == 'new')) {
  6.         if (!\in_array($k, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $directory_array[] = $k;
  8.         }
  9.       } else {
  10.         if (\in_array($k, $modules_installed)) {
  11.           $directory_array[] = $k;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/modules.php, line 134 
  1.       if (isset($_GET['list']) && ($_GET['list'] == 'new')) {
  2.         if (!\in_array($k, $modules_installed)) {
  3.           $directory_array[] = $k;
  4.         }
  5.       } else {
  6.         if (\in_array($k, $modules_installed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $directory_array[] = $k;
  8.         } else {
  9.           $new_modules_counter++;
  10.         }
  11.       }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/modules.php, line 265 
  1.         <tr>
  2.           <td><?php echo $module->title; ?></td>
  3.           <td class="text-start"><?php echo $module->group; ?></td>
  4.           <td class="text-end">
  5.             <?php
  6.             if (\in_array($module->code . $file_extension, $modules_installed) && is_numeric($module->sort_order)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               echo $module->sort_order;
  8.             }
  9.             ?>
  10.           </td>
  11.           <td class="text-center">
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/templates/modules.php, line 330 
  1.         $Qcheck = $CLICSHOPPING_Db->get('configuration', 'configuration_value', ['configuration_key' => 'TEMPLATE_BLOCK_GROUPS']);
  3.         if ($Qcheck->fetch() !== false) {
  4.           $tbgroups_array = explode(';', $Qcheck->value('configuration_value'));
  6.           if (!\in_array($module_type, $tbgroups_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             $tbgroups_array[] = $module_type;
  8.             sort($tbgroups_array);
  10.             $CLICSHOPPING_Db->save('configuration', [
  11.               'configuration_value' => implode(';', $tbgroups_array),
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/OrdersStatus/Module/ClicShoppingAdmin/Config/OU/OU.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ORDERS_STATUS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ORDERS_STATUS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/OrdersStatus/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/OrdersStatusInvoice/Module/ClicShoppingAdmin/Config/OI/OI.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ORDERS_STATUS_INVOICE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ORDERS_STATUS_INVOICE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/OrdersStatusInvoice/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ProductsLength/Module/ClicShoppingAdmin/Config/PL/PL.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PROUCTS_LENGTH_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PROUCTS_LENGTH_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ProductsLength/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ProductsQuantityUnit/Module/ClicShoppingAdmin/Config/PQ/PQ.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_QUANTITY_UNIT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_QUANTITY_UNIT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ProductsQuantityUnit/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Settings/Module/ClicShoppingAdmin/Config/ST/ST.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_SETTINGS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_SETTINGS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Settings/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/TaxClass/Module/ClicShoppingAdmin/Config/TC/TC.php, line 68 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_TAX_CLASS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_TAX_CLASS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/TaxClass/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/TaxGeoZones/Module/ClicShoppingAdmin/Config/TG/TG.php, line 64 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_TAX_GEO_ZONES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_TAX_GEO_ZONES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/TaxGeoZones/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/TaxRates/Module/ClicShoppingAdmin/Config/TR/TR.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_TAX_RATES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_TAX_RATES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/TaxRates/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/TemplateEmail/Module/ClicShoppingAdmin/Config/TE/TE.php, line 70 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_TEMPLATE_EMAIL_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_TEMPLATE_EMAIL_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/TemplateEmail/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Weight/Module/ClicShoppingAdmin/Config/WE/WE.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_WEIGHT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_WEIGHT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Weight/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Zones/Module/ClicShoppingAdmin/Config/ZN/ZN.php, line 73 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ZONES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ZONES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Zones/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Customers/Module/ClicShoppingAdmin/Config/CS/CS.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CUSTOMERS_INFO_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CUSTOMERS_INFO_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Customers/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Gdpr/Module/ClicShoppingAdmin/Config/GD/GD.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CUSTOMERS_GDPR_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CUSTOMERS_GDPR_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Gdpr/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Module/ClicShoppingAdmin/Config/GR/GR.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CUSTOMERS_GROUPS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CUSTOMERS_GROUPS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Module/Hooks/ClicShoppingAdmin/Customers/pageTab4.php, line 218 
  1.         for ($i = 0, $n = \count($include_modules); $i < $n; $i++) {
  2.           if (str_contains($include_modules[$i]['class'], '\\')) {
  3.             Registry::set('Payment_' . str_replace('\\', '_', $include_modules[$i]['class']), new $include_modules[$i]['file']);
  4.             $module = Registry::get('Payment_' . str_replace('\\', '_', $include_modules[$i]['class']));
  6.             if (($cInfo->customers_group_id != 0) && (\in_array($module->code, $payments_unallowed))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               $content .= '<div class="row">';
  8.               $content .= '<div class="col-md-5">';
  9.               $content .= '<div class="form-group row">';
  10.               $content .= '<div class="col-md-12">';
  11.               $content .= '<span class="col-md-1"><i class="bi-check text-success"></i></span>';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Module/Hooks/ClicShoppingAdmin/Customers/pageTab5.php, line 133 
  1.       for ($i = 0, $n = \count($include_modules); $i < $n; $i++) {
  2.         if (str_contains($include_modules[$i]['class'], '\\')) {
  3.           Registry::set('Shipping_' . str_replace('\\', '_', $include_modules[$i]['class']), new $include_modules[$i]['file']);
  4.           $module = Registry::get('Shipping_' . str_replace('\\', '_', $include_modules[$i]['class']));
  6.           if (($cInfo->customers_group_id != 0) && (\in_array($module->code, $shipping_unallowed))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             $content .= '<div class="col-md-12">';
  8.             $content .= '<span class="col-md-1"><i class="bi-check text-success"></i></span>';
  9.             $content .= '<span class="col-md-3">' . $module->title . '</span>';
  10.             $content .= '</div>';
  11.           } elseif ($cInfo->customers_group_id != 0 && !\in_array($module->code, $shipping_unallowed)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Module/Hooks/ClicShoppingAdmin/Customers/pageTab5.php, line 138 
  1.           if (($cInfo->customers_group_id != 0) && (\in_array($module->code, $shipping_unallowed))) {
  2.             $content .= '<div class="col-md-12">';
  3.             $content .= '<span class="col-md-1"><i class="bi-check text-success"></i></span>';
  4.             $content .= '<span class="col-md-3">' . $module->title . '</span>';
  5.             $content .= '</div>';
  6.           } elseif ($cInfo->customers_group_id != 0 && !\in_array($module->code, $shipping_unallowed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             $content .= '<div class="col-md-12">';
  8.             $content .= '<span class="col-md-1"><i class="bi-check text-danger"></i></span>';
  9.             $content .= '<span class="col-md-3">' . $module->title . '</span>';
  10.             $content .= '</div>';
  11.           } elseif ($cInfo->customers_group_id == 0) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 317 
  1.                     <div class="form-group row">
  2.                       <div class="col-md-12">
  3.                         <ul class="list-group-slider list-group-flush">
  4.                           <li class="list-group-item-slider">
  5.                             <label class="switch">
  6.                               <?php echo HTML::checkboxField('payment_unallowed[' . $i . ']', $module->code, (\in_array($module->code, $payments_unallowed)) ? true : false, 'class="success"'); ?>
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                               <span class="slider"></span>
  8.                             </label>
  9.                           </li>
  10.                           <span class="text-slider"><?php echo $module->title; ?></span>
  11.                         </ul>
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 387 
  1.                     <div class="form-group row">
  2.                       <div class="col-md-12">
  3.                         <ul class="list-group-slider list-group-flush">
  4.                           <li class="list-group-item-slider">
  5.                             <label class="switch">
  6.                               <?php echo HTML::checkboxField('shipping_unallowed[' . $i . ']', $module->code, (\in_array($module->code, $shipping_unallowed)) ? true : false, 'class="success"'); ?>
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                               <span class="slider"></span>
  8.                             </label>
  9.                           </li>
  10.                           <span class="text-slider"><?php echo $module->title; ?></span>
  11.                         </ul>
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Members/Module/ClicShoppingAdmin/Config/ME/ME.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CUSTOMERS_MEMBERS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CUSTOMERS_MEMBERS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Members/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Reviews/Module/ClicShoppingAdmin/Config/RV/RV.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_REVIEWS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_REVIEWS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Reviews/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/BannerManager/Module/ClicShoppingAdmin/Config/BM/BM.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_BANNER_MANAGER_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_BANNER_MANAGER_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/BannerManager/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/Favorites/Module/ClicShoppingAdmin/Config/FA/FA.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_FAVORITES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_FAVORITES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/Favorites/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/Featured/Module/ClicShoppingAdmin/Config/FE/FE.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_FEATURED_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_FEATURED_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/Featured/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/Recommendations/Module/ClicShoppingAdmin/Config/PR/PR.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_PRODUCT_RECOMMENDATIONS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_PRODUCT_RECOMMENDATIONS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/Recommendations/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/SEO/Module/ClicShoppingAdmin/Config/SE/SE.php, line 45 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_SEO_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_SEO_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/SEO/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/Specials/Module/ClicShoppingAdmin/Config/SP/SP.php, line 75 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_SPECIALS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_SPECIALS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Marketing/Specials/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/OrderTotal/SubTotal/Module/ClicShoppingAdmin/Config/ST/ST.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_ORDER_TOTAL_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_ORDER_TOTAL_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/OrderTotal/SubTotal/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/OrderTotal/Total/Module/ClicShoppingAdmin/Config/TO/TO.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_ORDER_TOTAL_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_ORDER_TOTAL_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/OrderTotal/Total/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/OrderTotal/TotalShipping/Module/ClicShoppingAdmin/Config/SH/SH.php, line 96 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_ORDER_TOTAL_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_ORDER_TOTAL_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/OrderTotal/TotalShipping/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/OrderTotal/TotalTax/Module/ClicShoppingAdmin/Config/TX/TX.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_ORDER_TOTAL_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_ORDER_TOTAL_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/OrderTotal/TotalTax/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Classes/Common/EInvoiceService.php, line 105 
  1.   {
  2.     if (!$this->isEnabled()) {
  3.       return $this->skip($this->app->getDef('skip_module_disabled'));
  4.     }
  6.     if (!in_array($invoice_status, [self::STATUS_INVOICE, self::STATUS_CANCEL, self::STATUS_CREDIT_NOTE])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return $this->skip($this->app->getDef('skip_status_not_actionable') . ' (' . $invoice_status . ')');
  8.     }
  10.     if ($this->isAlreadySent($order_id)) {
  11.       return $this->skip($this->app->getDef('skip_already_sent') . ' #' . $order_id);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Classes/Common/EInvoiceService.php, line 127 
  1.       $msg = $this->app->getDef('error_oauth2_failed') . ' #' . $order_id;
  2.       $this->writeOrderHistory($order_id, '[ERROR] ' . $msg, false);
  3.       return $this->failure($msg);
  4.     }
  6.     $doc_type = in_array($invoice_status, [self::STATUS_CANCEL, self::STATUS_CREDIT_NOTE]) ? self::TYPE_CREDIT_NOTE : self::TYPE_INVOICE;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     $payload = $this->buildPayload($order_id, $customer, $info, $products, $totals, $doc_type);
  9.     if ($payload === null) {
  10.       $msg = $this->app->getDef('error_payload_failed');
  11.       $this->writeOrderHistory($order_id, '[ERROR] ' . $msg, false);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Classes/Common/EInvoiceService.php, line 328 
  1.     // Extract totals from the order totals array
  2.     $ht = $tva = $ttc = 0.0;
  3.     foreach ($totals as $t) {
  4.       $val = (float)str_replace(',', '.', preg_replace('/[^0-9.,\-]/', '', strip_tags($t['text'] ?? '0')));
  5.       $c   = $t['class'] ?? '';
  6.       if (in_array($c, ['ot_subtotal', 'ST'])) $ht  = $val;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if (in_array($c, ['ot_tax',      'TX'])) $tva = $val;
  8.       if (in_array($c, ['ot_total',    'TO'])) $ttc = $val;
  9.     }
  11.     // Fallback: compute HT from product lines if ot_subtotal not found
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Classes/Common/EInvoiceService.php, line 329 
  1.     $ht = $tva = $ttc = 0.0;
  2.     foreach ($totals as $t) {
  3.       $val = (float)str_replace(',', '.', preg_replace('/[^0-9.,\-]/', '', strip_tags($t['text'] ?? '0')));
  4.       $c   = $t['class'] ?? '';
  5.       if (in_array($c, ['ot_subtotal', 'ST'])) $ht  = $val;
  6.       if (in_array($c, ['ot_tax',      'TX'])) $tva = $val;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if (in_array($c, ['ot_total',    'TO'])) $ttc = $val;
  8.     }
  10.     // Fallback: compute HT from product lines if ot_subtotal not found
  11.     if ($ht == 0.0) {
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Classes/Common/EInvoiceService.php, line 330 
  1.     foreach ($totals as $t) {
  2.       $val = (float)str_replace(',', '.', preg_replace('/[^0-9.,\-]/', '', strip_tags($t['text'] ?? '0')));
  3.       $c   = $t['class'] ?? '';
  4.       if (in_array($c, ['ot_subtotal', 'ST'])) $ht  = $val;
  5.       if (in_array($c, ['ot_tax',      'TX'])) $tva = $val;
  6.       if (in_array($c, ['ot_total',    'TO'])) $ttc = $val;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     }
  9.     // Fallback: compute HT from product lines if ot_subtotal not found
  10.     if ($ht == 0.0) {
  11.       foreach ($products as $p) {
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Module/ClicShoppingAdmin/Config/OD/OD.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ORDERS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ORDERS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Sites/ClicShoppingAdmin/Pages/Home/Actions/Orders/Update.php, line 164 
  1.     if ((int)$check['orders_status_invoice'] === $new_invoice_status) {
  2.       return;
  3.     }
  5.     // Only process actionable statuses
  6.     if (!in_array($new_invoice_status, [
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       EInvoiceService::STATUS_INVOICE,
  8.       EInvoiceService::STATUS_CANCEL,
  9.       EInvoiceService::STATUS_CREDIT_NOTE,
  10.     ])) {
  11.       return;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/Orders/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 555 
  1.                           ?>
  2.                           <span class="badge bg-success"><?php echo $CLICSHOPPING_Orders->getDef('badge_transmitted'); ?></span>
  3.                           &nbsp;<span class="text-success small"><?php echo $CLICSHOPPING_Orders->getDef('text_transmitted_notice'); ?></span>
  5.                         <?php
  6.                         } elseif (!in_array($current_invoice_status_id, [EInvoiceService::STATUS_INVOICE, EInvoiceService::STATUS_CANCEL, EInvoiceService::STATUS_CREDIT_NOTE])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                           ?>
  9.                           <span class="badge bg-warning text-dark"><?php echo $CLICSHOPPING_Orders->getDef('badge_pending'); ?></span>
  10.                           &nbsp;<span class="text-muted small"><?php echo $CLICSHOPPING_Orders->getDef('text_pending_notice'); ?></span>
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/ReturnOrders/Module/ClicShoppingAdmin/Config/RO/RO.php, line 46 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_PRODUCTS_RETURN_ORDERS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_PRODUCTS_RETURN_ORDERS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Orders/ReturnOrders/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Payment/COD/Module/ClicShoppingAdmin/Config/CO/CO.php, line 70 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_PAYMENT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_PAYMENT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Payment/COD/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 63 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Payment/MoneyOrder/Module/ClicShoppingAdmin/Config/MO/MO.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_PAYMENT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_PAYMENT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Payment/MoneyOrder/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 63 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4. }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Payment/Stripe/Module/ClicShoppingAdmin/Config/ST/ST.php, line 69 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_PAYMENT_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_PAYMENT_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Payment/Stripe/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Report/StatsProductsNotification/Module/ClicShoppingAdmin/Config/PN/PN.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_STATS_PRODUCTS_NOTIFICATION_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_STATS_PRODUCTS_NOTIFICATION_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Report/StatsProductsNotification/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Shipping/Item/Module/ClicShoppingAdmin/Config/IT/IT.php, line 68 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_SHIPPING_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_SHIPPING_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Shipping/Item/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Shipping/Table/Module/ClicShoppingAdmin/Config/TA/TA.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_SHIPPING_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_SHIPPING_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Shipping/Table/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 42 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4. }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ActionsRecorder/Classes/Shop/ActionRecorder.php, line 42 
  1.     $CLICSHOPPING_Language = Registry::get('Language');
  3.     $module = HTML::sanitize(str_replace(' ', '', $module));
  5.     if (defined('MODULE_ACTION_RECORDER_INSTALLED') && !is_null(MODULE_ACTION_RECORDER_INSTALLED)) {
  6.       if (!is_null($module) && in_array($module . '.' . substr(CLICSHOPPING::getIndex(), (strrpos(CLICSHOPPING::getIndex(), '.') + 1)), explode(';', MODULE_ACTION_RECORDER_INSTALLED))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         if (!class_exists($module)) {
  8.           if (is_file($CLICSHOPPING_Template->getModuleDirectory() . '/action_recorder/' . $module . '.' . substr(CLICSHOPPING::getIndex(), (strrpos(CLICSHOPPING::getIndex(), '.') + 1)))) {
  9.             $CLICSHOPPING_Language->loadDefinitions('modules/action_recorder/' . $module);
  10.             include($CLICSHOPPING_Template->getModuleDirectory() . '/action_recorder/' . $module . '.' . substr(CLICSHOPPING::getIndex(), (strrpos(CLICSHOPPING::getIndex(), '.') + 1)));
  11.           } else {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ActionsRecorder/Module/ClicShoppingAdmin/Config/AR/AR.php, line 67 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ACTIONS_RECORDER_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ACTIONS_RECORDER_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ActionsRecorder/Sites/ClicShoppingAdmin/Pages/Home/Actions/ActionsRecorder/Expire.php, line 68 
  1.       $modules_array[] = $Qmodules->value('module');
  2.     }
  4.     $expired_entries = 0;
  6.     if (isset($_GET['module']) && \in_array($_GET['module'], $modules_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $get_module_class = $CLICSHOPPING_ActionsRecorderClass->getClassModule($_GET['module']);
  9.       if (\is_object($get_module_class)) {
  10.         $expired_entries += $get_module_class->expireEntries();
  11.       } else {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ActionsRecorder/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ActionsRecorder/Sites/ClicShoppingAdmin/Pages/Home/templates/actions_recorder.php, line 85 
  1.             echo HTML::form('search', $CLICSHOPPING_ActionsRecorder->link('ActionsRecorder'), 'post', '', ['session_id' => true]);
  2.             echo HTML::selectField('module', $modules_list_array, null, 'onchange="this.form.submit();"');
  3.             ?>
  4.           </span>
  5.           <span class="col-md-1 text-end">
  6.             <?php echo HTML::button($CLICSHOPPING_ActionsRecorder->getDef('button_reset'), null, $CLICSHOPPING_ActionsRecorder->link('ActionsRecorder&Expire' . (isset($_POST['module']) && \in_array($_POST['module'], $modules_array) ? '&module=' . $_POST['module'] : '')), 'danger'); ?>
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           </span>
  8.         </div>
  9.         </form>
  10.       </div>
  11.     </div>
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ActionsRecorder/Sites/ClicShoppingAdmin/Pages/Home/templates/actions_recorder.php, line 124 
  1.     </thead>
  2.     <tbody>
  3.     <?php
  4.     $filter = [];
  6.     if (isset($_POST['module']) && \in_array($_POST['module'], $modules_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $filter[] = 'module = :module';
  8.     }
  10.     if (isset($_POST['search']) && !empty($_POST['search'])) {
  11.       $filter[] = 'identifier like :identifier';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ActionsRecorder/Sites/ClicShoppingAdmin/Pages/Home/templates/actions_recorder.php, line 143 
  1.     $sql_query .= ' order by date_added desc limit :page_set_offset, :page_set_max_results';
  3.     $Qactions = $CLICSHOPPING_ActionsRecorder->db->prepare($sql_query);
  5.     if (!empty($filter)) {
  6.       if (isset($_POST['module']) && \in_array($_POST['module'], $modules_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $Qactions->bindValue(':module', $_POST['module']);
  8.       }
  10.       if (isset($_POST['search']) && !empty($_POST['search'])) {
  11.         $Qactions->bindValue(':identifier', '%' . $_POST['search'] . '%');
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ActionsRecorder/Sites/ClicShoppingAdmin/Pages/Home/templates/actions_recorder.php, line 183 
  1.   <div class="row">
  2.     <div class="col-md-12">
  3.       <div
  4.         class="col-md-6 float-start pagenumber hidden-xs TextDisplayNumberOfLink"><?php echo $Qactions->getPageSetLabel($CLICSHOPPING_ActionsRecorder->getDef('text_display_number_of_link')); ?></div>
  5.       <div
  6.         class="float-end text-end"> <?php echo $Qactions->getPageSetLinks((isset($_POST['module']) && \in_array($_POST['module'], $modules_array) && \is_object($GLOBALS[$_POST['module']]) ? 'module=' . $_POST['module'] : null) . '&' . (isset($_POST['search']) && !empty($_POST['search']) ? 'search=' . $_POST['search'] : null)); ?></div>
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     </div>
  8.   </div>
  9. </div>
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/AdministratorMenu/Module/ClicShoppingAdmin/Config/AM/AM.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_ADMINISTRATOR_MENU_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_ADMINISTRATOR_MENU_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/AdministratorMenu/Sites/ClicShoppingAdmin/Pages/Home/Actions/AdministratorMenu/MoveCategoryConfirm.php, line 44 
  1.     if (isset($this->Id) && ($this->Id != $this->moveToCategoryID)) {
  2.       $new_parent_id = $this->moveToCategoryID;
  4.       $path = explode('_', AdministratorMenu::getGeneratedAdministratorMenuPathIds($new_parent_id));
  6.       if (\in_array($this->Id, $path)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $CLICSHOPPING_MessageStack->add($this->app->getDef('error_cannot_move_directory_to_parent'), 'error');
  9.         $this->app->redirect('AdministratorMenu&cPath=' . (int)$this->cPath . '&cID=' . (int)$this->Id);
  10.       } else {
  11.         $this->app->db->save('administrator_menu', [
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/AdministratorMenu/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Apps/Module/ClicShoppingAdmin/Config/AP/AP.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_APPS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_APPS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Apps/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Backup/Module/ClicShoppingAdmin/Config/BC/BC.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_BACKUP_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_BACKUP_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Backup/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Backup/Sites/ClicShoppingAdmin/Pages/Home/templates/backup.php, line 90 
  2.         $dir = dir($backup_directory);
  3.         $contents = [];
  5.         while ($file = $dir->read()) {
  6.           if (!is_dir($backup_directory . $file) && \in_array(substr($file, -3), array('zip', 'sql', '.gz'))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             $contents[] = $file;
  8.           }
  9.         }
  11.         sort($contents);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Cronjob/Module/ClicShoppingAdmin/Config/CJ/CJ.php, line 67 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_CRONJOB_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_CRONJOB_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Cronjob/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/DataBaseTables/Module/ClicShoppingAdmin/Config/DT/DT.php, line 66 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_DATA_BASE_TABLES_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_DATA_BASE_TABLES_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/DataBaseTables/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/DataBaseTables/Sites/ClicShoppingAdmin/Pages/Home/templates/data_base_tables.php, line 60 
  1.   ['id' => 'utf8',
  2.     'text' => $CLICSHOPPING_DataBaseTables->getDef('action_utf8_conversion')
  3.   ]);
  5. if (isset($_POST['action'])) {
  6.   if (\in_array($_POST['action'], array('check', 'analyze', 'optimize', 'repair', 'utf8'))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     if (isset($_POST['id']) && \is_array($_POST['id']) && !empty($_POST['id'])) {
  8.       $tables = Database::getDtTables();
  10.       foreach ($_POST['id'] as $key => $value) {
  11.         if (!\in_array($value, $tables)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/DataBaseTables/Sites/ClicShoppingAdmin/Pages/Home/templates/data_base_tables.php, line 65 
  1.   if (\in_array($_POST['action'], array('check', 'analyze', 'optimize', 'repair', 'utf8'))) {
  2.     if (isset($_POST['id']) && \is_array($_POST['id']) && !empty($_POST['id'])) {
  3.       $tables = Database::getDtTables();
  5.       foreach ($_POST['id'] as $key => $value) {
  6.         if (!\in_array($value, $tables)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           unset($_POST['id'][$key]);
  8.         }
  9.       }
  11.       if (!empty($_POST['id'])) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/DataBaseTables/Sites/ClicShoppingAdmin/Pages/Home/templates/data_base_tables.php, line 103 
  1.       while ($Qaction->fetch()) {
  2.         $table_data[] = [
  3.           ($table != $current_table) ? HTML::outputProtected($table) : '',
  4.           $Qaction->valueProtected('Msg_type'),
  5.           $Qaction->valueProtected('Msg_text'),
  6.           ($table != $current_table) ? HTML::checkboxField('id[]', $table, isset($_POST['id']) && \in_array($table, $_POST['id'])) : ''
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         ];
  9.         $current_table = $table;
  10.       }
  11.     }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/DefineLanguage/Module/ClicShoppingAdmin/Config/DL/DL.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_DEFINE_LANGUAGE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_DEFINE_LANGUAGE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/DefineLanguage/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Classes/Css.php, line 57 
  1.     $file_array = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($directory_selected));
  3.     foreach ($file_array as $filename => $current) {
  4.       $fileInfo = pathinfo($current->getFileName());
  6.       if (array_key_exists('extension', $fileInfo) && in_array($fileInfo['extension'], $fileTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $found[] = $current->getFileName();
  8.       }
  9.     }
  11.     if ($found) { // Check the $found array is not empty
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Classes/Gabari.php, line 43 
  1.     $file_array = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($filename_selected));
  3.     foreach ($file_array as $filename => $current) {
  4.       $fileInfo = pathinfo($current->getFileName());
  6.       if (array_key_exists('extension', $fileInfo) && in_array($fileInfo['extension'], $fileTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $found[] = $current->getFileName();
  8.       }
  9.     }
  11.     if ($found) { // Check the $found array is not empty
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Classes/Listing.php, line 58 
  1.     $file_array = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($template_directory));
  3.     foreach ($file_array as $filename => $current) {
  4.       $fileInfo = pathinfo($current->getFileName());
  6.       if (array_key_exists('extension', $fileInfo) && in_array($fileInfo['extension'], $fileTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $found[] = $current->getFileName();
  8.       }
  9.     }
  11.     if ($found) { // Check the $found array is not empty
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Classes/Module.php, line 52 
  2.     /* if empty error is produced : Fatal error: Uncaught exception 'RuntimeException'*/
  3.     foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($template_directory)) as $filename => $current) {
  4.       $fileInfo = pathinfo($current->getFileName());
  6.       if (array_key_exists('extension', $fileInfo) && \in_array($fileInfo['extension'], $fileTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $found[] = $current->getFileName();
  8.       }
  9.     }
  11.     if ($found) { // Check the $found array is not empty
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Module/ClicShoppingAdmin/Config/ED/ED.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_EDIT_DESIGN_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_EDIT_DESIGN_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditLogError/Module/ClicShoppingAdmin/Config/EL/EL.php, line 65 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_EDIT_LOG_ERROR_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_EDIT_LOG_ERROR_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditLogError/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Classes/ClicShoppingAdmin/McpHealth.php, line 220 
  1.    * @param array $checks An array of check results, each with a 'status' key.
  2.    * @return string The overall status: 'error', 'warning', or 'healthy'.
  3.    */
  4.   private function determineOverallStatus(array $checks): string
  5.   {
  6.     if (in_array('error', array_column($checks, 'status'))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return 'error';
  8.     }
  9.     if (in_array('warning', array_column($checks, 'status'))) {
  10.       return 'warning';
  11.     }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Classes/ClicShoppingAdmin/McpHealth.php, line 223 
  1.   private function determineOverallStatus(array $checks): string
  2.   {
  3.     if (in_array('error', array_column($checks, 'status'))) {
  4.       return 'error';
  5.     }
  6.     if (in_array('warning', array_column($checks, 'status'))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return 'warning';
  8.     }
  9.     return 'healthy';
  10.   }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Classes/Shop/Security/McpSecurity.php, line 535 
  2.       foreach ($Qips as $allowedIp) {
  3.         $ip = $allowedIp['ip'];
  5.         if ($ip === '127.0.0.1' || $ip === 'localhost') {
  6.           if (in_array($clientIp, ['127.0.0.1', '::1'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             self::logSecurityEvent('Localhost access granted', [
  8.               'mcp_id' => $mcp_id,
  9.               'client_ip' => $clientIp
  10.             ]);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Classes/Shop/Security/McpSecurity.php, line 609 
  1.    */
  2.   public static function isLocalEnvironment(): bool
  3.   {
  4.     $ip = HTTP::getIpAddress();
  6.     if (in_array($ip, ['127.0.0.1', '::1'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return true;
  8.     }
  10.     $serverName = $_SERVER['SERVER_NAME'] ?? '';
  11.     $host = $_SERVER['HTTP_HOST'] ?? '';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Classes/Shop/Security/McpShop.php, line 40 
  1.     }
  3.     $method = strtoupper($_SERVER["REQUEST_METHOD"]);
  4.     $allowedMethods = ['GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'OPTIONS'];
  6.     if (!in_array($method, $allowedMethods)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       throw new Exception("Invalid HTTP method: " . $method);
  8.     }
  10.     return $method;
  11.   }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Module/ClicShoppingAdmin/Config/MC/MC.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_MCP_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_MCP_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4. }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Sites/Shop/Pages/Auth/Auth copy.php, line 44 
  2.     /**
  3.      * Valide une clé d'API pour un niveau d'accès donné
  4.      */
  5.     public function validateMcpKey(string $mcpKey, string $accessLevel): bool {
  6.         if (!in_array($accessLevel, $this->accessLevels)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             return false;
  8.         }
  10.         if (!isset($this->validMcpKeys[$accessLevel])) {
  11.             return false;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Sites/Shop/Pages/Auth/Auth copy.php, line 52 
  2.         if (!isset($this->validMcpKeys[$accessLevel])) {
  3.             return false;
  4.         }
  6.         return in_array($mcpKey, $this->validMcpKeys[$accessLevel]);
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     }
  9.     /**
  10.      * Valide les headers de sécurité requis
  11.      */
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Sites/Shop/Pages/Auth/Auth.php, line 90 
  1.                     'ssl_enabled' => $sslEnabled,
  2.                     'origin' => $origin
  3.                 ];
  5.                 // Add to allowed origins list
  6.                 if (!in_array($origin, $this->allowedOrigins)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                     $this->allowedOrigins[] = $origin;
  8.                 }
  9.             }
  11.             // Fallback to localhost if no configurations found
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Sites/Shop/Pages/Auth/Auth.php, line 119 
  2.     /**
  3.      * Check if an origin is allowed
  4.      */
  5.     public function isOriginAllowed(string $origin): bool {
  6.         return in_array($origin, $this->allowedOrigins);
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     }
  9.     /**
  10.      * Valide une clé d'API pour un niveau d'accès donné
  11.      */
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Sites/Shop/Pages/Auth/Auth.php, line 126 
  2.     /**
  3.      * Valide une clé d'API pour un niveau d'accès donné
  4.      */
  5.     public function validateMcpKey(string $mcpKey, string $accessLevel): bool {
  6.         if (!in_array($accessLevel, $this->accessLevels)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             return false;
  8.         }
  10.         if (!isset($this->validMcpKeys[$accessLevel])) {
  11.             return false;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Sites/Shop/Pages/Auth/Auth.php, line 134 
  2.         if (!isset($this->validMcpKeys[$accessLevel])) {
  3.             return false;
  4.         }
  6.         return in_array($mcpKey, $this->validMcpKeys[$accessLevel]);
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     }
  9.     /**
  10.      * Valide les headers de sécurité requis
  11.      */
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ModulesHooks/Module/ClicShoppingAdmin/Config/MH/MH.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_MODULES_HOOKS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_MODULES_HOOKS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ModulesHooks/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4. }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/SecDirPermissions/Module/ClicShoppingAdmin/Config/SP/SP.php, line 62 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_SEC_DIR_PERMISSIONS_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_SEC_DIR_PERMISSIONS_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/SecDirPermissions/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/SecDirPermissions/Sites/ClicShoppingAdmin/Pages/Home/templates/sec_dir_permissions.php, line 34 
  2.   if ($handle = opendir($path)) {
  4.     while (false !== ($filename = readdir($handle))) {
  6.       if (!\in_array($filename, $exclude_array)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $file = ['name' => $path . $filename,
  8.           'is_dir' => is_dir($path . $filename),
  9.           'writable' => FileSystem::isWritable($path . $filename)
  10.         ];
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/SecDirPermissions/Sites/ClicShoppingAdmin/Pages/Home/templates/sec_dir_permissions.php, line 111 
  1.               <th
  2.                 scope="row"><?php echo substr($file['name'], \strlen(CLICSHOPPING::getConfig('dir_root', 'Shop'))); ?></th>
  3.               <td
  4.                 class="text-center"><?php echo $file['writable'] === true ? '<i class="bi-check text-success"></i>' : '<i class="bi bi-x text-danger"></i>'; ?></td>
  5.               <td
  6.                 class="text-center"><?php echo(\in_array(substr($file['name'], \strlen(CLICSHOPPING::getConfig('dir_root', 'Shop'))), $whitelist_array) ? '<i class="bi-check text-success"></i>' : '<i class="bi bi-x text-danger"></i>'); ?></td>
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             </tr>
  8.             <?php
  9.           }
  10.         }
  11.         ?>
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/SecurityCheck/Module/ClicShoppingAdmin/Config/SC/SC.php, line 47 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_SECURITY_CHECK_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_SECURITY_CHECK_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/SecurityCheck/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/SecurityCheck/Sites/ClicShoppingAdmin/Pages/Home/templates/security_check.php, line 113 
  2.     <?php
  3.     foreach ($modules as $module) {
  4.       $secCheck = $GLOBALS[$module['class']];
  6.       if (!\in_array($secCheck->type, $types)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $secCheck->type = 'info';
  8.       }
  10.       $output = '';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ServiceAPP/Module/ClicShoppingAdmin/Config/SV/SV.php, line 63 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_SERVICE_APP_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_SERVICE_APP_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/ServiceAPP/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Upgrade/Module/ClicShoppingAdmin/Config/UP/UP.php, line 66 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_UPGRADE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_UPGRADE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Upgrade/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/WhosOnline/Module/ClicShoppingAdmin/Config/WO/WO.php, line 69 
  1.   public function uninstall()
  2.   {
  3.     parent::uninstall();
  5.     $installed = explode(';', MODULE_MODULES_WHOS_ONLINE_INSTALLED);
  6.     $installed_pos = array_search($this->app->vendor . '\\' . $this->app->code . '\\' . $this->code, $installed);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ($installed_pos !== false) {
  9.       unset($installed[$installed_pos]);
  11.       $this->app->saveCfgParam('MODULE_MODULES_WHOS_ONLINE_INSTALLED', implode(';', $installed));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/WhosOnline/Sites/ClicShoppingAdmin/Pages/Home/Actions/Configure.php, line 40 
  1.         $default_module = $m;
  2.         break;
  3.       }
  4.     }
  6.     $this->page->data['current_module'] = (isset($_GET['module']) && \in_array($_GET['module'], $modules)) ? $_GET['module'] : $default_module;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  8. }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/ActionToolsRegistry.php, line 49 
  1.         continue;
  2.       }
  4.       $fullClass = self::NAMESPACE_PREFIX . $fileInfo->getBasename('.php');
  6.       if (class_exists($fullClass) && in_array(ActionToolsInterface::class, class_implements($fullClass))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         try {
  8.           /** @var ActionToolsInterface $toolInstance */
  9.           $toolInstance = new $fullClass();
  10.           $toolName = $toolInstance->getName();
  11.           $this->tools[$toolName] = $fullClass;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Db.php, line 911 
  1.           $details_string = preg_replace('/comment\(.+\)$/', '', $details_string);
  2.           $details = array_filter(explode(' ', $details_string), fn($v) => $v !== null && $v !== '');
  3.           $details = array_values($details);
  4.         }
  6.         $is_binary = array_search('binary', $details);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.         if (is_int($is_binary)) {
  9.           array_splice($details, $is_binary, 1);
  10.           $schema['col'][$field_name]['binary'] = true;
  11.         }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Db.php, line 918 
  1.         if (is_int($is_binary)) {
  2.           array_splice($details, $is_binary, 1);
  3.           $schema['col'][$field_name]['binary'] = true;
  4.         }
  6.         $is_unsigned = array_search('unsigned', $details);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.         if (is_int($is_unsigned)) {
  9.           array_splice($details, $is_unsigned, 1);
  10.           $schema['col'][$field_name]['unsigned'] = true;
  11.         }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Db.php, line 925 
  1.         if (is_int($is_unsigned)) {
  2.           array_splice($details, $is_unsigned, 1);
  3.           $schema['col'][$field_name]['unsigned'] = true;
  4.         }
  6.         $is_not_null = array_search('not_null', $details);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.         if (is_int($is_not_null)) {
  9.           array_splice($details, $is_not_null, 1);
  10.           $schema['col'][$field_name]['not_null'] = true;
  11.         }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Db.php, line 932 
  1.         if (is_int($is_not_null)) {
  2.           array_splice($details, $is_not_null, 1);
  3.           $schema['col'][$field_name]['not_null'] = true;
  4.         }
  6.         $is_auto_increment = array_search('auto_increment', $details);
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.         if (preg_match('/on_update\(([^)]+)\)/', $details_string, $on_update_match)) {
  9.           $schema['col'][$field_name]['on_update'] = $on_update_match[1];
  10.           $details_string = preg_replace('/on_update\([^)]+\)/', '', $details_string);
  11.           $details = array_values(array_filter(explode(' ', $details_string)));
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/DbStatement.php, line 193 
  1.       $this->result = $this->cache_data;
  2.     } else {
  3.       $fetch_argument = $args[0] ?? null;
  4.       $ctor_args = $args[1] ?? [];
  6.       if (in_array($fetch_style, [PDO::FETCH_COLUMN])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $this->result = parent::fetchAll($fetch_style, $fetch_argument);
  8.       } elseif (in_array($fetch_style, [PDO::FETCH_CLASS, PDO::FETCH_FUNC])) {
  9.         $this->result = parent::fetchAll($fetch_style, $fetch_argument, $ctor_args);
  10.       } else {
  11.         $this->result = parent::fetchAll($fetch_style);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/DbStatement.php, line 195 
  1.       $fetch_argument = $args[0] ?? null;
  2.       $ctor_args = $args[1] ?? [];
  4.       if (in_array($fetch_style, [PDO::FETCH_COLUMN])) {
  5.         $this->result = parent::fetchAll($fetch_style, $fetch_argument);
  6.       } elseif (in_array($fetch_style, [PDO::FETCH_CLASS, PDO::FETCH_FUNC])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $this->result = parent::fetchAll($fetch_style, $fetch_argument, $ctor_args);
  8.       } else {
  9.         $this->result = parent::fetchAll($fetch_style);
  10.       }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/DirectoryListing.php, line 101 
  1.    */
  2.   public function setExcludeEntries(?array $entries)
  3.   {
  4.     if (is_array($entries)) {
  5.       foreach ($entries as $value) {
  6.         if (!in_array($value, $this->exclude_entries)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $this->exclude_entries[] = $value;
  8.         }
  9.       }
  10.     } elseif (is_string($entries)) {
  11.       if (!in_array($entries, $this->exclude_entries)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/DirectoryListing.php, line 106 
  1.         if (!in_array($value, $this->exclude_entries)) {
  2.           $this->exclude_entries[] = $value;
  3.         }
  4.       }
  5.     } elseif (is_string($entries)) {
  6.       if (!in_array($entries, $this->exclude_entries)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $this->exclude_entries[] = $entries;
  8.       }
  9.     }
  10.   }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/DirectoryListing.php, line 186 
  1.       $this->listing = array();
  2.     }
  4.     if ($dir = @dir($directory)) {
  5.       while (($entry = $dir->read()) !== false) {
  6.         if (!in_array($entry, $this->exclude_entries)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           if (($this->include_files === true) && is_file($dir->path . DIRECTORY_SEPARATOR . $entry)) {
  8.             if (empty($this->check_extension) || in_array(mb_strtolower(substr($entry, strrpos($entry, '.') + 1)), $this->check_extension)) {
  9.               if ($this->adddirectory_to_filename === true) {
  10.                 if ($dir->path !== $this->directory) {
  11.                   $entry = substr($dir->path, strlen($this->directory) + 1) . DIRECTORY_SEPARATOR . $entry;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/DirectoryListing.php, line 188 
  2.     if ($dir = @dir($directory)) {
  3.       while (($entry = $dir->read()) !== false) {
  4.         if (!in_array($entry, $this->exclude_entries)) {
  5.           if (($this->include_files === true) && is_file($dir->path . DIRECTORY_SEPARATOR . $entry)) {
  6.             if (empty($this->check_extension) || in_array(mb_strtolower(substr($entry, strrpos($entry, '.') + 1)), $this->check_extension)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               if ($this->adddirectory_to_filename === true) {
  8.                 if ($dir->path !== $this->directory) {
  9.                   $entry = substr($dir->path, strlen($this->directory) + 1) . DIRECTORY_SEPARATOR . $entry;
  10.                 }
  11.               }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Domains/AppAbstract.php, line 164 
  1.    * @param string $type The type of the module to check for.
  2.    * @return bool Returns true if the module exists, false otherwise.
  3.    */
  4.   final public function hasModule(string $module, string $type): bool
  5.   {
  6.     return isset($this->modules[$type]) && in_array($module, $this->modules[$type]);
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  9.   /**
  10.    * Sets the app information by reflecting the current class and loading data
  11.    * from a metafile. Assigns the app's code, vendor, title, version, and modules
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HTML.php, line 400 
  1.         $field .= ' id="' . static::output(substr($parameters, $offset + 4, strpos($parameters, '"', $offset + 4) - ($offset + 4))) . '_' . $counter . '"';
  2.       }
  4.       $field .= ' value="' . static::output($selection_value) . '"';
  6.       if (isset($default) && (($default === true) || (!is_array($default) && ((string)$default == (string)$selection_value)) || (is_array($default) && in_array($selection_value, $default)))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $field .= ' checked="checked"';
  8.       }
  10.       if (!empty($parameters)) {
  11.         $field .= ' ' . $parameters;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HTML.php, line 874 
  2.     if (!isset($params['type'])) {
  3.       $params['type'] = 'submit';
  4.     }
  6.     if (!in_array($params['type'], $types)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $params['type'] = 'submit';
  8.     }
  10.     if (($params['type'] == 'submit') && isset($link)) {
  11.       $params['type'] = 'button';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HTML.php, line 882 
  2.     if (($params['type'] == 'submit') && isset($link)) {
  3.       $params['type'] = 'button';
  4.     }
  6.     if (isset($style) && !in_array($style, $styles)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       unset($style);
  8.     }
  10.     if (isset($size) && !in_array($size, $size_button)) {
  11.       unset($size);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HTML.php, line 886 
  2.     if (isset($style) && !in_array($style, $styles)) {
  3.       unset($style);
  4.     }
  6.     if (isset($size) && !in_array($size, $size_button)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       unset($size);
  8.     }
  10.     $button = '';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HTTP.php, line 148 
  2.     if (!isset($data['cafile'])) {
  3.       $data['cafile'] = CLICSHOPPING::BASE_DIR . 'External/cacert.pem';
  4.     }
  6.     if (isset($data['format']) && !in_array($data['format'], ['json'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       trigger_error('HttpRequest::getResponse(): Unknown "format": ' . $data['format']);
  9.       unset($data['format']);
  10.     }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Mail.php, line 570 
  1.       ];
  4.       $domain = strtolower(substr(strrchr($email, "@"), 1));
  6.       if (in_array($domain, $temp_domains)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/MessageStack.php, line 92 
  1.     $stack = [
  2.       'text' => $message,
  3.       'type' => $type
  4.     ];
  6.     if (!$this->exists($group) || !in_array($stack, $this->data[$group])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $this->data[$group][] = $stack;
  8.     }
  9.   }
  11.   /**
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Upload.php, line 112 
  1.       }
  2.     }
  4.     if (!empty($this->_upload)) {
  5.       if (!empty($this->_extensions)) {
  6.         if (!in_array(mb_strtolower(substr($this->_upload['name'], strrpos($this->_upload['name'], '.') + 1)), $this->_extensions)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $CLICSHOPPING_MessageStack->add(CLICSHOPPING::getDef('error_filetype_not_allowed') . implode(', ', $this->_extensions), 'warning');
  9.           return false;
  10.         }
  11.       }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/ClicShoppingAdmin/ActionRecorderAdmin.php, line 69 
  1.   public function isInstalled()
  2.   {
  3.     $module = HTML::sanitize(str_replace(' ', '', $this->_module));
  5.     if (defined('MODULE_ACTION_RECORDER_INSTALLED') && !is_null(MODULE_ACTION_RECORDER_INSTALLED)) {
  6.       if (!is_null($module) && \in_array($module . '.' . substr(CLICSHOPPING::getIndex(), (strrpos(CLICSHOPPING::getIndex(), '.') + 1)), explode(';', MODULE_ACTION_RECORDER_INSTALLED))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.         if (!class_exists($module)) {
  9.           if (is_file(CLICSHOPPING::getConfig('dir_root', 'Shop') . 'Core/modules/action_recorder/' . $module . '.' . substr(CLICSHOPPING::getIndex(), (strrpos(CLICSHOPPING::getIndex(), '.') + 1)))) {
  11.             $this->lang->loadDefinitions('Shop/Module/ActionRecorder/' . $module);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/ClicShoppingAdmin/Assets/CfgParameters/clic_cfg_set_multi_template_pull_down.php, line 37 
  2.     $name = (($key) ? 'configuration[' . $key . ']' : 'configuration_value');
  4.     foreach ($contents as $item) {
  5.       $fileInfo = pathinfo($item);
  6.       if (array_key_exists('extension', $fileInfo) && \in_array($fileInfo['extension'], $fileTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $found[] = $item;
  8.       }
  9.     }
  11.     if ($found) { // Check the $found array is not empty
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/ClicShoppingAdmin/Assets/CfgParameters/ht_datepicker_jquery_edit_pages.php, line 29 
  1.   sort($select_array);
  2.   $values_array = explode(';', $values);
  4.   $output = '';
  5.   foreach ($select_array as $file) {
  6.     $output .= HTML::checkboxField('ht_datepicker_jquery_file[]', $file, \in_array($file, $values_array)) . '&nbsp;' . HTML::outputProtected($file) . '<br />';
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  9.   if (!empty($output)) {
  10.     $output = '<br />' . substr($output, 0, -6);
  11.   }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/ClicShoppingAdmin/HTMLOverrideAdmin.php, line 105 
  1.     $Qproducts->bindInt(':language_id', (int)$CLICSHOPPING_Language->getId());
  2.     $Qproducts->execute();
  4.     while ($Qproducts->fetch()) {
  5.       if (MODE_B2B_B2C == 'True') {
  6.         if (!in_array($Qproducts->valueInt('products_id'), $exclude)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.           $Qprice = $CLICSHOPPING_Db->prepare('select customers_group_price,
  9.                                                   customers_group_id
  10.                                           from :table_products_groups
  11.                                           where products_id = :products_id
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/ClicShoppingAdmin/HTMLOverrideAdmin.php, line 125 
  2.           $price_string = '';
  3.           $sde = 0;
  4. //while(list($sdek,$sdev)=each($all_groups)){
  5.           foreach ($all_groups as $sdek => $sdev) {
  6.             if (!in_array($Qproducts->valueInt('products_id') . ":" . (int)$sdek, $exclude)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.               if ($sde)
  8.                 $price_string .= ' - ';
  9.               $price_string .= $sdev . ' : ' . $CLICSHOPPING_Currencies->format(isset($product_prices[$sdek]) ? $product_prices[$sdek] : $Qproducts->valueDecimal('products_price'));
  10.               $sde = 1;
  11.             }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/ClicShoppingAdmin/HTMLOverrideAdmin.php, line 137 
  2. // Ajouter VISITOR_NAME . ': ' . $CLICSHOPPING_Currencies->format($Qproducts->valueDecimal('products_price')) pour permettre d'afficher le prix des clients qui ne font pas partie d'un groupe B2B(
  3.           $select_string .= '<option value="' . $Qproducts->valueInt('products_id') . '">' . HTML::outputProtected($Qproducts->value('products_name')) . ' (' . CLICSHOPPING::getDef('visitor_name') . ': ' . $CLICSHOPPING_Currencies->format($Qproducts->valueDecimal('products_price')) . ' - ' . $price_string . ')</option>';
  4.         }
  5.       } else {
  6.         if (!in_array($Qproducts->valueInt('products_id'), $exclude)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $select_string .= '<option value="' . $Qproducts->valueInt('products_id') . '">' . HTML::outputProtected($Qproducts->value('products_name')) . ' (' . $CLICSHOPPING_Currencies->format($Qproducts->valueDecimal('products_price')) . ')</option>';
  8.         }
  9.       }
  11. // ####### END  #######
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/ClicShoppingAdmin/ModuleDownload.php, line 103 
  1.   {
  2.     if (is_dir($source) === true) {
  3.       $files = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($source), RecursiveIteratorIterator::CHILD_FIRST);
  5.       foreach ($files as $file) {
  6.         if (in_array($file->getBasename(), array('.', '..')) !== true) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           if ($file->isDir() === true) {
  8.             rmdir($file->getPathName());
  9.           } elseif (($file->isFile() === true) || ($file->isLink() === true)) {
  10.             unlink($file->getPathname());
  11.           }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/ClicShoppingAdmin/TemplateAdmin.php, line 392 
  1.       $fileTypes = ['php']; // Create an array of file types
  2.       $found = []; // Traverse the folder, and add filename to $found array if type matches
  4.       foreach ($contents as $item) {
  5.         $fileInfo = pathinfo($item);
  6.         if (array_key_exists('extension', $fileInfo) && in_array($fileInfo['extension'], $fileTypes)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $found[] = $item;
  8.         }
  9.       }
  11.       if ($found) { // Check the $found array is not empty
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Common/B2BCommon.php, line 59 
  1.         $QpaymentsNotAllowed->execute();
  3.         $payments_not_allowed = $QpaymentsNotAllowed->fetch();
  5.         $payments_unallowed = explode(",", $payments_not_allowed['group_payment_unallowed']);
  6.         $clearance = (in_array($pay_check, $payments_unallowed)) ? true : false;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.       } elseif ($CLICSHOPPING_Customer->isLoggedOn()) {
  9.         $clearance = true;
  10.       } else {
  11.         $clearance = false;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Common/B2BCommon.php, line 78 
  2.       $Qpayments->execute();
  4.       $payments_not_allowed = $Qpayments->fetch();
  5.       $payments_unallowed = explode(",", $payments_not_allowed['group_payment_unallowed']);
  6.       $clearance = (!in_array($pay_check, $payments_unallowed)) ? true : false;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.       return $clearance;
  9.     }
  10.   }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Common/B2BCommon.php, line 122 
  1.         $QshippingNotAllowed->execute();
  3.         $shipping_not_allowed = $QshippingNotAllowed->fetch();
  5.         $shipping_unallowed = explode(",", $shipping_not_allowed['group_shipping_unallowed']);
  6.         $shipping_clearance = (in_array($shipping_check, $shipping_unallowed)) ? true : false;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       } elseif ($CLICSHOPPING_Customer->isLoggedOn()) {
  8.         $shipping_clearance = true;
  9.       } else {
  10.         $shipping_clearance = false;
  11.       }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Common/B2BCommon.php, line 143 
  1.       $shipping_not_allowed = $Qshipping->fetch();
  3.       if (!empty($shipping_not_allowed['group_payment_unallowed'])) {
  4.         $shipping_unallowed = explode(',', $shipping_not_allowed['group_payment_unallowed']);
  6.         $shipping_clearance = (!in_array($shipping_check, $shipping_unallowed)) ? true : false;
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       } else {
  8.         $shipping_clearance = false;
  9.       }
  11.       return $shipping_clearance;
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/NavigationHistory.php, line 314 
  2.     $string = '';
  4.     if (is_array($array) && !empty($array)) {
  5.       foreach ($array as $key => $value) {
  6.         if (!in_array($key, $exclude)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           $string .= $key . '=' . $value . '&';
  8.         }
  9.       }
  11.       $string = substr($string, 0, -1);
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/Pages/Account/Actions/Notifications/Process.php, line 38 
  1.     $Qglobal->execute();
  3.     $global = $Qglobal->fetch();
  5.     if (isset($_POST['action']) && ($_POST['action'] == 'process') && isset($_POST['formid']) && ($_POST['formid'] === $_SESSION['sessiontoken'])) {
  6.       if (isset($_POST['product_global']) && is_numeric($_POST['product_global']) && in_array($_POST['product_global'], ['0', '1'])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $product_global = (int)$_POST['product_global'];
  8.       } else {
  9.         $product_global = 0;
  10.       }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/Pages/Account/Actions/Notifications/Process.php, line 63 
  2.       } elseif (count($products) > 0) {
  3.         $products_parsed = [];
  5.         foreach ($products as $value) {
  6.           if (is_numeric($value) && !in_array($value, $products_parsed)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             $products_parsed[] = $value;
  8.           }
  9.         }
  11.         if (count($products_parsed) > 0) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/Payment.php, line 57 
  1.     if (defined('MODULE_PAYMENT_INSTALLED') && !is_null(MODULE_PAYMENT_INSTALLED)) {
  2.       $this->modules = explode(';', MODULE_PAYMENT_INSTALLED);
  4.       $include_modules = [];
  6.       if ((!is_null($module)) && (in_array($module . '.' . substr(CLICSHOPPING::getIndex(), (strrpos(CLICSHOPPING::getIndex(), '.') + 1)), $this->modules, true) || in_array($module, $this->modules))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.         $this->selected_module = $module;
  10.         if (str_contains($module, '\\')) {
  11.           $class = Apps::getModuleClass($module, 'Payment');
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/Payment.php, line 94 
  2.       if (($this->getCountPaymentModules() == 1) && (!isset($_SESSION['payment']) || ($_SESSION['payment'] != $include_modules[0]['class']))) {
  3.         $_SESSION['payment'] = $include_modules[0]['class'];
  4.       }
  6.       if ((!is_null($module)) && (in_array($module . '.' . substr(CLICSHOPPING::getIndex(), (strrpos(CLICSHOPPING::getIndex(), '.') + 1)), $this->modules, true) || in_array($module, $this->modules))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         if (str_contains($module, '\\')) {
  8.           $CLICSHOPPING_PM = Registry::get('Payment_' . str_replace('\\', '_', $module));
  10.           if (isset($CLICSHOPPING_PM->form_action_url)) {
  11.             /**
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/Shipping.php, line 53 
  2.           $code = $vendor . '\\' . $app . '\\' . $module;
  3.         }
  4.       }
  6.       if (isset($code) && (in_array($code . '.' . substr(CLICSHOPPING::getIndex(), (strrpos(CLICSHOPPING::getIndex(), '.') + 1)), $this->modules) || in_array($code, $this->modules))) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         if (str_contains($code, '\\')) {
  8.           $class = Apps::getModuleClass($code, 'Shipping');
  10.           $include_modules[] = [
  11.             'class' => $code,
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/Template.php, line 685 
  1.                   include($this->_directoryIncludes . $this->_directoryModules . $group . DIRECTORY_SEPARATOR . $class . '.php');
  2.                 }
  3.               }
  5. // exclude $modules_boxe and search if the modules exist
  6.               if (is_numeric(array_search($group, $this->getReadModulesDefaultDirectories())) && $group != $modules_boxes) {
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 $result = array_search($group, $this->getReadModulesDefaultDirectories());
  9.                 if (!is_null($result)) {
  10.                   if (is_file($this->getPathDirectoryTemplateThema() . $this->_directoryModules . $group . DIRECTORY_SEPARATOR . $class . '.php')) {
  11.                     include($this->getPathDirectoryTemplateThema() . $this->_directoryModules . $group . DIRECTORY_SEPARATOR . $class . '.php');
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/Template.php, line 686 
  1.                 }
  2.               }
  4. // exclude $modules_boxe and search if the modules exist
  5.               if (is_numeric(array_search($group, $this->getReadModulesDefaultDirectories())) && $group != $modules_boxes) {
  6.                 $result = array_search($group, $this->getReadModulesDefaultDirectories());
    array_search() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.                 if (!is_null($result)) {
  9.                   if (is_file($this->getPathDirectoryTemplateThema() . $this->_directoryModules . $group . DIRECTORY_SEPARATOR . $class . '.php')) {
  10.                     include($this->getPathDirectoryTemplateThema() . $this->_directoryModules . $group . DIRECTORY_SEPARATOR . $class . '.php');
  11.                   } elseif (is_file($this->getDefaultTemplateDirectory() . DIRECTORY_SEPARATOR . $this->_directoryModules . $group . DIRECTORY_SEPARATOR . $class . '.php')) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/Module/Hooks/Shop/Api/ApiPutCategories.php, line 213 
  1.     $currentParent = $newParentId;
  2.     $visitedCategories = [];
  4.     // Traverse up the parent chain to check for circular reference
  5.     while ($currentParent !== 0) {
  6.       if (in_array($currentParent, $visitedCategories)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         return true; // Already visited, indicates circular reference
  8.       }
  10.       if ($currentParent === $categoryId) {
  11.         return true; // Found the original category in the parent chain
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/Module/Hooks/Shop/Api/ApiPutSupplier.php, line 244 
  1.     // Validate numeric fields
  2.     if (isset($data['suppliers_country_id']) && !is_numeric($data['suppliers_country_id'])) {
  3.       $errors[] = 'Country ID must be numeric';
  4.     }
  6.     if (isset($data['suppliers_status']) && !in_array($data['suppliers_status'], [0, 1])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $errors[] = 'Supplier status must be 0 or 1';
  8.     }
  10.     if (isset($data['languages_id']) && !is_numeric($data['languages_id'])) {
  11.       $errors[] = 'Language ID must be numeric';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in Core/Module/SecurityCheck/extended/admin_backup_file.php, line 67 
  2.       while ($file = $dir->read()) {
  3.         if (!is_dir($backup_directory . $file)) {
  4.           $ext = substr($file, strrpos($file, '.') + 1);
  6.           if (in_array($ext, array('zip', 'sql', 'gz')) && !isset($contents[$ext])) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.             $contents[$ext] = $file;
  9.             if ($ext != 'sql') { // zip and gz (binaries) are prioritized over sql (plain text)
  10.               break;
  11.             }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in sources/template/Default/modules/modules_products_info/pi_products_info_options.php, line 209 
  1.                 }
  2.               } else {
  3.                 $products_attributes_image = '';
  4.               }
  6.               $checked = \is_array($selected_attributes) && \in_array($value['id'], $selected_attributes) ? ' checked' : '';
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.               $chk_id = 'chk_' . $QproductsOptionsName->valueInt('products_options_id') . '_' . $value['id'];
  9.               $products_options_content_display .= '<div class="col-md-12">';
  10.               $products_options_content_display .= '<span class="ModuleProductsInfoOptionsPullDownMenu">';
  11.               $products_options_content_display .= '<div class="custom-control custom-checkbox">';
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in sources/template/ExNewTemplate/css/english/compressed_css.php, line 65 
  2.   foreach ($dir_content as $key => $content) {
  3.     $path = $root_dir . DIRECTORY_SEPARATOR . $content;
  4.     if (is_file($path) && is_readable($path)) {
  5. // skip ignored files
  6.       if (!\in_array($content, $ignore_files)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         if (preg_match($ignore_regex, $content) == 0) {
  8.           $content_chunks = explode(".", $content);
  9.           $ext = $content_chunks[\count($content_chunks) - 1];
  10. // only include files with desired extensions
  11.           if (\in_array($ext, $allow_extensions)) {
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in sources/template/ExNewTemplate/css/english/compressed_css.php, line 70 
  1.       if (!\in_array($content, $ignore_files)) {
  2.         if (preg_match($ignore_regex, $content) == 0) {
  3.           $content_chunks = explode(".", $content);
  4.           $ext = $content_chunks[\count($content_chunks) - 1];
  5. // only include files with desired extensions
  6.           if (\in_array($ext, $allow_extensions)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7. // save file name with path
  8.             $all_data[] = $path;
  9.           }
  10.         }
  11.       }
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included
in sources/template/ExNewTemplate/css/english/compressed_css.php, line 79 
  1.         }
  2.       }
  3.     } // if content is a directory and readable, add path and name
  4.     elseif (is_dir($path) && is_readable($path)) {
  5.       // skip any ignored dirs
  6.       if (!\in_array($content, $ignore_dirs)) {
    in_array() should be called with the third parameter set to true to enable strict comparison and avoid type juggling bugs.
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7. // recursive callback to open new directory
  8.         $all_data = get_files($path, $all_data);
  9.       }
  10.     }
  11.   } // end foreach
  • gyakutsuki

    not implemented
  • gyakutsuki

    not included

Your project should not contain PHP files defining multiple classes 2

More information: https://insight.symfony.com/what-we-analyse/php.file_contains_more_than_one_class

in Core/ClicShopping/Apps/Tools/MCP/Classes/ClicShoppingAdmin/Exceptions/Exceptions.php
This file contains 4 classes. Keeping only one class per file is a standard in the PHP community, since it promotes interoperability and maintainability.
Time to fix: about 1 day
Read doc Open Issue Permalink Copy Prompt
Last edited by ClicShopping
  • McpException (defined at line 19)
  • McpConnectionException (defined at line 28)
  • McpProtocolException (defined at line 37)
  • McpConfigurationException (defined at line 46)
  • gyakutsuki

    Ignored on Mon, 29 Sep 2025 19:19:44 GMT
in sources/template/Default/modules/modules_header/he_header_multi_template.php
This file contains 2 classes. Keeping only one class per file is a standard in the PHP community, since it promotes interoperability and maintainability.
Time to fix: about 4 hours
Read doc Open Issue Permalink Copy Prompt
Last edited by ClicShopping
  • he_header_multi_template (defined at line 16)
  • explodeCategoryTree (defined at line 238)
  • gyakutsuki

    Ignored on Thu, 18 Sep 2025 15:32:21 GMT

Your project should use dedicated PHP string functions 262

More information: https://insight.symfony.com/what-we-analyse/php.use_string_function

in Core/ClicShopping/Apps/Tools/Backup/Classes/ClicShoppingAdmin/Backup.php, line 126 
  2.         // Track statistics
  3.         if (strlen($columnComment) > 0) {
  4.           $backup_stats['columns_with_comments']++;
  5.         }
  6.         if (strpos(strtolower($columnType), 'vector') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           $backup_stats['vector_columns']++;
  8.         }
  10.         $schema .= '  ' . $Qfields->value('COLUMN_NAME') . ' ' . $columnType;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Backup/Classes/ClicShoppingAdmin/Backup.php, line 152 
  1.           // Check if column type is VECTOR (cannot have empty string default)
  2.           $is_vector_type = preg_match('/^vector/i', $columnType);
  4.           // Check if default value is already quoted (starts and ends with single quote)
  5.           $is_already_quoted = (strlen($default_value) >= 2 && 
  6.                                 substr($default_value, 0, 1) === "'" && 
    Consider replacing substr() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                                 substr($default_value, -1) === "'");
  9.           // Skip empty string defaults for numeric types (invalid SQL)
  10.           if ($is_numeric_type && $default_value === '') {
  11.             // Don't add default clause - let MySQL use its default behavior
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Backup/Classes/ClicShoppingAdmin/Backup.php, line 153 
  1.           $is_vector_type = preg_match('/^vector/i', $columnType);
  3.           // Check if default value is already quoted (starts and ends with single quote)
  4.           $is_already_quoted = (strlen($default_value) >= 2 && 
  5.                                 substr($default_value, 0, 1) === "'" && 
  6.                                 substr($default_value, -1) === "'");
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.           // Skip empty string defaults for numeric types (invalid SQL)
  9.           if ($is_numeric_type && $default_value === '') {
  10.             // Don't add default clause - let MySQL use its default behavior
  11.           } elseif ($is_datetime_type && $default_value === '') {
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/Backup/Classes/ClicShoppingAdmin/Backup.php, line 271 
  1.               $schema .= 'NULL, ';
  2.             } elseif (!\is_null($Qrows->value($i))) {
  3.               $row = $Qrows->value($i);
  5.               // Check if this is a VECTOR column
  6.               if (isset($columnTypes[$i]) && strpos(strtolower($columnTypes[$i]), 'vector') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                 // VECTOR data is already in the correct format from MariaDB
  8.                 // Just escape it properly
  9.                 $row = addslashes($row);
  10.               } else {
  11.                 $row = addslashes($row);
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 494 
  1.           glob($oldCacheDir . 'Rag_Embedding_*.cache'),
  2.           glob($oldCacheDir . 'embedding_*.cache')
  3.         );
  4.         // Exclude embedding_search files
  5.         $oldFiles = array_filter($oldFiles, function($file) {
  6.           return strpos(basename($file), 'embedding_search_') !== 0;
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         });
  8.         $filesBefore += count($oldFiles);
  10.         // Delete old embedding cache files
  11.         foreach ($oldFiles as $file) {
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 516 
  1.         $oldFiles = array_merge(
  2.           glob($oldCacheDir . 'Rag_Embedding_*.cache'),
  3.           glob($oldCacheDir . 'embedding_*.cache')
  4.         );
  5.         $oldFiles = array_filter($oldFiles, function($file) {
  6.           return strpos(basename($file), 'embedding_search_') !== 0;
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         });
  8.         $filesAfter += count($oldFiles);
  9.       }
  11.       $results['embedding'] = $filesBefore - $filesAfter;
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 724 
  1.           $oldFiles = array_merge(
  2.             glob($oldCacheDir . 'Rag_Embedding_*.cache'),
  3.             glob($oldCacheDir . 'embedding_*.cache')
  4.           );
  5.           $oldFiles = array_filter($oldFiles, function($file) {
  6.             return strpos(basename($file), 'embedding_search_') !== 0;
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           });
  8.           $filesBefore += count($oldFiles);
  9.           foreach ($oldFiles as $file) {
  10.             @unlink($file);
  11.           }
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/reset_cache.php, line 740 
  1.           $oldFilesAfter = array_merge(
  2.             glob($oldCacheDir . 'Rag_Embedding_*.cache'),
  3.             glob($oldCacheDir . 'embedding_*.cache')
  4.           );
  5.           $oldFilesAfter = array_filter($oldFilesAfter, function($file) {
  6.             return strpos(basename($file), 'embedding_search_') !== 0;
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           });
  8.           $filesAfter += count($oldFilesAfter);
  9.         }
  11.         $results['embeddings'] = $filesBefore - $filesAfter;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubAutonomous/ConflictDetector.php, line 192 
  1.       ['grow', 'shrink']
  2.     ];
  4.     // Check if goals contain contradictory terms
  5.     foreach ($contradictions as $pair) {
  6.       $has1in1 = strpos($goal1, $pair[0]) !== false;
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $has2in1 = strpos($goal1, $pair[1]) !== false;
  8.       $has1in2 = strpos($goal2, $pair[0]) !== false;
  9.       $has2in2 = strpos($goal2, $pair[1]) !== false;
  11.       // If obj1 has first term and obj2 has second term (or vice versa)
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubAutonomous/ConflictDetector.php, line 193 
  1.     ];
  3.     // Check if goals contain contradictory terms
  4.     foreach ($contradictions as $pair) {
  5.       $has1in1 = strpos($goal1, $pair[0]) !== false;
  6.       $has2in1 = strpos($goal1, $pair[1]) !== false;
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $has1in2 = strpos($goal2, $pair[0]) !== false;
  8.       $has2in2 = strpos($goal2, $pair[1]) !== false;
  10.       // If obj1 has first term and obj2 has second term (or vice versa)
  11.       if (($has1in1 && $has2in2) || ($has2in1 && $has1in2)) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubAutonomous/ConflictDetector.php, line 194 
  2.     // Check if goals contain contradictory terms
  3.     foreach ($contradictions as $pair) {
  4.       $has1in1 = strpos($goal1, $pair[0]) !== false;
  5.       $has2in1 = strpos($goal1, $pair[1]) !== false;
  6.       $has1in2 = strpos($goal2, $pair[0]) !== false;
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $has2in2 = strpos($goal2, $pair[1]) !== false;
  9.       // If obj1 has first term and obj2 has second term (or vice versa)
  10.       if (($has1in1 && $has2in2) || ($has2in1 && $has1in2)) {
  11.         // Check if they're operating on similar subjects
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubAutonomous/ConflictDetector.php, line 195 
  1.     // Check if goals contain contradictory terms
  2.     foreach ($contradictions as $pair) {
  3.       $has1in1 = strpos($goal1, $pair[0]) !== false;
  4.       $has2in1 = strpos($goal1, $pair[1]) !== false;
  5.       $has1in2 = strpos($goal2, $pair[0]) !== false;
  6.       $has2in2 = strpos($goal2, $pair[1]) !== false;
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.       // If obj1 has first term and obj2 has second term (or vice versa)
  9.       if (($has1in1 && $has2in2) || ($has2in1 && $has1in2)) {
  10.         // Check if they're operating on similar subjects
  11.         $similarity = $this->calculateSimilarity($obj1, $obj2);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubAutonomous/ConflictDetector.php, line 352 
  1.       'database', 'table', 'index', 'query', 'cache', 'memory',
  2.       'file', 'log', 'configuration', 'setting', 'registry'
  3.     ];
  5.     foreach ($resourceKeywords as $keyword) {
  6.       if (strpos($text, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $resources[] = $keyword;
  8.       }
  9.     }
  11.     return array_unique($resources);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubAutonomous/ConflictDetector.php, line 384 
  1.       'optimize' => ['optimize', 'improve', 'enhance', 'tune']
  2.     ];
  4.     foreach ($operationPatterns as $operation => $keywords) {
  5.       foreach ($keywords as $keyword) {
  6.         if (strpos($text, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           $operations[] = $operation;
  8.           break;
  9.         }
  10.       }
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Api/Classes/Shop/ApiSecurity.php, line 484 
  1.    * @param string $ip The IP address to check
  2.    * @param string $range The CIDR range (e.g., '
  3.    */
  4.   public static function ipInRange(string $ip, string $range): bool
  5.   {
  6.     if (strpos($range, '/') === false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return $ip === $range;
  8.     }
  10.     list($subnet, $bits) = explode('/', $range);
  11.     $ip = ip2long($ip);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ModelManager.php, line 213 
  1.   {
  2.     $params = [];
  4.     // Model-specific parameter mapping
  5.     // GPT-4o-mini, GPT-4.1 series, GPT-5 series use max_completion_tokens
  6.     if (strpos($model, 'gpt-4.1-mini') === 0 || 
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         strpos($model, 'gpt-4.1') === 0 ||
  8.         strpos($model, 'gpt-5') === 0) {
  9.       $params['max_completion_tokens'] = $maxtoken;
  10.     } else {
  11.       // Default for GPT-4o, Anthropic, Mistral, LM Studio, and other models
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ModelManager.php, line 214 
  1.     $params = [];
  3.     // Model-specific parameter mapping
  4.     // GPT-4o-mini, GPT-4.1 series, GPT-5 series use max_completion_tokens
  5.     if (strpos($model, 'gpt-4.1-mini') === 0 || 
  6.         strpos($model, 'gpt-4.1') === 0 ||
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         strpos($model, 'gpt-5') === 0) {
  8.       $params['max_completion_tokens'] = $maxtoken;
  9.     } else {
  10.       // Default for GPT-4o, Anthropic, Mistral, LM Studio, and other models
  11.       $params['max_tokens'] = $maxtoken;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ModelManager.php, line 215 
  2.     // Model-specific parameter mapping
  3.     // GPT-4o-mini, GPT-4.1 series, GPT-5 series use max_completion_tokens
  4.     if (strpos($model, 'gpt-4.1-mini') === 0 || 
  5.         strpos($model, 'gpt-4.1') === 0 ||
  6.         strpos($model, 'gpt-5') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $params['max_completion_tokens'] = $maxtoken;
  8.     } else {
  9.       // Default for GPT-4o, Anthropic, Mistral, LM Studio, and other models
  10.       $params['max_tokens'] = $maxtoken;
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ModelManager.php, line 242 
  1.     $models = self::getGptModel();
  3.     foreach ($models as $modelInfo) {
  4.       if ($modelInfo['id'] === $model) {
  5.         // Check if this is a GPT-5 series model (uses reasoning API)
  6.         if (strpos($modelInfo['id'], 'gpt-5') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           return true;
  8.         }
  10.         return false;
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ModelManager.php, line 251 
  1.         return false;
  2.       }
  3.     }
  5.     // Model not found in list - check by prefix as fallback
  6.     return strpos($model, 'gpt-5') === 0;
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.   }
  9.   /**
  10.    * Get model context length limit
  11.    *
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Modules/Sites/ClicShoppingAdmin/Pages/Home/Actions/Modules/Remove.php, line 50 
  2.     $module_key = $CLICSHOPPING_CfgModule->get($set, 'key');
  4.     $appModuleType = $CLICSHOPPING_ModulesAdmin->getSwitchModules($module_type);
  6.     if (strpos($_GET['module'], '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $class = Apps::getModuleClass($_GET['module'], $appModuleType);
  9.       if (class_exists($class)) {
  10.         $file_extension = '';
  11.         $module = new $class();
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 296 
  1.             $modules_payment = explode(';', $Qconfiguration_payment->value('configuration_value'));
  3.             $include_modules = [];
  5.             foreach ($modules_payment as $value) {
  6.               if (strpos($value, '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 $class = Apps::getModuleClass($value, 'Payment');
  9.                 $include_modules[] = ['class' => $value,
  10.                   'file' => $class
  11.                 ];
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 306 
  1.                 ];
  2.               }
  3.             }
  5.             for ($i = 0, $n = \count($include_modules); $i < $n; $i++) {
  6.               if (strpos($include_modules[$i]['class'], '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 Registry::set('Payment_' . str_replace('\\', '_', $include_modules[$i]['class']), new $include_modules[$i]['file']);
  8.                 $module = Registry::get('Payment_' . str_replace('\\', '_', $include_modules[$i]['class']));
  9.                 ?>
  10.                 <div class="row">
  11.                   <div class="col-md-12">
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 366 
  1.             $modules_shipping = explode(';', $Qconfiguration_shipping->value('configuration_value'));
  3.             $include_modules = [];
  5.             foreach ($modules_shipping as $value) {
  6.               if (strpos($value, '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 $class = Apps::getModuleClass($value, 'Shipping');
  9.                 $include_modules[] = ['class' => $value,
  10.                   'file' => $class
  11.                 ];
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/edit.php, line 376 
  1.                 ];
  2.               }
  3.             }
  5.             for ($i = 0, $n = \count($include_modules); $i < $n; $i++) {
  6.               if (strpos($include_modules[$i]['class'], '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 Registry::set('Shipping_' . str_replace('\\', '_', $include_modules[$i]['class']), new $include_modules[$i]['file']);
  8.                 $module = Registry::get('Shipping_' . str_replace('\\', '_', $include_modules[$i]['class']));
  9.                 ?>
  10.                 <div class="row">
  11.                   <div class="col-md-12">
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/DataBaseTables/Sites/ClicShoppingAdmin/Pages/Home/templates/data_base_tables.php, line 156 
  2.       while ($Qcols->fetch()) {
  3.         if ($Qcols->hasValue('Collation') && !\is_null($Qcols->value('Collation'))) {
  4.           // Skip VECTOR columns - they are binary data and cannot be converted to UTF8
  5.           $columnType = strtolower($Qcols->value('Type'));
  6.           if (strpos($columnType, 'vector') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             continue;
  8.           }
  10.           if ($_POST['from_charset'] == 'auto') {
  11.             $old_charset = substr($Qcols->value('Collation'), 0, strpos($Qcols->value('Collation'), '_'));
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Classes/Shop/Security/McpSecurity.php, line 588 
  1.    * @param string $ip The IP address to check
  2.    * @param string $range The CIDR range (e.g., '192.168.1.0/24')
  3.    */
  4.   public static function ipInRange(string $ip, string $range): bool
  5.   {
  6.     if (strpos($range, '/') === false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return $ip === $range;
  8.     }
  10.     list($subnet, $bits) = explode('/', $range);
  11.     $ip = ip2long($ip);
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Db.php, line 460 
  2.     // Process special vector fields
  3.     $vector_fields = [];
  4.     foreach ($data as $field => $value) {
  5.       // Check if the field is meant to be a vector and starts with 'vec_'
  6.       if (substr($field, 0, 4) === 'vec_') {
    Consider replacing substr() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $actual_field = substr($field, 4); // Get the actual field name without 'vec_' prefix
  8.         $vector_fields[$actual_field] = $value; // Store the vector value
  9.         unset($data[$field]); // Remove the special prefixed field
  10.       }
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Db.php, line 1158 
  1.     if (!preg_match('/^[a-zA-Z0-9_]*$/', $prefix)) {
  2.       throw new \InvalidArgumentException('Invalid table prefix');
  3.     }
  5.     // Ajout d'un underscore terminal si le préfixe est non vide et ne se termine pas déjà par un underscore
  6.     if ($prefix !== '' && substr($prefix, -1) !== '_') {
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $prefix .= '_';
  8.     }
  10.     // Substitution sûre des tokens
  11.     return preg_replace_callback('/:table_([a-zA-Z0-9_]+)/', function ($matches) use ($prefix) {
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HTTP.php, line 391 
  2.     if ($path === '' || $path === '.' . $separator) {
  3.       return $systemroot;
  4.     }
  6.     if (substr($path, 0, 3) === '..' . $separator) {
    Consider replacing substr() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $path = $systemroot . $path;
  8.     }
  10.     // Normalize path
  11.     $path = rtrim($path, $separator) . $separator;
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HTTP.php, line 399 
  2.     // Normalize path
  3.     $path = rtrim($path, $separator) . $separator;
  5.     // Absolute path
  6.     if ($path[0] === $separator || strpos($path, $systemroot) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return $path;
  8.     }
  10.     // Relative path from 'Here'
  11.     if (substr($path, 0, 2) === '.' . $separator || $path[0] !== '.') {
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HTTP.php, line 404 
  1.     if ($path[0] === $separator || strpos($path, $systemroot) === 0) {
  2.       return $path;
  3.     }
  5.     // Relative path from 'Here'
  6.     if (substr($path, 0, 2) === '.' . $separator || $path[0] !== '.') {
    Consider replacing substr() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $arrn = preg_split('/\\' . $separator . '/', $path, -1, PREG_SPLIT_NO_EMPTY);
  8.       if ($arrn[0] !== '.') {
  9.         array_unshift($arrn, '.');
  10.       }
  11.       $arrn[0] = rtrim($base, $separator);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Cache/Cache.php, line 1040 
  1.     // Clear from Memcached (note: Memcached doesn't support key pattern matching easily)
  2.     // We'll rely on TTL expiration for Memcached
  4.     // Clear from file cache
  5.     foreach ($this->promptCache as $key => $data) {
  6.       if (strpos($key, $prefix) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         unset($this->promptCache[$key]);
  8.         $cleared++;
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Cache/Cache.php, line 1103 
  1.     // iterate through all keys. We'll rely on TTL expiration for Memcached.
  2.     // For production use, consider using Redis for better invalidation support.
  4.     // Invalidate from file cache
  5.     foreach ($this->promptCache as $key => $data) {
  6.       if (strpos($key, self::CACHE_TYPE_SQL) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         if (isset($data['tables_used']) && in_array($cleanTableName, $data['tables_used'], true)) {
  8.           unset($this->promptCache[$key]);
  9.           $invalidated++;
  10.         }
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Cache/Cache.php, line 1157 
  1.       }
  2.     }
  4.     // Invalidate from file cache
  5.     foreach ($this->promptCache as $key => $data) {
  6.       if (strpos($key, self::CACHE_TYPE_SQL) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         if (isset($data['tables_used'])) {
  8.           $intersection = array_intersect($cleanTableNames, $data['tables_used']);
  9.           if (!empty($intersection)) {
  10.             unset($this->promptCache[$key]);
  11.             $invalidated++;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Cache/Helper/SQLTableParser.php, line 191 
  1.   {
  2.     // Remove backticks and quotes
  3.     $tableName = str_replace(['`', '"', "'"], '', $tableName);
  5.     // Remove database prefix (e.g., database.table -> table)
  6.     if (strpos($tableName, '.') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $parts = explode('.', $tableName);
  8.       $tableName = end($parts);
  9.     }
  11.     // Remove alias (take only the first word)
  • gyakutsuki

    not included
in ClicShoppingAdmin/ajax/RAG/export.php, line 242 
  1.   if ($output !== null) {
  2.     // Envoi des Headers HTTP
  3.     header('Content-Type: ' . $mimeType);
  5.     // Détermine l'extension et encode si c'est du JSON
  6.     if (strpos($mimeType, 'json') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       // S'assurer que la sortie est un tableau/objet avant d'encoder
  8.       if (is_array($output) || is_object($output)) {
  9.         $output = json_encode($output, JSON_PRETTY_PRINT);
  10.       }
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/Actors/ReasoningActor.php, line 614 
  1.         // Simple contradiction check
  2.         $s1Lower = strtolower($statement1);
  3.         $s2Lower = strtolower($statement2);
  5.         // Check for negation patterns
  6.         if (strpos($s1Lower, 'not') !== false && strpos($s2Lower, 'not') === false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             return true;
  8.         }
  10.         return false;
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/Critics/AnalyticsCritic.php, line 387 
  1.     private function evaluateSqlEfficiency(string $sql, array $tablesUsed, string $queryType): float
  2.     {
  3.         $score = 0.7; // Base score
  5.         // Check for SELECT * (inefficient)
  6.         if (strpos($sql, 'SELECT *') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $score -= 0.2;
  8.         }
  10.         // Check for proper indexing hints
  11.         if ($this->hasProperIndexing($sql, $tablesUsed)) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/Critics/AnalyticsCritic.php, line 1001 
  1.         $queryWords = explode(' ', strtolower($userQuery));
  2.         $sqlLower = strtolower($sql);
  4.         $matches = 0;
  5.         foreach ($queryWords as $word) {
  6.             if (strlen($word) > 3 && strpos($sqlLower, $word) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                 $matches++;
  8.             }
  9.         }
  11.         return $matches > 0;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/Critics/AnalyticsCritic.php, line 1012 
  1.     }
  3.     private function hasProperIndexing(string $sql, array $tables): bool
  4.     {
  5.         // Check for WHERE clauses that might benefit from indexes
  6.         return strpos($sql, 'WHERE') !== false;
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     }
  9.     private function hasUnnecessaryJoins(string $sql): bool
  10.     {
  11.         // Count JOINs - more than 5 might be excessive
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/Critics/AnalyticsCritic.php, line 1029 
  1.     }
  3.     private function isWellFormatted(string $sql): bool
  4.     {
  5.         // Check for basic formatting (line breaks, indentation)
  6.         return strpos($sql, "\n") !== false || strpos($sql, "\r") !== false;
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     }
  9.     private function hasMeaningfulAliases(string $sql): bool
  10.     {
  11.         // Check for table aliases that are more than single letters
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/Critics/AnalyticsCritic.php, line 1046 
  1.         return false;
  2.     }
  4.     private function hasComments(string $sql): bool
  5.     {
  6.         return strpos($sql, '--') !== false || strpos($sql, '/*') !== false;
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     }
  9.     private function hasConsistentData(array $results): bool
  10.     {
  11.         if (empty($results)) return true;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/Critics/AnalyticsCritic.php, line 1106 
  1.             // Fallback to simple keyword detection if detector fails
  2.             $ambiguousTerms = ['best', 'good', 'recent', 'popular', 'top', 'better', 'worse'];
  3.             $queryLower = strtolower($query);
  5.             foreach ($ambiguousTerms as $term) {
  6.                 if (strpos($queryLower, $term) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                     return true;
  8.                 }
  9.             }
  11.             return false;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/Critics/AnalyticsCritic.php, line 1129 
  1.             'HAVING',
  2.             'DISTINCT'
  3.         ];
  5.         foreach ($slowPatterns as $pattern) {
  6.             if (strpos($sqlUpper, $pattern) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                 return true;
  8.             }
  9.         }
  11.         // Check for multiple JOINs
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubActorCritic/WeightingEngine/WeightAuditLogger.php, line 337 
  1.      * @return string Escaped value
  2.      */
  3.     private function escapeCsvValue(string $value): string
  4.     {
  5.         // Escape quotes and wrap in quotes if contains comma, quote, or newline
  6.         if (strpos($value, ',') !== false || strpos($value, '"') !== false || strpos($value, "\n") !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             return '"' . str_replace('"', '""', $value) . '"';
  8.         }
  9.         return $value;
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubAutonomous/BusinessDomainPermissionManager.php, line 325 
  2.       // Propose permission level always requires approval for write actions
  3.       if ($permissionLevel === self::PERMISSION_PROPOSE) {
  4.         $writeActions = ['create', 'update', 'delete', 'modify', 'propose'];
  5.         foreach ($writeActions as $writeAction) {
  6.           if (strpos($action, $writeAction) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             return true;
  8.           }
  9.         }
  10.       }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubCorrectionAgent/FeedbackLearner.php, line 221 
  2.     $text = strtolower("$reason $comment");
  4.     foreach ($keywords as $type => $words) {
  5.       foreach ($words as $word) {
  6.         if (strpos($text, $word) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           return $type;
  8.         }
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubIntentAnalyzer/UnifiedQueryAnalyzer.php, line 261 
  1.       // 🔍 DEBUG: Log prompt loading verification
  2.       if ($this->debug) {
  3.         error_log("[INFO : ANALYSE] [UnifiedQueryAnalyzer] Prompt Loading Verification:");
  4.         error_log("  Prompt length: " . strlen($prompt) . " characters");
  5.         error_log("  Prompt preview (first 200 chars): " . substr($prompt, 0, 200) . "...");
  6.         error_log("  Query in prompt: " . (strpos($prompt, $query) !== false ? 'YES' : 'NO'));
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       }
  9.       // Single GPT call for everything
  10.       // Use Gpt::getGptResponse() instead of non-existent complete() method
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubIntentAnalyzer/UnifiedQueryAnalyzer.php, line 1123 
  2.     if ($this->debug) {
  3.       error_log("UnifiedQueryAnalyzer: Built prompt from language file sections");
  4.       error_log("UnifiedQueryAnalyzer: Query to analyze: {$query}");
  5.       error_log("UnifiedQueryAnalyzer: Total prompt length: " . strlen($prompt) . " characters");
  6.       error_log("UnifiedQueryAnalyzer: Prompt contains query: " . (strpos($prompt, $query) !== false ? 'YES' : 'NO'));
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     }
  9.     return $prompt;
  10.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/DiagnosticManager.php, line 266 
  1.    */
  2.   private function categorizeError(string $errorMessage): string
  3.   {
  4.     $message = strtolower($errorMessage);
  6.     if (strpos($message, 'database') !== false || strpos($message, 'sql') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 'database';
  8.     }
  9.     if (strpos($message, 'timeout') !== false || strpos($message, 'time out') !== false) {
  10.       return 'timeout';
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/DiagnosticManager.php, line 269 
  1.     $message = strtolower($errorMessage);
  3.     if (strpos($message, 'database') !== false || strpos($message, 'sql') !== false) {
  4.       return 'database';
  5.     }
  6.     if (strpos($message, 'timeout') !== false || strpos($message, 'time out') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 'timeout';
  8.     }
  9.     if (strpos($message, 'memory') !== false) {
  10.       return 'memory';
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/DiagnosticManager.php, line 272 
  1.       return 'database';
  2.     }
  3.     if (strpos($message, 'timeout') !== false || strpos($message, 'time out') !== false) {
  4.       return 'timeout';
  5.     }
  6.     if (strpos($message, 'memory') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 'memory';
  8.     }
  9.     if (strpos($message, 'validation') !== false || strpos($message, 'invalid') !== false) {
  10.       return 'validation';
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/DiagnosticManager.php, line 275 
  1.       return 'timeout';
  2.     }
  3.     if (strpos($message, 'memory') !== false) {
  4.       return 'memory';
  5.     }
  6.     if (strpos($message, 'validation') !== false || strpos($message, 'invalid') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 'validation';
  8.     }
  9.     if (strpos($message, 'classification') !== false || strpos($message, 'intent') !== false) {
  10.       return 'classification';
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/DiagnosticManager.php, line 278 
  1.       return 'memory';
  2.     }
  3.     if (strpos($message, 'validation') !== false || strpos($message, 'invalid') !== false) {
  4.       return 'validation';
  5.     }
  6.     if (strpos($message, 'classification') !== false || strpos($message, 'intent') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 'classification';
  8.     }
  9.     if (strpos($message, 'api') !== false || strpos($message, 'gpt') !== false) {
  10.       return 'api';
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/DiagnosticManager.php, line 281 
  1.       return 'validation';
  2.     }
  3.     if (strpos($message, 'classification') !== false || strpos($message, 'intent') !== false) {
  4.       return 'classification';
  5.     }
  6.     if (strpos($message, 'api') !== false || strpos($message, 'gpt') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 'api';
  8.     }
  10.     return 'unknown';
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/ResponseProcessor.php, line 142 
  2.     // If it's an array, search for the response
  3.     if (is_array($executionResult)) {
  4.       if (isset($executionResult['text_response']) && !empty($executionResult['text_response'])) {
  5.         // Check if text_response is NOT the JSON fallback
  6.         if (strpos($executionResult['text_response'], 'Résultat:') === false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           return $executionResult['text_response'];
  8.         }
  9.       }
  11.       if (isset($executionResult['response']) && !empty($executionResult['response'])) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/ResponseProcessor.php, line 543 
  1.       }
  2.     }
  4.     // Priority 4: Check if rawResult has 'text_response' field (but not if it's the JSON fallback)
  5.     if (isset($rawResult['text_response']) && !empty($rawResult['text_response'])) {
  6.       if (strpos($rawResult['text_response'], 'Résultat:') === false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $rawResult['text_response'];
  8.       }
  9.     }
  11.     // Priority 5: Use finalResponse if available (but not if it's the JSON fallback)
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/ResponseProcessor.php, line 549 
  1.         return $rawResult['text_response'];
  2.       }
  3.     }
  5.     // Priority 5: Use finalResponse if available (but not if it's the JSON fallback)
  6.     if (!empty($finalResponse) && strpos($finalResponse, 'Résultat:') === false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return $finalResponse;
  8.     }
  10.     return '';
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/ResultValidator.php, line 420 
  1.     // Check if source type is valid (case-insensitive, partial match)
  2.     $sourceType = strtolower($sourceAttr['source_type']);
  3.     $isValidSource = false;
  5.     foreach ($validSourceTypes as $validType) {
  6.       if (strpos($sourceType, strtolower($validType)) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $isValidSource = true;
  8.         break;
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/SubOrchestrator/ResultValidator.php, line 469 
  1.       'as an ai',
  2.       'i\'m an ai'
  3.     ];
  5.     foreach ($genericPhrases as $phrase) {
  6.       if (strpos($response, $phrase) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $validationErrors[] = "Response contains generic LLM phrase indicating lack of knowledge";
  8.         return false;
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Orchestrator/ValidationAgent.php, line 559 
  1.       $table = $matches[1];
  2.     }
  4.     // Ajouter le préfixe si nécessaire
  5.     $prefix = CLICSHOPPING::getConfig('db_prefix');
  6.     if (!empty($prefix) && strpos($table, $prefix) !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $table = $prefix . $table;
  8.     }
  10.     return trim($table, '`"\'');
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/AnalyticsExecutor.php, line 992 
  1.   private function determineSuggestedActionForSqlError(string $errorMessage, string $temporalPeriod): string
  2.   {
  3.     $errorLower = strtolower($errorMessage);
  5.     // Check for common error patterns
  6.     if (strpos($errorLower, 'column') !== false || strpos($errorLower, 'field') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return "The database may not have the required columns for {$temporalPeriod} aggregation. Try a different time period or check your data schema.";
  8.     }
  10.     if (strpos($errorLower, 'table') !== false) {
  11.       return "The required table for {$temporalPeriod} aggregation may not exist. Verify your database structure.";
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/AnalyticsExecutor.php, line 996 
  1.     // Check for common error patterns
  2.     if (strpos($errorLower, 'column') !== false || strpos($errorLower, 'field') !== false) {
  3.       return "The database may not have the required columns for {$temporalPeriod} aggregation. Try a different time period or check your data schema.";
  4.     }
  6.     if (strpos($errorLower, 'table') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return "The required table for {$temporalPeriod} aggregation may not exist. Verify your database structure.";
  8.     }
  10.     if (strpos($errorLower, 'syntax') !== false) {
  11.       return "There was a SQL syntax error. Try rephrasing your query or using a simpler time period.";
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/AnalyticsExecutor.php, line 1000 
  2.     if (strpos($errorLower, 'table') !== false) {
  3.       return "The required table for {$temporalPeriod} aggregation may not exist. Verify your database structure.";
  4.     }
  6.     if (strpos($errorLower, 'syntax') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return "There was a SQL syntax error. Try rephrasing your query or using a simpler time period.";
  8.     }
  10.     if (strpos($errorLower, 'permission') !== false || strpos($errorLower, 'access') !== false) {
  11.       return "You may not have permission to access the required data. Contact your administrator.";
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/AnalyticsExecutor.php, line 1004 
  2.     if (strpos($errorLower, 'syntax') !== false) {
  3.       return "There was a SQL syntax error. Try rephrasing your query or using a simpler time period.";
  4.     }
  6.     if (strpos($errorLower, 'permission') !== false || strpos($errorLower, 'access') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return "You may not have permission to access the required data. Contact your administrator.";
  8.     }
  10.     if (strpos($errorLower, 'timeout') !== false) {
  11.       return "The query took too long. Try a shorter time range or simpler aggregation.";
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/AnalyticsExecutor.php, line 1008 
  2.     if (strpos($errorLower, 'permission') !== false || strpos($errorLower, 'access') !== false) {
  3.       return "You may not have permission to access the required data. Contact your administrator.";
  4.     }
  6.     if (strpos($errorLower, 'timeout') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return "The query took too long. Try a shorter time range or simpler aggregation.";
  8.     }
  10.     // Default suggestion
  11.     return "Try rephrasing your query or using a different temporal period. If the problem persists, contact support.";
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/ResultSynthesizer.php, line 1219 
  2.         // Semantic results MUST have sources OR data, unless it's a valid LLM/memory fallback
  3.         if (!$hasSources) {
  4.           $sourceType = strtolower($finalResult['source_attribution']['source_type'] ?? '');
  5.           $isLLMFallback = $hasTextResponse && (
  6.             strpos($sourceType, 'llm') !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             strpos($sourceType, 'general knowledge') !== false ||
  8.             strpos($sourceType, 'conversation') !== false ||
  9.             strpos($sourceType, 'memory') !== false
  10.           );
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/ResultSynthesizer.php, line 1220 
  1.         // Semantic results MUST have sources OR data, unless it's a valid LLM/memory fallback
  2.         if (!$hasSources) {
  3.           $sourceType = strtolower($finalResult['source_attribution']['source_type'] ?? '');
  4.           $isLLMFallback = $hasTextResponse && (
  5.             strpos($sourceType, 'llm') !== false ||
  6.             strpos($sourceType, 'general knowledge') !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             strpos($sourceType, 'conversation') !== false ||
  8.             strpos($sourceType, 'memory') !== false
  9.           );
  11.           if (!$isLLMFallback) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/ResultSynthesizer.php, line 1221 
  1.         if (!$hasSources) {
  2.           $sourceType = strtolower($finalResult['source_attribution']['source_type'] ?? '');
  3.           $isLLMFallback = $hasTextResponse && (
  4.             strpos($sourceType, 'llm') !== false ||
  5.             strpos($sourceType, 'general knowledge') !== false ||
  6.             strpos($sourceType, 'conversation') !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             strpos($sourceType, 'memory') !== false
  8.           );
  10.           if (!$isLLMFallback) {
  11.             $sourcesStatus = isset($finalResult['sources']) ? 'empty' : 'not set';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/ResultSynthesizer.php, line 1222 
  1.           $sourceType = strtolower($finalResult['source_attribution']['source_type'] ?? '');
  2.           $isLLMFallback = $hasTextResponse && (
  3.             strpos($sourceType, 'llm') !== false ||
  4.             strpos($sourceType, 'general knowledge') !== false ||
  5.             strpos($sourceType, 'conversation') !== false ||
  6.             strpos($sourceType, 'memory') !== false
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           );
  9.           if (!$isLLMFallback) {
  10.             $sourcesStatus = isset($finalResult['sources']) ? 'empty' : 'not set';
  11.             $dataStatus = isset($finalResult['data']) ? 'empty' : 'not set';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/ResultSynthesizer.php, line 1269 
  1.   private function generateUserFriendlyErrorMessage(array $errors): string
  2.   {
  3.     // Check for common error patterns and generate appropriate messages
  4.     foreach ($errors as $error) {
  5.       // Pattern: "Semantic result missing sources and data"
  6.       if (strpos($error, 'Semantic result missing sources and data') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return "I couldn't find any information about that in the database. The requested content (like terms and conditions) may not be available yet. Please try asking about something else or contact support to add this content.";
  8.       }
  10.       // Pattern: "Analytics result missing data"
  11.       if (strpos($error, 'Analytics result missing data') !== false) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/ResultSynthesizer.php, line 1274 
  1.       if (strpos($error, 'Semantic result missing sources and data') !== false) {
  2.         return "I couldn't find any information about that in the database. The requested content (like terms and conditions) may not be available yet. Please try asking about something else or contact support to add this content.";
  3.       }
  5.       // Pattern: "Analytics result missing data"
  6.       if (strpos($error, 'Analytics result missing data') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return "I couldn't retrieve the requested data. This might be because there are no records matching your query, or the data hasn't been entered yet. Please try a different query or check if the data exists.";
  8.       }
  10.       // Pattern: "Hybrid result missing"
  11.       if (strpos($error, 'Hybrid result missing') !== false) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/ResultSynthesizer.php, line 1279 
  1.       if (strpos($error, 'Analytics result missing data') !== false) {
  2.         return "I couldn't retrieve the requested data. This might be because there are no records matching your query, or the data hasn't been entered yet. Please try a different query or check if the data exists.";
  3.       }
  5.       // Pattern: "Hybrid result missing"
  6.       if (strpos($error, 'Hybrid result missing') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return "I couldn't complete your request because some of the required information is missing. Please try breaking your question into smaller parts or asking about something else.";
  8.       }
  10.       // Pattern: "Empty response"
  11.       if (strpos($error, 'empty') !== false || strpos($error, 'Empty') !== false) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/ResultSynthesizer.php, line 1284 
  1.       if (strpos($error, 'Hybrid result missing') !== false) {
  2.         return "I couldn't complete your request because some of the required information is missing. Please try breaking your question into smaller parts or asking about something else.";
  3.       }
  5.       // Pattern: "Empty response"
  6.       if (strpos($error, 'empty') !== false || strpos($error, 'Empty') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return "I couldn't find any results for your query. The information you're looking for might not be available in the system yet. Please try rephrasing your question or asking about something else.";
  8.       }
  9.     }
  11.     // Default fallback message
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/SemanticExecutor.php, line 324 
  1.           // Fallback to source_table if no name found
  2.           if ($docName === null && isset($metadata['source_table'])) {
  3.             $tableName = $metadata['source_table'];
  4.             // Remove prefix and _embedding suffix
  5.             $prefix = defined('CLICSHOPPING_DB_TABLE_PREFIX') ? CLICSHOPPING_DB_TABLE_PREFIX : 'clic_';
  6.             if (strpos($tableName, $prefix) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.               $tableName = substr($tableName, strlen($prefix));
  8.             }
  9.             $tableName = str_replace('_embedding', '', $tableName);
  10.             $tableName = str_replace('_', ' ', $tableName);
  11.             $docName = ucwords($tableName);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubPlanExecutor/SemanticExecutor.php, line 485 
  1.       return $entityType;
  2.     }
  4.     // Remove table prefix if present
  5.     $prefix = CLICSHOPPING::getConfig('db_table_prefix');
  6.     if (!empty($prefix) && strpos($tableName, $prefix) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $tableName = substr($tableName, strlen($prefix));
  8.     }
  10.     // Remove '_embedding' suffix if present
  11.     $tableName = str_replace('_embedding', '', $tableName);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubTaskPlanning/HybridQueryDecomposer.php, line 605 
  1.             }
  3.             $keywords[] = $entityType;
  4.             $keywords[] = str_replace('_', ' ', $entityType);
  6.             if (substr($entityType, -3) === 'ies') {
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                 $keywords[] = substr($entityType, 0, -3) . 'y';
  8.             } elseif (substr($entityType, -1) === 's') {
  9.                 $keywords[] = substr($entityType, 0, -1);
  10.             } else {
  11.                 $keywords[] = $entityType . 's';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubTaskPlanning/HybridQueryDecomposer.php, line 607 
  1.             $keywords[] = $entityType;
  2.             $keywords[] = str_replace('_', ' ', $entityType);
  4.             if (substr($entityType, -3) === 'ies') {
  5.                 $keywords[] = substr($entityType, 0, -3) . 'y';
  6.             } elseif (substr($entityType, -1) === 's') {
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                 $keywords[] = substr($entityType, 0, -1);
  8.             } else {
  9.                 $keywords[] = $entityType . 's';
  10.             }
  11.         }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubTaskPlanning/HybridQueryDecomposer.php, line 672 
  1.      * @return bool
  2.      */
  3.     private function hasKeyword(string $text, array $keywords): bool
  4.     {
  5.         foreach ($keywords as $keyword) {
  6.             if (strpos($text, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                 return true;
  8.             }
  9.         }
  10.         return false;
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Agents/Planning/SubTaskPlanning/SubTaskPlannerPatternAnalysis.php, line 53 
  1.         // Simple keyword matching (replaces deleted PatternAnalysisPattern)
  2.         $patternKeywords = ['pattern', 'trend', 'style', 'dominant', 'recurring', 'common'];
  3.         $queryLower = strtolower($queryToAnalyze);
  5.         foreach ($patternKeywords as $keyword) {
  6.             if (strpos($queryLower, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.                 if ($this->debug) {
  8.                     $this->logDebug("Pattern analysis keyword detected: $keyword");
  9.                 }
  10.                 return true;
  11.             }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Agent/AmbiguityOptimizer.php, line 195 
  1.     // 🔧 FIX: If interpretations array is empty, use defaults based on ambiguity type
  2.     if (empty($availableInterpretations)) {
  3.       $ambiguityType = $ambiguityAnalysis['ambiguity_type'] ?? '';
  5.       // For quantification queries, default to count and sum
  6.       if (strpos($ambiguityType, 'quantification') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $availableInterpretations = ['count', 'sum'];
  9.         if ($this->debug) {
  10.           $this->logger->logSecurityEvent(
  11.             "AmbiguityOptimizer: Empty interpretations array, using defaults for quantification: count, sum",
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Agent/DatabaseSchemaManager.php, line 245 
  2.           // Extract type from column info (now returns array with 'type' and 'comment')
  3.           $type = is_array($columnInfo) ? $columnInfo['type'] : $columnInfo;
  5.           // Detect ID columns that could be foreign keys
  6.           if (preg_match('/_id$/', $column) && strpos($type, 'int') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $relatedTable = str_replace('_id', '', $column);
  9.             // Validate related table name
  10.             $safeRelatedTable = InputValidator::sanitizeIdentifier($relatedTable);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Agent/DatabaseSchemaManager.php, line 245 
  2.           // Extract type from column info (now returns array with 'type' and 'comment')
  3.           $type = is_array($columnInfo) ? $columnInfo['type'] : $columnInfo;
  5.           // Detect ID columns that could be foreign keys
  6.           if (preg_match('/_id$/', $column) && strpos($type, 'int') !== false) {
    Consider replacing preg_match() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $relatedTable = str_replace('_id', '', $column);
  9.             // Validate related table name
  10.             $safeRelatedTable = InputValidator::sanitizeIdentifier($relatedTable);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Helper/AnalyticsErrorHandler.php, line 173 
  1.     // Load language definitions
  2.     $CLICSHOPPING_Language = Registry::get('Language');
  3.     DomainConfig::loadLanguageFile('rag_error_handler');
  5.     // Suggestions based on the type of error
  6.     if (strpos($errorMessage, 'Unknown column') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return CLICSHOPPING::getDef('text_column_reference_does_not_exist');
  8.     }
  10.     if (strpos($errorMessage, 'syntax error') !== false) {
  11.       return CLICSHOPPING::getDef('text_sql_query_generated_error');
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Helper/AnalyticsErrorHandler.php, line 177 
  1.     // Suggestions based on the type of error
  2.     if (strpos($errorMessage, 'Unknown column') !== false) {
  3.       return CLICSHOPPING::getDef('text_column_reference_does_not_exist');
  4.     }
  6.     if (strpos($errorMessage, 'syntax error') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return CLICSHOPPING::getDef('text_sql_query_generated_error');
  8.     }
  10.     if (strpos($errorMessage, 'Table') !== false && strpos($errorMessage, 'doesn\'t exist') !== false) {
  11.       return CLICSHOPPING::getDef('text_table_referenced_does_not_exist');
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Helper/AnalyticsErrorHandler.php, line 181 
  2.     if (strpos($errorMessage, 'syntax error') !== false) {
  3.       return CLICSHOPPING::getDef('text_sql_query_generated_error');
  4.     }
  6.     if (strpos($errorMessage, 'Table') !== false && strpos($errorMessage, 'doesn\'t exist') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return CLICSHOPPING::getDef('text_table_referenced_does_not_exist');
  8.     }
  10.     // Generic suggestion
  11.     return CLICSHOPPING::getDef('text_error_executing_query');
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Helper/Detection/AmbiguousQueryDetector.php, line 268 
  1.       if ($this->debug) {
  2.         error_log("AmbiguousQueryDetector: LLM returned empty interpretations for ambiguous query, generating defaults");
  3.       }
  5.       // Generate default interpretations based on ambiguity type
  6.       if (strpos($ambiguityType, 'quantification') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         // For quantification queries: count vs sum
  8.         $interpretations = [
  9.           [
  10.             'type' => 'count',
  11.             'label' => 'Count of items',
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Helper/Detection/AmbiguousQueryDetector.php, line 284 
  1.             'label' => 'Sum of quantities',
  2.             'description' => 'Sum the total quantity',
  3.             'sql_hint' => 'Use SUM(quantity_field)'
  4.           ]
  5.         ];
  6.       } else if (strpos($ambiguityType, 'scope') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         // For scope queries: all vs recent
  8.         $interpretations = [
  9.           [
  10.             'type' => 'all',
  11.             'label' => 'All items',
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Helper/Formatter/AnalyticsFormatter.php, line 109 
  1.     $isHtmlContent = false;
  3.     if (isset($results['text_response']) && !empty($results['text_response'])) {
  4.       $interpretationText = $results['text_response'];
  5.       // Check if text_response contains HTML
  6.       $isHtmlContent = (strpos($interpretationText, '<div') !== false || strpos($interpretationText, '<p>') !== false);
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     } elseif (isset($results['interpretation']) && $results['interpretation'] !== 'Array') {
  8.       $interpretationText = $results['interpretation'];
  9.     }
  11.     if (!empty($interpretationText)) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/MultiTemporalPostFilter.php, line 152 
  1.   public static function hasTemporalConnector(string $query): bool
  2.   {
  3.     $query = strtolower($query);
  5.     foreach (self::$temporalConnectors as $connector) {
  6.       if (strpos($query, $connector) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/MultiTemporalPostFilter.php, line 172 
  1.   {
  2.     $query = strtolower($query);
  3.     $detected = [];
  5.     foreach (self::$temporalConnectors as $connector) {
  6.       if (strpos($query, $connector) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $detected[] = $connector;
  8.       }
  9.     }
  11.     return $detected;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/MultiTemporalPostFilter.php, line 191 
  1.   public static function hasFinancialMetric(string $query): bool
  2.   {
  3.     $query = strtolower($query);
  5.     foreach (self::$financialMetrics as $metric) {
  6.       if (strpos($query, $metric) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/QuerySplitterPatterns.php, line 176 
  1.   public static function extractBaseMetric(string $query): ?string
  2.   {
  3.     $query = strtolower($query);
  5.     foreach (self::FINANCIAL_METRICS as $pattern => $metric) {
  6.       if (strpos($query, $pattern) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $metric;
  8.       }
  9.     }
  11.     return null;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/QuerySplitterPatterns.php, line 224 
  1.       return "year {$matches[2]}";
  2.     }
  4.     // Check for relative time patterns
  5.     foreach (self::RELATIVE_TIME_PATTERNS as $pattern => $range) {
  6.       if (strpos($query, $pattern) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $range;
  8.       }
  9.     }
  11.     return null;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/SuperlativePostFilter.php, line 59 
  1.   public static function hasSuperlativePattern(string $query): bool
  2.   {
  3.     $query = strtolower($query);
  5.     foreach (SuperlativePatterns::$superlativeKeywords as $pattern) {
  6.       if (strpos($query, $pattern) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/SuperlativePostFilter.php, line 78 
  1.   public static function hasEntityKeyword(string $query): bool
  2.   {
  3.     $query = strtolower($query);
  5.     foreach (SuperlativePatterns::$entityKeywords as $entity) {
  6.       if (strpos($query, $entity) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/SuperlativePostFilter.php, line 123 
  1.   {
  2.     $query = strtolower($query);
  3.     $detected = [];
  5.     foreach (SuperlativePatterns::$superlativeKeywords as $pattern) {
  6.       if (strpos($query, $pattern) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $detected[] = $pattern;
  8.       }
  9.     }
  11.     return $detected;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/SuperlativePostFilter.php, line 143 
  1.   {
  2.     $query = strtolower($query);
  3.     $detected = [];
  5.     foreach (SuperlativePatterns::$entityKeywords as $entity) {
  6.       if (strpos($query, $entity) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $detected[] = $entity;
  8.       }
  9.     }
  11.     return $detected;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Analytics/Patterns/TimeRangePattern.php, line 85 
  1.     }
  3.     // Check for relative time patterns
  4.     $relativePatterns = self::getRelativeTimePatterns();
  5.     foreach ($relativePatterns as $pattern => $range) {
  6.       if (strpos($query, $pattern) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $range;
  8.       }
  9.     }
  11.     // Check for date range patterns (e.g., "from January to March")
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 47 
  1.    */
  2.   private static function getApiKey(): string
  3.   {
  4.     $api_key = CLICSHOPPING_APP_CHATGPT_CH_API_KEY;
  6.     if (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'mistral') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $api_key = CLICSHOPPING_APP_CHATGPT_CH_API_KEY_MISTRAL;
  8.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage') === 0) {
  9.       $api_key = CLICSHOPPING_APP_CHATGPT_RA_API_KEY_VOYAGE_AI;
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 49 
  1.   {
  2.     $api_key = CLICSHOPPING_APP_CHATGPT_CH_API_KEY;
  4.     if (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'mistral') === 0) {
  5.       $api_key = CLICSHOPPING_APP_CHATGPT_CH_API_KEY_MISTRAL;
  6.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $api_key = CLICSHOPPING_APP_CHATGPT_RA_API_KEY_VOYAGE_AI;
  8.     }
  10.     return $api_key;
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 64 
  1.    * @param string $model The embedding model to check
  2.    * @return bool True if API keys are available, false otherwise
  3.    */
  4.   private static function checkApiKeys(string $model): bool
  5.   {
  6.     if (strpos($model, 'gpt') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return !empty(CLICSHOPPING_APP_CHATGPT_CH_API_KEY);
  8.     } elseif (strpos($model, 'mistral') === 0) {
  9.       return !empty(CLICSHOPPING_APP_CHATGPT_CH_API_KEY_MISTRAL);
  10.     } elseif (strpos($model, 'voyage') === 0) {
  11.       return !empty(CLICSHOPPING_APP_CHATGPT_RA_API_KEY_VOYAGE_AI);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 66 
  1.    */
  2.   private static function checkApiKeys(string $model): bool
  3.   {
  4.     if (strpos($model, 'gpt') === 0) {
  5.       return !empty(CLICSHOPPING_APP_CHATGPT_CH_API_KEY);
  6.     } elseif (strpos($model, 'mistral') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return !empty(CLICSHOPPING_APP_CHATGPT_CH_API_KEY_MISTRAL);
  8.     } elseif (strpos($model, 'voyage') === 0) {
  9.       return !empty(CLICSHOPPING_APP_CHATGPT_RA_API_KEY_VOYAGE_AI);
  10.     } elseif (strpos($model, 'ollama') === 0) {
  11.       return true;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 68 
  1.   {
  2.     if (strpos($model, 'gpt') === 0) {
  3.       return !empty(CLICSHOPPING_APP_CHATGPT_CH_API_KEY);
  4.     } elseif (strpos($model, 'mistral') === 0) {
  5.       return !empty(CLICSHOPPING_APP_CHATGPT_CH_API_KEY_MISTRAL);
  6.     } elseif (strpos($model, 'voyage') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return !empty(CLICSHOPPING_APP_CHATGPT_RA_API_KEY_VOYAGE_AI);
  8.     } elseif (strpos($model, 'ollama') === 0) {
  9.       return true;
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 70 
  1.       return !empty(CLICSHOPPING_APP_CHATGPT_CH_API_KEY);
  2.     } elseif (strpos($model, 'mistral') === 0) {
  3.       return !empty(CLICSHOPPING_APP_CHATGPT_CH_API_KEY_MISTRAL);
  4.     } elseif (strpos($model, 'voyage') === 0) {
  5.       return !empty(CLICSHOPPING_APP_CHATGPT_RA_API_KEY_VOYAGE_AI);
  6.     } elseif (strpos($model, 'ollama') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return true;
  8.     }
  10.     return false;
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 118 
  1.       return null;
  2.     }
  4.     $api_key = self::getApiKey();
  6.     if (strpos($model, 'gpt-large') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $config = new OpenAIConfig();
  8.       $config->apiKey = $api_key;
  9.       return new OpenAI3LargeEmbeddingGenerator($config);
  10.     } elseif (strpos($model, 'gpt-medium') === 0) {
  11.       $config = new OpenAIConfig();
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 122 
  2.     if (strpos($model, 'gpt-large') === 0) {
  3.       $config = new OpenAIConfig();
  4.       $config->apiKey = $api_key;
  5.       return new OpenAI3LargeEmbeddingGenerator($config);
  6.     } elseif (strpos($model, 'gpt-medium') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $config = new OpenAIConfig();
  8.       $config->apiKey = $api_key;
  9.       return new OpenAI3SmallEmbeddingGenerator($config);
  10.     } elseif (strpos($model, 'mistral') === 0) {
  11.       $config = new OpenAIConfig();
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 126 
  1.       return new OpenAI3LargeEmbeddingGenerator($config);
  2.     } elseif (strpos($model, 'gpt-medium') === 0) {
  3.       $config = new OpenAIConfig();
  4.       $config->apiKey = $api_key;
  5.       return new OpenAI3SmallEmbeddingGenerator($config);
  6.     } elseif (strpos($model, 'mistral') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $config = new OpenAIConfig();
  8.       $config->apiKey = $api_key;
  9.       return new MistralEmbeddingGenerator($config);
  10.     } elseif (strpos($model, 'voyage3-large') === 0) {
  11.       $config = new VoyageAIConfig();
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 130 
  1.       return new OpenAI3SmallEmbeddingGenerator($config);
  2.     } elseif (strpos($model, 'mistral') === 0) {
  3.       $config = new OpenAIConfig();
  4.       $config->apiKey = $api_key;
  5.       return new MistralEmbeddingGenerator($config);
  6.     } elseif (strpos($model, 'voyage3-large') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $config = new VoyageAIConfig();
  8.       $config->apiKey = $api_key;
  9.       return new Voyage3LargeEmbeddingGenerator($config);
  10.     } elseif (strpos($model, 'voyage3-lite') === 0) {
  11.       $config = new VoyageAIConfig();
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 134 
  1.       return new MistralEmbeddingGenerator($config);
  2.     } elseif (strpos($model, 'voyage3-large') === 0) {
  3.       $config = new VoyageAIConfig();
  4.       $config->apiKey = $api_key;
  5.       return new Voyage3LargeEmbeddingGenerator($config);
  6.     } elseif (strpos($model, 'voyage3-lite') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $config = new VoyageAIConfig();
  8.       $config->apiKey = $api_key;
  9.       return new Voyage3LiteEmbeddingGenerator($config);
  10.     } elseif (strpos($model, 'voyage3') === 0) {
  11.       $config = new VoyageAIConfig();
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 138 
  1.       return new Voyage3LargeEmbeddingGenerator($config);
  2.     } elseif (strpos($model, 'voyage3-lite') === 0) {
  3.       $config = new VoyageAIConfig();
  4.       $config->apiKey = $api_key;
  5.       return new Voyage3LiteEmbeddingGenerator($config);
  6.     } elseif (strpos($model, 'voyage3') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $config = new VoyageAIConfig();
  8.       $config->apiKey = $api_key;
  9.       return new Voyage3EmbeddingGenerator($config);
  10.     } else {
  11.       return new OllamaEmbeddingGenerator($model);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 341 
  1.         $errorMessage .= " (estimated tokens: {$estimatedTokens}, chunk size: {$token_length})";
  2.       }
  4.       error_log($errorMessage);
  6.       if (strpos($e->getMessage(), 'maximum context length') !== false && $token_length > 200) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         error_log("Retrying with smaller chunk size...");
  8.         return self::createEmbedding($path_file_upload, $text_description, (int)($token_length / 2));
  9.       }
  11.       return null;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 432 
  1.    */
  2.   private static function estimateTokenCount(string $text): int
  3.   {
  4.     $model = CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL;
  6.     if (strpos($model, 'gpt') === 0 || strpos($model, 'voyage') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $avgCharsPerToken = 3.5;
  8.       return (int)ceil(strlen($text) / $avgCharsPerToken);
  9.     }
  11.     return (int)ceil(strlen($text) / 4);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 798 
  1.    *
  2.    * @return int The embedding length in dimensions for the selected model
  3.    */
  4.   public static function getEmbeddingLength(): int
  5.   {
  6.     if (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'gpt-large') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 3072;
  8.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'gpt-medium') === 0) {
  9.       return 1536;
  10.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'mistral') === 0) {
  11.       return 1024;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 800 
  1.    */
  2.   public static function getEmbeddingLength(): int
  3.   {
  4.     if (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'gpt-large') === 0) {
  5.       return 3072;
  6.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'gpt-medium') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 1536;
  8.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'mistral') === 0) {
  9.       return 1024;
  10.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-large') === 0) {
  11.       return 4096;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 802 
  1.   {
  2.     if (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'gpt-large') === 0) {
  3.       return 3072;
  4.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'gpt-medium') === 0) {
  5.       return 1536;
  6.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'mistral') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 1024;
  8.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-large') === 0) {
  9.       return 4096;
  10.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-lite') === 0) {
  11.       return 384;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 804 
  1.       return 3072;
  2.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'gpt-medium') === 0) {
  3.       return 1536;
  4.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'mistral') === 0) {
  5.       return 1024;
  6.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-large') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 4096;
  8.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-lite') === 0) {
  9.       return 384;
  10.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3') === 0) {
  11.       return 1024;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 806 
  1.       return 1536;
  2.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'mistral') === 0) {
  3.       return 1024;
  4.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-large') === 0) {
  5.       return 4096;
  6.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-lite') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 384;
  8.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3') === 0) {
  9.       return 1024;
  10.     } else {
  11.       return 1536;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 808 
  1.       return 1024;
  2.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-large') === 0) {
  3.       return 4096;
  4.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3-lite') === 0) {
  5.       return 384;
  6.     } elseif (strpos(CLICSHOPPING_APP_CHATGPT_RA_EMBEDDING_MODEL, 'voyage3') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return 1024;
  8.     } else {
  9.       return 1536;
  10.     }
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 835 
  1.       'voyage3-lite' => 4000,
  2.       'nomic-embed-text' => 8192,
  3.     ];
  5.     foreach ($contextLengths as $modelPrefix => $length) {
  6.       if (strpos($model, $modelPrefix) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $length;
  8.       }
  9.     }
  11.     return 4096;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 863 
  1.       'voyage3-lite' => 300,
  2.       'nomic-embed-text' => 800,
  3.     ];
  5.     foreach ($chunkSizes as $modelPrefix => $size) {
  6.       if (strpos($model, $modelPrefix) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $size;
  8.       }
  9.     }
  11.     return 500;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 878 
  1.    * @param string $model
  2.    * @return string
  3.    */
  4.   private static function getModelProvider(string $model): string
  5.   {
  6.     if (strpos($model, 'gpt') === 0) return 'openai';
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     if (strpos($model, 'mistral') === 0) return 'mistral';
  8.     if (strpos($model, 'voyage') === 0) return 'voyageai';
  9.     if (strpos($model, 'nomic') === 0) return 'ollama';
  11.     return 'unknown';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 879 
  1.    * @return string
  2.    */
  3.   private static function getModelProvider(string $model): string
  4.   {
  5.     if (strpos($model, 'gpt') === 0) return 'openai';
  6.     if (strpos($model, 'mistral') === 0) return 'mistral';
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     if (strpos($model, 'voyage') === 0) return 'voyageai';
  8.     if (strpos($model, 'nomic') === 0) return 'ollama';
  10.     return 'unknown';
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 880 
  1.    */
  2.   private static function getModelProvider(string $model): string
  3.   {
  4.     if (strpos($model, 'gpt') === 0) return 'openai';
  5.     if (strpos($model, 'mistral') === 0) return 'mistral';
  6.     if (strpos($model, 'voyage') === 0) return 'voyageai';
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     if (strpos($model, 'nomic') === 0) return 'ollama';
  9.     return 'unknown';
  10.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/NewVector.php, line 881 
  1.   private static function getModelProvider(string $model): string
  2.   {
  3.     if (strpos($model, 'gpt') === 0) return 'openai';
  4.     if (strpos($model, 'mistral') === 0) return 'mistral';
  5.     if (strpos($model, 'voyage') === 0) return 'voyageai';
  6.     if (strpos($model, 'nomic') === 0) return 'ollama';
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     return 'unknown';
  9.   }
  11.   //*********************
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Embedding/VectorType.php, line 109 
  1.     if ($value === null) {
  2.       return null;
  3.     }
  5.     // Si la valeur est déjà une chaîne formatée correctement, la retourner telle quelle
  6.     if (is_string($value) && strpos($value, '[') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       return $value;
  8.     }
  10.     // Convertir le tableau en chaîne formatée pour MariaDB
  11.     if (is_array($value)) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityHelper.php, line 54 
  1.     if (isset($specialCases[$entityType])) {
  2.       return $specialCases[$entityType];
  3.     }
  5.     // Handle compound words with underscores (e.g., "return_orders" -> "return_order")
  6.     if (strpos($entityType, '_') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $parts = explode('_', $entityType);
  8.       $lastPart = array_pop($parts);
  10.       // Apply singularization to the last part only
  11.       $singularLastPart = self::singularizeWord($lastPart);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityHelper.php, line 83 
  1.     if (strlen($word) < 2) {
  2.       return $word;
  3.     }
  5.     // Words ending in "ies" -> "y" (e.g., "categories" -> "category")
  6.     if (substr($word, -3) === 'ies') {
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return substr($word, 0, -3) . 'y';
  8.     }
  10.     // Words ending in "es" -> remove "es" (e.g., "boxes" -> "box")
  11.     if (substr($word, -2) === 'es') {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityHelper.php, line 88 
  1.     if (substr($word, -3) === 'ies') {
  2.       return substr($word, 0, -3) . 'y';
  3.     }
  5.     // Words ending in "es" -> remove "es" (e.g., "boxes" -> "box")
  6.     if (substr($word, -2) === 'es') {
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return substr($word, 0, -2);
  8.     }
  10.     // Words ending in "s" -> remove "s" (e.g., "products" -> "product")
  11.     if (substr($word, -1) === 's') {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityHelper.php, line 93 
  1.     if (substr($word, -2) === 'es') {
  2.       return substr($word, 0, -2);
  3.     }
  5.     // Words ending in "s" -> remove "s" (e.g., "products" -> "product")
  6.     if (substr($word, -1) === 's') {
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return substr($word, 0, -1);
  8.     }
  10.     // No change needed
  11.     return $word;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityHelper.php, line 128 
  1.     if (isset($specialCases[$entityType])) {
  2.       return $specialCases[$entityType];
  3.     }
  5.     // Handle compound words with underscores
  6.     if (strpos($entityType, '_') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $parts = explode('_', $entityType);
  8.       $lastPart = array_pop($parts);
  10.       // Apply pluralization to the last part only
  11.       $pluralLastPart = self::pluralizeWord($lastPart);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityHelper.php, line 157 
  1.     if (strlen($word) < 2) {
  2.       return $word;
  3.     }
  5.     // Words ending in "y" -> "ies" (e.g., "category" -> "categories")
  6.     if (substr($word, -1) === 'y') {
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return substr($word, 0, -1) . 'ies';
  8.     }
  10.     // Words ending in "s", "x", "z", "ch", "sh" -> add "es"
  11.     if (preg_match('/(s|x|z|ch|sh)$/i', $word)) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityIdExtractor.php, line 171 
  1.     // Check for table names in FROM clause
  2.     foreach ($entityColumnMap as $columnName => $entityType) {
  3.       $tableName = str_replace('_id', '', $columnName);
  5.       // Check if table name appears in query
  6.       if (strpos($sqlLower, "from {$tableName}") !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($sqlLower, "from clic_{$tableName}") !== false ||
  8.           strpos($sqlLower, "join {$tableName}") !== false ||
  9.           strpos($sqlLower, "join clic_{$tableName}") !== false) {
  11.         return [
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityIdExtractor.php, line 172 
  1.     foreach ($entityColumnMap as $columnName => $entityType) {
  2.       $tableName = str_replace('_id', '', $columnName);
  4.       // Check if table name appears in query
  5.       if (strpos($sqlLower, "from {$tableName}") !== false ||
  6.           strpos($sqlLower, "from clic_{$tableName}") !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($sqlLower, "join {$tableName}") !== false ||
  8.           strpos($sqlLower, "join clic_{$tableName}") !== false) {
  10.         return [
  11.           'entity_id' => null, // Can't extract ID from query alone
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityIdExtractor.php, line 173 
  1.       $tableName = str_replace('_id', '', $columnName);
  3.       // Check if table name appears in query
  4.       if (strpos($sqlLower, "from {$tableName}") !== false ||
  5.           strpos($sqlLower, "from clic_{$tableName}") !== false ||
  6.           strpos($sqlLower, "join {$tableName}") !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($sqlLower, "join clic_{$tableName}") !== false) {
  9.         return [
  10.           'entity_id' => null, // Can't extract ID from query alone
  11.           'entity_type' => $entityType,
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityIdExtractor.php, line 174 
  2.       // Check if table name appears in query
  3.       if (strpos($sqlLower, "from {$tableName}") !== false ||
  4.           strpos($sqlLower, "from clic_{$tableName}") !== false ||
  5.           strpos($sqlLower, "join {$tableName}") !== false ||
  6.           strpos($sqlLower, "join clic_{$tableName}") !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.         return [
  9.           'entity_id' => null, // Can't extract ID from query alone
  10.           'entity_type' => $entityType,
  11.         ];
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Patterns/Common/ContextResetPattern.php, line 112 
  1.   {
  2.     $markers = self::getResetMarkers();
  3.     $queryLower = mb_strtolower($query);
  5.     foreach ($markers as $marker) {
  6.       if (strpos($queryLower, $marker) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Patterns/Common/ContextResetPattern.php, line 136 
  1.     $markers = self::getResetMarkers();
  2.     $queryLower = mb_strtolower($query);
  3.     $foundMarkers = [];
  5.     foreach ($markers as $marker) {
  6.       if (strpos($queryLower, $marker) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $foundMarkers[] = $marker;
  8.       }
  9.     }
  11.     $hasReset = !empty($foundMarkers);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Patterns/Common/ModificationKeywordsPattern.php, line 82 
  1.   {
  2.     $keywords = self::getModificationKeywords();
  3.     $queryLower = mb_strtolower($query);
  5.     foreach ($keywords as $keyword) {
  6.       if (strpos($queryLower, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/CoreAI/Patterns/Common/ModificationKeywordsPattern.php, line 102 
  1.   {
  2.     $keywords = self::getModificationKeywords();
  3.     $queryLower = mb_strtolower($query);
  5.     foreach ($keywords as $keyword) {
  6.       if (strpos($queryLower, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $keyword;
  8.       }
  9.     }
  11.     return null;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Hybrid/Helper/Formatter/SubResultFormatters/ComplexQueryFormatter.php, line 102 
  1.     $isHtmlContent = false;
  3.     if (isset($results['text_response']) && !empty($results['text_response'])) {
  4.       $interpretationText = $results['text_response'];
  5.       // Check if text_response contains HTML
  6.       $isHtmlContent = (strpos($interpretationText, '<div') !== false || strpos($interpretationText, '<p>') !== false);
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     } elseif (isset($results['response']) && !empty($results['response'])) {
  8.       $interpretationText = $results['response'];
  9.     } elseif (isset($results['interpretation']) && $results['interpretation'] !== 'Array') {
  10.       $interpretationText = $results['interpretation'];
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Executor/SemanticQueryExecutor.php, line 303 
  1.             $tableName = $metadata['source_table'];
  3.             // Remove prefix and _embedding suffix
  4.             $prefix = CLICSHOPPING::getConfig('db_table_prefix');
  6.             if (strpos($tableName, $prefix) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.               $tableName = substr($tableName, strlen($prefix));
  8.             }
  9.             $tableName = str_replace('_embedding', '', $tableName);
  10.             $tableName = str_replace('_', ' ', $tableName);
  11.             $docName = ucwords($tableName);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Helper/SemanticDomainDetector.php, line 63 
  2.       foreach ($termGroups as $groupType => $terms) {
  3.         $weight = $this->termWeights[$groupType] ?? 0.5;
  5.         foreach ($terms as $term) {
  6.           if (strpos($query, $term) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $domainScore += $weight;
  8.             $matchedTerms[] = [
  9.               'term' => $term,
  10.               'type' => $groupType,
  11.               'weight' => $weight,
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Helper/SemanticDomainDetector.php, line 159 
  2.         $supplierBonus = 0;
  3.         $manufacturerBonus = 0;
  5.         foreach ($supplierIndicators as $indicator) {
  6.           if (strpos($query, $indicator) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $supplierBonus += 1.0;
  8.           }
  9.         }
  11.         foreach ($manufacturerIndicators as $indicator) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Helper/SemanticDomainDetector.php, line 165 
  1.             $supplierBonus += 1.0;
  2.           }
  3.         }
  5.         foreach ($manufacturerIndicators as $indicator) {
  6.           if (strpos($query, $indicator) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $manufacturerBonus += 1.0;
  8.           }
  9.         }
  11.         $scores['suppliers']['score'] += $supplierBonus;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Helper/SemanticDomainDetector.php, line 188 
  1.       if (abs($reviewScore - $sentimentScore) < 0.5) {
  2.         $sentimentIndicators = ['sentiment', 'feeling', 'positive', 'negative', 'emotion', 'analysis'];
  4.         $sentimentBonus = 0;
  5.         foreach ($sentimentIndicators as $indicator) {
  6.           if (strpos($query, $indicator) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $sentimentBonus += 0.5;
  8.           }
  9.         }
  11.         if ($sentimentBonus > 0) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/FeedbackAnalyzer.php, line 67 
  1.       'wrong category',
  2.       'incorrect classification'
  3.     ];
  5.     foreach ($classificationKeywords as $keyword) {
  6.       if (strpos($comment, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     if ($reason === 'irrelevant') {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/FeedbackAnalyzer.php, line 244 
  2.       $isClassificationError = false;
  3.       $errorType = 'unknown';
  5.       // Detect classification errors
  6.       if (strpos($comment, 'wrong type') !== false || 
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($comment, 'misclassified') !== false ||
  8.           strpos($comment, 'should be analytics') !== false ||
  9.           strpos($comment, 'should be semantic') !== false) {
  10.         $isClassificationError = true;
  11.         $errorType = 'misclassification';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/FeedbackAnalyzer.php, line 245 
  1.       $isClassificationError = false;
  2.       $errorType = 'unknown';
  4.       // Detect classification errors
  5.       if (strpos($comment, 'wrong type') !== false || 
  6.           strpos($comment, 'misclassified') !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($comment, 'should be analytics') !== false ||
  8.           strpos($comment, 'should be semantic') !== false) {
  9.         $isClassificationError = true;
  10.         $errorType = 'misclassification';
  11.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/FeedbackAnalyzer.php, line 246 
  1.       $errorType = 'unknown';
  3.       // Detect classification errors
  4.       if (strpos($comment, 'wrong type') !== false || 
  5.           strpos($comment, 'misclassified') !== false ||
  6.           strpos($comment, 'should be analytics') !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($comment, 'should be semantic') !== false) {
  8.         $isClassificationError = true;
  9.         $errorType = 'misclassification';
  10.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
  11.         $isClassificationError = true;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/FeedbackAnalyzer.php, line 247 
  2.       // Detect classification errors
  3.       if (strpos($comment, 'wrong type') !== false || 
  4.           strpos($comment, 'misclassified') !== false ||
  5.           strpos($comment, 'should be analytics') !== false ||
  6.           strpos($comment, 'should be semantic') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $isClassificationError = true;
  8.         $errorType = 'misclassification';
  9.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
  10.         $isClassificationError = true;
  11.         $errorType = 'irrelevant_result';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/FeedbackAnalyzer.php, line 250 
  1.           strpos($comment, 'misclassified') !== false ||
  2.           strpos($comment, 'should be analytics') !== false ||
  3.           strpos($comment, 'should be semantic') !== false) {
  4.         $isClassificationError = true;
  5.         $errorType = 'misclassification';
  6.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $isClassificationError = true;
  8.         $errorType = 'irrelevant_result';
  9.       } elseif ($reason === 'incomplete' && strpos($comment, 'wrong') !== false) {
  10.         $isClassificationError = true;
  11.         $errorType = 'partial_misclassification';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/FeedbackAnalyzer.php, line 253 
  1.         $isClassificationError = true;
  2.         $errorType = 'misclassification';
  3.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
  4.         $isClassificationError = true;
  5.         $errorType = 'irrelevant_result';
  6.       } elseif ($reason === 'incomplete' && strpos($comment, 'wrong') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $isClassificationError = true;
  8.         $errorType = 'partial_misclassification';
  9.       }
  11.       if ($isClassificationError) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/ThresholdManager.php, line 165 
  2.       $isClassificationError = false;
  3.       $errorType = 'unknown';
  5.       // Detect classification errors
  6.       if (strpos($comment, 'wrong type') !== false || 
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($comment, 'misclassified') !== false ||
  8.           strpos($comment, 'should be analytics') !== false ||
  9.           strpos($comment, 'should be semantic') !== false) {
  10.         $isClassificationError = true;
  11.         $errorType = 'misclassification';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/ThresholdManager.php, line 166 
  1.       $isClassificationError = false;
  2.       $errorType = 'unknown';
  4.       // Detect classification errors
  5.       if (strpos($comment, 'wrong type') !== false || 
  6.           strpos($comment, 'misclassified') !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($comment, 'should be analytics') !== false ||
  8.           strpos($comment, 'should be semantic') !== false) {
  9.         $isClassificationError = true;
  10.         $errorType = 'misclassification';
  11.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/ThresholdManager.php, line 167 
  1.       $errorType = 'unknown';
  3.       // Detect classification errors
  4.       if (strpos($comment, 'wrong type') !== false || 
  5.           strpos($comment, 'misclassified') !== false ||
  6.           strpos($comment, 'should be analytics') !== false ||
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           strpos($comment, 'should be semantic') !== false) {
  8.         $isClassificationError = true;
  9.         $errorType = 'misclassification';
  10.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
  11.         $isClassificationError = true;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/ThresholdManager.php, line 168 
  2.       // Detect classification errors
  3.       if (strpos($comment, 'wrong type') !== false || 
  4.           strpos($comment, 'misclassified') !== false ||
  5.           strpos($comment, 'should be analytics') !== false ||
  6.           strpos($comment, 'should be semantic') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $isClassificationError = true;
  8.         $errorType = 'misclassification';
  9.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
  10.         $isClassificationError = true;
  11.         $errorType = 'irrelevant_result';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/ThresholdManager.php, line 171 
  1.           strpos($comment, 'misclassified') !== false ||
  2.           strpos($comment, 'should be analytics') !== false ||
  3.           strpos($comment, 'should be semantic') !== false) {
  4.         $isClassificationError = true;
  5.         $errorType = 'misclassification';
  6.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $isClassificationError = true;
  8.         $errorType = 'irrelevant_result';
  9.       } elseif ($reason === 'incomplete' && strpos($comment, 'wrong') !== false) {
  10.         $isClassificationError = true;
  11.         $errorType = 'partial_misclassification';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/ThresholdManager.php, line 174 
  1.         $isClassificationError = true;
  2.         $errorType = 'misclassification';
  3.       } elseif ($reason === 'irrelevant' || strpos($comment, 'irrelevant') !== false) {
  4.         $isClassificationError = true;
  5.         $errorType = 'irrelevant_result';
  6.       } elseif ($reason === 'incomplete' && strpos($comment, 'wrong') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $isClassificationError = true;
  8.         $errorType = 'partial_misclassification';
  9.       }
  11.       if ($isClassificationError) {
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/TranslationHandler.php, line 223 
  1.     if (preg_match('/is:\s*["\'](.+?)["\']$/i', $cleaned, $matches)) {
  2.       $cleaned = $matches[1];
  3.     }
  5.     // STEP 4: Remove leading/trailing quotes if they wrap the entire string
  6.     if ((substr($cleaned, 0, 1) === '"' && substr($cleaned, -1) === '"') ||
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         (substr($cleaned, 0, 1) === "'" && substr($cleaned, -1) === "'")) {
  8.       $cleaned = substr($cleaned, 1, -1);
  9.     }
  11.     return trim($cleaned);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/TranslationHandler.php, line 223 
  1.     if (preg_match('/is:\s*["\'](.+?)["\']$/i', $cleaned, $matches)) {
  2.       $cleaned = $matches[1];
  3.     }
  5.     // STEP 4: Remove leading/trailing quotes if they wrap the entire string
  6.     if ((substr($cleaned, 0, 1) === '"' && substr($cleaned, -1) === '"') ||
    Consider replacing substr() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         (substr($cleaned, 0, 1) === "'" && substr($cleaned, -1) === "'")) {
  8.       $cleaned = substr($cleaned, 1, -1);
  9.     }
  11.     return trim($cleaned);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/TranslationHandler.php, line 224 
  1.       $cleaned = $matches[1];
  2.     }
  4.     // STEP 4: Remove leading/trailing quotes if they wrap the entire string
  5.     if ((substr($cleaned, 0, 1) === '"' && substr($cleaned, -1) === '"') ||
  6.         (substr($cleaned, 0, 1) === "'" && substr($cleaned, -1) === "'")) {
    Consider replacing substr() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $cleaned = substr($cleaned, 1, -1);
  8.     }
  10.     return trim($cleaned);
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/Semantic/Processor/TranslationHandler.php, line 224 
  1.       $cleaned = $matches[1];
  2.     }
  4.     // STEP 4: Remove leading/trailing quotes if they wrap the entire string
  5.     if ((substr($cleaned, 0, 1) === '"' && substr($cleaned, -1) === '"') ||
  6.         (substr($cleaned, 0, 1) === "'" && substr($cleaned, -1) === "'")) {
    Consider replacing substr() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $cleaned = substr($cleaned, 1, -1);
  8.     }
  10.     return trim($cleaned);
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Helper/Formatter/WebSearchFormatter.php, line 89 
  1.     if ($this->debug) {
  2.       error_log('[WebSearchFormatter] Formatting web search results\n');
  3.       error_log('[WebSearchFormatter] Result keys: ' . implode(', ', array_keys($results)) . "\n");
  4.       error_log('[WebSearchFormatter] Has text_response: ' . (isset($results['text_response']) ? 'YES' : 'NO') . "\n");
  5.       if (isset($results['text_response'])) {
  6.         $isHtml = (strpos($results['text_response'], '<') !== false);
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         error_log('[WebSearchFormatter] text_response is HTML: ' . ($isHtml ? 'YES' : 'NO') . "\n");
  8.         error_log('[WebSearchFormatter] text_response length: ' . strlen($results['text_response']) . "\n");
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Helper/Formatter/WebSearchFormatter.php, line 115 
  1.     $isHtmlContent = false;
  3.     if (isset($results['text_response']) && !empty($results['text_response'])) {
  4.       $interpretationText = $results['text_response'];
  5.       // Check if text_response contains HTML (from ResultSynthesizer)
  6.       $isHtmlContent = (strpos($interpretationText, '<div') !== false || strpos($interpretationText, '<p>') !== false);
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     } elseif (isset($results['interpretation']) && $results['interpretation'] !== 'Array') {
  8.       $interpretationText = $results['interpretation'];
  9.     } elseif (isset($results['response']) && !empty($results['response'])) {
  10.       $interpretationText = $results['response'];
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Patterns/WebSearchPostFilter.php, line 108 
  2.     // Check if query has entity keywords (database query, not web search)
  3.     // 🔧 MIGRATION: Use centralized EntityKeywordsPattern instead of WebSearchPatterns
  4.     $hasEntityKeyword = false;
  5.     foreach (WebSearchPatterns::getEntityKeywords() as $entity) {
  6.       if (strpos($query, $entity) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $hasEntityKeyword = true;
  8.         break;
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Patterns/WebSearchPostFilter.php, line 117 
  1.     }
  3.     // Check if query has financial metric keywords (analytics query, not web search)
  4.     $hasFinancialKeyword = false;
  5.     foreach ($financialMetricKeywords as $keyword) {
  6.       if (strpos($query, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $hasFinancialKeyword = true;
  8.         break;
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Patterns/WebSearchPostFilter.php, line 126 
  1.     }
  3.     // Only apply trends/news override if NO entity keywords AND NO financial keywords present
  4.     if (!$hasEntityKeyword && !$hasFinancialKeyword) {
  5.       foreach (WebSearchPatterns::$trendsNewsKeywords as $keyword) {
  6.         if (strpos($query, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           $analysis['intent_type'] = 'web_search';
  8.           $analysis['confidence'] = 0.95;
  9.           $analysis['override_reason'] = "Trends/news keyword detected: $keyword (no entity/financial keywords)";
  10.           $analysis['detection_method'] = 'pattern_post_filter';
  11.           return $analysis;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Patterns/WebSearchPostFilter.php, line 141 
  1.     // ========================================================================
  2.     // STEP 2: Check for competitor keywords (ENGLISH ONLY)
  3.     // ========================================================================
  5.     foreach (WebSearchPatterns::$competitorKeywords as $keyword) {
  6.       if (strpos($query, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $analysis['intent_type'] = 'web_search';
  8.         $analysis['confidence'] = 0.95;
  9.         $analysis['override_reason'] = "Competitor keyword detected: $keyword";
  10.         $analysis['detection_method'] = 'pattern_post_filter';
  11.         return $analysis;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Patterns/WebSearchPostFilter.php, line 172 
  1.         $externalSites[] = strtolower($row['site_domain']);
  2.       }
  4.       // Check if query mentions any configured external site
  5.       foreach ($externalSites as $site) {
  6.         if (strpos($query, $site) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           $analysis['intent_type'] = 'web_search';
  8.           $analysis['confidence'] = 0.95;
  9.           $analysis['override_reason'] = "External site detected: $site (from database)";
  10.           $analysis['detection_method'] = 'pattern_post_filter';
  11.           return $analysis;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Patterns/WebSearchPostFilter.php, line 194 
  2.     // Only check comparison if query is price-related
  3.     $hasPriceKeyword = false;
  5.     foreach (WebSearchPatterns::$priceKeywords as $priceWord) {
  6.       if (strpos($query, $priceWord) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $hasPriceKeyword = true;
  8.         break;
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Patterns/WebSearchPostFilter.php, line 202 
  1.       }
  2.     }
  4.     if ($hasPriceKeyword) {
  5.       foreach (WebSearchPatterns::$comparisonKeywords as $keyword) {
  6.         if (strpos($query, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           // Additional check: ensure it's not just internal comparison
  8.           // If query contains "database" or "internal", it's likely hybrid, not pure web_search
  9.           if (strpos($query, 'database') === false && strpos($query, 'internal') === false) {
  10.             $analysis['intent_type'] = 'web_search';
  11.             $analysis['confidence'] = 0.90;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/DomainsAI/WebSearch/Patterns/WebSearchPostFilter.php, line 205 
  1.     if ($hasPriceKeyword) {
  2.       foreach (WebSearchPatterns::$comparisonKeywords as $keyword) {
  3.         if (strpos($query, $keyword) !== false) {
  4.           // Additional check: ensure it's not just internal comparison
  5.           // If query contains "database" or "internal", it's likely hybrid, not pure web_search
  6.           if (strpos($query, 'database') === false && strpos($query, 'internal') === false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $analysis['intent_type'] = 'web_search';
  8.             $analysis['confidence'] = 0.90;
  9.             $analysis['override_reason'] = "Price comparison detected: $keyword";
  10.             $analysis['detection_method'] = 'pattern_post_filter';
  11.             return $analysis;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Metrics/ApiCostCalculator.php, line 121 
  1.       return self::PRICING[$model];
  2.     }
  4.     // Match partiel (ex: "gpt-4-0613" match "gpt-4")
  5.     foreach (self::PRICING as $knownModel => $pricing) {
  6.       if (strpos($model, $knownModel) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $pricing;
  8.       }
  9.     }
  11.     // Détection par provider
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Metrics/ApiCostCalculator.php, line 127 
  1.         return $pricing;
  2.       }
  3.     }
  5.     // Détection par provider
  6.     if (strpos($model, 'gpt') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return self::PRICING['gpt-3.5-turbo']; // Défaut OpenAI
  8.     }
  9.     if (strpos($model, 'claude') !== false) {
  10.       return self::PRICING['claude-3-haiku']; // Défaut Anthropic (le moins cher)
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Metrics/ApiCostCalculator.php, line 130 
  2.     // Détection par provider
  3.     if (strpos($model, 'gpt') !== false) {
  4.       return self::PRICING['gpt-3.5-turbo']; // Défaut OpenAI
  5.     }
  6.     if (strpos($model, 'claude') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return self::PRICING['claude-3-haiku']; // Défaut Anthropic (le moins cher)
  8.     }
  9.     if (strpos($model, 'mistral') !== false) {
  10.       return self::PRICING['mistral-small']; // Défaut Mistral
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Metrics/ApiCostCalculator.php, line 133 
  1.       return self::PRICING['gpt-3.5-turbo']; // Défaut OpenAI
  2.     }
  3.     if (strpos($model, 'claude') !== false) {
  4.       return self::PRICING['claude-3-haiku']; // Défaut Anthropic (le moins cher)
  5.     }
  6.     if (strpos($model, 'mistral') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return self::PRICING['mistral-small']; // Défaut Mistral
  8.     }
  9.     if (strpos($model, 'llama') !== false || strpos($model, 'ollama') !== false) {
  10.       return [0.0, 0.0]; // Local, gratuit
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Metrics/ApiCostCalculator.php, line 136 
  1.       return self::PRICING['claude-3-haiku']; // Défaut Anthropic (le moins cher)
  2.     }
  3.     if (strpos($model, 'mistral') !== false) {
  4.       return self::PRICING['mistral-small']; // Défaut Mistral
  5.     }
  6.     if (strpos($model, 'llama') !== false || strpos($model, 'ollama') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return [0.0, 0.0]; // Local, gratuit
  8.     }
  10.     return null;
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Monitoring/MonitoringAgent.php, line 204 
  1.       $metrics = array_merge($metrics, $componentStats);
  2.     }
  4.     // Méthodes spécifiques par type de composant
  5.     switch (true) {
  6.       case strpos($name, 'Planner') !== false:
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $metrics['type'] = 'planner';
  8.         $metrics['total_plans'] = $componentStats['total_plans_created'] ?? 0;
  9.         $metrics['avg_steps'] = $componentStats['avg_steps_per_plan'] ?? 0;
  10.         break;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Monitoring/MonitoringAgent.php, line 210 
  1.         $metrics['type'] = 'planner';
  2.         $metrics['total_plans'] = $componentStats['total_plans_created'] ?? 0;
  3.         $metrics['avg_steps'] = $componentStats['avg_steps_per_plan'] ?? 0;
  4.         break;
  6.       case strpos($name, 'Memory') !== false:
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $metrics['type'] = 'memory';
  8.         if (method_exists($component, 'getStats')) {
  9.           $memStats = $component->getStats();
  10.           $metrics['total_interactions'] = $memStats['total_interactions'] ?? 0;
  11.           $metrics['memory_size'] = $memStats['total_size'] ?? 0;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Monitoring/MonitoringAgent.php, line 219 
  1.           $metrics['total_interactions'] = $memStats['total_interactions'] ?? 0;
  2.           $metrics['memory_size'] = $memStats['total_size'] ?? 0;
  3.         }
  4.         break;
  6.       case strpos($name, 'Correction') !== false:
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $metrics['type'] = 'correction';
  8.         if (method_exists($component, 'getLearningStats')) {
  9.           $learnStats = $component->getLearningStats();
  10.           $metrics['correction_accuracy'] = $learnStats['correction_accuracy'] ?? 0;
  11.           $metrics['learned_patterns'] = $learnStats['learned_patterns'] ?? 0;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Monitoring/MonitoringAgent.php, line 228 
  1.           $metrics['correction_accuracy'] = $learnStats['correction_accuracy'] ?? 0;
  2.           $metrics['learned_patterns'] = $learnStats['learned_patterns'] ?? 0;
  3.         }
  4.         break;
  6.       case strpos($name, 'WebSearch') !== false:
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $metrics['type'] = 'web_search';
  8.         $metrics['cache_hit_rate'] = $this->extractCacheHitRate($componentStats);
  9.         break;
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Orm/DoctrineOrm.php, line 120 
  2.       if ($serverVersion) {
  3.         $serverVersionLower = strtolower($serverVersion);
  5.         // Extraire et formater correctement la version
  6.         if (strpos($serverVersionLower, 'mariadb') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           // Format typique: "10.11.8-MariaDB" ou "11.7.0-mariadb"
  8.           preg_match('/(\d+\.\d+\.\d+)/', $serverVersion, $matches);
  10.           if (!empty($matches[1])) {
  11.             $versionNumber = $matches[1];
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Orm/DoctrineOrm.php, line 769 
  1.       return true;
  2.     }
  4.     // Fuzzy match
  5.     foreach ($allFields as $field) {
  6.       if (strpos($field, $word) !== false || strpos($word, $field) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     // Check against non-database words
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Orm/DoctrineOrm.php, line 806 
  1.     if (in_array($fieldName, $skipFields, true)) {
  2.       return null;
  3.     }
  5.     // Remove _id suffix for non-ID fields
  6.     if ($fieldName !== 'id' && preg_match('/_id$/', $fieldName)) {
    Consider replacing preg_match() with str_ends_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return null;
  8.     }
  10.     return $fieldName;
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Orm/DoctrineOrm.php, line 1089 
  1.       if (self::$prefixDb === null) {
  2.         self::$prefixDb = CLICSHOPPING::getConfig('db_table_prefix');
  3.       }
  5.       // Add prefix if not already present
  6.       if (strpos($tableName, self::$prefixDb) !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $tableName = self::$prefixDb . $tableName;
  8.       }
  10.       $connection = self::getEntityManager()->getConnection();
  11.       $affectedRows = $connection->insert($tableName, $data);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Orm/DoctrineOrm.php, line 1124 
  1.       if (self::$prefixDb === null) {
  2.         self::$prefixDb = CLICSHOPPING::getConfig('db_table_prefix');
  3.       }
  5.       // Add prefix if not already present
  6.       if (strpos($tableName, self::$prefixDb) !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $tableName = self::$prefixDb . $tableName;
  8.       }
  10.       $connection = self::getEntityManager()->getConnection();
  11.       return $connection->update($tableName, $data, $criteria);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Orm/DoctrineOrm.php, line 1155 
  1.       if (self::$prefixDb === null) {
  2.         self::$prefixDb = CLICSHOPPING::getConfig('db_table_prefix');
  3.       }
  5.       // Add prefix if not already present
  6.       if (strpos($tableName, self::$prefixDb) !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $tableName = self::$prefixDb . $tableName;
  8.       }
  10.       $connection = self::getEntityManager()->getConnection();
  11.       return $connection->delete($tableName, $criteria);
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Prompt/PromptBuilder.php, line 274 
  1.       error_log("text_order_calculation length: " . strlen($orderCalculation) . " chars");
  2.       error_log("text_query_examples length: " . strlen($queryExamples) . " chars");
  3.       error_log("sqlFormatInstructions length: " . strlen($sqlFormatInstructions) . " chars");
  4.       error_log("text_response_format length: " . strlen($responseFormat) . " chars");
  5.       error_log("text_multi_token_rules length: " . strlen($multiTokenRules) . " chars");
  6.       error_log("Contains 'MULTI-TOKEN' in multiTokenRules: " . (strpos($multiTokenRules, 'MULTI-TOKEN') !== false ? 'YES' : 'NO'));
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       error_log("Contains 'ABSOLUTE RULE' in aggregationRules: " . (strpos($aggregationRules, 'ABSOLUTE RULE') !== false ? 'YES' : 'NO'));
  8.       error_log("First 200 chars of multiTokenRules: " . substr($multiTokenRules, 0, 200));
  9.       error_log("================================================================================");
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Prompt/PromptBuilder.php, line 275 
  1.       error_log("text_query_examples length: " . strlen($queryExamples) . " chars");
  2.       error_log("sqlFormatInstructions length: " . strlen($sqlFormatInstructions) . " chars");
  3.       error_log("text_response_format length: " . strlen($responseFormat) . " chars");
  4.       error_log("text_multi_token_rules length: " . strlen($multiTokenRules) . " chars");
  5.       error_log("Contains 'MULTI-TOKEN' in multiTokenRules: " . (strpos($multiTokenRules, 'MULTI-TOKEN') !== false ? 'YES' : 'NO'));
  6.       error_log("Contains 'ABSOLUTE RULE' in aggregationRules: " . (strpos($aggregationRules, 'ABSOLUTE RULE') !== false ? 'YES' : 'NO'));
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       error_log("First 200 chars of multiTokenRules: " . substr($multiTokenRules, 0, 200));
  8.       error_log("================================================================================");
  9.     }
  11.     // Construct complete message in the correct order
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Prompt/PromptBuilder.php, line 310 
  1.       error_log("================================================================================");
  2.       error_log("DEBUG PromptBuilder::buildSystemMessage() - FINAL");
  3.       error_log("================================================================================");
  4.       error_log("Language ID: " . $this->languageId);
  5.       error_log("Final message length: " . strlen($finalMessage));
  6.       error_log("Contains 'CRITICAL RULES': " . (strpos($finalMessage, 'CRITICAL RULES') !== false ? 'YES' : 'NO'));
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       error_log("Contains 'products_quantity': " . (strpos($finalMessage, 'products_quantity') !== false ? 'YES' : 'NO'));
  8.       error_log("First 500 chars: " . substr($finalMessage, 0, 500));
  9.       error_log("================================================================================");
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Prompt/PromptBuilder.php, line 311 
  1.       error_log("DEBUG PromptBuilder::buildSystemMessage() - FINAL");
  2.       error_log("================================================================================");
  3.       error_log("Language ID: " . $this->languageId);
  4.       error_log("Final message length: " . strlen($finalMessage));
  5.       error_log("Contains 'CRITICAL RULES': " . (strpos($finalMessage, 'CRITICAL RULES') !== false ? 'YES' : 'NO'));
  6.       error_log("Contains 'products_quantity': " . (strpos($finalMessage, 'products_quantity') !== false ? 'YES' : 'NO'));
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       error_log("First 500 chars: " . substr($finalMessage, 0, 500));
  8.       error_log("================================================================================");
  9.     }
  11.     return $finalMessage;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Prompt/PromptBuilder.php, line 489 
  2.     while ($tableRow = $tablesResult->fetch()) {
  3.       $tableName = array_values($tableRow)[0];
  5.       // Skip non-clic tables
  6.       if (strpos($tableName, 'clic_') !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         continue;
  8.       }
  10.       $schema .= "Table: {$tableName}\n";
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Schema/ColumnIndex.php, line 83 
  1.       }
  2.     }
  4.     foreach ($tablesList as $tableName) {
  5.       // Skip technical tables
  6.       if (strpos($tableName, '_embedding') !== false || strpos($tableName, $prefix . 'rag_') === 0) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         continue;
  8.       }
  10.       $this->totalTables++;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Schema/ColumnIndex.php, line 83 
  1.       }
  2.     }
  4.     foreach ($tablesList as $tableName) {
  5.       // Skip technical tables
  6.       if (strpos($tableName, '_embedding') !== false || strpos($tableName, $prefix . 'rag_') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         continue;
  8.       }
  10.       $this->totalTables++;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Schema/SchemaEmbedder.php, line 159 
  2.     while ($Qembeddings->fetch()) {
  3.       $tableName = $Qembeddings->value('table_name');
  5.       // Skip technical tables (should not be in embeddings, but filter just in case)
  6.       if (strpos($tableName, '_embedding') !== false || strpos($tableName, 'clic_rag_') === 0) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         continue;
  8.       }
  10.       $embeddingText = $Qembeddings->value('embedding_text');
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Schema/SchemaEmbedder.php, line 159 
  2.     while ($Qembeddings->fetch()) {
  3.       $tableName = $Qembeddings->value('table_name');
  5.       // Skip technical tables (should not be in embeddings, but filter just in case)
  6.       if (strpos($tableName, '_embedding') !== false || strpos($tableName, 'clic_rag_') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         continue;
  8.       }
  10.       $embeddingText = $Qembeddings->value('embedding_text');
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Schema/SchemaRetriever.php, line 378 
  1.    * @param string $tableName Table name
  2.    * @return bool True if junction table
  3.    */
  4.   private function isJunctionTable(string $tableName): bool
  5.   {
  6.     return preg_match('/_to_/', $tableName) === 1;
    Consider replacing preg_match() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.   }
  9.   /**
  10.    * Calculate cosine similarity between two vectors
  11.    *
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Infrastructure/Storage/MariaDBVectorStore.php, line 66 
  1.   public function __construct(EmbeddingGeneratorInterface $embeddingGenerator, string $tableName = 'rag_embeddings')
  2.   {
  3.     $this->embeddingGenerator = $embeddingGenerator;
  4.     $prefix = CLICSHOPPING::getConfig('db_table_prefix');
  6.     if (!empty($prefix) && strpos($tableName, $prefix) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $this->tableName = $tableName;
  8.     } else {
  9.       $this->tableName = $prefix . $tableName;
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Rag/MultiDBRAGManager.php, line 1512 
  1.     if (isset($metadata['source_table']) && !empty($metadata['source_table'])) {
  2.       $tableName = $metadata['source_table'];
  4.       // Remove prefix and _embedding suffix
  5.       $prefix = CLICSHOPPING::getConfig('db_table_prefix');
  6.       if (!empty($prefix) && strpos($tableName, $prefix) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $tableName = substr($tableName, strlen($prefix));
  8.       }
  9.       $tableName = str_replace('_embedding', '', $tableName);
  11.       // Convert to readable format (e.g., "pages_manager_description" -> "Pages Manager Description")
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Security/InputValidator.php, line 357 
  2.     // Check if the path is within allowed directories
  3.     $isAllowed = false;
  4.     foreach ($allowedDirs as $allowedDir) {
  5.       $normalizedAllowedDir = str_replace('\\', '/', realpath($allowedDir));
  6.       if ($normalizedAllowedDir && strpos($realPath, $normalizedAllowedDir) === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $isAllowed = true;
  8.         break;
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Security/LlmGuardrails.php, line 330 
  1.    * @return bool True if the text contains valid JSON, false otherwise.
  2.    */
  3.   private static function validateJsonStructure(string $text): bool
  4.   {
  5.     // Si le texte contient du JSON, vérifier sa validité
  6.     if (strpos($text, '{') !== false || strpos($text, '[') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       return json_last_error() === JSON_ERROR_NONE;
  8.     }
  10.     return true; // Pas de JSON détecté
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Security/ObfuscationPreprocessor.php, line 165 
  1.    */
  2.   private static function containsMaliciousPatterns(string $text): bool
  3.   {
  4.     $lowerText = strtolower($text);
  5.     foreach (ObfuscationPatterns::$maliciousKeywords as $keyword) {
  6.       if (strpos($lowerText, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Tools/Performance/QueryPerformanceMonitor.php, line 204 
  1.    */
  2.   private function detectQueryType(string $sql): string
  3.   {
  4.     $sql = trim(strtoupper($sql));
  6.     if (strpos($sql, 'SELECT') === 0) return 'SELECT';
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     if (strpos($sql, 'INSERT') === 0) return 'INSERT';
  8.     if (strpos($sql, 'UPDATE') === 0) return 'UPDATE';
  9.     if (strpos($sql, 'DELETE') === 0) return 'DELETE';
  11.     return 'UNKNOWN';
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Tools/Performance/QueryPerformanceMonitor.php, line 205 
  1.   private function detectQueryType(string $sql): string
  2.   {
  3.     $sql = trim(strtoupper($sql));
  5.     if (strpos($sql, 'SELECT') === 0) return 'SELECT';
  6.     if (strpos($sql, 'INSERT') === 0) return 'INSERT';
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     if (strpos($sql, 'UPDATE') === 0) return 'UPDATE';
  8.     if (strpos($sql, 'DELETE') === 0) return 'DELETE';
  10.     return 'UNKNOWN';
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Tools/Performance/QueryPerformanceMonitor.php, line 206 
  1.   {
  2.     $sql = trim(strtoupper($sql));
  4.     if (strpos($sql, 'SELECT') === 0) return 'SELECT';
  5.     if (strpos($sql, 'INSERT') === 0) return 'INSERT';
  6.     if (strpos($sql, 'UPDATE') === 0) return 'UPDATE';
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     if (strpos($sql, 'DELETE') === 0) return 'DELETE';
  9.     return 'UNKNOWN';
  10.   }
  • gyakutsuki

    not included
in Core/ClicShopping/AI/Tools/Performance/QueryPerformanceMonitor.php, line 207 
  1.     $sql = trim(strtoupper($sql));
  3.     if (strpos($sql, 'SELECT') === 0) return 'SELECT';
  4.     if (strpos($sql, 'INSERT') === 0) return 'INSERT';
  5.     if (strpos($sql, 'UPDATE') === 0) return 'UPDATE';
  6.     if (strpos($sql, 'DELETE') === 0) return 'DELETE';
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     return 'UNKNOWN';
  9.   }
  11.   /**
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/Patterns/AnalyticsPatterns.php, line 106 
  1.   {
  2.     $query = strtolower($query);
  3.     $metrics = self::getMetricsPatterns();
  5.     foreach ($metrics as $pattern => $metric) {
  6.       if (strpos($query, $pattern) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return $metric;
  8.       }
  9.     }
  11.     return null;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/Patterns/AnalyticsPatterns.php, line 209 
  1.   public static function hasTimePeriod(string $query): bool
  2.   {
  3.     $query = strtolower($query);
  5.     foreach (self::$timePeriods as $period) {
  6.       if (strpos($query, $period) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         return true;
  8.       }
  9.     }
  11.     return false;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/Patterns/AnalyticsPatterns.php, line 286 
  1.   {
  2.     $query = strtolower($query);
  3.     $detected = [];
  5.     foreach (self::$financialMetrics as $metric) {
  6.       if (strpos($query, $metric) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $detected[] = $metric;
  8.       }
  9.     }
  11.     return $detected;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/Patterns/AnalyticsPatterns.php, line 306 
  1.   {
  2.     $query = strtolower($query);
  3.     $detected = [];
  5.     foreach (self::$timePeriods as $period) {
  6.       if (strpos($query, $period) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $detected[] = $period;
  8.       }
  9.     }
  11.     return $detected;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/Patterns/HybridPreFilter.php, line 89 
  2.     $hasConjunction = false;
  3.     $conjunctionUsed = '';
  5.     foreach ($conjunctions as $conj) {
  6.       if (strpos($query, $conj) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $hasConjunction = true;
  8.         $conjunctionUsed = trim($conj);
  9.         break;
  10.       }
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/Patterns/HybridPreFilter.php, line 157 
  1.       $part = trim($part);
  2.       $partIntent = null;
  4.       // Check analytics
  5.       foreach ($analyticsKeywords as $keyword) {
  6.         if (strpos($part, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           $partIntent = 'analytics';
  8.           break;
  9.         }
  10.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/Patterns/HybridPreFilter.php, line 166 
  1.       }
  3.       // Check semantic
  4.       if ($partIntent === null) {
  5.         foreach ($semanticKeywords as $keyword) {
  6.           if (strpos($part, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $partIntent = 'semantic';
  8.             break;
  9.           }
  10.         }
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/Patterns/HybridPreFilter.php, line 176 
  1.       }
  3.       // Check web_search
  4.       if ($partIntent === null) {
  5.         foreach ($webSearchKeywords as $keyword) {
  6.           if (strpos($part, $keyword) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $partIntent = 'web_search';
  8.             break;
  9.           }
  10.         }
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/ACP/ACP.php, line 156 
  1. // Simple routing
  3. // --------------------------------------------------------------------------------
  4. // POST /agentic_commerce/delegate_payment - Handle delegated payment vaulting
  5. // --------------------------------------------------------------------------------
  6.     if ($method === 'POST' && ($hasDelegatePaymentParam || strpos($path, '/agentic_commerce/delegate_payment') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $headers = [
  8.         'idempotency_key' => $_SERVER['HTTP_IDEMPOTENCY_KEY'] ?? null,
  9.         'request_id' => $_SERVER['HTTP_REQUEST_ID'] ?? null
  10.       ];
  11.       $result = $CLICSHOPPING_getRetailers->handleDelegatePayment($input, $headers);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/ACP/ACP.php, line 171 
  2. // --------------------------------------------------------------------------------
  3. // GET /products - Returns product catalog
  4. // --------------------------------------------------------------------------------
  6.     if ($method === 'GET' && ($hasProductsParam || strpos($path, '/products') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       // Return full product catalog
  8.       $products = $CLICSHOPPING_getRetailers->getProducts();
  9.       echo json_encode(['products' => $products], JSON_UNESCAPED_SLASHES);
  11.       exit;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/ACP/ACP.php, line 218 
  1.     } elseif (!empty($checkoutIdParam)) {
  2.       // Fallback ou prise en compte du paramètre 'id' si l'ID n'est pas dans le chemin
  3.       $sessionId = $checkoutIdParam;
  4.     }
  6.     if ($method === 'POST' && ($hasCheckoutParam || strpos($path, '/checkout_sessions') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if ($sessionId) {
  8.         if ($hasCompleteParam || strpos($path, '/complete') !== false) {
  9.           $validation = $CLICSHOPPING_getRetailers->validateAcpInput($input, 'complete', $input['items'] ?? []);
  10.           if (!empty($validation)) {
  11.             http_response_code(400);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/ACP/ACP.php, line 220 
  1.       $sessionId = $checkoutIdParam;
  2.     }
  4.     if ($method === 'POST' && ($hasCheckoutParam || strpos($path, '/checkout_sessions') !== false)) {
  5.       if ($sessionId) {
  6.         if ($hasCompleteParam || strpos($path, '/complete') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           $validation = $CLICSHOPPING_getRetailers->validateAcpInput($input, 'complete', $input['items'] ?? []);
  8.           if (!empty($validation)) {
  9.             http_response_code(400);
  10.             echo json_encode(['messages' => $validation], JSON_UNESCAPED_SLASHES);
  11.             exit;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/ACP/ACP.php, line 238 
  1.               echo json_encode($result['checkout_session'], JSON_UNESCAPED_SLASHES);
  2.             } else {
  3.               echo json_encode($result, JSON_UNESCAPED_SLASHES);
  4.             }
  5.           }
  6.         } elseif ($hasCancelParam || strpos($path, '/cancel') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           $result = $CLICSHOPPING_getRetailers->cancelSession($sessionId);
  8.           if ($result === null) {
  9.             http_response_code(404);
  10.             echo json_encode(['error' => 'Session not found']);
  11.           } else {
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/ACP/ACP.php, line 367 
  1.       exit;
  2.     }
  3. // --------------------------------------------------------------------------------
  4. // POST /stripe_webhook - Handle Stripe webhooks
  5. // --------------------------------------------------------------------------------
  6.     if ($method === 'POST' && ($hasStripeWebhookParam || strpos($path, '/stripe_webhook') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $CLICSHOPPING_getRetailers->handleStripeWebhook();
  9.       exit;
  10.     }
  11. // --------------------------------------------------------------------------------
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/ACP/ACP.php, line 378 
  1. // POST /create_order - Create ClicShopping order from session
  2. // --------------------------------------------------------------------------------
  3.     $hasCreateOrderParam = isset($_GET['create_order']);
  4.     $orderSessionIdParam = isset($_GET['session_id']) ? (string)$_GET['session_id'] : null;
  6.     if ($method === 'POST' && ($hasCreateOrderParam || strpos($path, '/create_order') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if (empty($orderSessionIdParam)) {
  8.         http_response_code(400);
  9.         echo json_encode(['error' => 'Session ID required']);
  10.         exit;
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/ACP/ACP.php, line 398 
  1. // POST /complete_and_order - Complete session then create order
  2. // --------------------------------------------------------------------------------
  3.     $hasCompleteAndOrderParam = isset($_GET['complete_and_order']);
  4.     $completeSessionIdParam = isset($_GET['session_id']) ? (string)$_GET['session_id'] : null;
  6.     if ($method === 'POST' && ($hasCompleteAndOrderParam || strpos($path, '/complete_and_order') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if (empty($completeSessionIdParam)) {
  8.         http_response_code(400);
  9.         echo json_encode(['error' => 'Session ID required']);
  10.         exit;
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/UCP/UCP.php, line 173 
  1.     $hasCheckoutParam = isset($_GET['checkout_sessions']) || isset($_GET['retailers/checkout_sessions']);
  2.     $checkoutIdParam = isset($_GET['id']) ? (string)$_GET['id'] : null;
  3.     $hasCompleteParam = isset($_GET['complete']);
  4.     $hasWebhookParam = isset($_GET['webhook']);
  6.     if ($method === 'GET' && ($hasProductsParam || strpos($path, '/products') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $filters = [
  8.         'page' => $_GET['page'] ?? 1,
  9.         'limit' => $_GET['limit'] ?? 100,
  10.         'category' => $_GET['category'] ?? null,
  11.         'min_price' => $_GET['min_price'] ?? null,
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/UCP/UCP.php, line 192 
  1.         'action' => 'products'
  2.       ]);
  3.       exit;
  4.     }
  6.     if ($method === 'POST' && ($hasCheckoutParam || strpos($path, '/checkout_sessions') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if (($hasCompleteParam || strpos($path, '/complete') !== false) && (($checkoutIdParam !== null) || preg_match('#/checkout_sessions/([^/]+)/complete#', $path, $matches))) {
  8.         $sessionId = $checkoutIdParam ?? $matches[1] ?? null;
  9.         if (!$sessionId) {
  10.           $errorResponse('VALIDATION_ERROR', 'Missing session id');
  11.         }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/UCP/UCP.php, line 193 
  1.       ]);
  2.       exit;
  3.     }
  5.     if ($method === 'POST' && ($hasCheckoutParam || strpos($path, '/checkout_sessions') !== false)) {
  6.       if (($hasCompleteParam || strpos($path, '/complete') !== false) && (($checkoutIdParam !== null) || preg_match('#/checkout_sessions/([^/]+)/complete#', $path, $matches))) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $sessionId = $checkoutIdParam ?? $matches[1] ?? null;
  8.         if (!$sessionId) {
  9.           $errorResponse('VALIDATION_ERROR', 'Missing session id');
  10.         }
  11.         $result = $ucp->completeSession($sessionId, $input);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/AI/Ecommerce/Sites/Shop/Pages/UCP/UCP.php, line 252 
  1.         'action' => 'checkout_sessions.update'
  2.       ]);
  3.       exit;
  4.     }
  6.     if ($method === 'POST' && ($hasWebhookParam || strpos($path, '/webhook') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $result = $ucp->handleWebhook($input);
  8.       echo json_encode($result, JSON_UNESCAPED_SLASHES);
  9.       $logger->info('UCP response', [
  10.         'request_id' => $requestId,
  11.         'status' => 200,
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Products/Classes/Shop/DynamicPricingRules.php, line 446 
  1.      * @return bool True if it contains a comparison operator, false otherwise.
  2.      */
  3.     private function isComparisonClause(string $clause): bool
  4.     {
  5.       foreach (self::ALLOWED_OPERATORS as $operator) {
  6.         if (strpos($clause, $operator) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           return true;
  8.         }
  9.       }
  10.       return false;
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Catalog/Products/Sites/ClicShoppingAdmin/Pages/Home/templates/configuration_popup_fields.php, line 41 
  2. while ($Qconfiguration->fetch()) {
  3.   if ($Qconfiguration->hasValue('use_function') && !\is_null($Qconfiguration->value('use_function'))) {
  4.     $use_function = $Qconfiguration->value('use_function');
  6.     if (preg_match('/->/', $use_function)) {
    Consider replacing preg_match() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $class_method = explode('->', $use_function);
  9.       if (!\is_object($class_method[0])) {
  10.         include_once('Core/classes/' . $class_method[0] . '.php');
  11.         ${$class_method[0]} = new $class_method[0]();
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/RequestValidator.php, line 195 
  2.     // Register shutdown function to handle timeout gracefully
  3.     register_shutdown_function(function() use ($seconds) {
  4.       $error = error_get_last();
  5.       if ($error && ($error['type'] === E_ERROR || $error['type'] === E_USER_ERROR)) {
  6.         if (strpos($error['message'], 'Maximum execution time') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           error_log('[INFO : TIME] TIMEOUT ERROR: Query exceeded ' . $seconds . ' seconds');
  9.           if (ob_get_length()) ob_clean();
  11.           header('Content-Type: application/json; charset=UTF-8');
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ResponseProcessor.php, line 246 
  1.       define('CLICSHOPPING_APP_CHATGPT_CH_MODEL', 'gpt-5-mini');
  2.     }
  4.     $model = $engine ?? CLICSHOPPING_APP_CHATGPT_CH_MODEL;
  6.     if (strpos($model, 'gpt') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $maxtoken = self::getMaxTokens($maxtoken);
  8.       $temperature = $temperature ?? (float)CLICSHOPPING_APP_CHATGPT_CH_TEMPERATURE;
  10.       $tokenParams = ModelManager::getModelApiParameters($model, $maxtoken);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ResponseProcessor.php, line 286 
  1.       if ($engine !== null) {
  2.         $parameters['model'] = $engine;
  3.       }
  5.       $client = ProviderManager::getOpenAiGpt($parameters);
  6.     } elseif (strpos($model, 'anth') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $client = ProviderManager::getAnthropicChat($model, $maxtoken);
  8.     } elseif (strpos($model, 'mistral') === 0) {
  9.       $client = ProviderManager::getMistralChat($model, $maxtoken);
  10.     } elseif (strpos($model, 'ollama') === 0 || str_contains($model, ':latest')) {
  11.       $client = ProviderManager::getOllamaChat($model);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ResponseProcessor.php, line 288 
  1.       }
  3.       $client = ProviderManager::getOpenAiGpt($parameters);
  4.     } elseif (strpos($model, 'anth') === 0) {
  5.       $client = ProviderManager::getAnthropicChat($model, $maxtoken);
  6.     } elseif (strpos($model, 'mistral') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $client = ProviderManager::getMistralChat($model, $maxtoken);
  8.     } elseif (strpos($model, 'ollama') === 0 || str_contains($model, ':latest')) {
  9.       $client = ProviderManager::getOllamaChat($model);
  10.     } elseif (strpos($model, 'openai/') === 0) {
  11.       $client = ProviderManager::getLmStudioChat($model);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ResponseProcessor.php, line 290 
  1.       $client = ProviderManager::getOpenAiGpt($parameters);
  2.     } elseif (strpos($model, 'anth') === 0) {
  3.       $client = ProviderManager::getAnthropicChat($model, $maxtoken);
  4.     } elseif (strpos($model, 'mistral') === 0) {
  5.       $client = ProviderManager::getMistralChat($model, $maxtoken);
  6.     } elseif (strpos($model, 'ollama') === 0 || str_contains($model, ':latest')) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $client = ProviderManager::getOllamaChat($model);
  8.     } elseif (strpos($model, 'openai/') === 0) {
  9.       $client = ProviderManager::getLmStudioChat($model);
  10.     } else {
  11.       $client = ProviderManager::getLmStudioChat($model);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/ClicShoppingAdmin/SubGpt/ResponseProcessor.php, line 292 
  1.       $client = ProviderManager::getAnthropicChat($model, $maxtoken);
  2.     } elseif (strpos($model, 'mistral') === 0) {
  3.       $client = ProviderManager::getMistralChat($model, $maxtoken);
  4.     } elseif (strpos($model, 'ollama') === 0 || str_contains($model, ':latest')) {
  5.       $client = ProviderManager::getOllamaChat($model);
  6.     } elseif (strpos($model, 'openai/') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $client = ProviderManager::getLmStudioChat($model);
  8.     } else {
  9.       $client = ProviderManager::getLmStudioChat($model);
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Classes/Shop/GptShop.php, line 83 
  2.     if (is_null($temperature)) {
  3.       $temperature = 0.5;
  4.     }
  6.     if (strpos(CLICSHOPPING_APP_CHATGPT_CH_MODEL, 'gpt') === 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $engine = CLICSHOPPING_APP_CHATGPT_CH_MODEL;
  8.       $response = Gpt::getGptResponse($question, $maxtoken, $temperature, $engine);
  9.     } else {
  10.       //ollama
  11.       $response = Gpt::getGptResponse($question, $maxtoken, $temperature);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Sites/Shop/Pages/GptRetailers/GptRetailers.php, line 121 
  1. // Simple routing
  3. // --------------------------------------------------------------------------------
  4. // GET /products - Returns product catalog
  5. // --------------------------------------------------------------------------------
  6.     if ($method === 'GET' && ($hasProductsParam || strpos($path, '/products') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       // Return full product catalog
  8.       $products = $CLICSHOPPING_getRetailers->getProducts();
  9.       echo json_encode(['products' => $products], JSON_UNESCAPED_SLASHES);
  11.       exit;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Sites/Shop/Pages/GptRetailers/GptRetailers.php, line 168 
  1.     } elseif (!empty($checkoutIdParam)) {
  2.       // Fallback ou prise en compte du paramètre 'id' si l'ID n'est pas dans le chemin
  3.       $sessionId = $checkoutIdParam;
  4.     }
  6.     if ($method === 'POST' && ($hasCheckoutParam || strpos($path, '/checkout_sessions') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if ($sessionId) {
  8.         // Completion: POST /checkout_sessions/{id}
  9.         // Choose Delegated Payment or Stripe based on payload
  10.         if (!empty($input['delegated_payment'])) {
  11.           $session = $CLICSHOPPING_getRetailers->completeSessionWithDelegatedPayment($sessionId, $input);
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Sites/Shop/Pages/GptRetailers/GptRetailers.php, line 250 
  1.       exit;
  2.     }
  3. // --------------------------------------------------------------------------------
  4. // POST /stripe_webhook - Handle Stripe webhooks
  5. // --------------------------------------------------------------------------------
  6.     if ($method === 'POST' && ($hasStripeWebhookParam || strpos($path, '/stripe_webhook') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $CLICSHOPPING_getRetailers->handleStripeWebhook();
  9.       exit;
  10.     }
  11. // --------------------------------------------------------------------------------
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Sites/Shop/Pages/GptRetailers/GptRetailers.php, line 261 
  1. // POST /create_order - Create ClicShopping order from session
  2. // --------------------------------------------------------------------------------
  3.     $hasCreateOrderParam = isset($_GET['create_order']);
  4.     $orderSessionIdParam = isset($_GET['session_id']) ? (string)$_GET['session_id'] : null;
  6.     if ($method === 'POST' && ($hasCreateOrderParam || strpos($path, '/create_order') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if (empty($orderSessionIdParam)) {
  8.         http_response_code(400);
  9.         echo json_encode(['error' => 'Session ID required']);
  10.         exit;
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/ChatGpt/Sites/Shop/Pages/GptRetailers/GptRetailers.php, line 281 
  1. // POST /complete_and_order - Complete session then create order
  2. // --------------------------------------------------------------------------------
  3.     $hasCompleteAndOrderParam = isset($_GET['complete_and_order']);
  4.     $completeSessionIdParam = isset($_GET['session_id']) ? (string)$_GET['session_id'] : null;
  6.     if ($method === 'POST' && ($hasCompleteAndOrderParam || strpos($path, '/complete_and_order') !== false)) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       if (empty($completeSessionIdParam)) {
  8.         http_response_code(400);
  9.         echo json_encode(['error' => 'Session ID required']);
  10.         exit;
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Configuration/Settings/Sites/ClicShoppingAdmin/Pages/Home/templates/settings_popup.php, line 37 
  1. while ($Qconfiguration->fetch()) {
  3.   if ($Qconfiguration->hasValue('use_function') && !\is_null($Qconfiguration->value('use_function'))) {
  4.     $use_function = $Qconfiguration->value('use_function');
  6.     if (preg_match('/->/', $use_function)) {
    Consider replacing preg_match() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $class_method = explode('->', $use_function);
  9.       if (!\is_object($class_method[0])) {
  10.         include_once('Core/classes/' . $class_method[0] . '.php');
  11.         $class_method[0] = new $class_method[0]();
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/insert.php, line 220 
  1.             $module_active = $modules_payment;
  3.             $include_modules = [];
  5.             foreach ($modules_payment as $value) {
  6.               if (strpos($value, '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 $class = Apps::getModuleClass($value, 'Payment');
  9.                 $include_modules[] = ['class' => $value,
  10.                   'file' => $class
  11.                 ];
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/insert.php, line 235 
  1.                 ];
  2.               }
  3.             }
  5.             for ($i = 0, $n = \count($include_modules); $i < $n; $i++) {
  6.               if (strpos($include_modules[$i]['class'], '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 Registry::set('Payment_' . str_replace('\\', '_', $include_modules[$i]['class']), new $include_modules[$i]['file']);
  8.                 $module = Registry::get('Payment_' . str_replace('\\', '_', $include_modules[$i]['class']));
  9.                 ?>
  10.                 <div class="row">
  11.                   <div class="col-md-12">
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/insert.php, line 294 
  1.             $module_active = $modules_shipping;
  3.             $include_modules = [];
  5.             foreach ($modules_shipping as $value) {
  6.               if (strpos($value, '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 $class = Apps::getModuleClass($value, 'Shipping');
  9.                 $include_modules[] = ['class' => $value,
  10.                   'file' => $class
  11.                 ];
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Customers/Groups/Sites/ClicShoppingAdmin/Pages/Home/templates/insert.php, line 304 
  1.                 ];
  2.               }
  3.             }
  5.             for ($i = 0, $n = \count($include_modules); $i < $n; $i++) {
  6.               if (strpos($include_modules[$i]['class'], '\\') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 Registry::set('Shipping_' . str_replace('\\', '_', $include_modules[$i]['class']), new $include_modules[$i]['file']);
  8.                 $module = Registry::get('Shipping_' . str_replace('\\', '_', $include_modules[$i]['class']));
  9.                 ?>
  10.                 <div class="row">
  11.                   <div class="col-md-5">
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Sites/ClicShoppingAdmin/Pages/Home/Actions/EditDesign/UpdateContent.php, line 34 
  2.     $basePath = CLICSHOPPING::getConfig('dir_root', 'Shop') . $CLICSHOPPING_Template->getDynamicTemplateDirectory() . '/modules/' . $directory_selected . '/content/';
  3.     $filePath = realpath($basePath . $filename_selected);
  5.     // Sécurité chemin
  6.     if ($filePath === false || strpos($filePath, realpath($basePath)) !== 0 || !is_file($filePath)) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $CLICSHOPPING_MessageStack->add($CLICSHOPPING_EditDesign->getDef('error_file_does_not_exist'), 'error');
  8.       $CLICSHOPPING_EditDesign->redirect('EditModuleContent&action=directory&directory_html=' . $directory_selected);
  9.       return false;
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Sites/ClicShoppingAdmin/Pages/Home/Actions/EditDesign/UpdateCss.php, line 36 
  1.     $lang_dir = $CLICSHOPPING_Language->get('directory');
  2.     $basePathLang = CLICSHOPPING::getConfig('dir_root', 'Shop') . $CLICSHOPPING_Template->getDynamicTemplateDirectory() . "/css/{$lang_dir}/{$directory_selected}/";
  3.     $basePathFallback = CLICSHOPPING::getConfig('dir_root', 'Shop') . $CLICSHOPPING_Template->getDynamicTemplateDirectory() . "/css/english/{$directory_selected}/";
  5.     $filePath = realpath($basePathLang . $filename_selected);
  6.     if ($filePath === false || strpos($filePath, realpath($basePathLang)) !== 0 || !is_file($filePath)) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $filePath = realpath($basePathFallback . $filename_selected);
  8.       if ($filePath === false || strpos($filePath, realpath($basePathFallback)) !== 0 || !is_file($filePath)) {
  9.         $CLICSHOPPING_MessageStack->add($CLICSHOPPING_EditDesign->getDef('error_file_does_not_exist'), 'error');
  10.         $CLICSHOPPING_EditDesign->redirect('EditCss&action=directory&directory_css=' . $directory_selected);
  11.         return false;
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Sites/ClicShoppingAdmin/Pages/Home/Actions/EditDesign/UpdateCss.php, line 38 
  1.     $basePathFallback = CLICSHOPPING::getConfig('dir_root', 'Shop') . $CLICSHOPPING_Template->getDynamicTemplateDirectory() . "/css/english/{$directory_selected}/";
  3.     $filePath = realpath($basePathLang . $filename_selected);
  4.     if ($filePath === false || strpos($filePath, realpath($basePathLang)) !== 0 || !is_file($filePath)) {
  5.       $filePath = realpath($basePathFallback . $filename_selected);
  6.       if ($filePath === false || strpos($filePath, realpath($basePathFallback)) !== 0 || !is_file($filePath)) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $CLICSHOPPING_MessageStack->add($CLICSHOPPING_EditDesign->getDef('error_file_does_not_exist'), 'error');
  8.         $CLICSHOPPING_EditDesign->redirect('EditCss&action=directory&directory_css=' . $directory_selected);
  9.         return false;
  10.       }
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Sites/ClicShoppingAdmin/Pages/Home/Actions/EditDesign/UpdateGabari.php, line 37 
  1.     $baseDir = CLICSHOPPING::getConfig('dir_root', 'Shop') . $CLICSHOPPING_Template->getDynamicTemplateDirectory() . '/files/';
  3.     $filePath = realpath($baseDir . $filename_selected);
  5.     // Sécuriser le chemin pour éviter directory traversal
  6.     if ($filePath === false || strpos($filePath, realpath($baseDir)) !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $CLICSHOPPING_MessageStack->add($CLICSHOPPING_EditDesign->getDef('error_file_does_not_exist'), 'error');
  8.       $CLICSHOPPING_EditDesign->redirect('EditModuleContent&action=directory&directory_html=' . $directory_selected);
  9.       return false;
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/EditDesign/Sites/ClicShoppingAdmin/Pages/Home/Actions/EditDesign/UpdateListing.php, line 37 
  1.       . $CLICSHOPPING_Template->getDynamicTemplateDirectory()
  2.       . '/modules/' . $directory_selected . '/template_html/';
  4.     $filePath = realpath($basePath . $filename_selected);
  6.     if ($filePath === false || strpos($filePath, realpath($basePath)) !== 0 || !is_file($filePath)) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       $CLICSHOPPING_MessageStack->add($CLICSHOPPING_EditDesign->getDef('error_file_does_not_exist'), 'error');
  8.       $CLICSHOPPING_EditDesign->redirect('EditListing&action=directory&directory_html=' . $directory_selected);
  9.       return false;
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/MCP/Classes/Shop/EndPoint/Products.php, line 509 
  1.     $Qcategories->execute();
  3.     $categories_array = $Qcategories->fetchAll();
  4.     foreach ($categories_array as $cat) {
  5.       $catLower = strtolower($cat['categories_name'] ?? '');
  6.       if (strpos($translated, $catLower) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $intent['entities']['category'] = $catLower;
  8.         $matchWeight += 0.8;
  9.         $totalWeight += 1;
  10.         break;
  11.       }
  • gyakutsuki

    not included
in Core/ClicShopping/Apps/Tools/WhosOnline/Sites/ClicShoppingAdmin/Pages/Home/templates/whos_online.php, line 148 
  1.                     'text' => $Qproducts->valueInt('customers_basket_quantity') . ' x ' . $Qproducts->value('products_name')
  2.                   ];
  4.                   $attributes = [];
  6.                   if (strpos($Qproducts->valueInt('products_id'), '{') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                     $combos = [];
  8.                     preg_match_all('/(\{[0-9]+\}[0-9]+){1}/', $Qproducts->valueInt('products_id'), $combos);
  10.                     foreach ($combos[0] as $combo) {
  11.                       $att = [];
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HttpRequest/Stream.php, line 207 
  1.       'Connection' => 'close'
  2.     ];
  4.     if (!empty($parameters['header'])) {
  5.       foreach ($parameters['header'] as $header) {
  6.         if (strpos($header, ':') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.           [$name, $value] = explode(':', $header, 2);
  8.           $headers[trim($name)] = trim($value);
  9.         }
  10.       }
  11.     }
  • gyakutsuki

    not included
in Core/ClicShopping/OM/HttpRequest/Stream.php, line 277 
  1.     $headers = ['status_code' => $statusCode];
  3.     while (($line = fgets($socket)) !== false) {
  4.       $line = trim($line);
  5.       if ($line === '') break;
  6.       if (strpos($line, ':') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$name, $value] = explode(':', $line, 2);
  8.         $headers[strtolower(trim($name))] = trim($value);
  9.       }
  10.     }
  • gyakutsuki

    not included
in Core/ClicShopping/OM/Service.php, line 65 
  1.     foreach ($files as $sm) {
  2.       $result['file'][] = ['files_name' => $sm];
  3.     }
  5.     foreach ($result['file'] as &$module) {
  6.       if (strpos($module['files_name'], '.') !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         $class = substr($module['files_name'], 0, strrpos($module['files_name'], '.'));
  8.         $this->startService($class);
  9.       }
  10.     }
  11.   }
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/BotDetector.php, line 82 
  1.         $content = file($spiders_file, FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES);
  3.         foreach ($content as $line) {
  4.           $line = trim($line);
  5.           // Ignore empty lines and comments starting with '#'
  6.           if (!empty($line) && strpos($line, '#') !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.             $spiders_array[] = strtolower($line);
  8.           }
  9.         }
  11.         // Save processed list to cache for future requests
  • gyakutsuki

    not included
in Core/ClicShopping/Sites/Shop/TemplateCss.php, line 200 
  1.           $this->logSecurityError("Invalid path detected", $path);
  2.           continue;
  3.         }
  5.         // Ensure the resolved path is still within the root directory
  6.         if (strpos($real_path, $root_dir) !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.           $this->logSecurityError("Path traversal attempt detected", $real_path);
  8.           continue;
  9.         }
  11.         if (is_file($real_path) && is_readable($real_path)) {
  • gyakutsuki

    not included
in Core/Module/Hooks/Shop/Session/StartBefore.php, line 46 
  1.             if ((substr($spider, strlen($spider) - 1, 1) == ' ') || (substr($spider, strlen($spider) - 1, 1) == "\n")) {
  2.               $spider = substr($spider, 0, strlen($spider) - 1);
  3.             }
  5.             if (!empty($spider)) {
  6.               if (strpos($user_agent, $spider) !== false) {
    Consider replacing strpos() with str_contains() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.                 $parameters['can_start'] = false;
  8.                 break;
  9.               }
  10.             }
  11.           }
  • gyakutsuki

    not included
in clear_all_caches_complete.php, line 530 
  1. // Also clear old embedding cache files from root cache directory (excluding embedding_search)
  2. $oldEmbeddingFiles = glob($generalCacheDir . 'embedding_*.cache');
  3. if ($oldEmbeddingFiles) {
  4.   // Filter out embedding_search files
  5.   $oldEmbeddingFiles = array_filter($oldEmbeddingFiles, function($file) {
  6.     return strpos(basename($file), 'embedding_search_') !== 0;
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.   });
  9.   $cleared = 0;
  10.   foreach ($oldEmbeddingFiles as $file) {
  11.     if (unlink($file)) {
  • gyakutsuki

    not included
in sources/template/Default/css/english/compressed_css.php, line 91 
  1.         $CLICSHOPPING_templateCss->logSecurityError("CSS file not accessible", $cssFile);
  2.         continue;
  3.       }
  5.       // Directory Traversal protection: ensure the file is within the allowed root directory
  6.       if (strpos($real_path, $root_dir . DIRECTORY_SEPARATOR) !== 0) {
    Consider replacing strpos() with str_starts_with() for improved readability.
    Time to fix: about 1 hour
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $CLICSHOPPING_templateCss->logSecurityError("CSS file outside allowed directory", $cssFile);
  8.         continue;
  9.       }
  11.       // Check individual file size
  • gyakutsuki

    not included

Your project uses legacy callable syntax instead of first-class callable syntax 30

More information: https://insight.symfony.com/what-we-analyse/php.use_first_class_callable_syntax

New rule! We've recently added this rule to Insight. Don't be surprised to see new suggestions even though the codebase didn't change.
in Core/ClicShopping/OM/CLICSHOPPING.php, line 403 
  1.       $page = $matches[2];
  2.     }
  4.     $args[0] = $req_site . DIRECTORY_SEPARATOR . self::getConfig('http_images_path', $req_site) . $page;
  6.     $url = forward_static_call_array([static::class, 'link'], $args);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     return $url;
  9.   }
  11.   /**
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/CLICSHOPPING.php, line 440 
  1.       $page = $matches[2];
  2.     }
  4.     $args[0] = 'Shop/public/Sites/' . $req_site . DIRECTORY_SEPARATOR . $page;
  6.     $url = forward_static_call_array([self::class, 'link'], $args);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     return $url;
  9.   }
  11.   /**
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/CLICSHOPPING.php, line 454 
  1.    */
  2.   public static function redirect(): string
  3.   {
  4.     $args = func_get_args();
  6.     $url = call_user_func_array([self::class, 'link'], $args);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  8.     if ((strstr($url, "\n") !== false) || (strstr($url, "\r") !== false)) {
  9.       $url = self::link(null, '', false);
  10.     }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/CLICSHOPPING.php, line 472 
  1.    */
  2.   public static function getDef(): string
  3.   {
  4.     $CLICSHOPPING_Language = Registry::get('Language');
  6.     return call_user_func_array([$CLICSHOPPING_Language, 'getDef'], func_get_args());
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  9.   /**
  10.    * Checks if the specified route exists by comparing the beginning of the $_GET keys with the given path array.
  11.    *
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/AnalyticsConfig.php, line 82 
  2.       $config = [];
  4.       foreach ($embeddingTables as $embeddingTable) {
  5.         // Extract entity type: clic_products_embedding -> products
  6.         $entityType = str_replace([$prefix, '_embedding'], '', $embeddingTable);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $table = $prefix . $entityType;
  9.         // Get ID column from EntityRegistry (reuse existing logic)
  10.         $idColumn = $entityRegistry->getIdColumnForEntityType($entityType);
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/Apps/AI/Ecommerce/Classes/ClicShoppingAdmin/EntityConfig.php, line 80 
  2.       $config = [];
  4.       foreach ($embeddingTables as $embeddingTable) {
  5.         // Extract entity type: clic_products_embedding -> products
  6.         $entityType = str_replace([$prefix, '_embedding'], '', $embeddingTable);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         $table = $prefix . $entityType;
  9.         // Get ID column from EntityRegistry (reuse existing logic)
  10.         $idColumn = $entityRegistry->getIdColumnForEntityType($entityType);
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Db.php, line 427 
  1.     if (isset($cache)) {
  2.       if (!is_array($cache)) {
  3.         $cache = [$cache];
  4.       }
  6.       call_user_func_array([$Q, 'setCache'], $cache);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     }
  9.     $Q->execute();
  11.     return $Q;
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/DirectoryListing.php, line 259 
  1.       $this->read();
  2.     }
  4.     if (is_array($this->listing) && (count($this->listing) > 0)) {
  5.       if ($sort_by_directories === true) {
  6.         usort($this->listing, array($this, 'sortListing'));
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       }
  9.       return $this->listing;
  10.     }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Domains/AppAbstract.php, line 218 
  2.     if (!isset($args[2])) {
  3.       $args[2] = $this->vendor . '-' . $this->code;
  4.     }
  6.     return call_user_func_array([$this->lang, 'getDef'], $args);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.   }
  9.   /**
  10.    * Checks whether a definitions file exists for the specified group and optionally a language code.
  11.    *
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/AI/Security/SecurityLogger.php, line 77 
  1.             $this->db = Registry::get('Db');
  2.         }
  4.         // Register shutdown function to flush buffer
  5.         if ($bufferEnabled) {
  6.             register_shutdown_function([$this, 'flushBuffer']);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.         }
  9. 	$this->stats = new SecurityStatistics();
  10.     }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/AI/Agents/Memory/ConversationMemory.php, line 1150 
  1.         return $document;
  2.       }
  4.       public function embedDocuments(array $documents): array
  5.       {
  6.         return array_map([$this, 'embedDocument'], $documents);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       }
  9.       public function getEmbeddingLength(): int
  10.       {
  11.         return NewVector::getEmbeddingLength();
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/AI/Agents/Memory/CorrectionPatterns.php, line 78 
  1.         return $document;
  2.       }
  4.       public function embedDocuments(array $documents): array
  5.       {
  6.         return array_map([$this, 'embedDocument'], $documents);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       }
  9.       public function getEmbeddingLength(): int
  10.       {
  11.         return NewVector::getEmbeddingLength();
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/AI/Agents/Orchestrator/SubCorrectionAgent/CorrectionMemory.php, line 302 
  1.     // Build a mapping of table names (without prefix) to entity types
  2.     $tableToEntityType = [];
  3.     foreach ($allTables as $fullTableName) {
  4.       $entityType = $registry->getEntityTypeForTable($fullTableName);
  5.       // Remove prefix and _embedding suffix to get base table name
  6.       $tableName = str_replace([$prefix, '_embedding'], '', $fullTableName);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $tableToEntityType[$tableName] = $entityType;
  8.     }
  10.     // Pattern 1: FROM {table_name}
  11.     if (preg_match('/FROM\s+(?:\w+\.)?(\w+)/i', $query, $matches)) {
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityRegistry.php, line 241 
  1.     }
  3.     $prefix = CLICSHOPPING::getConfig('db_table_prefix');
  5.     // Remove prefix and '_embedding' suffix to get entity type
  6.     $entityType = str_replace([$prefix, '_embedding'], '', $tableName);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     // Get ID column for this entity type
  9.     $idColumn = $this->getIdColumnForEntityType($entityType);
  11.     // Cache the result
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/AI/DomainsAI/CoreAI/Entity/EntityRegistry.php, line 300 
  1.   public function getEntityTypeForTable(string $tableName): string
  2.   {
  3.     $prefix = CLICSHOPPING::getConfig('db_table_prefix');
  5.     // Remove prefix and '_embedding' suffix
  6.     $entityType = str_replace([$prefix, '_embedding'], '', $tableName);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  8.     return $entityType;
  9.   }
  11.   /**
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/AI/Infrastructure/Cache/Cache.php, line 1133 
  1.    */
  2.   public function invalidateCacheByTables(array $tableNames): int
  3.   {
  4.     $invalidated = 0;
  5.     $cleanTableNames = array_map(
  6.       [SQLTableParser::class, 'cleanTableName'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.       $tableNames
  8.     );
  10.     // Invalidate from Redis
  11.     if ($this->useRedis && $this->redis) {
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/AI/Infrastructure/Cache/Helper/SQLTableParser.php, line 63 
  1.     // Extract tables from DELETE FROM
  2.     $tables = array_merge($tables, self::extractDeleteTable($normalizedQuery, $upperQuery));
  4.     // Remove duplicates and clean table names
  5.     $tables = array_unique($tables);
  6.     $tables = array_map([self::class, 'cleanTableName'], $tables);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by clicshopping
                    
  7.     $tables = array_filter($tables); // Remove empty strings
  9.     return array_values($tables);
  10.   }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/EventSource.php, line 312 
  1.       ($this->onOpen)();
  2.     }
  4.     try {
  5.       // Utilisation du streaming de la nouvelle classe Stream
  6.       Stream::executeStreaming($parameters, [$this, 'processStreamData']);
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.     } catch (Exception $e) {
  8.       throw $e;
  9.     } finally {
  10.       $this->connected = false;
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Memcached.php, line 50 
  2.     if (class_exists('Memcached')) {
  3.       $this->orig_module_name = session_module_name();
  5.       session_set_save_handler(
  6.         [$this, 'open'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'close'],
  8.         [$this, 'read'],
  9.         [$this, 'write'],
  10.         [$this, 'destroy'],
  11.         [$this, 'gc']
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Memcached.php, line 51 
  1.     if (class_exists('Memcached')) {
  2.       $this->orig_module_name = session_module_name();
  4.       session_set_save_handler(
  5.         [$this, 'open'],
  6.         [$this, 'close'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'read'],
  8.         [$this, 'write'],
  9.         [$this, 'destroy'],
  10.         [$this, 'gc']
  11.       );
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Memcached.php, line 52 
  1.       $this->orig_module_name = session_module_name();
  3.       session_set_save_handler(
  4.         [$this, 'open'],
  5.         [$this, 'close'],
  6.         [$this, 'read'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'write'],
  8.         [$this, 'destroy'],
  9.         [$this, 'gc']
  10.       );
  11.     }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Memcached.php, line 53 
  2.       session_set_save_handler(
  3.         [$this, 'open'],
  4.         [$this, 'close'],
  5.         [$this, 'read'],
  6.         [$this, 'write'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'destroy'],
  8.         [$this, 'gc']
  9.       );
  10.     }
  11.   }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Memcached.php, line 54 
  1.       session_set_save_handler(
  2.         [$this, 'open'],
  3.         [$this, 'close'],
  4.         [$this, 'read'],
  5.         [$this, 'write'],
  6.         [$this, 'destroy'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'gc']
  8.       );
  9.     }
  10.   }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Memcached.php, line 55 
  1.         [$this, 'open'],
  2.         [$this, 'close'],
  3.         [$this, 'read'],
  4.         [$this, 'write'],
  5.         [$this, 'destroy'],
  6.         [$this, 'gc']
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       );
  8.     }
  9.   }
  11.   /**
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Redis.php, line 48 
  2.     if (class_exists('\Redis')) {
  3.       $this->orig_module_name = session_module_name();
  5.       session_set_save_handler(
  6.         [$this, 'open'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'close'],
  8.         [$this, 'read'],
  9.         [$this, 'write'],
  10.         [$this, 'destroy'],
  11.         [$this, 'gc']
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Redis.php, line 49 
  1.     if (class_exists('\Redis')) {
  2.       $this->orig_module_name = session_module_name();
  4.       session_set_save_handler(
  5.         [$this, 'open'],
  6.         [$this, 'close'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'read'],
  8.         [$this, 'write'],
  9.         [$this, 'destroy'],
  10.         [$this, 'gc']
  11.       );
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Redis.php, line 50 
  1.       $this->orig_module_name = session_module_name();
  3.       session_set_save_handler(
  4.         [$this, 'open'],
  5.         [$this, 'close'],
  6.         [$this, 'read'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'write'],
  8.         [$this, 'destroy'],
  9.         [$this, 'gc']
  10.       );
  11.     }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Redis.php, line 51 
  2.       session_set_save_handler(
  3.         [$this, 'open'],
  4.         [$this, 'close'],
  5.         [$this, 'read'],
  6.         [$this, 'write'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'destroy'],
  8.         [$this, 'gc']
  9.       );
  10.     }
  11.   }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Redis.php, line 52 
  1.       session_set_save_handler(
  2.         [$this, 'open'],
  3.         [$this, 'close'],
  4.         [$this, 'read'],
  5.         [$this, 'write'],
  6.         [$this, 'destroy'],
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.         [$this, 'gc']
  8.       );
  9.     }
  10.   }
  • gyakutsuki

    change but there are false posittive
in Core/ClicShopping/OM/Session/Redis.php, line 53 
  1.         [$this, 'open'],
  2.         [$this, 'close'],
  3.         [$this, 'read'],
  4.         [$this, 'write'],
  5.         [$this, 'destroy'],
  6.         [$this, 'gc']
    Use the first-class callable syntax ($this->method(...))
    Time to fix: about 15 minutes
    Read doc
                Open Issue
             Permalink Copy Prompt
    
                                    Last edited  by ClicShopping
                    
  7.       );
  8.     }
  9.   }
  11.   /**
  • gyakutsuki

    change but there are false posittive