Your project should not use invalid default value types 2
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.invalid_default_value
- */
- class GuardPluginManager extends AbstractPluginManager
- {
- protected $instanceOf = GuardInterface::class;
- protected $factories = [
Property Dot\Rbac\Guard\Guard\GuardPluginManager::$factories (Laminas\ServiceManager\FactoriesConfiguration) does not accept default value of type array<string, string>.
Last edited by Popa Tiberiu- RouteGuard::class => GuardFactory::class,
- RoutePermissionGuard::class => PermissionGuardFactory::class,
- ControllerGuard::class => GuardFactory::class,
- ControllerPermissionGuard::class => PermissionGuardFactory::class,
- */
- class GuardsProviderPluginManager extends AbstractPluginManager
- {
- protected $instanceOf = GuardsProviderInterface::class;
- protected $factories = [
Property Dot\Rbac\Guard\Provider\GuardsProviderPluginManager::$factories (Laminas\ServiceManager\FactoriesConfiguration) does not accept default value of type array<string, string>.
Last edited by n3vrax- ArrayGuardsProvider::class => GuardsProviderFactory::class,
- ];
- protected $aliases = [
- 'arrayguardsprovider' => ArrayGuardsProvider::class,
Your project should not use invalid parameter and return typehints 7
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.invalid_typehint
- /**
- * @param ContainerInterface $container
- * @param $requestedName
- * @return ForbiddenHandler
- */
- public function __invoke(ContainerInterface $container, $requestedName)
Method Dot\Rbac\Guard\Factory\ForbiddenHandlerFactory::__invoke() has parameter $requestedName with no type specified.
Last edited by Popa Tiberiu- {
- $config = $container->get('config');
- $debug = (bool)$config['debug'] ?? false;
- $authorizationService = $container->get(AuthorizationInterface::class);
- * Class GuardFactory
- * @package Dot\Rbac\Guard\Factory
- */
- class GuardFactory
- {
- public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
Method Dot\Rbac\Guard\Factory\GuardFactory::__invoke() has parameter $requestedName with no type specified.
Last edited by Popa Tiberiu- {
- $options = $options ?? [];
- $options['role_service'] = isset($options['role_service'])
- && is_string($options['role_service'])
- && $container->has($options['role_service'])
- * @param ContainerInterface $container
- * @param $requestedName
- * @param array $options
- * @return ArrayGuardsProvider
- */
- public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
Method Dot\Rbac\Guard\Factory\GuardsProviderFactory::__invoke() has parameter $requestedName with no type specified.
Last edited by Popa Tiberiu- {
- $options = $options ?? [];
- $options['guard_factory'] = isset($options['guard_factory'])
- && is_string($options['guard_factory'])
- && $container->has($options['guard_factory'])
- * Class PermissionGuardFactory
- * @package Dot\Rbac\Guard\Factory
- */
- class PermissionGuardFactory
- {
- public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
Method Dot\Rbac\Guard\Factory\PermissionGuardFactory::__invoke() has parameter $requestedName with no type specified.
Last edited by Popa Tiberiu- {
- $options = $options ?? [];
- $options['authorization_service'] = isset($options['authorization_service'])
- && is_string($options['authorization_service'])
- && $container->has($options['authorization_service'])
- /**
- * @param ContainerInterface $container
- * @param $requestedName
- * @return RbacGuardMiddleware
- */
- public function __invoke(ContainerInterface $container, $requestedName)
Method Dot\Rbac\Guard\Factory\RbacGuardMiddlewareFactory::__invoke() has parameter $requestedName with no type specified.
Last edited by Popa Tiberiu- {
- /** @var RbacGuardOptions $options */
- $options = $container->get(RbacGuardOptions::class);
- /** @var Factory $guardsProviderFactory */
- /**
- * @param ContainerInterface $container
- * @param $requestedName
- * @return RbacGuardOptions
- */
- public function __invoke(ContainerInterface $container, $requestedName)
Method Dot\Rbac\Guard\Factory\RbacGuardOptionsFactory::__invoke() has parameter $requestedName with no type specified.
Last edited by Popa Tiberiu- {
- return new $requestedName($container->get('config')['dot_authorization']);
- }
- }
- * @param $error
- * @param ServerRequestInterface $request
- * @return ResponseInterface
- * @throws \Exception
- */
- protected function handleForbiddenError(
Method Dot\Rbac\Guard\Middleware\ForbiddenHandler::handleForbiddenError() has parameter $error with no type specified.
Last edited by n3vrax- $error,
- ServerRequestInterface $request
- ): ResponseInterface {
- $event = $this->dispatchEvent(AuthorizationEvent::EVENT_FORBIDDEN, [
- 'request' => $request,
Your project should use return types 34
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.missing_return_typehint
- * Class GuardFactory
- * @package Dot\Rbac\Guard\Factory
- */
- class GuardFactory
- {
- public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
Method Dot\Rbac\Guard\Factory\GuardFactory::__invoke() has no return type specified.
Last edited by Popa Tiberiu- {
- $options = $options ?? [];
- $options['role_service'] = isset($options['role_service'])
- && is_string($options['role_service'])
- && $container->has($options['role_service'])
- * Class PermissionGuardFactory
- * @package Dot\Rbac\Guard\Factory
- */
- class PermissionGuardFactory
- {
- public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
Method Dot\Rbac\Guard\Factory\PermissionGuardFactory::__invoke() has no return type specified.
Last edited by Popa Tiberiu- {
- $options = $options ?? [];
- $options['authorization_service'] = isset($options['authorization_service'])
- && is_string($options['authorization_service'])
- && $container->has($options['authorization_service'])
- }
- /**
- * @param bool $debug
- */
- public function setDebug(bool $debug)
Method Dot\Rbac\Guard\Middleware\ForbiddenHandler::setDebug() has no return type specified.
Last edited by n3vrax- {
- $this->debug = $debug;
- }
- }
- interface AuthorizationEventListenerInterface extends ListenerAggregateInterface
- {
- /**
- * @param AuthorizationEvent $e
- */
- public function onBeforeAuthorization(AuthorizationEvent $e);
Method Dot\Rbac\Guard\Event\AuthorizationEventListenerInterface::onBeforeAuthorization() has no return type specified.
Last edited by Popa Tiberiu- /**
- * @param AuthorizationEvent $e
- */
- public function onAfterAuthorization(AuthorizationEvent $e);
- public function onBeforeAuthorization(AuthorizationEvent $e);
- /**
- * @param AuthorizationEvent $e
- */
- public function onAfterAuthorization(AuthorizationEvent $e);
Method Dot\Rbac\Guard\Event\AuthorizationEventListenerInterface::onAfterAuthorization() has no return type specified.
Last edited by Popa Tiberiu- /**
- * @param AuthorizationEvent $e
- */
- public function onForbidden(AuthorizationEvent $e);
- public function onAfterAuthorization(AuthorizationEvent $e);
- /**
- * @param AuthorizationEvent $e
- */
- public function onForbidden(AuthorizationEvent $e);
Method Dot\Rbac\Guard\Event\AuthorizationEventListenerInterface::onForbidden() has no return type specified.
Last edited by Popa Tiberiu- }
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onBeforeAuthorization(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Middleware\ForbiddenHandler::onBeforeAuthorization() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- /**
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onBeforeAuthorization(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Middleware\RbacGuardMiddleware::onBeforeAuthorization() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- /**
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onBeforeAuthorization(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Event\AbstractAuthorizationEventListener::onBeforeAuthorization() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- /**
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onAfterAuthorization(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Event\AbstractAuthorizationEventListener::onAfterAuthorization() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- /**
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onAfterAuthorization(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Middleware\RbacGuardMiddleware::onAfterAuthorization() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- /**
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onAfterAuthorization(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Middleware\ForbiddenHandler::onAfterAuthorization() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- /**
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onForbidden(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Middleware\ForbiddenHandler::onForbidden() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- }
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onForbidden(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Middleware\RbacGuardMiddleware::onForbidden() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- }
- }
- /**
- * @param AuthorizationEvent $e
- */
- public function onForbidden(AuthorizationEvent $e)
Method Dot\Rbac\Guard\Event\AbstractAuthorizationEventListener::onForbidden() has no return type specified.
Last edited by Popa Tiberiu- {
- // no-op
- }
- }
- {
- /**
- * @param ContainerInterface $container
- * @param EventManagerInterface $eventManager
- */
- protected function attachListeners(ContainerInterface $container, EventManagerInterface $eventManager)
Method Dot\Rbac\Guard\Factory\ForbiddenHandlerFactory::attachListeners() has no return type specified.
Last edited by Popa Tiberiu- {
- /** @var RbacGuardOptions $options */
- $options = $container->get(RbacGuardOptions::class);
- if (!empty($options->getEventListeners())
- {
- /**
- * @param ContainerInterface $container
- * @param EventManagerInterface $eventManager
- */
- protected function attachListeners(ContainerInterface $container, EventManagerInterface $eventManager)
Method Dot\Rbac\Guard\Factory\RbacGuardMiddlewareFactory::attachListeners() has no return type specified.
Last edited by Popa Tiberiu- {
- /** @var RbacGuardOptions $options */
- $options = $container->get(RbacGuardOptions::class);
- if (!empty($options->getEventListeners())
- }
- /**
- * @param array $rules
- */
- abstract public function setRules(array $rules);
Method Dot\Rbac\Guard\Guard\AbstractGuard::setRules() has no return type specified.
Last edited by Popa Tiberiu- /**
- * @return int
- */
- public function getPriority(): int
- }
- /**
- * @param array $rules
- */
- public function setRules(array $rules)
Method Dot\Rbac\Guard\Guard\ControllerGuard::setRules() has no return type specified.
Last edited by n3vrax- {
- $this->rules = [];
- foreach ($rules as $rule) {
- $route = strtolower($rule['route']);
- }
- /**
- * @param RoleServiceInterface $roleService
- */
- public function setRoleService(RoleServiceInterface $roleService)
Method Dot\Rbac\Guard\Guard\ControllerGuard::setRoleService() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->roleService = $roleService;
- }
- /**
- }
- /**
- * @param array $rules
- */
- public function setRules(array $rules)
Method Dot\Rbac\Guard\Guard\ControllerPermissionGuard::setRules() has no return type specified.
Last edited by n3vrax- {
- $this->rules = [];
- foreach ($rules as $rule) {
- $route = strtolower($rule['route']);
- }
- /**
- * @param AuthorizationInterface $authorizationService
- */
- public function setAuthorizationService(AuthorizationInterface $authorizationService)
Method Dot\Rbac\Guard\Guard\ControllerPermissionGuard::setAuthorizationService() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->authorizationService = $authorizationService;
- }
- }
- }
- /**
- * @param array $rules
- */
- public function setRules(array $rules)
Method Dot\Rbac\Guard\Guard\RouteGuard::setRules() has no return type specified.
Last edited by n3vrax- {
- $this->rules = [];
- foreach ($rules as $key => $value) {
- if (is_int($key)) {
- }
- /**
- * @param RoleServiceInterface $roleService
- */
- public function setRoleService(RoleServiceInterface $roleService)
Method Dot\Rbac\Guard\Guard\RouteGuard::setRoleService() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->roleService = $roleService;
- }
- /**
- }
- /**
- * @param array $rules
- */
- public function setRules(array $rules)
Method Dot\Rbac\Guard\Guard\RoutePermissionGuard::setRules() has no return type specified.
Last edited by n3vrax- {
- $this->rules = [];
- foreach ($rules as $key => $value) {
- if (is_int($key)) {
- $routeName = strtolower($value);
- }
- /**
- * @param AuthorizationInterface $authorizationService
- */
- public function setAuthorizationService(AuthorizationInterface $authorizationService)
Method Dot\Rbac\Guard\Guard\RoutePermissionGuard::setAuthorizationService() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->authorizationService = $authorizationService;
- }
- }
- }
- /**
- * @param $messages
- */
- public function setMessages(array $messages)
Method Dot\Rbac\Guard\Options\MessagesOptions::setMessages() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->messages = ArrayUtils::merge($this->messages, $messages, true);
- }
- /**
- }
- /**
- * @param string $protectionPolicy
- */
- public function setProtectionPolicy(string $protectionPolicy)
Method Dot\Rbac\Guard\Options\RbacGuardOptions::setProtectionPolicy() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->protectionPolicy = $protectionPolicy;
- }
- /**
- }
- /**
- * @param array $guardsProvider
- */
- public function setGuardsProvider(array $guardsProvider)
Method Dot\Rbac\Guard\Options\RbacGuardOptions::setGuardsProvider() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->guardsProvider = $guardsProvider;
- }
- /**
- }
- /**
- * @param array $messagesOptions
- */
- public function setMessagesOptions(array $messagesOptions)
Method Dot\Rbac\Guard\Options\RbacGuardOptions::setMessagesOptions() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->messagesOptions = new MessagesOptions($messagesOptions);
- }
- /**
- }
- /**
- * @param array $eventListeners
- */
- public function setEventListeners(array $eventListeners)
Method Dot\Rbac\Guard\Options\RbacGuardOptions::setEventListeners() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->eventListeners = $eventListeners;
- }
- }
- }
- /**
- * @param $protectionPolicy
- */
- public function setProtectionPolicy(string $protectionPolicy)
Method Dot\Rbac\Guard\Guard\AbstractGuard::setProtectionPolicy() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->protectionPolicy = $protectionPolicy;
- }
- }
- }
- /**
- * @param Factory $guardFactory
- */
- public function setGuardFactory(Factory $guardFactory)
Method Dot\Rbac\Guard\Provider\AbstractGuardsProvider::setGuardFactory() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->guardFactory = $guardFactory;
- }
- }
- }
- /**
- * @param array $guardsConfig
- */
- public function setGuardsConfig(array $guardsConfig)
Method Dot\Rbac\Guard\Provider\ArrayGuardsProvider::setGuardsConfig() has no return type specified.
Last edited by Popa Tiberiu- {
- $this->guardsConfig = $guardsConfig;
- }
- }
Your project should not contain duplicated code
- Read doc
- Productivity
- Minor
More information: https://insight.symfony.com/what-we-analyse/php.duplicated_code
- $allowedPermissions = $this->rules[$route][0];
- } else {
- return $this->protectionPolicy === self::POLICY_ALLOW;
- }
- if (empty($allowedPermissions)) {
The next 49 lines appear both in
src/Guard/ControllerPermissionGuard.php:106andsrc/Guard/RoutePermissionGuard.php:92.Last edited by n3vrax- return $this->protectionPolicy === self::POLICY_ALLOW;
- }
- if (in_array('*', $allowedPermissions)) {
- return true;