Your project controllers should only contains actions as public methods 2

More information: https://insight.symfony.com/what-we-analyse/symfony.controller.non_action_public_method_in_controller_class

  1. use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
  2. #[Route(path: '/favicon', name: 'enabel_layout_favicon_')]
  3. class FaviconController extends AbstractController
  4. {
  5. #[Route(

    Non-action public method found in controller class

    Time to fix: about 1 hour
    Read doc Open Issue Permalink
    Last edited by Damien Lagae
  6. path: '/site.webmanifest',
  7. name: 'webmanifest',
  8. methods: 'GET',
  9. defaults: [
  10. '_format' => 'json',
  1. 'url' => $this->generateUrl('homepage', [], UrlGeneratorInterface::ABSOLUTE_URL),
  2. ],
  3. ]);
  4. }
  5. #[Route(

    Non-action public method found in controller class

    Time to fix: about 1 hour
    Read doc Open Issue Permalink
    Last edited by Damien Lagae
  6. path: '/browserconfig.xml',
  7. name: 'browserconfig',
  8. methods: 'GET',
  9. defaults: [
  10. '_format' => 'xml',

Text files should end with a valid new line character. 6

More information: https://insight.symfony.com/what-we-analyse/missing_e_o_l

in CONTRIBUTING.md, line 55
  1. - **One pull request per feature** - If you want to do more than one thing, send multiple pull requests.
  2. - **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please [squash them](http://www.git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages) before submitting.
  3. **Happy coding**!

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Read doc Open Issue Permalink
    Last edited by Damien Lagae
  1. *

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Read doc Open Issue Permalink
    Last edited by Damien Lagae
  1. *

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Read doc Open Issue Permalink
    Last edited by Damien Lagae
  1. <div class="alert alert-{{ type }}">
  2. {% if icon is not null %}
  3. <i class="fa {{ icon }}"></i>
  4. {% endif %}
  5. {{ message|trans }}
  6. </div>

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Read doc Open Issue Permalink
    Last edited by Damien Lagae
  1. {% endblock %}
  2. <small>{% block error_details %}{{ 'enabel_layout.error.details'|trans({'%code%': status_code, '%message%': status_text})|nl2br}}{% endblock %}</small>
  3. <img class ="logo" src="{{ asset('bundles/enabellayout/images/enabel-logo-email.png') }}" alt="enabel-logo">
  4. </div>
  5. </div>
  6. {% endblock %}

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Read doc Open Issue Permalink
    Last edited by Damien Lagae
  1. <footer class="footer mt-auto py-2 bg-light">
  2. <div class="container">
  3. <span class="text-muted">&copy; {{ date('now')|date('Y') }} Enabel</span>
  4. </div>
  5. </footer>

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Read doc Open Issue Permalink
    Last edited by Damien Lagae