Your project must not contain invalid function or method calls 2
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.invalid_call
- {
- $header = array_values(
- array_filter($header, $this->isColumnNameValid(...)),
- );
- return \array_map(static fn (?string $name): string => \str_replace(' ', '_', $name), $header);
Parameter #3 $subject of function str_replace expects array<string>|string, string|null given.
Last edited by Jarosław Grygierek- }
- /**
- * @param array<string, string> $data
- *
- * @param string[] $header
- */
- private static function addKeysToRows(array $header, array &$data): void
- {
- $data = array_map(
- static fn (array $row): array => array_combine($header, $row),
Parameter #1 $callback of function array_map expects (callable(mixed): mixed)|null, Closure(array): array<string, mixed> given.
Last edited by Jarosław Grygierek- $data
- );
- }
- private static function getReader(UploadedFile $file): BaseReader
Your project must not contain invalid instantiations 4
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.invalid_instantiation
- $data = $spreadsheet->getActiveSheet()->toArray();
- /** @var string[] $header */
- $header = array_shift($data);
- self::addKeysToRows($header, $data);
- return new Matrix($header, $data);
Parameter #2 $recordsData of class JG\BatchEntityImportBundle\Model\Matrix\Matrix constructor expects array<array<string, string>>, array given.
Last edited by Jarek- }
- /**
- * @param array<array<string, mixed>> $data
- */
- /**
- * @param array<array<string, mixed>> $data
- */
- public static function createFromPostData(array $data): Matrix
- {
- return $data ? new Matrix(array_keys($data[0]), $data) : new Matrix();
Parameter #2 $recordsData of class JG\BatchEntityImportBundle\Model\Matrix\Matrix constructor expects array<array<string, string>>, array<array<string, mixed>> given.
Last edited by Jarek- }
- /**
- * @param string[] $header
- */
- /**
- * @throws ReflectionException
- */
- public function __construct(string $entityClass)
- {
- $this->reflectionClass = new ReflectionClass($entityClass);
Parameter #1 $objectOrClass of class ReflectionClass constructor expects class-string<T of object>|T of object, string given.
Last edited by Micheal- if (\interface_exists(TranslatableInterface::class) && is_subclass_of($entityClass, TranslatableInterface::class)) {
- /** @var TranslatableInterface $instance */
- $instance = $this->reflectionClass->newInstanceWithoutConstructor();
- $this->translationReflectionClass = new ReflectionClass($instance->translate());
- }
- {
- $this->reflectionClass = new ReflectionClass($entityClass);
- if (\interface_exists(TranslatableInterface::class) && is_subclass_of($entityClass, TranslatableInterface::class)) {
- /** @var TranslatableInterface $instance */
- $instance = $this->reflectionClass->newInstanceWithoutConstructor();
- $this->translationReflectionClass = new ReflectionClass($instance->translate());
Parameter #1 $objectOrClass of class ReflectionClass constructor expects class-string<T of object>|T of object, mixed given.
Last edited by Jarosław Grygierek- }
- }
- public function propertyExists(string $name): bool
- {
Your project should not use invalid parameter and return typehints 17
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.invalid_typehint
- }
- /**
- * @param string[] $header
- */
- private static function addKeysToRows(array $header, array &$data): void
Method JG\BatchEntityImportBundle\Model\Matrix\MatrixFactory::addKeysToRows() has parameter $data with no value type specified in iterable type array.
Last edited by Jarek- {
- $data = array_map(
- static fn (array $row): array => array_combine($header, $row),
- $data
- );
- private function translationPropertyExists(string $name): bool
- {
- return $this->translationReflectionClass instanceof ReflectionClass && $this->isPropertyWritable($this->translationReflectionClass, $name);
- }
- private function isPropertyWritable(ReflectionClass $entity, string $name): bool
Method JG\BatchEntityImportBundle\Service\PropertyExistenceChecker::isPropertyWritable() has parameter $entity with generic class ReflectionClass but does not specify its types: T
Last edited by Jarosław Grygierek- {
- $setterName = ColumnNameHelper::getSetterName($name);
- return ($entity->hasProperty($name) && $entity->getProperty($name)->isPublic())
- || ($entity->hasMethod($setterName) && $entity->getMethod($setterName)->isPublic());
- }
- $this->save();
- }
- protected function prepareRecord(MatrixRecord $record, array $headerInfo): void
Method JG\BatchEntityImportBundle\Model\Configuration\AbstractImportConfiguration::prepareRecord() has parameter $headerInfo with no value type specified in iterable type array.
Last edited by Jarosław Grygierek- {
- $entity = $this->getEntity($record);
- $data = $record->getData();
- $fieldDefinitions = $this->getFieldsDefinitions();
- }
- parent::validateArguments($value, $constraint);
- }
- private function getMatrixRecordDataToCompare(MatrixRecord $matrixRecord, array $fields): array
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::getMatrixRecordDataToCompare() has parameter $fields with no value type specified in iterable type array.
Last edited by Jarek- {
- $data = [];
- foreach ($fields as $field) {
- $data[$field] = $matrixRecord->$field;
- }
- }
- return $data;
- }
- private function isDuplicate(array $matrixDataToCompare): bool
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::isDuplicate() has parameter $matrixDataToCompare with no value type specified in iterable type array.
Last edited by Jarek- {
- return array_key_exists($this->getHash($matrixDataToCompare), $this->duplicatedRecords);
- }
- private function isCorrectRecord(array $matrixDataToCompare): bool
- private function isDuplicate(array $matrixDataToCompare): bool
- {
- return array_key_exists($this->getHash($matrixDataToCompare), $this->duplicatedRecords);
- }
- private function isCorrectRecord(array $matrixDataToCompare): bool
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::isCorrectRecord() has parameter $matrixDataToCompare with no value type specified in iterable type array.
Last edited by Jarek- {
- return array_key_exists($this->getHash($matrixDataToCompare), $this->correctRecords);
- }
- private function addDuplicate(array $matrixDataToCompare): void
- private function isCorrectRecord(array $matrixDataToCompare): bool
- {
- return array_key_exists($this->getHash($matrixDataToCompare), $this->correctRecords);
- }
- private function addDuplicate(array $matrixDataToCompare): void
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::addDuplicate() has parameter $matrixDataToCompare with no value type specified in iterable type array.
Last edited by Jarek- {
- $this->duplicatedRecords[$this->getHash($matrixDataToCompare)] = true;
- }
- private function markAsCorrectRecord(array $matrixDataToCompare): void
- private function addDuplicate(array $matrixDataToCompare): void
- {
- $this->duplicatedRecords[$this->getHash($matrixDataToCompare)] = true;
- }
- private function markAsCorrectRecord(array $matrixDataToCompare): void
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::markAsCorrectRecord() has parameter $matrixDataToCompare with no value type specified in iterable type array.
Last edited by Jarek- {
- $this->correctRecords[$this->getHash($matrixDataToCompare)] = true;
- }
- /**
- }
- /**
- * @return array<string, array<int, array{0: string, 1: scalar}>>
- */
- private function buildCriteria(MatrixRecord $matrixRecord, array $matrixDataToCompare): array
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::buildCriteria() has parameter $matrixDataToCompare with no value type specified in iterable type array.
Last edited by Jarek- {
- /** @var array<string, array<int, array{0: string, 1: scalar}>> $criteria */
- $criteria = [];
- foreach ($matrixDataToCompare as $fieldName => $value) {
- $criteria[ColumnNameHelper::toCamelCase($fieldName)][] = ['=', $value];
- }
- return $criteria;
- }
- private function addCriteriaToOmitEntity(array &$criteria, object $entityToOverride): void
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::addCriteriaToOmitEntity() has parameter $criteria with no value type specified in iterable type array.
Last edited by Jarek- {
- $primaryKeyData = $this->entityManager->getUnitOfWork()->getEntityIdentifier($entityToOverride);
- foreach ($primaryKeyData as $primaryKeyName => $primaryValue) {
- $criteria[$primaryKeyName][] = ['!=', $primaryValue];
- $container
- ->registerForAutoconfiguration(ImportConfigurationAutoInjectInterface::class)
- ->addTag('batch_entity_import.controller');
- }
- private function setParameters(array $configs, ContainerBuilder $container): void
Method JG\BatchEntityImportBundle\DependencyInjection\BatchEntityImportExtension::setParameters() has parameter $configs with no value type specified in iterable type array.
Last edited by Jarek- {
- $processor = new Processor();
- $configuration = new Configuration();
- $config = $processor->processConfiguration($configuration, $configs);
- $this->addTemplatesConfig($rootNode->children());
- return $treeBuilder;
- }
- private function addTemplatesConfig(NodeBuilder $parentBuilder): void
Method JG\BatchEntityImportBundle\DependencyInjection\Configuration::addTemplatesConfig() has parameter $parentBuilder with generic class Symfony\Component\Config\Definition\Builder\NodeBuilder but does not specify its types: TParent
Last edited by Jarek- {
- $builder = $parentBuilder->arrayNode('templates')->addDefaultsIfNotSet()->children();
- $this->addNodeConfig($builder, 'select_file', '@BatchEntityImport/select_file.html.twig');
- $this->addNodeConfig($builder, 'edit_matrix', '@BatchEntityImport/edit_matrix.html.twig');
- $this->addNodeConfig($builder, 'select_file', '@BatchEntityImport/select_file.html.twig');
- $this->addNodeConfig($builder, 'edit_matrix', '@BatchEntityImport/edit_matrix.html.twig');
- $this->addNodeConfig($builder, 'layout', '@BatchEntityImport/layout.html.twig');
- }
- private function addNodeConfig(NodeBuilder $builder, string $name, string $value): void
Method JG\BatchEntityImportBundle\DependencyInjection\Configuration::addNodeConfig() has parameter $builder with generic class Symfony\Component\Config\Definition\Builder\NodeBuilder but does not specify its types: TParent
Last edited by Jarek- {
- $builder
- ->scalarNode($name)
- ->defaultValue($value)
- ->cannotBeEmpty()
- namespace JG\BatchEntityImportBundle\Model\Form;
- readonly class FormFieldDefinition
- {
- public function __construct(private string $class, private array $options = [])
Method JG\BatchEntityImportBundle\Model\Form\FormFieldDefinition::__construct() has parameter $options with no value type specified in iterable type array.
Last edited by Jarosław Grygierek- {
- }
- public function getClass(): string
- {
- class MatrixRecord
- {
- private ?object $entity = null;
- private array $data = [];
- public function __construct(array $data = [], public readonly int|string|null $entityId = null)
Method JG\BatchEntityImportBundle\Model\Matrix\MatrixRecord::__construct() has parameter $data with no value type specified in iterable type array.
Last edited by Jarek- {
- foreach ($data as $name => $value) {
- if (!empty(\trim((string) $name))) {
- $this->data[\str_replace(' ', '_', (string) $name)] = $value;
- }
- protected function prepareContext(): void
- {
- $this->context->setNode($this->context->getValue(), $this->context->getObject(), $this->context->getMetadata(), '');
- }
- protected function addErrorToMatrixRecord(MatrixRecord $record, MatrixRecordUnique|DatabaseEntityUnique $constraint, int $index, array $fields): void
Method JG\BatchEntityImportBundle\Validator\Constraints\AbstractValidator::addErrorToMatrixRecord() has parameter $fields with no value type specified in iterable type array.
Last edited by Jarosław Grygierek- {
- $this->context
- ->buildViolation($constraint->message, ['%fields%' => implode(', ', $fields)])
- ->atPath(sprintf('children[records][%d][%s]', $index, $constraint->fields[0]))
- ->setInvalidValue($record)
- ->atPath(sprintf('children[records][%d][%s]', $index, $constraint->fields[0]))
- ->setInvalidValue($record)
- ->addViolation();
- }
- protected function getHash(array $data): string
Method JG\BatchEntityImportBundle\Validator\Constraints\AbstractValidator::getHash() has parameter $data with no value type specified in iterable type array.
Last edited by Jarek- {
- return md5(implode('--', $data));
- }
- }
Your project should not use invalid return types 2
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.invalid_return_typehint
- /**
- * @phpstan-return non-empty-string
- */
- private function getSeparator(FormFieldDefinition $fieldDefinition): string
- {
- return $fieldDefinition->getOptions()['separator'] ?? ArrayTextType::DEFAULT_SEPARATOR;
Method JG\BatchEntityImportBundle\Model\Configuration\AbstractImportConfiguration::getSeparator() should return non-empty-string but returns mixed.
Last edited by Jarosław Grygierek- }
- }
- $entityToOverride = $matrixRecord->getEntity();
- if (null !== $entityToOverride) {
- $this->addCriteriaToOmitEntity($criteria, $entityToOverride);
- }
- return $criteria;
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::buildCriteria() should return array<string, array<int, array{string, bool|float|int|string}>> but returns array.
Last edited by Jarek- }
- private function addCriteriaToOmitEntity(array &$criteria, object $entityToOverride): void
- {
- $primaryKeyData = $this->entityManager->getUnitOfWork()->getEntityIdentifier($entityToOverride);
Your project should use return types 7
- Read doc
- Reliability
- Major
More information: https://insight.symfony.com/what-we-analyse/php.missing_return_typehint
- }
- parent::validateArguments($value, $constraint);
- }
- private function getMatrixRecordDataToCompare(MatrixRecord $matrixRecord, array $fields): array
Method JG\BatchEntityImportBundle\Validator\Constraints\DatabaseEntityUniqueValidator::getMatrixRecordDataToCompare() return type has no value type specified in iterable type array.
Last edited by Jarek- {
- $data = [];
- foreach ($fields as $field) {
- $data[$field] = $matrixRecord->$field;
- }
- public function getClass(): string
- {
- return $this->class;
- }
- public function getOptions(): array
Method JG\BatchEntityImportBundle\Model\Form\FormFieldDefinition::getOptions() return type has no value type specified in iterable type array.
Last edited by Jarek- {
- return $this->options;
- }
- }
- public function setEntity(?object $entity): void
- {
- $this->entity = $entity;
- }
- public function getData(): array
Method JG\BatchEntityImportBundle\Model\Matrix\MatrixRecord::getData() return type has no value type specified in iterable type array.
Last edited by Jarek- {
- return $this->data;
- }
- public function __isset(string $name): bool
- }
- return implode($this->separator, $value);
- }
- public function reverseTransform(mixed $value): array
Method JG\BatchEntityImportBundle\Form\Type\ArrayTextType::reverseTransform() return type has no value type specified in iterable type array.
Last edited by Pierre Svgnt- {
- if (!is_string($value)) {
- throw new UnexpectedValueException('Only strings are allowed');
- }
- public function getEntityTranslationRelationName(): ?string;
- /**
- * Use this method to pass constraints to the main Matrix form.
- */
- public function getMatrixConstraints(): array;
Method JG\BatchEntityImportBundle\Model\Configuration\ImportConfigurationInterface::getMatrixConstraints() return type has no value type specified in iterable type array.
Last edited by Jarek- /**
- * Use this method to set allowed file extensions.
- */
- public function getAllowedFileExtensions(): array;
- public function getMatrixConstraints(): array;
- /**
- * Use this method to set allowed file extensions.
- */
- public function getAllowedFileExtensions(): array;
Method JG\BatchEntityImportBundle\Model\Configuration\ImportConfigurationInterface::getAllowedFileExtensions() return type has no value type specified in iterable type array.
Last edited by Jarek- /**
- * Import data from matrix to database.
- */
- public function import(Matrix $matrix): void;
- }
- /**
- * @param string[] $fieldsUsedInDuplicationCheck
- */
- private function getMatrixRecordDataForDuplicationCheck(MatrixRecord $matrixRecord, array $fieldsUsedInDuplicationCheck): array
Method JG\BatchEntityImportBundle\Validator\Constraints\MatrixRecordUniqueValidator::getMatrixRecordDataForDuplicationCheck() return type has no value type specified in iterable type array.
Last edited by Jarek- {
- return array_intersect_key($matrixRecord->getData(), array_flip($fieldsUsedInDuplicationCheck));
- }
- }