Analysis laurentmuller / fpdf2-make-font #6

Your project should not contain commented code 2

Productivity

Minor

More information: https://insight.symfony.com/what-we-analyse/php.commented_out_code

in src/TTFParser.php, line 519

                    do {
                        $flags = $this->readUShort();
                        $index = $this->readUShort();
                        $components[$offset + 2] = $index;
                        if ($this->isBitSet($flags, 1)) { // ARG_1_AND_2_ARE_WORDS
                            $skip = 4; // 2 * 2;Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes
Read doc
                Open Issue
             Permalink

                                    Last edited Thu, 10 Apr 2025 15:23:38 +0000 by Laurent Muller
                    
                        } else {
                            $skip = 2;
                        }
                        if ($this->isBitSet($flags, 8)) { // WE_HAVE_A_SCALE
                            $skip += 2;

in src/TTFParser.php, line 528

                        if ($this->isBitSet($flags, 8)) { // WE_HAVE_A_SCALE
                            $skip += 2;
                        } elseif ($this->isBitSet($flags, 64)) { // WE_HAVE_AN_X_AND_Y_SCALE
                            $skip += 4; // 2 * 2
                        } elseif ($this->isBitSet($flags, 128)) { // WE_HAVE_A_TWO_BY_TWO
                            $skip += 8; // 4 * 2;Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes
Read doc
                Open Issue
             Permalink

                                    Last edited Thu, 10 Apr 2025 15:23:38 +0000 by Laurent Muller
                    
                        }
                        $this->skip($skip);
                        $offset += 2 * 2 + $skip;
                    } while ($flags & 32); // MORE COMPONENTS
                    $glyph['components'] = $components;