Unused method, property, variable or parameter

More information: https://insight.symfony.com/what-we-analyse/php.unused_local_variable_or_private_member

  1. {
  2. if (! $scope->getTestResult()->isPassed()) {
  3. $makeScreenshot = false;
  4. $suiteName = urlencode(str_replace(' ', '_', $scope->getSuite()->getName()));
  5. $featureName = urlencode(str_replace(' ', '_', $scope->getFeature()->getTitle()));
  6. if ($background = $this->getBackground($scope)) {

    This background local variable is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Fabien Somnier
  7. $makeScreenshot = $scope->getFeature()->hasTag('javascript');
  8. $scenarioName = 'background';
  9. } else {
  10. $scenario = $this->getScenario($scope);
  11. $makeScreenshot = $scope->getFeature()->hasTag('javascript') || $scenario->hasTag('javascript');

The composer.json file should not raise warnings

More information: https://insight.symfony.com/what-we-analyse/composer.warning

License "beerware" is not a valid SPDX license identifier, see http://www.spdx.org/licenses/ if you use an open license.
If the software is closed-source, you may use "proprietary" as license.

Time to fix: about 1 hour
Open Issue Permalink
Collective

Interfaces names should end with "Interface" 2

More information: https://insight.symfony.com/what-we-analyse/php.interface_has_no_interface_suffix

  1. <?php
  2. namespace Sanpi\Behatch\HttpCall;
  3. interface ContextSupportedVoter

    Interface ContextSupportedVoter should be named ContextSupportedVoterInterface for better clarity.

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Timothée Barray
  4. {
  5. public function vote(HttpCallResult $httpCallResult);
  6. }
  1. <?php
  2. namespace Sanpi\Behatch\HttpCall;
  3. interface FilterableHttpCallResult

    Interface FilterableHttpCallResult should be named FilterableHttpCallResultInterface for better clarity.

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Timothée Barray
  4. {
  5. public function filter(HttpCallResult $httpCallResult);
  6. }