Deprecated class usage found

  • Info
  • Architecture

More information: https://insight.symfony.com/what-we-analyse/third_party.use_deprecated_class

  1. $container->setDefinition($clientServiceId, $client);
  2. if (isset($options['description'])) {
  3. $descriptionFactory->addMethodCall('addResource', [$name, $options['description']]);
  4. $serviceDefinition = new DefinitionDecorator('csa_guzzle.service.abstract');

    The Symfony\Component\DependencyInjection\DefinitionDecorator class has been deprecated in Symfony 3.3. Use the Symfony\Component\DependencyInjection\ChildDefinition class instead.

    Time to fix: about 2 hours
    Open Issue Permalink
    Last edited by Charles Sarrazin
  5. $serviceDefinition->addArgument(new Reference($clientServiceId));
  6. $serviceDefinition->addArgument(new Expression(sprintf(
  7. 'service("csa_guzzle.description_factory").getDescription("%s")',
  8. $name
  9. )));

Text files should end with a newline character

  • Info
  • Codestyle

More information: https://insight.symfony.com/what-we-analyse/missing_e_o_l

in composer.json, line 43
  1. "extra": {
  2. "branch-alias": {
  3. "dev-master": "1.3.x-dev"
  4. }
  5. }
  6. }

    This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Charles Sarrazin