Public methods in controller classes should only be actions (with the Action suffix)

More information: https://insight.symfony.com/what-we-analyse/symfony.controller.non_action_public_method_in_controller_class

  1. * @param array $slugs
  2. * @param array $elements
  3. *
  4. * @return Category|Page
  5. */
  6. public function getFinalTreeElement(array $slugs, array $elements)

    Non-action public method found in controller class

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Alex Pierstoval
  7. {
  8. if (!count($slugs) || count($slugs) !== count($elements)) {
  9. throw $this->createNotFoundException();
  10. }
  11. /** @var Page|Category $element */

Unused use statement should be avoided

More information: https://insight.symfony.com/what-we-analyse/php.unused_use_statement

  1. * file that was distributed with this source code.
  2. */
  3. namespace Orbitale\Bundle\CmsBundle\Controller;
  4. use Doctrine\ORM\EntityManager;

    The class Doctrine\ORM\EntityManager is declared but never used. You should remove the use statement.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Alex Pierstoval
  5. use Orbitale\Bundle\CmsBundle\Entity\Page;
  6. use Orbitale\Bundle\CmsBundle\Repository\PageRepository;
  7. use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
  8. use Symfony\Component\HttpFoundation\Request;

Text files should end with a valid new line character. 2

More information: https://insight.symfony.com/what-we-analyse/missing_e_o_l

  1. }
  2. return $element;
  3. }
  4. }

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Alex Pierstoval
in README.md, line 226
  1. ```
  2. ## Changelog
  3. Go to the [releases](https://github.com/Orbitale/CmsBundle/releases) page to see what are the changes between each
  4. new version of Orbitale CmsBundle!

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Alex Pierstoval