guite / core #2394

     * @param VariableApiInterface $variableApi
     * @param array $options
     * @param AbstractProxy|NativeSessionHandler|\SessionHandlerInterface|null $handler
     * @param MetadataBag $metaBag
     */
    public function __construct(VariableApiInterface $variableApi, array $options = [], $handler = null, MetadataBag $metaBag = null)
You should use the interface Symfony\Component\HttpFoundation\Session\SessionStorageInterface instead of the class Symfony\Component\HttpFoundation\Session\Storage\MetadataBag as a typehint.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 12 Apr 2017 13:12:58 +0200 by Craig Heydenburg
                    
    {
        $this->securityLevel = $variableApi->getSystemVar('seclevel', self::SECURITY_LEVEL_MEDIUM);
        $this->inactiveSeconds = $variableApi->getSystemVar('secinactivemins', 20) * 60;
        $this->autoLogoutAfterSeconds = $variableApi->getSystemVar('secmeddays', 7) * 24 * 60 * 60;

     * @param UserRepositoryInterface $userRepository
     * @param PermissionApiInterface $permissionApi
     * @param VariableApiInterface $variableApi
     * @param TranslatorInterface $translator
     */
    public function __construct(
You should use the interface Symfony\Component\HttpFoundation\Session\SessionInterface instead of the class Symfony\Component\HttpFoundation\Session\Session as a typehint.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Jul 2016 17:45:06 +0200 by Craig Heydenburg
                    
        Session $session,
        UserRepositoryInterface $userRepository,
        PermissionApiInterface $permissionApi,
        VariableApiInterface $variableApi,
        TranslatorInterface $translator

     * @param TranslatorInterface $translator
     * @param VariableApiInterface $variableApi
     * @param ValidatorInterface $validator
     * @param PasswordApiInterface $passwordApi
     */
    public function __construct(
You should use the interface Symfony\Component\HttpFoundation\Session\SessionInterface instead of the class Symfony\Component\HttpFoundation\Session\Session as a typehint.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Jul 2016 17:45:06 +0200 by Craig Heydenburg
                    
        AuthenticationMappingRepositoryInterface $mappingRepository,
        Session $session,
        TranslatorInterface $translator,
        VariableApiInterface $variableApi,
        ValidatorInterface $validator,

        // PHPIDS should run with PHP 5.1.2 but this is untested - set this value to force compatibilty with minor versions
        $config['General']['min_php_version'] = '5.1.6';
        // caching settings
        // @todo: add UI for those caching settings
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Sun, 04 Jul 2010 07:38:25 +0200 by Drak
                    
        $config['Caching'] = [];
        // caching method (session|file|database|memcached|none), default file
        $config['Caching']['caching'] = 'none'; // deactivate caching for now
        $config['Caching']['expiration_time'] = 600;

\Locale::setDefault($parameters['locale']);
if (version_compare(PHP_VERSION, '7.2.0') >= 0) {
    // suppress deprecated warnings because create_function() is used in SymfonyRequirements.php but deprecated in PHP 7.2
    // see https://github.com/symfony/requirements-checker/pull/11
    // TODO remove as soon as we use Flex
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Fri, 06 Jul 2018 07:48:23 +0200 by Axel Guckelsberger
                    
    $reportingLevel = error_reporting();
    error_reporting($reportingLevel & ~E_DEPRECATED);
}
// on install or upgrade, check if system requirements are met.

// on install or upgrade, check if system requirements are met.
$requirementChecker = new RequirementChecker();
$requirementChecker->verify($parameters);
if (version_compare(PHP_VERSION, '7.2.0') >= 0) {
    // TODO remove as soon as we use Flex
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Fri, 06 Jul 2018 07:48:23 +0200 by Axel Guckelsberger
                    
    error_reporting($reportingLevel);
}
$kernel = new ZikulaKernel($parameters['env'], $parameters['debug']);
$kernel->boot();

    public function runSymfonyChecks($parameters = [])
    {
        if (version_compare(PHP_VERSION, '7.2.0') >= 0) {
            // suppress deprecated warnings because create_function() is used in SymfonyRequirements.php but deprecated in PHP 7.2
            // see https://github.com/symfony/requirements-checker/pull/11
            // TODO remove as soon as we use Flex
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Fri, 06 Jul 2018 07:48:23 +0200 by Axel Guckelsberger
                    
            $reportingLevel = error_reporting();
            error_reporting($reportingLevel & ~E_DEPRECATED);
        }
        try {

        } catch (MethodArgumentValueNotImplementedException $e) {
            // workaround https://github.com/symfony/symfony-installer/issues/163
        }
        if (version_compare(PHP_VERSION, '7.2.0') >= 0) {
            // TODO remove as soon as we use Flex
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Fri, 06 Jul 2018 07:48:23 +0200 by Axel Guckelsberger
                    
            error_reporting($reportingLevel);
        }
    }
    protected function getErrorMessage(\Requirement $requirement, $lineSize = 70)

    {% endfor %}
    </tbody>
</table>
{{ pager({rowcount:pager.count, limit:pager.limit, route:'zikulaextensionsmodule_module_viewmodulelist'}) }}
{{ adminFooter() }}
{# todo move to own file #}
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Mon, 11 Jun 2018 16:58:04 +0200 by Guite
                    
{% set initScript %}
<script>
    ( function($) {
        $(document).ready(function() {
            $('i[class*=fa-caret-]').on('click', function() {

{{ adminHeader() }}{# @todo wrong header! see below #}
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Wed, 09 Mar 2016 03:48:52 +0100 by Craig Heydenburg
                    
{#{admincategorymenu}#}
{#<div class="z-admin-content clearfix">#}
    {#{modgetinfo modname=$currentmodule info='displayname' assign='displayName'}#}
    {#{modgetimage modname=$currentmodule assign='image'}#}

            }
            if ('Filter' == $namespace) {
                if (
                // Do not allow Filter.Custom for now. Causing errors.
                // TODO research why Filter.Custom is causing exceptions and correct.
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Tue, 31 May 2016 05:56:41 +0200 by Axel Guckelsberger
                    
                        ('Custom' == $directive)
                        // Do not allow Filter.ExtractStyleBlock* for now. Causing errors.
                        // TODO Filter.ExtractStyleBlock* requires CSSTidy
                        || (false !== stripos($directive, 'ExtractStyleBlock'))
                ) {

                if (
                // Do not allow Filter.Custom for now. Causing errors.
                // TODO research why Filter.Custom is causing exceptions and correct.
                        ('Custom' == $directive)
                        // Do not allow Filter.ExtractStyleBlock* for now. Causing errors.
                        // TODO Filter.ExtractStyleBlock* requires CSSTidy
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Tue, 31 May 2016 05:56:41 +0200 by Axel Guckelsberger
                    
                        || (false !== stripos($directive, 'ExtractStyleBlock'))
                ) {
                    continue;
                }
            }

     */
    public function getBrowserLocale($default = 'en')
    {
        $request = null !== $this->requestStack ? $this->requestStack->getCurrentRequest() : null;
        // @todo consider http://php.net/manual/en/locale.acceptfromhttp.php and http://php.net/manual/en/locale.lookup.php
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Sun, 16 Apr 2017 03:25:26 +0200 by Craig Heydenburg
                    
        if (null === $request || !$request->server->has('HTTP_ACCEPT_LANGUAGE') || 'cli' == php_sapi_name()) {
            return $default;
        }
        preg_match_all('~([\w-]+)(?:[^,\d]+([\d.]+))?~', strtolower($request->server->get('HTTP_ACCEPT_LANGUAGE')), $matches, PREG_SET_ORDER);
        $availableLanguages = [];

                if (false === $data['multilingual']) {
                    $data['language_detect'] = false;
                    $this->get('zikula_extensions_module.api.variable')->del(VariableApi::CONFIG, 'language');
                }
                $this->setSystemVars($data);
                $this->get('zikula_extensions_module.api.variable')->set(VariableApi::CONFIG, 'locale', $data['language_i18n']); // @todo which variable are we using?
TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Mon, 23 Jan 2017 07:43:41 +0100 by Craig Heydenburg
                    
                $this->get('zikula_routes_module.multilingual_routing_helper')->reloadMultilingualRoutingSettings(); // resets config/dynamic/generated.yml & custom_parameters.yml
                $request->getSession()->set('_locale', $data['language_i18n']);
                $this->addFlash('status', $this->__('Done! Localization configuration updated.'));
            }

        if ($currentStage instanceof WizardCompleteInterface) {
            return $currentStage->getResponse($request);
        }
        $templateParams = $this->controllerHelper->getTemplateGlobals($currentStage);
        $templateParams['headertemplate'] = '@ZikulaCoreInstaller/installheader.html.twig';
        if ($wizard->isHalted()) {
The next 14 lines appear both in src/lib/Zikula/Bundle/CoreInstallerBundle/Controller/InstallerController.php:58 and src/lib/Zikula/Bundle/CoreInstallerBundle/Controller/UpgraderController.php:66.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Tue, 30 Dec 2014 23:22:38 +0100 by Craig Heydenburg
                    
            $request->getSession()->getFlashBag()->add('danger', $wizard->getWarning());
            return $this->renderResponse('ZikulaCoreInstallerBundle::error.html.twig', $templateParams);
        }

    /**
     * Get id
     *
     * @return integer
     */
    public function getId()
The next 104 lines appear both in src/lib/Zikula/Bundle/HookBundle/Dispatcher/Storage/Doctrine/Entity/HookBindingEntity.php:81 and src/lib/Zikula/Bundle/HookBundle/Dispatcher/Storage/Doctrine/Entity/HookRuntimeEntity.php:102.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 22:08:54 +0100 by Drak
                    
    {
        return $this->id;
    }
    /**

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $translator = $options['translator'];
        $builder
            ->add('name', TextType::class, [
The next 40 lines appear both in src/system/AdminModule/Form/Type/CreateCategoryType.php:35 and src/system/AdminModule/Form/Type/EditCategoryType.php:37.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Wed, 21 Jun 2017 18:15:59 +0200 by Axel Guckelsberger
                    
                'label' => $translator->__('Name'),
                'attr' => [
                    'maxlength' => 50
                ]
            ])

 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Zikula\BlocksModule\Container;
The next 66 lines appear both in src/system/BlocksModule/Container/LinkContainer.php:12 and src/system/MenuModule/Container/LinkContainer.php:12.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Sun, 13 Dec 2015 07:54:21 +0100 by Craig Heydenburg
                    
use Symfony\Component\Routing\RouterInterface;
use Zikula\Common\Translator\TranslatorInterface;
use Zikula\Core\LinkContainer\LinkContainerInterface;
use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;

 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Zikula\BlocksModule\Container;
The next 69 lines appear in src/system/BlocksModule/Container/LinkContainer.php:12, src/system/MailerModule/Container/LinkContainer.php:12 and src/system/ThemeModule/Container/LinkContainer.php:12.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Sun, 13 Dec 2015 07:54:21 +0100 by Craig Heydenburg
                    
use Symfony\Component\Routing\RouterInterface;
use Zikula\Common\Translator\TranslatorInterface;
use Zikula\Core\LinkContainer\LinkContainerInterface;
use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;

 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Zikula\BlocksModule\Container;
The next 64 lines appear in src/system/BlocksModule/Container/LinkContainer.php:12, src/system/ExtensionsModule/Container/LinkContainer.php:12 and src/system/PermissionsModule/Container/LinkContainer.php:12.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Sun, 13 Dec 2015 07:54:21 +0100 by Craig Heydenburg
                    
use Symfony\Component\Routing\RouterInterface;
use Zikula\Common\Translator\TranslatorInterface;
use Zikula\Core\LinkContainer\LinkContainerInterface;
use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;

 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Zikula\GroupsModule\Form\Type;
The next 32 lines appear both in src/system/GroupsModule/Form/Type/ConfigType.php:12 and src/system/SearchModule/Form/Type/ConfigType.php:12.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Wed, 29 Jun 2016 10:09:15 +0200 by Axel Guckelsberger
                    
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
use Symfony\Component\Form\Extension\Core\Type\IntegerType;

        $groupsCommon = new CommonHelper($translator);
        $typeChoices = array_flip($groupsCommon->gtypeLabels());
        $stateChoices = array_flip($groupsCommon->stateLabels());
        $builder
            ->add('name', TextType::class, [
The next 25 lines appear both in src/system/GroupsModule/Form/Type/CreateGroupType.php:44 and src/system/GroupsModule/Form/Type/EditGroupType.php:46.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Sat, 19 Nov 2016 12:03:49 +0100 by Axel Guckelsberger
                    
                'label' => $translator->__('Name'),
                'attr' => [
                    'maxlength' => 30
                ],
                'constraints' => [

    }
    /**
     * {@inheritdoc}
     */
    public function getResults($filters = [], $sorting = [], $limit = 0, $offset = 0)
The next 33 lines appear both in src/system/SearchModule/Entity/Repository/SearchResultRepository.php:48 and src/system/SearchModule/Entity/Repository/SearchStatRepository.php:43.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Thu, 24 Nov 2016 15:52:50 +0100 by Guite
                    
    {
        $qb = $this->createQueryBuilder('tbl')
            ->select('tbl');
        // add clauses for where

 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Zikula\UsersModule\Validator\Constraints;
The next 64 lines appear both in src/system/UsersModule/Validator/Constraints/ValidEmailValidator.php:12 and src/system/ZAuthModule/Validator/Constraints/ValidEmailValidator.php:12.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Mon, 11 Jul 2016 17:45:06 +0200 by Craig Heydenburg
                    
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\Constraints\Email;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Component\Validator\ConstraintViolationListInterface;

        return;
    }
    private function isSerialized($string)
    {
        return 'b:0;' === $string || false !== @unserialize($string);
Adding "@" before unserialize($string) prevents warning and errors during this function execution from being displayed.

If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
Time to fix: about 4 hours

                Open Issue
             Permalink

                                    Last edited Tue, 31 Oct 2017 07:56:25 +0100 by Axel Guckelsberger
                    
    }
}

        }
        $response = $event->getResponse();
        $response->headers->set('X-Frame-Options', $this->xFrameOptions);
        //$response->headers->set('X-Content-Security-Policy', "frame-ancestors 'self'");
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 21 Mar 2016 07:52:18 +0100 by Guite
                    
        $response->headers->set('X-XSS-Protection', '1');
    }
}

        if ($this->csrfToken) {
            $core['authid'] = $this->authid;
            $core['token'] = $this->csrfToken;
        }
        //$logUtilMessages = (array) \LogUtil::getStatusMessages();
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 15:14:33 +0100 by Drak
                    
        //$core['statusmsg'] = array_merge($this->messages, $logUtilMessages);
        $core['statusmsg'] = $this->messages;
        return $core;
    }

        if ($this->csrfToken) {
            $core['authid'] = $this->authid;
            $core['token'] = $this->csrfToken;
        }
        //$logUtilMessages = (array) \LogUtil::getStatusMessages();
        //$core['statusmsg'] = array_merge($this->messages, $logUtilMessages);
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 15:14:33 +0100 by Drak
                    
        $core['statusmsg'] = $this->messages;
        return $core;
    }

                    $event = new ModuleStateEvent($bundle, $extensionEntity->toArray());
                    $this->get('event_dispatcher')->dispatch(CoreEvents::MODULE_POSTINSTALL, $event);
                }
            }
            // currently commented out because it takes a long time.
//            $this->get('zikula_extensions_module.extension_helper')->installAssets();
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 15 Mar 2016 05:19:13 +0100 by Craig Heydenburg
                    
        }
        return $this->redirectToRoute('zikulaextensionsmodule_module_viewmodulelist', ['justinstalled' => json_encode($extensions)]);
    }

                $logger->addError("Could not send message to: $emailList :: " . $this->message->toString());
            }
            $this->eventDispatcher->dispatch(MailerEvents::SEND_MESSAGE_FAILURE, $event);
            //throw new \RuntimeException($this->__('Error! A problem occurred while sending the e-mail message.'));
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Fri, 21 Oct 2016 14:01:41 +0200 by Axel Guckelsberger
                    
            return false;
        }
        if ($this->dataValues['enableLogging']) {

     * MenuItemEntity constructor.
     */
    public function __construct()
    {
        $this->title = '';
        $this->options = []; /*new ArrayCollection();
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Thu, 13 Jul 2017 13:39:04 +0200 by Guite
                    
        $this->options = [
            'routeParameters' => [],
            'attributes' => [],
            'linkAttributes' => [],
            'childrenAttributes' => [],

                $record['level']     = ACCESS_COMMENT; // 300
                $record['bond']      = 0;
                $this->entityManager->persist($record);
                $lastPerm->setSequence($record->getSequence() + 1);
                $this->entityManager->flush();
                //$this->addFlash('success', $this->__('A permission rule was added to allow users access to "utility" themes. Please check the sequence.'));
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Fri, 02 Sep 2016 08:45:14 +0200 by Guite
                    
            case '1.1.2':
            // future upgrade routines
        }

            if ($multilingual) {
                // get all available locales
                $langs = $installedLanguages;
            } else {
                // get only the default locale
                $langs = [$variableApi->getSystemVar('language_i18n', 'en')]; //$this->container->getParameter('locale');
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Thu, 05 Jan 2017 06:05:41 +0100 by Craig Heydenburg
                    
            }
        }
        $errors = '';

            if ($request->server->has('USER_AGENT')) {
                $requestArgs['USER_AGENT'] = $request->server->get('USER_AGENT');
            }
            // while i think that REQUEST_URI is unnecessary,
            // the REFERER would be important, but results in way too many false positives
            /*
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 31 May 2016 05:56:41 +0200 by Axel Guckelsberger
                    
            if ($request->server->has('REQUEST_URI')) {
                $requestArgs['REQUEST_URI'] = $request->server->get('REQUEST_URI');
            }
            if ($request->server->has('HTTP_REFERER')) {
                $requestArgs['REFERER'] = $request->server->get('HTTP_REFERER');

        $config['General']['filter_type'] = $this->getSystemVar('idsfilter', 'xml');
        if (empty($config['General']['filter_type'])) {
            $config['General']['filter_type'] = 'xml';
        }
        $config['General']['base_path'] = ''; //PHPIDS_PATH_PREFIX;
Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.
Time to fix: about 30 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 12 Nov 2013 04:51:22 +0100 by Craig Heydenburg
                    
        // we don't use the base path because the tmp directory is in zkTemp (see below)
        $config['General']['use_base_path'] = false;
        // path to the filters used
        $config['General']['filter_path'] = $this->getSystemVar('idsrulepath', 'system/SecurityCenterModule/Resources/config/phpids_zikula_default.xml');

     * @param string $context Usage context (allowed values: controllerAction, api, actionHandler, block, contentType)
     * @param array  $args    Additional arguments
     *
     * @return array List of template variables to be assigned
     */
    protected function getViewQuickNavParametersForRoute($context = '', array $args = [])
This context argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 13 Nov 2017 09:12:14 +0100 by Axel Guckelsberger
                    
    {
        $parameters = [];
        if (null === $this->request) {
            return $parameters;
        }

     * @param string $context Usage context (allowed values: controllerAction, api, actionHandler, block, contentType)
     * @param array  $args    Additional arguments
     *
     * @return array List of template variables to be assigned
     */
    protected function getViewQuickNavParametersForRoute($context = '', array $args = [])
This args argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 13 Nov 2017 09:12:14 +0100 by Axel Guckelsberger
                    
    {
        $parameters = [];
        if (null === $this->request) {
            return $parameters;
        }

     * @param QueryBuilder $qb         Query builder to be enhanced
     * @param array        $parameters List of determined filter options
     *
     * @return QueryBuilder Enriched query builder instance
     */
    protected function applyDefaultFiltersForRoute(QueryBuilder $qb, array $parameters = [])
This parameters argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 13 Nov 2017 09:12:14 +0100 by Axel Guckelsberger
                    
    {
        if (null === $this->request) {
            return $qb;
        }
        $routeName = $this->request->get('_route');

        $permissionApi = $this->container->get('zikula_permissions_module.api.permission');
        $currentUserApi = $this->container->get('zikula_users_module.current_user');
        $entityDisplayHelper = $this->container->get('zikula_routes_module.entity_display_helper');
        $menu->setChildrenAttribute('class', 'list-inline');
        $currentUserId = $currentUserApi->isLoggedIn() ? $currentUserApi->get('uid') : UsersConstant::USER_ID_ANONYMOUS;
This currentUserId local variable is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 24 Apr 2017 18:34:53 +0200 by Axel Guckelsberger
                    
        if ($entity instanceof RouteEntity) {
            $component = 'ZikulaRoutesModule:Route:';
            $instance = $entity->getKey() . '::';
            $routePrefix = 'zikularoutesmodule_route_';

    /**
     * Dispatcher instance.
     *
     * @var EventDispatcher
     */
    protected $dispatcher;
The Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher class has been deprecated in Symfony 3.3. Use the Symfony\Component\EventDispatcher\EventDispatcher class instead.
Time to fix: about 2 hours

                Open Issue
             Permalink

                                    Last edited Sun, 01 Sep 2013 18:46:26 +0200 by Drak
                    
    /**
     * Translation domain.
     *
     * @var string

    /**
     * Constructor.
     *
     * @param EventDispatcher $dispatcher ServiceManager
     */
    public function __construct(EventDispatcherInterface $dispatcher)
The Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher class has been deprecated in Symfony 3.3. Use the Symfony\Component\EventDispatcher\EventDispatcher class instead.
Time to fix: about 2 hours

                Open Issue
             Permalink

                                    Last edited Mon, 25 Nov 2013 19:49:33 +0100 by Drak
                    
    {
        $this->dispatcher = $dispatcher;
        $this->setTranslator($dispatcher->getContainer()->get('translator.default'));
        $this->setup();
        if (null !== $this->domain) {

    /**
     * Get dispatcher.
     *
     * @return EventDispatcher
     */
    public function getDispatcher()
The Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher class has been deprecated in Symfony 3.3. Use the Symfony\Component\EventDispatcher\EventDispatcher class instead.
Time to fix: about 2 hours

                Open Issue
             Permalink

                                    Last edited Sun, 01 Sep 2013 18:46:26 +0200 by Drak
                    
    {
        return $this->dispatcher;
    }
    /**

    /**
     * get the category locked status
     *
     * @return bool locked status flag
     */
    public function getIs_locked()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        return $this->is_locked;
    }
    /**

    /**
     * get the category locked status
     *
     * @param bool $is_locked locked status flag
     */
    public function setIs_locked($is_locked)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        $this->is_locked = $is_locked;
    }
    /**

    /**
     * get the category leaf status
     *
     * @return bool leaf status flag
     */
    public function getIs_leaf()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        return $this->is_leaf;
    }
    /**

    /**
     * set the category leaf status
     *
     * @param bool $is_leaf leaft status flag
     */
    public function setIs_leaf($is_leaf)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        $this->is_leaf = $is_leaf;
    }
    /**

     * get the category display name
     * @param $lang
     *
     * @return array|string the category display name(s)
     */
    public function getDisplay_name($lang = null)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Feb 2015 23:19:06 +0100 by Craig Heydenburg
                    
    {
        if (!empty($lang)) {
            if (isset($this->display_name[$lang])) {
                return $this->display_name[$lang];
            }

    /**
     * set the category display name
     *
     * @param array $display_name the category display name array
     */
    public function setDisplay_name($display_name)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Feb 2015 06:09:30 +0100 by Craig Heydenburg
                    
    {
        $this->display_name = $display_name;
    }
    /**

     * get the category display description
     * @param $lang
     *
     * @return array|string the category display description
     */
    public function getDisplay_desc($lang = null)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Feb 2015 23:19:06 +0100 by Craig Heydenburg
                    
    {
        if (!empty($lang)) {
            if (isset($this->display_desc[$lang])) {
                return $this->display_desc[$lang];
            }

    /**
     * set the category display description
     *
     * @param array $display_desc the category display description
     */
    public function setDisplay_desc($display_desc)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Feb 2015 06:09:30 +0100 by Craig Heydenburg
                    
    {
        $this->display_desc = $display_desc;
    }
    /**

    /**
     * set the creation date of the category
     *
     * @param mixed $cr_date the creation date
     */
    public function setCr_date($cr_date)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Sep 2013 07:10:12 +0200 by Craig Heydenburg
                    
    {
        $this->cr_date = $cr_date;
    }
    /**

    /**
     * get the creation date of the category
     *
     * @return mixed the creation date
     */
    public function getCr_date()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Sep 2013 07:10:12 +0200 by Craig Heydenburg
                    
    {
        return $this->cr_date;
    }
    /**

    /**
     * set the creation user id of the category
     *
     * @param int $cr_uid the user id
     */
    public function setCr_uid($cr_uid)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Sep 2013 07:10:12 +0200 by Craig Heydenburg
                    
    {
        $this->cr_uid = $cr_uid;
    }
    /**

    /**
     * get the creation user id
     *
     * @return int the user id
     */
    public function getCr_uid()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Sep 2013 07:10:12 +0200 by Craig Heydenburg
                    
    {
        return $this->cr_uid;
    }
    /**

    /**
     * set the last updated timestamp of the category
     *
     * @param mixed $lu_date the last updated timestamp
     */
    public function setLu_date($lu_date)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Sep 2013 07:10:12 +0200 by Craig Heydenburg
                    
    {
        $this->lu_date = $lu_date;
    }
    /**

    /**
     * get the last updated timestamp of the category
     *
     * @return mixed the last updated timestamp
     */
    public function getLu_date()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Sep 2013 07:10:12 +0200 by Craig Heydenburg
                    
    {
        return $this->lu_date;
    }
    /**

    /**
     * set the user id of the user who last updated the category
     *
     * @param int $lu_uid the user id
     */
    public function setLu_uid($lu_uid)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Sep 2013 07:10:12 +0200 by Craig Heydenburg
                    
    {
        $this->lu_uid = $lu_uid;
    }
    /**

    /**
     * get the user id of the user who last updated the category
     *
     * @return int the user id
     */
    public function getLu_uid()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 16 Sep 2013 07:10:12 +0200 by Craig Heydenburg
                    
    {
        return $this->lu_uid;
    }
    /**

     * @param string $m2 Plural instance
     * @param integer $n Object count
     * @param string| null $locale Optional forced locale
     * @return string
     */
    public function _n($m1, $m2, $n, $locale = null)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Sat, 18 Aug 2018 07:35:33 +0200 by Guite
                    
    {
        /** @Ignore */
        return $this->translator->_n($m1, $m2, $n, $this->domain, $locale);
    }

     * @param integer $n Object count
     * @param string|array $param Format parameters
     * @param string|null $locale Optional forced locale
     * @return string
     */
    public function _fn($m1, $m2, $n, $param, $locale = null)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Sat, 18 Aug 2018 07:35:33 +0200 by Guite
                    
    {
        /** @Ignore */
        return $this->translator->_fn($m1, $m2, $n, $param, $this->domain, $locale);
    }

    /**
     * get last update time of the block
     *
     * @return \DateTime the block's last updated time
     */
    public function getLast_Update()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Sun, 13 Dec 2015 07:54:21 +0100 by Craig Heydenburg
                    
    {
        return $this->last_update;
    }
    /**

    /**
     * set the last updated time of the block
     *
     * @param none
     */
    public function setLast_Update()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Sun, 13 Dec 2015 07:54:21 +0100 by Craig Heydenburg
                    
    {
        $this->last_update = new \DateTime("now");
    }
    /**

    /**
     * set the creation date
     *
     * @param mixed $cr_date the creation date
     */
    public function setCr_date($cr_date)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        $this->cr_date = $cr_date;
    }
    /**

    /**
     * get the creation date
     *
     * @return mixed the creation date
     */
    public function getCr_date()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        return $this->cr_date;
    }
    /**

    /**
     * set the creation user id
     *
     * @param mixed $cr_uid the user id
     */
    public function setCr_uid($cr_uid)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        $this->cr_uid = $cr_uid;
    }
    /**

    /**
     * get the creation user id
     *
     * @return int the user id
     */
    public function getCr_uid()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        return $this->cr_uid;
    }
    /**

    /**
     * set the last updated date
     *
     * @param mixed $lu_date the date of the last update
     */
    public function setLu_date($lu_date)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        $this->lu_date = $lu_date;
    }
    /**

    /**
     * get the last updated date
     *
     * @return mixed the date of the last update
     */
    public function getLu_date()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        return $this->lu_date;
    }
    /**

    /**
     * set the user id of the user who last updated the entity
     *
     * @param mixed $lu_uid the user id
     */
    public function setLu_uid($lu_uid)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        $this->lu_uid = $lu_uid;
    }
    /**

    /**
     * get the user id of the user who last updated the entity
     *
     * @return int the user id
     */
    public function getLu_uid()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        return $this->lu_uid;
    }
    /**

    /**
     * set the status of the entity
     *
     * @param string $obj_status the entity status
     */
    public function setObj_status($obj_status)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        $this->obj_status = $obj_status;
    }
    /**

    /**
     * get the status of the entity
     *
     * @return string the entity status
     */
    public function getObj_status()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 18 Sep 2013 02:40:08 +0200 by Craig Heydenburg
                    
    {
        return $this->obj_status;
    }
}

    public function setSecurityschema($securityschema)
    {
        $this->securityschema = $securityschema;
    }
    public function getCore_min()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        return $this->core_min;
    }
    public function setCore_min($core_min)

    public function getCore_min()
    {
        return $this->core_min;
    }
    public function setCore_min($core_min)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        $this->core_min = $core_min;
    }
    public function getCore_max()

    public function setCore_min($core_min)
    {
        $this->core_min = $core_min;
    }
    public function getCore_max()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        return $this->core_max;
    }
    public function setCore_max($core_max)

    public function getCore_max()
    {
        return $this->core_max;
    }
    public function setCore_max($core_max)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        $this->core_max = $core_max;
    }
    public function setCorecompatibility($coreCompatibility)

    /**
     * Returns the _object type.
     *
     * @return string
     */
    public function get_objectType()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 23 Dec 2014 11:29:00 +0100 by Christian Flach
                    
    {
        return $this->_objectType;
    }
    /**

     *
     * @param string $_objectType
     *
     * @return void
     */
    public function set_objectType($_objectType)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 23 Dec 2014 11:29:00 +0100 by Christian Flach
                    
    {
        if ($this->_objectType != $_objectType) {
            $this->_objectType = $_objectType;
        }
    }

    /**
     * get the approved date of the user
     *
     * @return \DateTime the user's approved date
     */
    public function getApproved_Date()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 25 Aug 2015 18:55:12 +0200 by Craig Heydenburg
                    
    {
        return $this->approved_date;
    }
    /**

    /**
     * set the approved date for the user
     *
     * @param \DateTime $approved_date the user's approved date
     */
    public function setApproved_Date($approved_date)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 25 Aug 2015 18:55:12 +0200 by Craig Heydenburg
                    
    {
        if ($approved_date instanceof \DateTime) {
            $this->approved_date = $approved_date;
        } else {
            // assume $approved_date is a string.

    /**
     * get the user id who approved the user
     *
     * @return integer the user's id who approved the user
     */
    public function getApproved_By()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 25 Aug 2015 18:55:12 +0200 by Craig Heydenburg
                    
    {
        return $this->approved_by;
    }
    /**

    /**
     * set the user id who approved the user
     *
     * @param integer $approved_by the user's id who approved the user
     */
    public function setApproved_By($approved_by)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 25 Aug 2015 18:55:12 +0200 by Craig Heydenburg
                    
    {
        $this->approved_by = $approved_by;
    }
    /**

    /**
     * get the regdate of the user
     *
     * @return \DateTime the user's regdate
     */
    public function getUser_Regdate()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 25 Aug 2015 18:55:12 +0200 by Craig Heydenburg
                    
    {
        return $this->user_regdate;
    }
    /**

    /**
     * set the regdate for the user
     *
     * @param \DateTime $user_regdate the user's regdate
     */
    public function setUser_Regdate($user_regdate)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Tue, 25 Aug 2015 18:55:12 +0200 by Craig Heydenburg
                    
    {
        if ($user_regdate instanceof \DateTime) {
            $this->user_regdate = $user_regdate;
        } else {
            // assume $user_regdate is a string

    /**
     * get the created date of the user verification
     *
     * @return \DateTime the user verification's created date
     */
    public function getCreated_Dt()
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        return $this->created_dt;
    }
    /**

    /**
     * set the created date for the user verification
     *
     * @param string|\DateTime $created_dt the user verification's created date
     */
    public function setCreated_Dt($created_dt)
Method names should be declared in camelCase. 
You should rename this method to comply with PSR-1.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Wed, 26 Dec 2012 17:34:39 +0100 by Drak
                    
    {
        if ($created_dt instanceof \DateTime) {
            $this->created_dt = $created_dt;
        } else {
            $this->created_dt = new \DateTime($created_dt);