Text files should end with a valid new line character. 5

More information: https://insight.symfony.com/what-we-analyse/missing_e_o_l

  1. 'name' => 'Átirányítások Modul',
  2. 'description' => 'Kezeld az átirányításokat az URL-ek között.',
  3. 'section' => [
  4. 'redirects' => 'Átirányítások',
  5. ],
  6. ];

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by kiger
  1. <?php
  2. return [
  3. 'new_redirect' => 'Új Átirányítás',
  4. ];

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by kiger
  1. 'name' => 'Biztonság',
  2. 'label' => 'Biztonságos URL-re irányítód?',
  3. 'instructions' => 'Forszírozod a biztonságos kapcsolatot az átirányításnál?',
  4. 'warning' => 'Ha az átirányítás értékének beállítasz egy protokolt a rendszer nem veszi figyelembe az opciót.',
  5. ],
  6. ];

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by kiger
  1. 'read' => 'Hozzáférhet az átirányításokhoz?',
  2. 'write' => 'Létrehozhat és szerkeszthet átirányítást?',
  3. 'delete' => 'Törölhet átirányítást?',
  4. ],
  5. ],
  6. ];

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by kiger
  1. return [
  2. 'redirects' => [
  3. 'name' => 'Átirányítások',
  4. ],
  5. ];

    This file ends with no newline character, or with a different newline character than other files in your project. It won't render properly on a terminal, and it's considered a bad practice.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by kiger

Methods and properties visibility should always be explicitly defined

More information: https://insight.symfony.com/what-we-analyse/php.method_or_property_missing_visibility

New rule! We've recently added this rule to Insight. Don't be surprised to see new suggestions even though the codebase didn't change.
  1. * @param Route $route
  2. * @param Parser $parser
  3. * @param Request $request
  4. * @param Redirector $redirector
  5. */
  6. function __construct(UrlGenerator $url, Route $route, Parser $parser, Request $request, Redirector $redirector)

    This method has no explicit visibility which may lead to maintainability issues. You should always declare a visibility for methods and properties.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Ryan Thompson
  7. {
  8. $this->url = $url;
  9. $this->route = $route;
  10. $this->parser = $parser;
  11. $this->request = $request;