Source code should not contain TODO comments 2

More information: https://insight.symfony.com/what-we-analyse/task_todo_comment

  1. array(
  2. 'name' => 'paragraph',
  3. 'groups' => array('list', 'indent', 'blocks', 'align'),
  4. 'items' => array('NumberedList', 'BulletedList'
  5. /**
  6. * @todo Add support for the floats

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Bob van de Vijver
  7. * , '-', 'JustifyLeft', 'JustifyCenter', 'JustifyRight', 'JustifyBlock'
  8. */
  9. ),
  10. ),
  11. array(
  • bobvandevijver

    Ignored on Thu, 28 Jul 2016 14:57:42 GMT
  1. 'name' => 'clipboard',
  2. 'groups' => array('clipboard', 'undo'),
  3. 'items' => array('Cut', 'Copy', 'Paste', 'PasteText', 'PasteFromWord', '-', 'Undo', 'Redo'),
  4. ),
  5. /**
  6. * @todo: add support for tables/special chars

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Bob van de Vijver
  7. * array(
  8. * 'name' => 'insert',
  9. * 'items' => array('Table', 'SpecialChar'),
  10. * ),
  11. */
  • bobvandevijver

    Ignored on Thu, 28 Jul 2016 14:57:45 GMT

Error silenced by the at sign (@)

More information: https://insight.symfony.com/what-we-analyse/php.silenced_error

in Helper/Parser.php, line 182
  1. // Remove ZERO-WIDTH-SPACE
  2. $text = str_replace("\xE2\x80\x8B", '', $text);
  3. // Load the document, we force the usage of UTF-8
  4. $DOM = new \DOMDocument();
  5. @$DOM->loadHTML('<meta http-equiv="content-type" content="text/html; charset=utf-8">' . $text);

    Adding "@" before $DOM->loadHTML('' . $text) prevents warning and errors during this function execution from being displayed.
    If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Bob van de Vijver
  6. // Replace tags with latex equivalents
  7. self::updateNode($DOM, 'b', '\textbf{');
  8. self::updateNode($DOM, 'strong', '\textbf{');
  9. self::updateNode($DOM, 'i', '\textit{');
  • bobvandevijver

    Ignored on Thu, 28 Jul 2016 14:57:18 GMT

User specific files should not appear in .gitignore

More information: https://insight.symfony.com/what-we-analyse/git.user_specific_ignored_file

in .gitignore, line 5
  1. # Bootstrap
  2. app/bootstrap*
  3. # Phpstorm project files
  4. .idea/*

    .idea/* is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Bob van de Vijver
  5. # Symfony directories
  6. vendor/*
  7. */logs/*
  8. */cache/*
  • bobvandevijver

    Ignored on Sun, 28 Feb 2016 11:30:01 GMT