User specific files should not appear in .gitignore

  • Minor
  • Codestyle

More information: https://insight.symfony.com/what-we-analyse/git.user_specific_ignored_file

in .gitignore, line 4 
  1. composer.lock
  2. composer.phar
  3. vendor/
  4. .idea/
    .idea/ is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Jérémy M
                    
  5. build/

Text files should end with a newline character

  • Info
  • Codestyle

More information: https://insight.symfony.com/what-we-analyse/missing_e_o_l

in .gitignore, line 5 
  1. composer.lock
  2. composer.phar
  3. vendor/
  4. .idea/
  5. build/
    This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Tim Bernhard

Methods and properties visibility should always be explicitly defined

  • Info
  • Readability

More information: https://insight.symfony.com/what-we-analyse/php.method_or_property_missing_visibility

in Twig/Extension.php, line 14 
  1.     protected $piwikHost;
  2.     protected $trackerPath;
  4.     protected $paqs = array();
  6.     function __construct($disabled, $siteId, $piwikHost, $trackerPath)
    This method has no explicit visibility which may lead to maintenability issues. You should always declare a visibility for methods and properties.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by bnw
                    
  7.     {
  8.         $this->disabled = $disabled;
  9.         $this->siteId = $siteId;
  10.         $this->piwikHost = rtrim($piwikHost, '/');
  11.         $this->trackerPath = ltrim($trackerPath, '/');