Code should not be duplicated 2

More information: https://insight.symfony.com/what-we-analyse/php.duplicated_code

  1. /** @var \Picamator\NeoWsClient\Request\Builder\FeedRequestFactory $requestFactory */
  2. $requestFactory = $container->get('neo_ws_request_builder_feed_request_factory');
  3. $request = $requestFactory->create($startDate, $endDate);
  4. $response = $manager->find($request);

    The next 39 lines appear both in doc/example/feed.detailed.php:22 and doc/example/feed.php:23.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  5. /** @var \Picamator\NeoWsClient\Model\Api\Data\FeedInterface $data */
  6. $data = $response->getData();
  7. echo <<<EOT
  • picamator

    Ignored on Sat, 26 Nov 2016 18:24:29 GMT
  1. /** @var \Picamator\NeoWsClient\Manager\Manager $manager */
  2. $manager = $container->get('neo_ws_manager_feed_manager');
  3. // get response
  4. $request = new FeedTodayRequest();
  5. $response = $manager->find($request);

    The next 39 lines appear both in doc/example/feed.today.detailed.php:18 and doc/example/feed.today.php:18.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  6. /** @var \Picamator\NeoWsClient\Model\Api\Data\FeedInterface $data */
  7. $data = $response->getData();
  8. echo <<<EOT
  • picamator

    Ignored on Sat, 26 Nov 2016 18:28:29 GMT

User specific files should not appear in .gitignore 2

More information: https://insight.symfony.com/what-we-analyse/git.user_specific_ignored_file

in .gitignore, line 2
  1. vendor/
  2. .idea/

    .idea/ is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  3. nbproject/
  4. .settings/
  5. .buildpath
  6. .project
  7. *.*~
  • picamator

    Ignored on Sat, 26 Nov 2016 18:24:36 GMT
in .gitignore, line 3
  1. vendor/
  2. .idea/
  3. nbproject/

    nbproject/ is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  4. .settings/
  5. .buildpath
  6. .project
  7. *.*~
  8. *.log
  • picamator

    Ignored on Sat, 26 Nov 2016 18:28:35 GMT