Source code should not contain TODO comments 4

More information: https://insight.symfony.com/what-we-analyse/task_todo_comment

  1. private $maxJoins;
  2. private $serializerContextBuilder;
  3. private $requestStack;
  4. /**
  5. * @TODO move $fetchPartial after $forceEager (@soyuka) in 3.0

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by abluchet
  6. */
  7. public function __construct(PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, ResourceMetadataFactoryInterface $resourceMetadataFactory, int $maxJoins = 30, bool $forceEager = true, RequestStack $requestStack = null, SerializerContextBuilderInterface $serializerContextBuilder = null, bool $fetchPartial = false, ClassMetadataFactoryInterface $classMetadataFactory = null)
  8. {
  9. if (null !== $this->requestStack) {
  10. @trigger_error(sprintf('Passing an instance of "%s" is deprecated since version 2.2 and will be removed in 3.0. Use the data provider\'s context instead.', RequestStack::class), E_USER_DEPRECATED);
  • dunglas

    Ignored on Tue, 27 Jun 2017 06:03:31 GMT
  1. }
  2. $filters = $request->attributes->get('_api_filters', []);
  3. $request->attributes->set('_api_filters', array_merge($pageParameter, $filters));
  4. /* @TODO remove the `_api_pagination` attribute in 3.0 (@meyerbaptiste) */

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Baptiste Meyer
  5. $request->attributes->set('_api_pagination', $pageParameter);
  6. }
  7. }
  • dunglas

    Ignored on Fri, 18 Jan 2019 23:40:58 GMT
  1. }
  2. try {
  3. [$normalizationGroups, $denormalizationGroups] = $this->getEffectiveSerializerGroups($options, $resourceClass);
  4. } catch (ResourceClassNotFoundException $e) {
  5. // TODO: for input/output classes, the serializer groups must be read from the actual resource class

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Teoh Han Hui
  6. return $propertyMetadata;
  7. }
  8. $propertyMetadata = $this->transformReadWrite($propertyMetadata, $resourceClass, $property, $normalizationGroups, $denormalizationGroups);
  • dunglas

    Ignored on Fri, 28 Jun 2019 15:07:51 GMT
  1. /**
  2. * @throws ResourceClassNotFoundException
  3. */
  4. private function addSubresourceOperation(bool $v3, array $subresourceOperation, \ArrayObject $definitions, string $operationId, ResourceMetadata $resourceMetadata): \ArrayObject
  5. {
  6. $operationName = 'get'; // TODO: we might want to extract that at some point to also support other subresource operations

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Ron Rademaker
  7. $collection = $subresourceOperation['collection'] ?? false;
  8. $subResourceMetadata = $this->resourceMetadataFactory->create($subresourceOperation['resource_class']);
  9. $pathOperation = new \ArrayObject([]);
  • dunglas

    Ignored on Fri, 28 Jun 2019 15:03:17 GMT

Unused method, property, variable or parameter 36

More information: https://insight.symfony.com/what-we-analyse/php.unused_local_variable_or_private_member

  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var string
  5. */
  6. private $deprecationReason;

    This deprecationReason attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:29:37 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $fetchable;

    This fetchable attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:29:41 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $fetchEager;

    This fetchEager attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:29:44 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $jsonldContext;

    This jsonldContext attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:29:46 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $openapiContext;

    This openapiContext attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Fri, 18 Jan 2019 23:41:03 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $push;

    This push attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Fri, 18 Jan 2019 23:41:07 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $swaggerContext;

    This swaggerContext attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @throws InvalidArgumentException
  9. */
  10. public function __construct(array $values = [])
  • dunglas

    Ignored on Fri, 18 Jan 2019 23:41:19 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $cacheHeaders;

    This cacheHeaders attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Daniel West
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Thu, 08 Nov 2018 15:26:51 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $denormalizationContext;

    This denormalizationContext attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var string
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:29:55 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var string
  5. */
  6. private $deprecationReason;

    This deprecationReason attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:29:57 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $elasticsearch;

    This elasticsearch attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by soyuka
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 15 May 2019 23:11:43 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $fetchPartial;

    This fetchPartial attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:00 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $forceEager;

    This forceEager attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:03 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $formats;

    This formats attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Anto
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var string[]
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:06 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var string[]
  5. */
  6. private $filters;

    This filters attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var string[]
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:08 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var string[]
  5. */
  6. private $hydraContext;

    This hydraContext attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var int
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:11 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var int
  5. */
  6. private $maximumItemsPerPage;

    This maximumItemsPerPage attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var mixed
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:13 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var mixed
  5. */
  6. private $mercure;

    This mercure attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool|string
  • dunglas

    Ignored on Thu, 08 Nov 2018 15:27:06 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool|string
  5. */
  6. private $messenger;

    This messenger attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Mon, 24 Dec 2018 16:16:34 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $normalizationContext;

    This normalizationContext attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:15 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $order;

    This order attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:16 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $paginationClientEnabled;

    This paginationClientEnabled attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:19 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $paginationClientItemsPerPage;

    This paginationClientItemsPerPage attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:21 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $paginationClientPartial;

    This paginationClientPartial attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:23 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $paginationEnabled;

    This paginationEnabled attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var bool
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:25 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var bool
  5. */
  6. private $paginationFetchJoinCollection;

    This paginationFetchJoinCollection attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var int
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:27 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var int
  5. */
  6. private $paginationItemsPerPage;

    This paginationItemsPerPage attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var int
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:28 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var int
  5. */
  6. private $paginationPartial;

    This paginationPartial attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var string
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:30 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var string
  5. */
  6. private $routePrefix;

    This routePrefix attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:32 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $swaggerContext;

    This swaggerContext attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Kévin Dunglas
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var mixed
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:34 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var mixed
  5. */
  6. private $validationGroups;

    This validationGroups attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Baptiste Meyer
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var string
  • dunglas

    Ignored on Wed, 04 Jul 2018 14:30:54 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var string
  5. */
  6. private $sunset;

    This sunset attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Thomas Blank
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var string|false
  • dunglas

    Ignored on Tue, 23 Oct 2018 17:31:38 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var string|false
  5. */
  6. private $input;

    This input attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by soyuka
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var string|false
  • dunglas

    Ignored on Tue, 26 Feb 2019 17:49:34 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var string|false
  5. */
  6. private $output;

    This output attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by soyuka
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Tue, 26 Feb 2019 17:49:45 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $openapiContext;

    This openapiContext attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Anto
  7. /**
  8. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  9. *
  10. * @var array
  • dunglas

    Ignored on Thu, 20 Dec 2018 13:48:41 GMT
  1. /**
  2. * @see https://github.com/Haehnchen/idea-php-annotation-plugin/issues/112
  3. *
  4. * @var array
  5. */
  6. private $paginationViaCursor;

    This paginationViaCursor attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by soyuka
  7. /**
  8. * @throws InvalidArgumentException
  9. */
  10. public function __construct(array $values = [])
  • dunglas

    Ignored on Tue, 26 Feb 2019 17:49:40 GMT