Methods and properties visibility should always be explicitly defined

More information: https://insight.symfony.com/what-we-analyse/php.method_or_property_missing_visibility

New rule! We've recently added this rule to Insight. Don't be surprised to see new suggestions even though the codebase didn't change.
  1. protected $errorTemplate;
  2. protected $attachmentMail;
  3. function __construct($adminMail, $broker, $doctrine, $logger, $mailer, $mailerTransport, $sender, $twig, $supervisorClient, $applicationName, $errorTemplate, $attachmentMail)

    This method has no explicit visibility which may lead to maintainability issues. You should always declare a visibility for methods and properties.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by hlecorche
  4. {
  5. $this->adminMail = $adminMail;
  6. $this->broker = $broker;
  7. $this->doctrine = $doctrine;
  8. $this->logger = $logger;