Global variable or function should never be used 3

More information: https://insight.symfony.com/what-we-analyse/php.use_global_variable_or_function

in helpers.php, line 4
  1. <?php
  2. if (! function_exists('on_route')) {
  3. function on_route($route)

    on_route() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.

    Time to fix: about 1 day
    Open Issue Permalink
    Last edited by Nicolas Widart
  4. {
  5. return Route::current() ? Route::is($route) : false;
  6. }
  7. }
  • nwidart

    Not needed
  • nwidart

    sad
  • nwidart

    asd
in helpers.php, line 11
  1. return Route::current() ? Route::is($route) : false;
  2. }
  3. }
  4. if (! function_exists('locale')) {
  5. function locale($locale = null)

    locale() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.

    Time to fix: about 1 day
    Open Issue Permalink
    Last edited by Nicolas Widart
  6. {
  7. if (is_null($locale)) {
  8. return app()->getLocale();
  9. }
  • nwidart

    sad
  • nwidart

    asd
in helpers.php, line 24
  1. return app()->getLocale();
  2. }
  3. }
  4. if (! function_exists('is_module_enabled')) {
  5. function is_module_enabled($module)

    is_module_enabled() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.

    Time to fix: about 1 day
    Open Issue Permalink
    Last edited by Nicolas Widart
  6. {
  7. return array_key_exists($module, app('modules')->enabled());
  8. }
  9. }
  • nwidart

    asd

Version of dependencies should be fixed

More information: https://insight.symfony.com/what-we-analyse/composer.unfixed_dependency_version

Package pingpong/modules#dev-feature/5.1 is not fixed.

Time to fix: about 1 hour
Open Issue Permalink
Collective
  • nwidart

    asd