Use interfaces instead of classes in typehints 6

More information: https://insight.symfony.com/what-we-analyse/symfony.dependency_injection.use_interface_type_hint

in src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php, line 102 
  1.      * trans_sid_hosts, $_SERVER['HTTP_HOST']
  2.      * trans_sid_tags, "a=href,area=href,frame=src,form="
  3.      *
  4.      * @param AbstractProxy|\SessionHandlerInterface|null $handler
  5.      */
  6.     public function __construct(array $options = [], $handler = null, MetadataBag $metaBag = null)
    You should use the interface Symfony\Component\HttpFoundation\Session\SessionStorageInterface instead of the class Symfony\Component\HttpFoundation\Session\Storage\MetadataBag as a typehint.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.     {
  8.         if (!\extension_loaded('session')) {
  9.             throw new \LogicException('PHP extension "session" is required.');
  10.         }
in src/Symfony/Component/HttpFoundation/Session/Storage/MockArraySessionStorage.php, line 65 
  1.     /**
  2.      * @var array|SessionBagInterface[]
  3.      */
  4.     protected $bags = [];
  6.     public function __construct(string $name = 'MOCKSESSID', MetadataBag $metaBag = null)
    You should use the interface Symfony\Component\HttpFoundation\Session\SessionStorageInterface instead of the class Symfony\Component\HttpFoundation\Session\Storage\MetadataBag as a typehint.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     {
  8.         $this->name = $name;
  9.         $this->setMetadataBag($metaBag);
  10.     }
in src/Symfony/Component/HttpFoundation/Session/Storage/MockFileSessionStorage.php, line 32 
  1.     private $savePath;
  3.     /**
  4.      * @param string $savePath Path of directory to save session files
  5.      */
  6.     public function __construct(string $savePath = null, string $name = 'MOCKSESSID', MetadataBag $metaBag = null)
    You should use the interface Symfony\Component\HttpFoundation\Session\SessionStorageInterface instead of the class Symfony\Component\HttpFoundation\Session\Storage\MetadataBag as a typehint.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     {
  8.         if (null === $savePath) {
  9.             $savePath = sys_get_temp_dir();
  10.         }
in src/Symfony/Component/HttpFoundation/Session/Storage/PhpBridgeSessionStorage.php, line 26 
  1. class PhpBridgeSessionStorage extends NativeSessionStorage
  2. {
  3.     /**
  4.      * @param AbstractProxy|\SessionHandlerInterface|null $handler
  5.      */
  6.     public function __construct($handler = null, MetadataBag $metaBag = null)
    You should use the interface Symfony\Component\HttpFoundation\Session\SessionStorageInterface instead of the class Symfony\Component\HttpFoundation\Session\Storage\MetadataBag as a typehint.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Drak
                    
  7.     {
  8.         if (!\extension_loaded('session')) {
  9.             throw new \LogicException('PHP extension "session" is required.');
  10.         }
in src/Symfony/Component/HttpKernel/DependencyInjection/AddAnnotatedClassesToCachePass.php, line 30 
  1.  */
  2. class AddAnnotatedClassesToCachePass implements CompilerPassInterface
  3. {
  4.     private $kernel;
  6.     public function __construct(Kernel $kernel)
    You should use the interface Symfony\Component\HttpKernel\KernelInterface instead of the class Symfony\Component\HttpKernel\Kernel as a typehint.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     {
  8.         $this->kernel = $kernel;
  9.     }
  11.     /**
in src/Symfony/Component/Validator/Constraints/BicValidator.php, line 53 
  1.         'VG' => 'GB', // British Virgin Islands
  2.     ];
  4.     private $propertyAccessor;
  6.     public function __construct(PropertyAccessor $propertyAccessor = null)
    You should use the interface Symfony\Component\PropertyAccess\PropertyAccessorInterface instead of the class Symfony\Component\PropertyAccess\PropertyAccessor as a typehint.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Sylvain Fabre
                    
  7.     {
  8.         $this->propertyAccessor = $propertyAccessor;
  9.     }
  11.     /**

Global variable or function should never be used 16

More information: https://insight.symfony.com/what-we-analyse/php.use_global_variable_or_function

in src/Symfony/Component/VarDumper/Resources/functions/dump.php, line 18 
  2. if (!function_exists('dump')) {
  3.     /**
  4.      * @author Nicolas Grekas <p@tchwork.com>
  5.      */
  6.     function dump($var, ...$moreVars)
    dump() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Robin Chalas
                    
  7.     {
  8.         VarDumper::dump($var);
  10.         foreach ($moreVars as $v) {
  11.             VarDumper::dump($v);
in src/Symfony/Component/VarDumper/Resources/functions/dump.php, line 35 
  1.         return $var;
  2.     }
  3. }
  5. if (!function_exists('dd')) {
  6.     function dd(...$vars)
    dd() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Sjors Ottjes
                    
  7.     {
  8.         foreach ($vars as $v) {
  9.             VarDumper::dump($v);
  10.         }
in .github/rm-invalid-lowest-lock-files.php, line 12 
  1.     }
  2. });
  3. array_shift($_SERVER['argv']);
  4. $dirs = $_SERVER['argv'];
  6. function getRelevantContent(array $composerJson)
    getRelevantContent() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7. {
  8.     $relevantKeys = array(
  9.         'name',
  10.         'require',
  11.         'require-dev',
in .github/rm-invalid-lowest-lock-files.php, line 39 
  1.     }
  3.     return $relevantContent;
  4. }
  6. function getContentHash(array $composerJson)
    getContentHash() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7. {
  8.     $relevantContent = getRelevantContent($composerJson);
  9.     ksort($relevantContent);
  11.     return md5(json_encode($relevantContent));
in src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php, line 187 
  1.     chdir('..');
  2.     file_put_contents(".$PHPUNIT_VERSION_DIR.md5", $configurationHash);
  3.     chdir($oldPwd);
  4. }
  6. global $argv, $argc;
    $argc adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Dmitry Simushev
                    
  7. $argv = isset($_SERVER['argv']) ? $_SERVER['argv'] : array();
  8. $argc = isset($_SERVER['argc']) ? $_SERVER['argc'] : 0;
  10. if ($PHPUNIT_VERSION < 8.0) {
  11.     $argv = array_filter($argv, function ($v) use (&$argc) { if ('--do-not-cache-result' !== $v) return true; --$argc; return false; });
in src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php, line 187 
  1.     chdir('..');
  2.     file_put_contents(".$PHPUNIT_VERSION_DIR.md5", $configurationHash);
  3.     chdir($oldPwd);
  4. }
  6. global $argv, $argc;
    $argv adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Dmitry Simushev
                    
  7. $argv = isset($_SERVER['argv']) ? $_SERVER['argv'] : array();
  8. $argc = isset($_SERVER['argc']) ? $_SERVER['argc'] : 0;
  10. if ($PHPUNIT_VERSION < 8.0) {
  11.     $argv = array_filter($argv, function ($v) use (&$argc) { if ('--do-not-cache-result' !== $v) return true; --$argc; return false; });
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 84 
  1.     printTranslationStatus($originalFilePath, $translationStatus, $config['verbose_output']);
  2. }
  4. exit($totalMissingTranslations > 0 ? 1 : 0);
  6. function findTranslationFiles($originalFilePath, $localeToAnalyze)
    findTranslationFiles() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     $translations = [];
  10.     $translationsDir = dirname($originalFilePath);
  11.     $originalFileName = basename($originalFilePath);
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 106 
  1.     }
  3.     return $translations;
  4. }
  6. function calculateTranslationStatus($originalFilePath, $translationFilePaths)
    calculateTranslationStatus() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     $translationStatus = [];
  9.     $allTranslationKeys = extractTranslationKeys($originalFilePath);
  11.     foreach ($translationFilePaths as $locale => $translationPath) {
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 125 
  1.     }
  3.     return $translationStatus;
  4. }
  6. function printTranslationStatus($originalFilePath, $translationStatus, $verboseOutput)
    printTranslationStatus() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     printTitle($originalFilePath);
  9.     printTable($translationStatus, $verboseOutput);
  10.     echo PHP_EOL.PHP_EOL;
  11. }
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 132 
  1.     printTitle($originalFilePath);
  2.     printTable($translationStatus, $verboseOutput);
  3.     echo PHP_EOL.PHP_EOL;
  4. }
  6. function extractLocaleFromFilePath($filePath)
    extractLocaleFromFilePath() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     $parts = explode('.', $filePath);
  10.     return $parts[count($parts) - 2];
  11. }
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 139 
  1.     $parts = explode('.', $filePath);
  3.     return $parts[count($parts) - 2];
  4. }
  6. function extractTranslationKeys($filePath)
    extractTranslationKeys() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     $translationKeys = [];
  9.     $contents = new \SimpleXMLElement(file_get_contents($filePath));
  11.     foreach ($contents->file->body->{'trans-unit'} as $translationKey) {
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 154 
  1.     }
  3.     return $translationKeys;
  4. }
  6. function printTitle($title)
    printTitle() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     echo $title.PHP_EOL;
  9.     echo str_repeat('=', strlen($title)).PHP_EOL.PHP_EOL;
  10. }
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 160 
  1. {
  2.     echo $title.PHP_EOL;
  3.     echo str_repeat('=', strlen($title)).PHP_EOL.PHP_EOL;
  4. }
  6. function printTable($translations, $verboseOutput)
    printTable() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     if (0 === count($translations)) {
  9.         echo 'No translations found';
  11.         return;
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 193 
  1.             echo str_repeat('-', 80).PHP_EOL;
  2.         }
  3.     }
  4. }
  6. function textColorGreen()
    textColorGreen() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     echo "\033[32m";
  9. }
  11. function textColorRed()
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 198 
  1. function textColorGreen()
  2. {
  3.     echo "\033[32m";
  4. }
  6. function textColorRed()
    textColorRed() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Roland Franssen
                    
  7. {
  8.     echo "\033[31m";
  9. }
  11. function textColorNormal()
in src/Symfony/Component/Translation/Resources/bin/translation-status.php, line 203 
  1. function textColorRed()
  2. {
  3.     echo "\033[31m";
  4. }
  6. function textColorNormal()
    textColorNormal() adds to the global scope. Prefer class properties or methods to let other developers know what this relates to.
    Time to fix: about 1 day
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7. {
  8.     echo "\033[0m";
  9. }

PHP configuration should not be changed dynamically 21

More information: https://insight.symfony.com/what-we-analyse/php.dynamically_change_configuration

in src/Symfony/Component/Cache/Adapter/ApcuAdapter.php, line 31 
  1.     {
  2.         if (!static::isSupported()) {
  3.             throw new CacheException('APCu is not enabled');
  4.         }
  5.         if ('cli' === \PHP_SAPI) {
  6.             ini_set('apc.use_request_time', 0);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  8.         parent::__construct($namespace, $defaultLifetime);
  10.         if (null !== $version) {
  11.             CacheItem::validateKey($version);
in src/Symfony/Component/Cache/Adapter/ApcuAdapter.php, line 55 
  1.     /**
  2.      * {@inheritdoc}
  3.      */
  4.     protected function doFetch(array $ids)
  5.     {
  6.         $unserializeCallbackHandler = ini_set('unserialize_callback_func', __CLASS__.'::handleUnserializeCallback');
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         try {
  8.             $values = [];
  9.             foreach (apcu_fetch($ids, $ok) ?: [] as $k => $v) {
  10.                 if (null !== $v || $ok) {
  11.                     $values[$k] = $v;
in src/Symfony/Component/Cache/Adapter/ApcuAdapter.php, line 68 
  2.             return $values;
  3.         } catch (\Error $e) {
  4.             throw new \ErrorException($e->getMessage(), $e->getCode(), E_ERROR, $e->getFile(), $e->getLine());
  5.         } finally {
  6.             ini_set('unserialize_callback_func', $unserializeCallbackHandler);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  8.     }
  10.     /**
  11.      * {@inheritdoc}
in src/Symfony/Component/Cache/Adapter/DoctrineAdapter.php, line 44 
  1.     /**
  2.      * {@inheritdoc}
  3.      */
  4.     protected function doFetch(array $ids)
  5.     {
  6.         $unserializeCallbackHandler = ini_set('unserialize_callback_func', parent::class.'::handleUnserializeCallback');
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         try {
  8.             return $this->provider->fetchMultiple($ids);
  9.         } catch (\Error $e) {
  10.             $trace = $e->getTrace();
in src/Symfony/Component/Cache/Adapter/DoctrineAdapter.php, line 61 
  1.                 }
  2.             }
  4.             throw $e;
  5.         } finally {
  6.             ini_set('unserialize_callback_func', $unserializeCallbackHandler);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  8.     }
  10.     /**
  11.      * {@inheritdoc}
in src/Symfony/Component/Cache/Marshaller/DefaultMarshaller.php, line 72 
  1.         }
  2.         static $igbinaryNull;
  3.         if ($value === ($igbinaryNull ?? $igbinaryNull = \extension_loaded('igbinary') && \PHP_VERSION_ID !== 70400 ? igbinary_serialize(null) : false)) {
  4.             return null;
  5.         }
  6.         $unserializeCallbackHandler = ini_set('unserialize_callback_func', __CLASS__.'::handleUnserializeCallback');
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         try {
  8.             if (':' === ($value[1] ?? ':')) {
  9.                 if (false !== $value = unserialize($value)) {
  10.                     return $value;
  11.                 }
in src/Symfony/Component/Cache/Marshaller/DefaultMarshaller.php, line 88 
  2.             throw new \DomainException(error_get_last() ? error_get_last()['message'] : 'Failed to unserialize values.');
  3.         } catch (\Error $e) {
  4.             throw new \ErrorException($e->getMessage(), $e->getCode(), E_ERROR, $e->getFile(), $e->getLine());
  5.         } finally {
  6.             ini_set('unserialize_callback_func', $unserializeCallbackHandler);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  8.     }
  10.     /**
  11.      * @internal
in src/Symfony/Component/Config/ResourceCheckerConfigCache.php, line 159 
  1.     {
  2.         $e = null;
  3.         $meta = false;
  4.         $content = file_get_contents($file);
  5.         $signalingException = new \UnexpectedValueException();
  6.         $prevUnserializeHandler = ini_set('unserialize_callback_func', self::class.'::handleUnserializeCallback');
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by renanbr
                    
  7.         $prevErrorHandler = set_error_handler(function ($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler, $signalingException) {
  8.             if (__FILE__ === $file) {
  9.                 throw $signalingException;
  10.             }
in src/Symfony/Component/Config/ResourceCheckerConfigCache.php, line 176 
  1.             if ($e !== $signalingException) {
  2.                 throw $e;
  3.             }
  4.         } finally {
  5.             restore_error_handler();
  6.             ini_set('unserialize_callback_func', $prevUnserializeHandler);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  9.         return $meta;
  10.     }
in src/Symfony/Component/ErrorHandler/Debug.php, line 43 
  1.         } else {
  2.             error_reporting(E_ALL);
  3.         }
  5.         if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg'], true)) {
  6.             ini_set('display_errors', 0);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.         } elseif ($displayErrors && (!filter_var(ini_get('log_errors'), FILTER_VALIDATE_BOOLEAN) || ini_get('error_log'))) {
  8.             // CLI - display errors only if they're not already logged to STDERR
  9.             ini_set('display_errors', 1);
  10.         }
  11.         if ($displayErrors) {
in src/Symfony/Component/ErrorHandler/Debug.php, line 46 
  2.         if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg'], true)) {
  3.             ini_set('display_errors', 0);
  4.         } elseif ($displayErrors && (!filter_var(ini_get('log_errors'), FILTER_VALIDATE_BOOLEAN) || ini_get('error_log'))) {
  5.             // CLI - display errors only if they're not already logged to STDERR
  6.             ini_set('display_errors', 1);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.         }
  8.         if ($displayErrors) {
  9.             ErrorHandler::register(new ErrorHandler(new BufferingLogger()));
  10.         } else {
  11.             ErrorHandler::register()->throwAt(0, true);
in src/Symfony/Component/HttpFoundation/Session/Storage/Handler/NativeFileSessionHandler.php, line 52 
  2.         if ($baseDir && !is_dir($baseDir) && !@mkdir($baseDir, 0777, true) && !is_dir($baseDir)) {
  3.             throw new \RuntimeException(sprintf('Session Storage was not able to create directory "%s"', $baseDir));
  4.         }
  6.         ini_set('session.save_path', $savePath);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Drak
                    
  7.         ini_set('session.save_handler', 'files');
  8.     }
  9. }
in src/Symfony/Component/HttpFoundation/Session/Storage/Handler/NativeFileSessionHandler.php, line 53 
  1.         if ($baseDir && !is_dir($baseDir) && !@mkdir($baseDir, 0777, true) && !is_dir($baseDir)) {
  2.             throw new \RuntimeException(sprintf('Session Storage was not able to create directory "%s"', $baseDir));
  3.         }
  5.         ini_set('session.save_path', $savePath);
  6.         ini_set('session.save_handler', 'files');
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Drak
                    
  7.     }
  8. }
in src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php, line 214 
  1.         if (headers_sent()) {
  2.             return false;
  3.         }
  5.         if (null !== $lifetime) {
  6.             ini_set('session.cookie_lifetime', $lifetime);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Drak
                    
  7.         }
  9.         if ($destroy) {
  10.             $this->metadataBag->stampNew();
  11.         }
in src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php, line 389 
  1.                     // PHP < 7.3 does not support same_site cookies. We will emulate it in
  2.                     // the start() method instead.
  3.                     $this->emulateSameSite = $value;
  4.                     continue;
  5.                 }
  6.                 ini_set('url_rewriter.tags' !== $key ? 'session.'.$key : $key, $value);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nikolay Labinskiy
                    
  7.             }
  8.         }
  9.     }
  11.     /**
in src/Symfony/Component/Messenger/Transport/Serialization/PhpSerializer.php, line 55 
  2.     private function safelyUnserialize(string $contents)
  3.     {
  4.         $e = null;
  5.         $signalingException = new MessageDecodingFailedException(sprintf('Could not decode message using PHP serialization: %s.', $contents));
  6.         $prevUnserializeHandler = ini_set('unserialize_callback_func', self::class.'::handleUnserializeCallback');
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Ryan Weaver
                    
  7.         $prevErrorHandler = set_error_handler(function ($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler, $signalingException) {
  8.             if (__FILE__ === $file) {
  9.                 throw $signalingException;
  10.             }
in src/Symfony/Component/Messenger/Transport/Serialization/PhpSerializer.php, line 68 
  2.         try {
  3.             $meta = unserialize($contents);
  4.         } finally {
  5.             restore_error_handler();
  6.             ini_set('unserialize_callback_func', $prevUnserializeHandler);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Ryan Weaver
                    
  7.         }
  9.         return $meta;
  10.     }
in src/Symfony/Component/Security/Http/Firewall/ContextListener.php, line 251 
  1.     }
  3.     private function safelyUnserialize(string $serializedToken)
  4.     {
  5.         $e = $token = null;
  6.         $prevUnserializeHandler = ini_set('unserialize_callback_func', __CLASS__.'::handleUnserializeCallback');
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Chris Wilkinson
                    
  7.         $prevErrorHandler = set_error_handler(function ($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler) {
  8.             if (__FILE__ === $file) {
  9.                 throw new \ErrorException($msg, 0x37313bc, $type, $file, $line);
  10.             }
in src/Symfony/Component/Security/Http/Firewall/ContextListener.php, line 265 
  1.         try {
  2.             $token = unserialize($serializedToken);
  3.         } catch (\Throwable $e) {
  4.         }
  5.         restore_error_handler();
  6.         ini_set('unserialize_callback_func', $prevUnserializeHandler);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Chris Wilkinson
                    
  7.         if ($e) {
  8.             if (!$e instanceof \ErrorException || 0x37313bc !== $e->getCode()) {
  9.                 throw $e;
  10.             }
  11.             if ($this->logger) {
in src/Symfony/Component/VarExporter/Internal/Registry.php, line 39 
  1.         }
  2.     }
  4.     public static function unserialize($objects, $serializables)
  5.     {
  6.         $unserializeCallback = ini_set('unserialize_callback_func', __CLASS__.'::getClassReflector');
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  8.         try {
  9.             foreach ($serializables as $k => $v) {
  10.                 $objects[$k] = unserialize($v);
  11.             }
in src/Symfony/Component/VarExporter/Internal/Registry.php, line 46 
  1.         try {
  2.             foreach ($serializables as $k => $v) {
  3.                 $objects[$k] = unserialize($v);
  4.             }
  5.         } finally {
  6.             ini_set('unserialize_callback_func', $unserializeCallback);
    Changing PHP configuration dynamically through ini_set() may create hard to debug errors.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  9.         return $objects;
  10.     }

Missing use statement should be avoided 10

More information: https://insight.symfony.com/what-we-analyse/php.missing_use_statement

in src/Symfony/Component/ErrorHandler/ErrorHandler.php, line 696 
  1.     {
  2.         $charset = ini_get('default_charset') ?: 'UTF-8';
  3.         $statusCode = 500;
  4.         $headers = [];
  6.         if (class_exists(HtmlErrorRenderer::class)) {
    The HtmlErrorRenderer class resolves to the following class: Symfony\Component\ErrorRenderer\ErrorRenderer\HtmlErrorRenderer.
    
Did you forget to add a corresponding use statement?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.             $exception = FlattenException::createFromThrowable($exception);
  8.             $statusCode = $exception->getStatusCode();
  9.             $headers = $exception->getHeaders();
  10.             $response = (new HtmlErrorRenderer(0 !== $this->scopedErrors))->render($exception);
  11.         } else {
in src/Symfony/Component/ErrorHandler/ErrorHandler.php, line 697 
  1.         $charset = ini_get('default_charset') ?: 'UTF-8';
  2.         $statusCode = 500;
  3.         $headers = [];
  5.         if (class_exists(HtmlErrorRenderer::class)) {
  6.             $exception = FlattenException::createFromThrowable($exception);
    The FlattenException class resolves to the following class: Symfony\Component\ErrorRenderer\Exception\FlattenException.
    
Did you forget to add a corresponding use statement?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.             $statusCode = $exception->getStatusCode();
  8.             $headers = $exception->getHeaders();
  9.             $response = (new HtmlErrorRenderer(0 !== $this->scopedErrors))->render($exception);
  10.         } else {
  11.             $message = htmlspecialchars($exception->getMessage(), ENT_COMPAT | ENT_SUBSTITUTE, $charset);
in src/Symfony/Component/ErrorHandler/ErrorHandler.php, line 700 
  2.         if (class_exists(HtmlErrorRenderer::class)) {
  3.             $exception = FlattenException::createFromThrowable($exception);
  4.             $statusCode = $exception->getStatusCode();
  5.             $headers = $exception->getHeaders();
  6.             $response = (new HtmlErrorRenderer(0 !== $this->scopedErrors))->render($exception);
    The HtmlErrorRenderer class resolves to the following class: Symfony\Component\ErrorRenderer\ErrorRenderer\HtmlErrorRenderer.
    
Did you forget to add a corresponding use statement?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.         } else {
  8.             $message = htmlspecialchars($exception->getMessage(), ENT_COMPAT | ENT_SUBSTITUTE, $charset);
  9.             $response = sprintf('<!DOCTYPE html><html><head><meta charset="%s" /><meta name="robots" content="noindex,nofollow" /></head><body>%s</body></html>', $charset, $message);
  10.         }
in src/Symfony/Component/Mime/Test/Constraint/EmailAttachmentCount.php, line 43 
  1.      *
  2.      * {@inheritdoc}
  3.      */
  4.     protected function matches($message): bool
  5.     {
  6.         if (RawMessage::class === \get_class($message) || Message::class === \get_class($message)) {
    The Message class resolves to the following class: Symfony\Component\Mime\Message.
    
Did you forget to add a corresponding use statement?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             throw new \LogicException('Unable to test a message attachment on a RawMessage or Message instance.');
  8.         }
  10.         return $this->expectedValue === \count($message->getAttachments());
  11.     }
in src/Symfony/Component/Mime/Test/Constraint/EmailHtmlBodyContains.php, line 40 
  1.      *
  2.      * @param RawMessage $message
  3.      */
  4.     protected function matches($message): bool
  5.     {
  6.         if (RawMessage::class === \get_class($message) || Message::class === \get_class($message)) {
    The Message class resolves to the following class: Symfony\Component\Mime\Message.
    
Did you forget to add a corresponding use statement?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             throw new \LogicException('Unable to test a message HTML body on a RawMessage or Message instance.');
  8.         }
  10.         return false !== mb_strpos($message->getHtmlBody(), $this->expectedText);
  11.     }
in src/Symfony/Component/Mime/Test/Constraint/EmailHtmlBodyContains.php, line 40 
  1.      *
  2.      * @param RawMessage $message
  3.      */
  4.     protected function matches($message): bool
  5.     {
  6.         if (RawMessage::class === \get_class($message) || Message::class === \get_class($message)) {
    The RawMessage class resolves to the following class: Symfony\Component\Mime\RawMessage.
    
Did you forget to add a corresponding use statement?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             throw new \LogicException('Unable to test a message HTML body on a RawMessage or Message instance.');
  8.         }
  10.         return false !== mb_strpos($message->getHtmlBody(), $this->expectedText);
  11.     }
in src/Symfony/Component/Mime/Test/Constraint/EmailTextBodyContains.php, line 40 
  1.      *
  2.      * @param RawMessage $message
  3.      */
  4.     protected function matches($message): bool
  5.     {
  6.         if (RawMessage::class === \get_class($message) || Message::class === \get_class($message)) {
    The Message class resolves to the following class: Symfony\Component\Mime\Message.
    
Did you forget to add a corresponding use statement?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             throw new \LogicException('Unable to test a message text body on a RawMessage or Message instance.');
  8.         }
  10.         return false !== mb_strpos($message->getTextBody(), $this->expectedText);
  11.     }
in src/Symfony/Component/Mime/Test/Constraint/EmailTextBodyContains.php, line 40 
  1.      *
  2.      * @param RawMessage $message
  3.      */
  4.     protected function matches($message): bool
  5.     {
  6.         if (RawMessage::class === \get_class($message) || Message::class === \get_class($message)) {
    The RawMessage class resolves to the following class: Symfony\Component\Mime\RawMessage.
    
Did you forget to add a corresponding use statement?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             throw new \LogicException('Unable to test a message text body on a RawMessage or Message instance.');
  8.         }
  10.         return false !== mb_strpos($message->getTextBody(), $this->expectedText);
  11.     }
in src/Symfony/Component/Security/Core/Authorization/TraceableAccessDecisionManager.php, line 108 
  1.     {
  2.         return $this->decisionLog;
  3.     }
  4. }
  6. class_alias(TraceableAccessDecisionManager::class, DebugAccessDecisionManager::class);
    The DebugAccessDecisionManager class resolves to the Symfony\Component\Security\Core\Authorization\DebugAccessDecisionManager class which PHP does not seem to be able to autoload.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Alessandro Lai
in src/Symfony/Component/Translation/Command/XliffLintCommand.php, line 162 
  1.             case 'txt':
  2.                 return $this->displayTxt($io, $files);
  3.             case 'json':
  4.                 return $this->displayJson($io, $files);
  5.             default:
  6.                 throw new InvalidArgumentException(sprintf('The format "%s" is not supported.', $this->format));
    The InvalidArgumentException class resolves to the following classes: Doctrine\Common\Proxy\Exception\InvalidArgumentException or Doctrine\DBAL\Exception\InvalidArgumentException or Doctrine\Instantiator\Exception\InvalidArgumentException or Psr\SimpleCache\InvalidArgumentException or Symfony\Component\Asset\Exception\InvalidArgumentException or Symfony\Component\Cache\Exception\InvalidArgumentException or Symfony\Component\Console\Exception\InvalidArgumentException or Symfony\Component\DependencyInjection\Exception\InvalidArgumentException or Symfony\Component\Filesystem\Exception\InvalidArgumentException or Symfony\Component\Form\Exception\InvalidArgumentException or Symfony\Component\HttpClient\Exception\InvalidArgumentException or Symfony\Component\Intl\Exception\InvalidArgumentException or Symfony\Component\Lock\Exception\InvalidArgumentException or Symfony\Component\Mailer\Exception\InvalidArgumentException or Symfony\Component\Messenger\Exception\InvalidArgumentException or Symfony\Component\Mime\Exception\InvalidArgumentException or Symfony\Component\Notifier\Exception\InvalidArgumentException or Symfony\Component\OptionsResolver\Exception\InvalidArgumentException or Symfony\Component\Process\Exception\InvalidArgumentException or Symfony\Component\PropertyAccess\Exception\InvalidArgumentException or Symfony\Component\Security\Core\Exception\InvalidArgumentException or Symfony\Component\Serializer\Exception\InvalidArgumentException or Symfony\Component\String\Exception\InvalidArgumentException or Symfony\Component\Translation\Exception\InvalidArgumentException or Symfony\Component\Validator\Exception\InvalidArgumentException or Symfony\Component\Workflow\Exception\InvalidArgumentException or Zend\Code\Exception\InvalidArgumentException or Zend\Code\Generator\Exception\InvalidArgumentException or Zend\Code\Reflection\Exception\InvalidArgumentException or Zend\EventManager\Exception\InvalidArgumentException or Psr\Cache\InvalidArgumentException or Psr\Log\InvalidArgumentException.
    
Did you forget to add a corresponding use statement for one of them?
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.         }
  8.     }
  10.     private function displayTxt(SymfonyStyle $io, array $filesInfo)
  11.     {

exit() and die() functions should be avoided 11

More information: https://insight.symfony.com/what-we-analyse/php.use_exit_function

in src/Symfony/Component/ErrorHandler/ErrorHandler.php, line 680 
  1.             // Ignore this re-throw
  2.         }
  4.         if ($exit && self::$exitCode) {
  5.             $exitCode = self::$exitCode;
  6.             register_shutdown_function('register_shutdown_function', function () use ($exitCode) { exit($exitCode); });
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.         }
  8.     }
  10.     /**
  11.      * Sends the error associated with the given Exception as a plain PHP response.
in .github/build-packages.php, line 5 
  1. <?php
  3. if (3 > $_SERVER['argc']) {
  4.     echo "Usage: branch dir1 dir2 ... dirN\n";
  5.     exit(1);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  6. }
  7. chdir(dirname(__DIR__));
  9. $json = ltrim(file_get_contents('composer.json'));
  10. if ($json !== $package = preg_replace('/\n    "repositories": \[\n.*?\n    \],/s', '', $json)) {
in .github/build-packages.php, line 25 
  1. $preferredInstall = json_decode(file_get_contents(__DIR__.'/composer-config.json'), true)['config']['preferred-install'];
  3. foreach ($dirs as $k => $dir) {
  4.     if (!system("git diff --name-only $mergeBase -- $dir", $exitStatus)) {
  5.         if ($exitStatus) {
  6.             exit($exitStatus);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  8.         unset($dirs[$k]);
  9.         continue;
  10.     }
  11.     echo "$dir\n";
in .github/build-packages.php, line 35 
  1.     echo "$dir\n";
  3.     $json = ltrim(file_get_contents($dir.'/composer.json'));
  4.     if (null === $package = json_decode($json)) {
  5.         passthru("composer validate $dir/composer.json");
  6.         exit(1);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     }
  9.     $package->repositories = array(array(
  10.         'type' => 'composer',
  11.         'url' => 'file://'.str_replace(DIRECTORY_SEPARATOR, '/', dirname(__DIR__)).'/',
in .github/build-packages.php, line 55 
  1.         passthru("cd $dir && git init && git add . && git commit -q -m - && git archive -o package.tar HEAD && rm .git/ -Rf");
  2.     }
  4.     if (!isset($package->extra->{'branch-alias'}->{'dev-master'})) {
  5.         echo "Missing \"dev-master\" branch-alias in composer.json extra.\n";
  6.         exit(1);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     }
  8.     $package->version = str_replace('-dev', '.x-dev', $package->extra->{'branch-alias'}->{'dev-master'});
  9.     $package->dist['type'] = 'tar';
  10.     $package->dist['url'] = 'file://'.str_replace(DIRECTORY_SEPARATOR, '/', dirname(__DIR__))."/$dir/package.tar";
in .github/build-packages.php, line 81 
  2. if ($dirs) {
  3.     $json = ltrim(file_get_contents('composer.json'));
  4.     if (null === $package = json_decode($json)) {
  5.         passthru("composer validate $dir/composer.json");
  6.         exit(1);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     }
  9.     $package->repositories = array(array(
  10.         'type' => 'composer',
  11.         'url' => 'file://'.str_replace(DIRECTORY_SEPARATOR, '/', dirname(__DIR__)).'/',
in .github/patch-types.php, line 5 
  1. <?php
  3. if (false === getenv('SYMFONY_PATCH_TYPE_DECLARATIONS')) {
  4.     echo "Please define the SYMFONY_PATCH_TYPE_DECLARATIONS env var when running this script.\n";
  5.     exit(1);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  6. }
  8. require __DIR__.'/../.phpunit/phpunit-8.3-0/vendor/autoload.php';
  10. $loader = require __DIR__.'/../vendor/autoload.php';
in src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php, line 148 
  1.             }
  3.             if ($this->getConfiguration()->shouldDisplayStackTrace($msg)) {
  4.                 echo "\n".ucfirst($group).' '.$deprecation->toString();
  6.                 exit(1);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Grégoire Paris
                    
  7.             }
  8.             if ('legacy' !== $group) {
  9.                 $ref = &$this->deprecations[$group][$msg]['count'];
  10.                 ++$ref;
  11.                 $ref = &$this->deprecations[$group][$msg][$class.'::'.$method];
in src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php, line 210 
  1.             }
  3.             $this->displayDeprecations($groups, $configuration);
  5.             if ($isFailing || !$configuration->tolerates($this->deprecations)) {
  6.                 exit(1);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             }
  8.         });
  9.     }
  11.     private function getConfiguration()
in src/Symfony/Component/Console/Application.php, line 183 
  1.         if ($this->autoExit) {
  2.             if ($exitCode > 255) {
  3.                 $exitCode = 255;
  4.             }
  6.             exit($exitCode);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.         }
  9.         return $exitCode;
  10.     }
in src/Symfony/Component/VarDumper/Resources/functions/dump.php, line 41 
  1.     {
  2.         foreach ($vars as $v) {
  3.             VarDumper::dump($v);
  4.         }
  6.         die(1);
    This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Sjors Ottjes
                    
  7.     }
  8. }

Source code should not contain tasks comments 13

More information: https://insight.symfony.com/what-we-analyse/task_fixme_comment

in src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php, line 86 
  1.                 continue;
  2.             }
  4.             if (1 === substr_count($controller, ':')) {
  5.                 $nonDeprecatedNotation = str_replace(':', '::', $controller);
  6.                 // TODO deprecate this in 5.1
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Bourigault
                    
  7.             }
  9.             $route->setDefault('_controller', $controller);
  10.         }
in src/Symfony/Component/CssSelector/XPath/Extension/FunctionExtension.php, line 97 
  1.             $conditions[] = sprintf('(%s) mod %d = 0', $expr, $a);
  2.         }
  4.         return $xpath->addCondition(implode(' and ', $conditions));
  6.         // todo: handle an+b, odd, even
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Jean-François Simon
                    
  7.         // an+b means every-a, plus b, e.g., 2n+1 means odd
  8.         // 0n+b means b
  9.         // n+0 means a=1, i.e., all elements
  10.         // an means every a elements, i.e., 2n means even
  11.         // -n means -1n
in src/Symfony/Component/CssSelector/XPath/Extension/HtmlExtension.php, line 103 
  1.                 ." or name(.) = 'select'"
  2.                 ." or name(.) = 'textarea'"
  3.             .')'
  4.             .' and ancestor::fieldset[@disabled]'
  5.         );
  6.         // todo: in the second half, add "and is not a descendant of that fieldset element's first legend element child, if any."
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Jean-François Simon
                    
  7.     }
  9.     public function translateEnabled(XPathExpr $xpath): XPathExpr
  10.     {
  11.         return $xpath->addCondition(
in src/Symfony/Component/HttpFoundation/ServerBag.php, line 77 
  1.                     // In some circumstances PHP_AUTH_DIGEST needs to be set
  2.                     $headers['PHP_AUTH_DIGEST'] = $authorizationHeader;
  3.                     $this->parameters['PHP_AUTH_DIGEST'] = $authorizationHeader;
  4.                 } elseif (0 === stripos($authorizationHeader, 'bearer ')) {
  5.                     /*
  6.                      * XXX: Since there is no PHP_AUTH_BEARER in PHP predefined variables,
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Lance Chen
                    
  7.                      *      I'll just set $headers['AUTHORIZATION'] here.
  8.                      *      https://php.net/reserved.variables.server
  9.                      */
  10.                     $headers['AUTHORIZATION'] = $authorizationHeader;
  11.                 }
in src/Symfony/Component/HttpFoundation/Session/Storage/Handler/PdoSessionHandler.php, line 446 
  1.     }
  3.     /**
  4.      * Builds a PDO DSN from a URL-like connection string.
  5.      *
  6.      * @todo implement missing support for oci DSN (which look totally different from other PDO ones)
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Christophe Coevoet
                    
  7.      */
  8.     private function buildDsnFromUrl(string $dsnOrUrl): string
  9.     {
  10.         // (pdo_)?sqlite3?:///... => (pdo_)?sqlite3?://localhost/... or else the URL will be invalid
  11.         $url = preg_replace('#^((?:pdo_)?sqlite3?):///#', '$1://localhost/', $dsnOrUrl);
in src/Symfony/Component/HttpFoundation/Session/Storage/Handler/PdoSessionHandler.php, line 681 
  1.      *
  2.      * @return \PDOStatement The statement that needs to be executed later to release the lock
  3.      *
  4.      * @throws \DomainException When an unsupported PDO driver is used
  5.      *
  6.      * @todo implement missing advisory locks
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Tobias Schultze
                    
  7.      *       - for oci using DBMS_LOCK.REQUEST
  8.      *       - for sqlsrv using sp_getapplock with LockOwner = Session
  9.      */
  10.     private function doAdvisoryLock(string $sessionId): \PDOStatement
  11.     {
in src/Symfony/Component/HttpKernel/Controller/ContainerControllerResolver.php, line 39 
  2.     protected function createController(string $controller)
  3.     {
  4.         if (1 === substr_count($controller, ':')) {
  5.             $controller = str_replace(':', '::', $controller);
  6.             // TODO deprecate this in 5.1
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Christophe Coevoet
                    
  7.         }
  9.         return parent::createController($controller);
  10.     }
in src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php, line 195 
  1.     /**
  2.      * {@inheritdoc}
  3.      */
  4.     public function handle(Request $request, int $type = HttpKernelInterface::MASTER_REQUEST, bool $catch = true)
  5.     {
  6.         // FIXME: catch exceptions and implement a 500 error page here? -> in Varnish, there is a built-in error page mechanism
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by pborreli
                    
  7.         if (HttpKernelInterface::MASTER_REQUEST === $type) {
  8.             $this->traces = [];
  9.             // Keep a clone of the original request for surrogates so they can access it.
  10.             // We must clone here to get a separate instance because the application will modify the request during
  11.             // the application flow (we know it always does because we do ourselves by setting REMOTE_ADDR to 127.0.0.1
in src/Symfony/Component/HttpKernel/HttpCache/Store.php, line 157 
  1.         $headers = $match[1];
  2.         if (file_exists($body = $this->getPath($headers['x-content-digest'][0]))) {
  3.             return $this->restoreResponse($headers, $body);
  4.         }
  6.         // TODO the metaStore referenced an entity that doesn't exist in
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Pascal Borreli
                    
  7.         // the entityStore. We definitely want to return nil but we should
  8.         // also purge the entry from the meta-store when this is detected.
  9.         return null;
  10.     }
in src/Symfony/Component/Mime/Header/ParameterizedHeader.php, line 118 
  1.         $maxValueLength = $this->getMaxLineLength() - \strlen($name.'=*N"";') - 1;
  2.         $firstLineOffset = 0;
  4.         // If it's not already a valid parameter value...
  5.         if (!preg_match('/^'.self::TOKEN_REGEX.'$/D', $value)) {
  6.             // TODO: text, or something else??
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             // ... and it's not ascii
  8.             if (!preg_match('/^[\x00-\x08\x0B\x0C\x0E-\x7F]*$/D', $value)) {
  9.                 $encoded = true;
  10.                 // Allow space for the indices, charset and language
  11.                 $maxValueLength = $this->getMaxLineLength() - \strlen($name.'*N*="";') - 1;
in src/Symfony/Component/Mime/Part/DataPart.php, line 49 
  1.         $this->setDisposition('attachment');
  2.     }
  4.     public static function fromPath(string $path, string $name = null, string $contentType = null): self
  5.     {
  6.         // FIXME: if file is not readable, exception?
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  8.         if (null === $contentType) {
  9.             $ext = strtolower(substr($path, strrpos($path, '.') + 1));
  10.             if (null === self::$mimeTypes) {
  11.                 self::$mimeTypes = new MimeTypes();
in src/Symfony/Component/Serializer/Encoder/XmlEncoder.php, line 143 
  1.             if (!$rootNode && !\in_array($child->nodeType, $decoderIgnoredNodeTypes, true)) {
  2.                 $rootNode = $child;
  3.             }
  4.         }
  6.         // todo: throw an exception if the root node name is not correctly configured (bc)
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Charles Sarrazin
                    
  8.         if ($rootNode->hasChildNodes()) {
  9.             $xpath = new \DOMXPath($dom);
  10.             $data = [];
  11.             foreach ($xpath->query('namespace::*', $dom->documentElement) as $nsNode) {
in src/Symfony/Component/Translation/Loader/PoFileLoader.php, line 90 
  1.                 $flags = [];
  2.             } elseif ('#,' === substr($line, 0, 2)) {
  3.                 $flags = array_map('trim', explode(',', substr($line, 2)));
  4.             } elseif ('msgid "' === substr($line, 0, 7)) {
  5.                 // We start a new msg so save previous
  6.                 // TODO: this fails when comments or contexts are added
    Tasks comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.
    Time to fix: about 2 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Clemens Tolboom
                    
  7.                 $this->addMessage($messages, $item);
  8.                 $item = $defaults;
  9.                 $item['ids']['singular'] = substr($line, 7, -1);
  10.             } elseif ('msgstr "' === substr($line, 0, 8)) {
  11.                 $item['translated'] = substr($line, 8, -1);

sleep() should not be used 3

More information: https://insight.symfony.com/what-we-analyse/php.use_php_sleep_function

in src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php, line 299 
  2.         $this->stop();
  3.         if (0 < $sleep = $this->restartThresholdSleep) {
  4.             $this->getLogger()->debug(sprintf('Email transport "%s" sleeps for %d seconds after stopping', __CLASS__, $sleep));
  6.             sleep($sleep);
    sleep() may create timeouts without even protecting your application.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.         }
  8.         $this->start();
  9.         $this->restartCounter = 0;
  10.     }
in src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php, line 613 
  1.     {
  2.         $client = $this->getHttpClient(__FUNCTION__);
  3.         $response = $client->request('GET', 'http://localhost:8057/timeout-header', [
  4.             'timeout' => 0.9,
  5.         ]);
  6.         sleep(1);
    sleep() may create timeouts without even protecting your application.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         $this->assertSame(200, $response->getStatusCode());
  8.     }
  10.     public function testTimeoutOnAccess()
  11.     {
in src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php, line 47 
  1.             }
  2.         };
  4.         self::$server->process = $process;
  6.         sleep('\\' === \DIRECTORY_SEPARATOR ? 10 : 1);
    sleep() may create timeouts without even protecting your application.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     }
  8. }

Files should not be executable

More information: https://insight.symfony.com/what-we-analyse/php.too_permissive_file_permissions

Your project contains files with permissive permissions. In order to avoid opening a security breach, you should restrict execution rights on following files:

  • src/Symfony/Component/HttpClient/DependencyInjection/HttpClientPass.php

Time to fix: about 15 minutes
Open Issue Permalink
Collective 
chmod a-x 'src/Symfony/Component/HttpClient/DependencyInjection/HttpClientPass.php'

Code should not be duplicated 13

More information: https://insight.symfony.com/what-we-analyse/php.duplicated_code

in src/Symfony/Bridge/Twig/Extension/CodeExtension.php, line 120 
  1.     }
  3.     /**
  4.      * Returns an excerpt of a code file around the given line number.
  5.      */
  6.     public function fileExcerpt(string $file, int $line, int $srcContext = 3): ?string
    The next 21 lines appear both in src/Symfony/Bridge/Twig/Extension/CodeExtension.php:120 and src/Symfony/Component/ErrorRenderer/ErrorRenderer/HtmlErrorRenderer.php:238.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Alexander M. Turek
                    
  7.     {
  8.         if (is_file($file) && is_readable($file)) {
  9.             // highlight_file could throw warnings
  10.             // see https://bugs.php.net/25725
  11.             $code = @highlight_file($file, true);
in src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php, line 1232 
  1.                             ->info('The maximum number of connections to a single host.')
  2.                         ->end()
  3.                         ->arrayNode('default_options')
  4.                             ->fixXmlConfig('header')
  5.                             ->children()
  6.                                 ->arrayNode('headers')
    The next 81 lines appear both in src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php:1232 and src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php:1371.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                                     ->info('Associative array: header => value(s).')
  8.                                     ->useAttributeAsKey('name')
  9.                                     ->normalizeKeys(false)
  10.                                     ->variablePrototype()->end()
  11.                                 ->end()
in src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/FormLoginLdapFactory.php, line 28 
  1.  * @author Grégoire Pineau <lyrixx@lyrixx.info>
  2.  * @author Charles Sarrazin <charles@sarraz.in>
  3.  */
  4. class FormLoginLdapFactory extends FormLoginFactory
  5. {
  6.     protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)
    The next 36 lines appear both in src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/FormLoginLdapFactory.php:28 and src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/JsonLoginLdapFactory.php:30.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Christian Flothmann
                    
  7.     {
  8.         $provider = 'security.authentication.provider.ldap_bind.'.$id;
  9.         $definition = $container
  10.             ->setDefinition($provider, new ChildDefinition('security.authentication.provider.ldap_bind'))
  11.             ->replaceArgument(0, new Reference($userProviderId))
in src/Symfony/Component/BrowserKit/Test/Constraint/BrowserHasCookie.php, line 17 
  1. namespace Symfony\Component\BrowserKit\Test\Constraint;
  3. use PHPUnit\Framework\Constraint\Constraint;
  4. use Symfony\Component\BrowserKit\AbstractBrowser;
  6. final class BrowserHasCookie extends Constraint
    The next 35 lines appear both in src/Symfony/Component/BrowserKit/Test/Constraint/BrowserHasCookie.php:17 and src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseHasCookie.php:18.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7. {
  8.     private $name;
  9.     private $path;
  10.     private $domain;
in src/Symfony/Component/Cache/Adapter/AbstractAdapter.php, line 155 
  1.             $this->doDelete($expiredIds);
  2.         }
  3.         foreach ($byLifetime as $lifetime => $values) {
  4.             try {
  5.                 $e = $this->doSave($values, $lifetime);
  6.             } catch (\Exception $e) {
    The next 25 lines appear both in src/Symfony/Component/Cache/Adapter/AbstractAdapter.php:155 and src/Symfony/Component/Cache/Adapter/AbstractTagAwareAdapter.php:188.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             }
  8.             if (true === $e || [] === $e) {
  9.                 continue;
  10.             }
  11.             if (\is_array($e) || 1 === \count($values)) {
in src/Symfony/Component/Cache/Adapter/PdoAdapter.php, line 87 
  1.             $this->dsn = $connOrDsn;
  2.         } else {
  3.             throw new InvalidArgumentException(sprintf('"%s" requires PDO or Doctrine\DBAL\Connection instance or DSN string as first argument, "%s" given.', __CLASS__, \is_object($connOrDsn) ? \get_class($connOrDsn) : \gettype($connOrDsn)));
  4.         }
  6.         $this->table = isset($options['db_table']) ? $options['db_table'] : $this->table;
    The next 9 lines appear both in src/Symfony/Component/Cache/Adapter/PdoAdapter.php:87 and src/Symfony/Component/HttpFoundation/Session/Storage/Handler/PdoSessionHandler.php:188.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         $this->idCol = isset($options['db_id_col']) ? $options['db_id_col'] : $this->idCol;
  8.         $this->dataCol = isset($options['db_data_col']) ? $options['db_data_col'] : $this->dataCol;
  9.         $this->lifetimeCol = isset($options['db_lifetime_col']) ? $options['db_lifetime_col'] : $this->lifetimeCol;
  10.         $this->timeCol = isset($options['db_time_col']) ? $options['db_time_col'] : $this->timeCol;
  11.         $this->username = isset($options['db_username']) ? $options['db_username'] : $this->username;
in src/Symfony/Component/ErrorRenderer/ErrorRenderer/TxtErrorRenderer.php, line 68 
  2.     private function formatPath(string $path, int $line): string
  3.     {
  4.         $file = preg_match('#[^/\\\\]*+$#', $path, $file) ? $file[0] : $path;
  6.         return sprintf('in %s %s', $path, 0 < $line ? ' line '.$line : '');
    The next 22 lines appear both in src/Symfony/Component/ErrorRenderer/ErrorRenderer/TxtErrorRenderer.php:68 and src/Symfony/Component/ErrorRenderer/ErrorRenderer/XmlErrorRenderer.php:92.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.     }
  9.     /**
  10.      * Formats an array as a string.
  11.      */
in src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php, line 176 
  1.                 ->add('date', __NAMESPACE__.'\DateType', $dateOptions)
  2.                 ->add('time', __NAMESPACE__.'\TimeType', $timeOptions)
  3.             ;
  4.         }
  6.         if ('datetime_immutable' === $options['input']) {
    The next 23 lines appear both in src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php:176 and src/Symfony/Component/Form/Extension/Core/Type/TimeType.php:180.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Valentin
                    
  7.             $builder->addModelTransformer(new DateTimeImmutableToDateTimeTransformer());
  8.         } elseif ('string' === $options['input']) {
  9.             $builder->addModelTransformer(new ReversedTransformer(
  10.                 new DateTimeToStringTransformer($options['model_timezone'], $options['model_timezone'], $options['input_format'])
  11.             ));
in src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/NotTaggedControllerValueResolver.php, line 25 
  1. /**
  2.  * Provides an intuitive error message when controller fails because it is not registered as a service.
  3.  *
  4.  * @author Simeon Kolev <simeon.kolev9@gmail.com>
  5.  */
  6. final class NotTaggedControllerValueResolver implements ArgumentValueResolverInterface
    The next 31 lines appear both in src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/NotTaggedControllerValueResolver.php:25 and src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/ServiceValueResolver.php:25.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Simeon Kolev
                    
  7. {
  8.     private $container;
  10.     public function __construct(ContainerInterface $container)
  11.     {
in src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunApiTransport.php, line 58 
  1.         $headers = [];
  2.         foreach ($body->getPreparedHeaders()->all() as $header) {
  3.             $headers[] = $header->toString();
  4.         }
  6.         $endpoint = sprintf('%s/v3/%s/messages', $this->getEndpoint(), urlencode($this->domain));
    The next 14 lines appear both in src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunApiTransport.php:58 and src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunHttpTransport.php:60.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.         $response = $this->client->request('POST', 'https://'.$endpoint, [
  8.             'auth_basic' => 'api:'.$this->key,
  9.             'headers' => $headers,
  10.             'body' => $body->bodyToIterable(),
  11.         ]);
in src/Symfony/Component/Mailer/Transport/Dsn.php, line 14 
  1.  * file that was distributed with this source code.
  2.  */
  4. namespace Symfony\Component\Mailer\Transport;
  6. use Symfony\Component\Mailer\Exception\InvalidArgumentException;
    The next 30 lines appear both in src/Symfony/Component/Mailer/Transport/Dsn.php:14 and src/Symfony/Component/Notifier/Transport/Dsn.php:14.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Konstantin Myakshin
                    
  8. /**
  9.  * @author Konstantin Myakshin <molodchick@gmail.com>
  10.  */
  11. final class Dsn
in src/Symfony/Component/Mailer/Transport/Dsn.php, line 49 
  1.         if (!isset($parsedDsn['scheme'])) {
  2.             throw new InvalidArgumentException(sprintf('The "%s" mailer DSN must contain a scheme.', $dsn));
  3.         }
  5.         if (!isset($parsedDsn['host'])) {
  6.             throw new InvalidArgumentException(sprintf('The "%s" mailer DSN must contain a host (use "default" by default).', $dsn));
    The next 39 lines appear both in src/Symfony/Component/Mailer/Transport/Dsn.php:49 and src/Symfony/Component/Notifier/Transport/Dsn.php:51.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.         }
  9.         $user = isset($parsedDsn['user']) ? urldecode($parsedDsn['user']) : null;
  10.         $password = isset($parsedDsn['pass']) ? urldecode($parsedDsn['pass']) : null;
  11.         $port = $parsedDsn['port'] ?? null;
in src/Symfony/Component/Messenger/Transport/AmqpExt/AmqpTransport.php, line 26 
  1. /**
  2.  * @author Nicolas Grekas <p@tchwork.com>
  3.  */
  4. class AmqpTransport implements TransportInterface, SetupableTransportInterface, MessageCountAwareInterface
  5. {
  6.     private $serializer;
    The next 49 lines appear both in src/Symfony/Component/Messenger/Transport/AmqpExt/AmqpTransport.php:26 and src/Symfony/Component/Messenger/Transport/RedisExt/RedisTransport.php:26.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Samuel ROZE
                    
  7.     private $connection;
  8.     private $receiver;
  9.     private $sender;
  11.     public function __construct(Connection $connection, SerializerInterface $serializer = null)

Error silenced by the at sign (@) 68

More information: https://insight.symfony.com/what-we-analyse/php.silenced_error

in src/Symfony/Component/Config/ResourceCheckerConfigCache.php, line 141 
  1.                 // discard chmod failure (some filesystem may not support it)
  2.             }
  3.         }
  5.         if (\function_exists('opcache_invalidate') && filter_var(ini_get('opcache.enable'), FILTER_VALIDATE_BOOLEAN)) {
  6.             @opcache_invalidate($this->file, true);
    Adding "@" before opcache_invalidate($this->file, true) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.         }
  8.     }
  10.     /**
  11.      * Gets the meta file path.
in src/Symfony/Component/VarExporter/Internal/Registry.php, line 92 
  1.                 $instantiableWithoutConstructor = true;
  2.             } catch (\ReflectionException $e) {
  3.                 $proto = $reflector->implementsInterface('Serializable') && !method_exists($class, '__unserialize') ? 'C:' : 'O:';
  4.                 if ('C:' === $proto && !$reflector->getMethod('unserialize')->isInternal()) {
  5.                     $proto = null;
  6.                 } elseif (false === $proto = @unserialize($proto.\strlen($class).':"'.$class.'":0:{}')) {
    Adding "@" before unserialize($proto . \strlen($class) . ':"' . $class . '":0:{}') prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                     throw new NotInstantiableTypeException($class);
  8.                 }
  9.             }
  10.             if (null !== $proto && !$proto instanceof \Throwable && !$proto instanceof \Serializable && !method_exists($class, '__sleep') && (\PHP_VERSION_ID < 70400 || !method_exists($class, '__serialize'))) {
  11.                 try {
in .github/build-packages.php, line 63 
  1.     $package->dist['type'] = 'tar';
  2.     $package->dist['url'] = 'file://'.str_replace(DIRECTORY_SEPARATOR, '/', dirname(__DIR__))."/$dir/package.tar";
  4.     $packages[$package->name][$package->version] = $package;
  6.     $versions = @file_get_contents('https://repo.packagist.org/p/'.$package->name.'.json') ?: sprintf('{"packages":{"%s":{"dev-master":%s}}}', $package->name, file_get_contents($dir.'/composer.json'));
    Adding "@" before \file_get_contents('https://repo.packagist.org/p/' . $package->name . '.json') prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     $versions = json_decode($versions)->packages->{$package->name};
  9.     if (isset($versions->{'dev-master'}) && $package->version === str_replace('-dev', '.x-dev', $versions->{'dev-master'}->extra->{'branch-alias'}->{'dev-master'})) {
  10.         unset($versions->{'dev-master'});
  11.     }
in .github/rm-invalid-lowest-lock-files.php, line 50 
  1. }
  3. $composerJsons = array();
  5. foreach ($dirs as $dir) {
  6.     if (!file_exists($dir.'/composer.lock') || !$composerLock = @json_decode(file_get_contents($dir.'/composer.lock'), true)) {
    Adding "@" before \json_decode(\file_get_contents($dir . '/composer.lock'), \true) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         @unlink($dir.'/composer.lock');
  8.         continue;
  9.     }
  10.     if (!file_exists($dir.'/composer.json') || !$composerJson = @json_decode(file_get_contents($dir.'/composer.json'), true)) {
  11.         echo "$dir/composer.json not found or invalid.\n";
in .github/rm-invalid-lowest-lock-files.php, line 54 
  1. foreach ($dirs as $dir) {
  2.     if (!file_exists($dir.'/composer.lock') || !$composerLock = @json_decode(file_get_contents($dir.'/composer.lock'), true)) {
  3.         @unlink($dir.'/composer.lock');
  4.         continue;
  5.     }
  6.     if (!file_exists($dir.'/composer.json') || !$composerJson = @json_decode(file_get_contents($dir.'/composer.json'), true)) {
    Adding "@" before \json_decode(\file_get_contents($dir . '/composer.json'), \true) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         echo "$dir/composer.json not found or invalid.\n";
  8.         @unlink($dir.'/composer.lock');
  9.         continue;
  10.     }
  11.     if (!isset($composerLock['content-hash']) || getContentHash($composerJson) !== $composerLock['content-hash']) {
in src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php, line 108 
  1.     : 'composer';
  3. $SYMFONY_PHPUNIT_REMOVE = $getEnvVar('SYMFONY_PHPUNIT_REMOVE', 'phpspec/prophecy'.($PHPUNIT_VERSION < 6.0 ? ' symfony/yaml': ''));
  4. $configurationHash = md5(implode(PHP_EOL, array(md5_file(__FILE__), $SYMFONY_PHPUNIT_REMOVE, (int) $PHPUNIT_REMOVE_RETURN_TYPEHINT)));
  5. $PHPUNIT_VERSION_DIR=sprintf('phpunit-%s-%d', $PHPUNIT_VERSION, $PHPUNIT_REMOVE_RETURN_TYPEHINT);
  6. if (!file_exists("$PHPUNIT_DIR/$PHPUNIT_VERSION_DIR/phpunit") || $configurationHash !== @file_get_contents("$PHPUNIT_DIR/.$PHPUNIT_VERSION_DIR.md5")) {
    Adding "@" before \file_get_contents("{$PHPUNIT_DIR}/.{$PHPUNIT_VERSION_DIR}.md5") prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Jérémy Derussé
                    
  7.     // Build a standalone phpunit without symfony/yaml nor prophecy by default
  9.     @mkdir($PHPUNIT_DIR, 0777, true);
  10.     chdir($PHPUNIT_DIR);
  11.     if (file_exists("$PHPUNIT_VERSION_DIR")) {
in src/Symfony/Component/HttpKernel/HttpCache/Store.php, line 353 
  1.     {
  2.         $path = $this->getPath($key);
  4.         if (isset($this->locks[$key])) {
  5.             $fp = $this->locks[$key];
  6.             @ftruncate($fp, 0);
    Adding "@" before ftruncate($fp, 0) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Matthias Pigulla
                    
  7.             @fseek($fp, 0);
  8.             $len = @fwrite($fp, $data);
  9.             if (\strlen($data) !== $len) {
  10.                 @ftruncate($fp, 0);
in src/Symfony/Component/HttpKernel/HttpCache/Store.php, line 354 
  1.         $path = $this->getPath($key);
  3.         if (isset($this->locks[$key])) {
  4.             $fp = $this->locks[$key];
  5.             @ftruncate($fp, 0);
  6.             @fseek($fp, 0);
    Adding "@" before fseek($fp, 0) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Matthias Pigulla
                    
  7.             $len = @fwrite($fp, $data);
  8.             if (\strlen($data) !== $len) {
  9.                 @ftruncate($fp, 0);
  11.                 return false;
in src/Symfony/Component/HttpKernel/HttpCache/Store.php, line 357 
  1.             $fp = $this->locks[$key];
  2.             @ftruncate($fp, 0);
  3.             @fseek($fp, 0);
  4.             $len = @fwrite($fp, $data);
  5.             if (\strlen($data) !== $len) {
  6.                 @ftruncate($fp, 0);
    Adding "@" before ftruncate($fp, 0) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Matthias Pigulla
                    
  8.                 return false;
  9.             }
  10.         } else {
  11.             if (!file_exists(\dirname($path)) && false === @mkdir(\dirname($path), 0777, true) && !is_dir(\dirname($path))) {
in src/Symfony/Component/ErrorHandler/DebugClassLoader.php, line 331 
  1.         try {
  2.             if ($this->isFinder && !isset($this->loaded[$class])) {
  3.                 $this->loaded[$class] = true;
  4.                 if (!$file = $this->classLoader[0]->findFile($class) ?: '') {
  5.                     // no-op
  6.                 } elseif (\function_exists('opcache_is_script_cached') && @opcache_is_script_cached($file)) {
    Adding "@" before opcache_is_script_cached($file) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Yonel Ceruto
                    
  7.                     include $file;
  9.                     return;
  10.                 } elseif (false === include $file) {
  11.                     return;
in src/Symfony/Component/ErrorHandler/DebugClassLoader.php, line 412 
  2.         $className = isset($class[15]) && "\0" === $class[15] && 0 === strpos($class, "class@anonymous\x00") ? get_parent_class($class).'@anonymous' : $class;
  4.         // Don't trigger deprecations for classes in the same vendor
  5.         if ($class !== $className) {
  6.             $vendor = preg_match('/^namespace ([^;\\\\\s]++)[;\\\\]/m', @file_get_contents($refl->getFileName()), $vendor) ? $vendor[1].'\\' : '';
    Adding "@" before file_get_contents($refl->getFileName()) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             $vendorLen = \strlen($vendor);
  8.         } elseif (2 > $vendorLen = 1 + (strpos($class, '\\') ?: strpos($class, '_'))) {
  9.             $vendorLen = 0;
  10.             $vendor = '';
  11.         } else {
in src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php, line 319 
  2.             return $h ? $h($type, $msg, $file, $line, $context) : false;
  3.         }
  4.         // If the message is serialized we need to extract the message. This occurs when the error is triggered by
  5.         // by the isolated test path in \Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerTrait::endTest().
  6.         $parsedMsg = @unserialize($msg);
    Adding "@" before unserialize($msg) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Alex Pott
                    
  7.         if (\is_array($parsedMsg)) {
  8.             $msg = $parsedMsg['deprecation'];
  9.         }
  10.         if (error_reporting()) {
  11.             $msg = 'Unsilenced deprecation: '.$msg;
in src/Symfony/Component/Cache/Traits/RedisTrait.php, line 176 
  1.             $connect = $params['persistent'] || $params['persistent_id'] ? 'pconnect' : 'connect';
  2.             $redis = new $class();
  4.             $initializer = function ($redis) use ($connect, $params, $dsn, $auth, $hosts) {
  5.                 try {
  6.                     @$redis->{$connect}($hosts[0]['host'] ?? $hosts[0]['path'], $hosts[0]['port'] ?? null, $params['timeout'], (string) $params['persistent_id'], $params['retry_interval']);
    Adding "@" before $redis->{$connect}($hosts[0]['host'] ?? $hosts[0]['path'], $hosts[0]['port'] ?? null, $params['timeout'], (string) $params['persistent_id'], $params['retry_interval']) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                 } catch (\RedisException $e) {
  8.                     throw new InvalidArgumentException(sprintf('Redis connection failed (%s): %s', $e->getMessage(), $dsn));
  9.                 }
  11.                 set_error_handler(function ($type, $msg) use (&$error) { $error = $msg; });
in src/Symfony/Bridge/Twig/Command/DebugCommand.php, line 373 
  1.         if ('globals' === $type) {
  2.             if (\is_object($meta)) {
  3.                 return ' = object('.\get_class($meta).')';
  4.             }
  6.             $description = substr(@json_encode($meta), 0, 50);
    Adding "@" before json_encode($meta) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by SpacePossum
                    
  8.             return sprintf(' = %s', $decorated ? OutputFormatter::escape($description) : $description);
  9.         }
  11.         if ('functions' === $type) {
in src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php, line 137 
  1.             if (!$fs->exists($warmupDir.'/'.$containerDir)) {
  2.                 $fs->rename($realCacheDir.'/'.$containerDir, $warmupDir.'/'.$containerDir);
  3.                 touch($warmupDir.'/'.$containerDir.'.legacy');
  4.             }
  6.             if ('/' === \DIRECTORY_SEPARATOR && $mounts = @file('/proc/mounts')) {
    Adding "@" before file('/proc/mounts') prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                 foreach ($mounts as $mount) {
  8.                     $mount = \array_slice(explode(' ', $mount), 1, -3);
  9.                     if (!\in_array(array_pop($mount), ['vboxsf', 'nfs'])) {
  10.                         continue;
  11.                     }
in src/Symfony/Bundle/WebProfilerBundle/WebProfilerBundle.php, line 24 
  1. class WebProfilerBundle extends Bundle
  2. {
  3.     public function boot()
  4.     {
  5.         if ('prod' === $this->container->getParameter('kernel.environment')) {
  6.             @trigger_error('Using WebProfilerBundle in production is not supported and puts your project at risk, disable it.', E_USER_WARNING);
    Adding "@" before trigger_error('Using WebProfilerBundle in production is not supported and puts your project at risk, disable it.', E_USER_WARNING) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.         }
  8.     }
  9. }
in src/Symfony/Component/Cache/Adapter/PhpFilesAdapter.php, line 243 
  1.             $file = $this->files[$key] = $this->getFile($key, true);
  2.             // Since OPcache only compiles files older than the script execution start, set the file's mtime in the past
  3.             $ok = $this->write($file, "<?php //{$encodedKey}\n\n{$value}\n", self::$startTime - 10) && $ok;
  5.             if ($allowCompile) {
  6.                 @opcache_invalidate($file, true);
    Adding "@" before opcache_invalidate($file, true) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                 @opcache_compile_file($file);
  8.             }
  9.         }
  11.         if (!$ok && !is_writable($this->directory)) {
in src/Symfony/Component/Cache/Adapter/PhpFilesAdapter.php, line 244 
  1.             // Since OPcache only compiles files older than the script execution start, set the file's mtime in the past
  2.             $ok = $this->write($file, "<?php //{$encodedKey}\n\n{$value}\n", self::$startTime - 10) && $ok;
  4.             if ($allowCompile) {
  5.                 @opcache_invalidate($file, true);
  6.                 @opcache_compile_file($file);
    Adding "@" before opcache_compile_file($file) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             }
  8.         }
  10.         if (!$ok && !is_writable($this->directory)) {
  11.             throw new CacheException(sprintf('Cache directory is not writable (%s)', $this->directory));
in src/Symfony/Component/Cache/Adapter/PhpFilesAdapter.php, line 280 
  1.     }
  3.     protected function doUnlink($file)
  4.     {
  5.         if (self::isSupported()) {
  6.             @opcache_invalidate($file, true);
    Adding "@" before opcache_invalidate($file, true) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  9.         return @unlink($file);
  10.     }
in src/Symfony/Component/Cache/CacheItem.php, line 187 
  1.             foreach ($context as $k => $v) {
  2.                 if (is_scalar($v)) {
  3.                     $replace['{'.$k.'}'] = $v;
  4.                 }
  5.             }
  6.             @trigger_error(strtr($message, $replace), E_USER_WARNING);
    Adding "@" before trigger_error(strtr($message, $replace), E_USER_WARNING) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  8.     }
  9. }
in src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php, line 144 
  1.             for ($j = 0; $j < 38; ++$j) {
  2.                 if (!file_exists($dir = $directory.$chars[$i].\DIRECTORY_SEPARATOR.$chars[$j])) {
  3.                     continue;
  4.                 }
  6.                 foreach (@scandir($dir, SCANDIR_SORT_NONE) ?: [] as $file) {
    Adding "@" before scandir($dir, SCANDIR_SORT_NONE) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                     if ('.' !== $file && '..' !== $file) {
  8.                         yield $dir.\DIRECTORY_SEPARATOR.$file;
  9.                     }
  10.                 }
  11.             }
in src/Symfony/Component/Config/FileLocator.php, line 60 
  2.         $paths = array_unique($paths);
  3.         $filepaths = $notfound = [];
  5.         foreach ($paths as $path) {
  6.             if (@file_exists($file = $path.\DIRECTORY_SEPARATOR.$name)) {
    Adding "@" before file_exists($file = $path . \DIRECTORY_SEPARATOR . $name) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                 if (true === $first) {
  8.                     return $file;
  9.                 }
  10.                 $filepaths[] = $file;
  11.             } else {
in src/Symfony/Component/Config/Util/XmlUtils.php, line 89 
  1.                 } catch (\Exception $e) {
  2.                     $valid = false;
  3.                 }
  4.             } elseif (!\is_array($schemaOrCallable) && is_file((string) $schemaOrCallable)) {
  5.                 $schemaSource = file_get_contents((string) $schemaOrCallable);
  6.                 $valid = @$dom->schemaValidateSource($schemaSource);
    Adding "@" before $dom->schemaValidateSource($schemaSource) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Curtis
                    
  7.             } else {
  8.                 libxml_use_internal_errors($internalErrors);
  10.                 throw new XmlParsingException('The schemaOrCallable argument has to be a valid path to XSD file or callable.');
  11.             }
in src/Symfony/Component/Config/Util/XmlUtils.php, line 125 
  1.      * @throws XmlParsingException       When XML parsing returns any errors
  2.      * @throws \RuntimeException         When DOM extension is missing
  3.      */
  4.     public static function loadFile(string $file, $schemaOrCallable = null)
  5.     {
  6.         $content = @file_get_contents($file);
    Adding "@" before file_get_contents($file) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Ole Rößner
                    
  7.         if ('' === trim($content)) {
  8.             throw new \InvalidArgumentException(sprintf('File %s does not contain valid XML, it is empty.', $file));
  9.         }
  11.         try {
in src/Symfony/Component/Console/Command/Command.php, line 225 
  2.         $this->initialize($input, $output);
  4.         if (null !== $this->processTitle) {
  5.             if (\function_exists('cli_set_process_title')) {
  6.                 if (!@cli_set_process_title($this->processTitle)) {
    Adding "@" before cli_set_process_title($this->processTitle) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                     if ('Darwin' === PHP_OS) {
  8.                         $output->writeln('<comment>Running "cli_set_process_title" as an unprivileged user is not supported on MacOS.</comment>', OutputInterface::VERBOSITY_VERY_VERBOSE);
  9.                     } else {
  10.                         cli_set_process_title($this->processTitle);
  11.                     }
in src/Symfony/Component/Console/Output/StreamOutput.php, line 106 
  1.             return true;
  2.         }
  4.         if (\DIRECTORY_SEPARATOR === '\\') {
  5.             return (\function_exists('sapi_windows_vt100_support')
  6.                 && @sapi_windows_vt100_support($this->stream))
    Adding "@" before sapi_windows_vt100_support($this->stream) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by johnstevenson
                    
  7.                 || false !== getenv('ANSICON')
  8.                 || 'ON' === getenv('ConEmuANSI')
  9.                 || 'xterm' === getenv('TERM');
  10.         }
in src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php, line 623 
  1. </xsd:schema>
  2. EOF
  3.         ;
  5.         $disableEntities = libxml_disable_entity_loader(false);
  6.         $valid = @$dom->schemaValidateSource($source);
    Adding "@" before $dom->schemaValidateSource($source) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Anthon Pang
                    
  7.         libxml_disable_entity_loader($disableEntities);
  9.         foreach ($tmpfiles as $tmpfile) {
  10.             @unlink($tmpfile);
  11.         }
in src/Symfony/Component/DomCrawler/Crawler.php, line 232 
  2.         $dom = new \DOMDocument('1.0', $charset);
  3.         $dom->validateOnParse = true;
  5.         if ('' !== trim($content)) {
  6.             @$dom->loadXML($content, $options);
    Adding "@" before $dom->loadXML($content, $options) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.         }
  9.         libxml_use_internal_errors($internalErrors);
  10.         libxml_disable_entity_loader($disableEntities);
in src/Symfony/Component/DomCrawler/Crawler.php, line 1128 
  2.         $dom = new \DOMDocument('1.0', $charset);
  3.         $dom->validateOnParse = true;
  5.         if ('' !== trim($htmlContent)) {
  6.             @$dom->loadHTML($htmlContent);
    Adding "@" before $dom->loadHTML($htmlContent) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Titouan Galopin
                    
  7.         }
  9.         libxml_use_internal_errors($internalErrors);
  10.         libxml_disable_entity_loader($disableEntities);
in src/Symfony/Component/Filesystem/Filesystem.php, line 592 
  1.     {
  2.         list($scheme, $hierarchy) = $this->getSchemeAndHierarchy($dir);
  4.         // If no scheme or scheme is "file" or "gs" (Google Cloud) create temp file in local filesystem
  5.         if (null === $scheme || 'file' === $scheme || 'gs' === $scheme) {
  6.             $tmpFile = @tempnam($hierarchy, $prefix);
    Adding "@" before tempnam($hierarchy, $prefix) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  8.             // If tempnam failed or no scheme return the filename otherwise prepend the scheme
  9.             if (false !== $tmpFile) {
  10.                 if (null !== $scheme && 'gs' !== $scheme) {
  11.                     return $scheme.'://'.$tmpFile;
in src/Symfony/Component/Finder/Iterator/RecursiveDirectoryIterator.php, line 129 
  1.     {
  2.         if (null !== $this->rewindable) {
  3.             return $this->rewindable;
  4.         }
  6.         if (false !== $stream = @opendir($this->getPath())) {
    Adding "@" before opendir($this->getPath()) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by alquerci
                    
  7.             $infos = stream_get_meta_data($stream);
  8.             closedir($stream);
  10.             if ($infos['seekable']) {
  11.                 return $this->rewindable = true;
in src/Symfony/Component/Form/Util/StringUtil.php, line 34 
  1.      *
  2.      * @return string
  3.      */
  4.     public static function trim(string $string)
  5.     {
  6.         if (null !== $result = @preg_replace('/^[\pZ\p{Cc}]+|[\pZ\p{Cc}]+$/u', '', $string)) {
    Adding "@" before preg_replace('/^[\\pZ\\p{Cc}]+|[\\pZ\\p{Cc}]+$/u', '', $string) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Issei.M
                    
  7.             return $result;
  8.         }
  10.         return trim($string);
  11.     }
in src/Symfony/Component/HttpClient/HttpClient.php, line 37 
  1.         if (\extension_loaded('curl')) {
  2.             if ('\\' !== \DIRECTORY_SEPARATOR || ini_get('curl.cainfo') || ini_get('openssl.cafile') || ini_get('openssl.capath')) {
  3.                 return new CurlHttpClient($defaultOptions, $maxHostConnections, $maxPendingPushes);
  4.             }
  6.             @trigger_error('Configure the "curl.cainfo", "openssl.cafile" or "openssl.capath" php.ini setting to enable the CurlHttpClient', E_USER_WARNING);
    Adding "@" before trigger_error('Configure the "curl.cainfo", "openssl.cafile" or "openssl.capath" php.ini setting to enable the CurlHttpClient', E_USER_WARNING) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  9.         return new NativeHttpClient($defaultOptions, $maxHostConnections);
  10.     }
in src/Symfony/Component/HttpClient/HttpClientTrait.php, line 275 
  1.             }
  3.             return $body;
  4.         }
  6.         if (!\is_string($body) && !\is_array(@stream_get_meta_data($body))) {
    Adding "@" before stream_get_meta_data($body) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             throw new InvalidArgumentException(sprintf('Option "body" must be string, stream resource, iterable or callable, %s given.', \is_resource($body) ? get_resource_type($body) : \gettype($body)));
  8.         }
  10.         return $body;
  11.     }
in src/Symfony/Component/HttpClient/Response/CurlResponse.php, line 290 
  1.             $active = 0;
  2.             while (CURLM_CALL_MULTI_PERFORM === curl_multi_exec($multi->handle, $active));
  4.             while ($info = curl_multi_info_read($multi->handle)) {
  5.                 $multi->handlesActivity[(int) $info['handle']][] = null;
  6.                 $multi->handlesActivity[(int) $info['handle']][] = \in_array($info['result'], [\CURLE_OK, \CURLE_TOO_MANY_REDIRECTS], true) || (\CURLE_WRITE_ERROR === $info['result'] && 'destruct' === @curl_getinfo($info['handle'], CURLINFO_PRIVATE)) ? null : new TransportException(sprintf('%s for "%s".', curl_strerror($info['result']), curl_getinfo($info['handle'], CURLINFO_EFFECTIVE_URL)));
    Adding "@" before curl_getinfo($info['handle'], CURLINFO_PRIVATE) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7.             }
  8.         } finally {
  9.             self::$performing = false;
  10.         }
  11.     }
in src/Symfony/Component/HttpClient/Response/CurlResponse.php, line 315 
  1.     /**
  2.      * Parses header lines as curl yields them to us.
  3.      */
  4.     private static function parseHeaderLine($ch, string $data, array &$info, array &$headers, ?array $options, CurlClientState $multi, int $id, ?string &$location, ?callable $resolveRedirect, ?LoggerInterface $logger, &$content = null): int
  5.     {
  6.         if (!\in_array($waitFor = @curl_getinfo($ch, CURLINFO_PRIVATE), ['headers', 'destruct'], true)) {
    Adding "@" before curl_getinfo($ch, CURLINFO_PRIVATE) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             return \strlen($data); // Ignore HTTP trailers
  8.         }
  10.         if ("\r\n" !== $data) {
  11.             // Regular header line: add it to the list
in src/Symfony/Component/HttpClient/Response/NativeResponse.php, line 279 
  1.                 }
  2.             } elseif ('' !== $data = stream_get_contents($buffer, -1, 0)) {
  3.                 rewind($buffer);
  4.                 ftruncate($buffer, 0);
  6.                 if (null !== $inflate && false === $data = @inflate_add($inflate, $data)) {
    Adding "@" before inflate_add($inflate, $data) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                     $e = new TransportException('Error while processing content unencoding.');
  8.                 }
  10.                 if ('' !== $data && null === $e) {
  11.                     $multi->handlesActivity[$i][] = $data;
in src/Symfony/Component/HttpFoundation/IpUtils.php, line 116 
  1.         $cacheKey = $requestIp.'-'.$ip;
  2.         if (isset(self::$checkedIps[$cacheKey])) {
  3.             return self::$checkedIps[$cacheKey];
  4.         }
  6.         if (!((\extension_loaded('sockets') && \defined('AF_INET6')) || @inet_pton('::1'))) {
    Adding "@" before inet_pton('::1') prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Christophe Coevoet
                    
  7.             throw new \RuntimeException('Unable to check Ipv6. Check that PHP was not compiled with option "disable-ipv6".');
  8.         }
  10.         if (false !== strpos($ip, '/')) {
  11.             list($address, $netmask) = explode('/', $ip, 2);
in src/Symfony/Component/HttpFoundation/IpUtils.php, line 124 
  2.         if (false !== strpos($ip, '/')) {
  3.             list($address, $netmask) = explode('/', $ip, 2);
  5.             if ('0' === $netmask) {
  6.                 return (bool) unpack('n*', @inet_pton($address));
    Adding "@" before inet_pton($address) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Stéphan Kochen
                    
  7.             }
  9.             if ($netmask < 1 || $netmask > 128) {
  10.                 return self::$checkedIps[$cacheKey] = false;
  11.             }
in src/Symfony/Component/HttpFoundation/IpUtils.php, line 135 
  1.         } else {
  2.             $address = $ip;
  3.             $netmask = 128;
  4.         }
  6.         $bytesAddr = unpack('n*', @inet_pton($address));
    Adding "@" before inet_pton($address) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Jakub Zalas
                    
  7.         $bytesTest = unpack('n*', @inet_pton($requestIp));
  9.         if (!$bytesAddr || !$bytesTest) {
  10.             return self::$checkedIps[$cacheKey] = false;
  11.         }
in src/Symfony/Component/HttpFoundation/IpUtils.php, line 136 
  1.             $address = $ip;
  2.             $netmask = 128;
  3.         }
  5.         $bytesAddr = unpack('n*', @inet_pton($address));
  6.         $bytesTest = unpack('n*', @inet_pton($requestIp));
    Adding "@" before inet_pton($requestIp) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Jakub Zalas
                    
  8.         if (!$bytesAddr || !$bytesTest) {
  9.             return self::$checkedIps[$cacheKey] = false;
  10.         }
in src/Symfony/Component/HttpKernel/CacheWarmer/CacheWarmer.php, line 23 
  1.  */
  2. abstract class CacheWarmer implements CacheWarmerInterface
  3. {
  4.     protected function writeCacheFile(string $file, $content)
  5.     {
  6.         $tmpFile = @tempnam(\dirname($file), basename($file));
    Adding "@" before tempnam(\dirname($file), basename($file)) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Christophe Coevoet
                    
  7.         if (false !== @file_put_contents($tmpFile, $content) && @rename($tmpFile, $file)) {
  8.             @chmod($file, 0666 & ~umask());
  10.             return;
  11.         }
in src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php, line 142 
  2.         if (false === $this->connection) {
  3.             throw new LdapException(sprintf('Could not connect to Ldap server: %s.', ldap_error($this->connection)));
  4.         }
  6.         if ('tls' === $this->config['encryption'] && false === @ldap_start_tls($this->connection)) {
    Adding "@" before ldap_start_tls($this->connection) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             throw new LdapException(sprintf('Could not initiate TLS connection: %s.', ldap_error($this->connection)));
  8.         }
  9.     }
  11.     private function disconnect()
in src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php, line 81 
  1.      */
  2.     public function addAttributeValues(Entry $entry, string $attribute, array $values)
  3.     {
  4.         $con = $this->getConnectionResource();
  6.         if (!@ldap_mod_add($con, $entry->getDn(), [$attribute => $values])) {
    Adding "@" before ldap_mod_add($con, $entry->getDn(), [$attribute => $values]) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             throw new LdapException(sprintf('Could not add values to entry "%s", attribute %s: %s.', $entry->getDn(), $attribute, ldap_error($con)));
  8.         }
  9.     }
  11.     /**
in src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php, line 96 
  1.      */
  2.     public function removeAttributeValues(Entry $entry, string $attribute, array $values)
  3.     {
  4.         $con = $this->getConnectionResource();
  6.         if (!@ldap_mod_del($con, $entry->getDn(), [$attribute => $values])) {
    Adding "@" before ldap_mod_del($con, $entry->getDn(), [$attribute => $values]) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             throw new LdapException(sprintf('Could not remove values from entry "%s", attribute %s: %s.', $entry->getDn(), $attribute, ldap_error($con)));
  8.         }
  9.     }
  11.     /**
in src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php, line 108 
  1.      */
  2.     public function rename(Entry $entry, string $newRdn, bool $removeOldRdn = true)
  3.     {
  4.         $con = $this->getConnectionResource();
  6.         if (!@ldap_rename($con, $entry->getDn(), $newRdn, null, $removeOldRdn)) {
    Adding "@" before ldap_rename($con, $entry->getDn(), $newRdn, null, $removeOldRdn) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Kevin
                    
  7.             throw new LdapException(sprintf('Could not rename entry "%s" to "%s": %s.', $entry->getDn(), $newRdn, ldap_error($con)));
  8.         }
  9.     }
  11.     /**
in src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php, line 124 
  1.     public function move(Entry $entry, string $newParent)
  2.     {
  3.         $con = $this->getConnectionResource();
  4.         $rdn = $this->parseRdnFromEntry($entry);
  5.         // deleteOldRdn does not matter here, since the Rdn will not be changing in the move.
  6.         if (!@ldap_rename($con, $entry->getDn(), $rdn, $newParent, true)) {
    Adding "@" before ldap_rename($con, $entry->getDn(), $rdn, $newParent, true) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Kyle Evans
                    
  7.             throw new LdapException(sprintf('Could not move entry "%s" to "%s": %s.', $entry->getDn(), $newParent, ldap_error($con)));
  8.         }
  9.     }
  11.     /**
in src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php, line 154 
  1.         $operationsMapped = [];
  2.         foreach ($operations as $modification) {
  3.             $operationsMapped[] = $modification->toArray();
  4.         }
  6.         if (!@ldap_modify_batch($this->getConnectionResource(), $dn, $operationsMapped)) {
    Adding "@" before ldap_modify_batch($this->getConnectionResource(), $dn, $operationsMapped) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Malte Blättermann
                    
  7.             throw new UpdateOperationException(sprintf('Error executing UpdateOperation on "%s": "%s".', $dn, ldap_error($this->getConnectionResource())));
  8.         }
  9.     }
  11.     private function parseRdnFromEntry(Entry $entry): string
in src/Symfony/Component/Ldap/Adapter/ExtLdap/Query.php, line 106 
  1.                 }
  2.                 $sizeLimit = $itemsLeft;
  3.                 if ($pageSize > 0 && $sizeLimit >= $pageSize) {
  4.                     $sizeLimit = 0;
  5.                 }
  6.                 $search = @$func(
    Adding "@" before $func($con, $this->dn, $this->query, $this->options['filter'], $this->options['attrsOnly'], $sizeLimit, $this->options['timeout'], $this->options['deref']) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Kyle Evans
                    
  7.                     $con,
  8.                     $this->dn,
  9.                     $this->query,
  10.                     $this->options['filter'],
  11.                     $this->options['attrsOnly'],
in src/Symfony/Component/Lock/Store/SemaphoreStore.php, line 67 
  1.             return;
  2.         }
  4.         $keyId = crc32($key);
  5.         $resource = sem_get($keyId);
  6.         $acquired = @sem_acquire($resource, !$blocking);
    Adding "@" before sem_acquire($resource, !$blocking) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  8.         while ($blocking && !$acquired) {
  9.             $resource = sem_get($keyId);
  10.             $acquired = @sem_acquire($resource);
  11.         }
in src/Symfony/Component/Lock/Store/SemaphoreStore.php, line 71 
  1.         $resource = sem_get($keyId);
  2.         $acquired = @sem_acquire($resource, !$blocking);
  4.         while ($blocking && !$acquired) {
  5.             $resource = sem_get($keyId);
  6.             $acquired = @sem_acquire($resource);
    Adding "@" before sem_acquire($resource) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Jérémy Derussé
                    
  7.         }
  9.         if (!$acquired) {
  10.             throw new LockConflictedException();
  11.         }
in src/Symfony/Component/Mime/Crypto/SMimeEncrypter.php, line 51 
  1.         $bufferFile = tmpfile();
  2.         $outputFile = tmpfile();
  4.         $this->iteratorToFile($message->toIterable(), $bufferFile);
  6.         if (!@openssl_pkcs7_encrypt(stream_get_meta_data($bufferFile)['uri'], stream_get_meta_data($outputFile)['uri'], $this->certs, [], 0, $this->cipher)) {
    Adding "@" before openssl_pkcs7_encrypt(stream_get_meta_data($bufferFile)['uri'], stream_get_meta_data($outputFile)['uri'], $this->certs, [], 0, $this->cipher) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Sebastiaan Stok
                    
  7.             throw new RuntimeException(sprintf('Failed to encrypt S/Mime message. Error: "%s".', openssl_error_string()));
  8.         }
  10.         $mimePart = $this->convertMessageToSMimePart($outputFile, 'application', 'pkcs7-mime');
  11.         $mimePart->getHeaders()
in src/Symfony/Component/Mime/Crypto/SMimeSigner.php, line 65 
  1.         $bufferFile = tmpfile();
  2.         $outputFile = tmpfile();
  4.         $this->iteratorToFile($message->getBody()->toIterable(), $bufferFile);
  6.         if (!@openssl_pkcs7_sign(stream_get_meta_data($bufferFile)['uri'], stream_get_meta_data($outputFile)['uri'], $this->signCertificate, $this->signPrivateKey, [], $this->signOptions, $this->extraCerts)) {
    Adding "@" before openssl_pkcs7_sign(stream_get_meta_data($bufferFile)['uri'], stream_get_meta_data($outputFile)['uri'], $this->signCertificate, $this->signPrivateKey, [], $this->signOptions, $this->extraCerts) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Sebastiaan Stok
                    
  7.             throw new RuntimeException(sprintf('Failed to sign S/Mime message. Error: "%s".', openssl_error_string()));
  8.         }
  10.         return new Message($message->getHeaders(), $this->convertMessageToSMimePart($outputFile, 'multipart', 'signed'));
  11.     }
in src/Symfony/Component/Process/ExecutableFinder.php, line 56 
  1.         if (ini_get('open_basedir')) {
  2.             $searchPath = array_merge(explode(PATH_SEPARATOR, ini_get('open_basedir')), $extraDirs);
  3.             $dirs = [];
  4.             foreach ($searchPath as $path) {
  5.                 // Silencing against https://bugs.php.net/69240
  6.                 if (@is_dir($path)) {
    Adding "@" before is_dir($path) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Ben
                    
  7.                     $dirs[] = $path;
  8.                 } else {
  9.                     if (basename($path) == $name && @is_executable($path)) {
  10.                         return $path;
  11.                     }
in src/Symfony/Component/Process/Pipes/AbstractPipes.php, line 122 
  2.         $r = $e = [];
  3.         $w = [$this->pipes[0]];
  5.         // let's have a look if something changed in streams
  6.         if (false === @stream_select($r, $w, $e, 0, 0)) {
    Adding "@" before stream_select($r, $w, $e, 0, 0) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Titouan Galopin
                    
  7.             return null;
  8.         }
  10.         foreach ($w as $stdin) {
  11.             if (isset($this->inputBuffer[0])) {
in src/Symfony/Component/Process/Pipes/WindowsPipes.php, line 137 
  1.         $w = $this->write();
  2.         $read = $r = $e = [];
  4.         if ($blocking) {
  5.             if ($w) {
  6.                 @stream_select($r, $w, $e, 0, Process::TIMEOUT_PRECISION * 1E6);
    Adding "@" before stream_select($r, $w, $e, 0, \Symfony\Component\Process\Process::TIMEOUT_PRECISION * 1000000.0) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             } elseif ($this->fileHandles) {
  8.                 usleep(Process::TIMEOUT_PRECISION * 1E6);
  9.             }
  10.         }
  11.         foreach ($this->fileHandles as $type => $fileHandle) {
in src/Symfony/Component/Process/Process.php, line 1216 
  1.     public static function isTtySupported(): bool
  2.     {
  3.         static $isTtySupported;
  5.         if (null === $isTtySupported) {
  6.             $isTtySupported = (bool) @proc_open('echo 1 >/dev/null', [['file', '/dev/tty', 'r'], ['file', '/dev/tty', 'w'], ['file', '/dev/tty', 'w']], $pipes);
    Adding "@" before proc_open('echo 1 >/dev/null', [['file', '/dev/tty', 'r'], ['file', '/dev/tty', 'w'], ['file', '/dev/tty', 'w']], $pipes) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.         }
  9.         return $isTtySupported;
  10.     }
in src/Symfony/Component/Process/Process.php, line 1239 
  2.         if ('\\' === \DIRECTORY_SEPARATOR) {
  3.             return $result = false;
  4.         }
  6.         return $result = (bool) @proc_open('echo 1 >/dev/null', [['pty'], ['pty'], ['pty']], $pipes);
    Adding "@" before proc_open('echo 1 >/dev/null', [['pty'], ['pty'], ['pty']], $pipes) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.     }
  9.     /**
  10.      * Creates the descriptors needed by the proc_open.
  11.      */
in src/Symfony/Component/Process/Process.php, line 1477 
  2.                 return false;
  3.             }
  4.         } else {
  5.             if (!$this->isSigchildEnabled()) {
  6.                 $ok = @proc_terminate($this->process, $signal);
    Adding "@" before proc_terminate($this->process, $signal) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             } elseif (\function_exists('posix_kill')) {
  8.                 $ok = @posix_kill($pid, $signal);
  9.             } elseif ($ok = proc_open(sprintf('kill -%d %d', $signal, $pid), [2 => ['pipe', 'w']], $pipes)) {
  10.                 $ok = false === fgets($pipes[2]);
  11.             }
in src/Symfony/Component/Process/Process.php, line 1479 
  1.             }
  2.         } else {
  3.             if (!$this->isSigchildEnabled()) {
  4.                 $ok = @proc_terminate($this->process, $signal);
  5.             } elseif (\function_exists('posix_kill')) {
  6.                 $ok = @posix_kill($pid, $signal);
    Adding "@" before posix_kill($pid, $signal) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             } elseif ($ok = proc_open(sprintf('kill -%d %d', $signal, $pid), [2 => ['pipe', 'w']], $pipes)) {
  8.                 $ok = false === fgets($pipes[2]);
  9.             }
  10.             if (!$ok) {
  11.                 if ($throwException) {
in src/Symfony/Component/Translation/Util/XliffUtils.php, line 66 
  1.     {
  2.         $xliffVersion = static::getVersionNumber($dom);
  3.         $internalErrors = libxml_use_internal_errors(true);
  4.         $disableEntities = libxml_disable_entity_loader(false);
  6.         $isValid = @$dom->schemaValidateSource(self::getSchema($xliffVersion));
    Adding "@" before $dom->schemaValidateSource(self::getSchema($xliffVersion)) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Javier Eguiluz
                    
  7.         if (!$isValid) {
  8.             libxml_disable_entity_loader($disableEntities);
  10.             return self::getXmlErrors($internalErrors);
  11.         }
in src/Symfony/Component/Validator/Constraints/LengthValidator.php, line 47 
  2.         if (null !== $constraint->normalizer) {
  3.             $stringValue = ($constraint->normalizer)($stringValue);
  4.         }
  6.         if (!$invalidCharset = !@mb_check_encoding($stringValue, $constraint->charset)) {
    Adding "@" before mb_check_encoding($stringValue, $constraint->charset) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             $length = mb_strlen($stringValue, $constraint->charset);
  8.         }
  10.         if ($invalidCharset) {
  11.             $this->context->buildViolation($constraint->charsetMessage)
in src/Symfony/Component/Validator/Constraints/TimezoneValidator.php, line 81 
  1.     }
  3.     private static function getPhpTimezones(int $zone, string $countryCode = null): array
  4.     {
  5.         if (null !== $countryCode) {
  6.             return @\DateTimeZone::listIdentifiers($zone, $countryCode) ?: [];
    Adding "@" before \DateTimeZone::listIdentifiers($zone, $countryCode) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Roland Franssen
                    
  7.         }
  9.         return \DateTimeZone::listIdentifiers($zone);
  10.     }
in src/Symfony/Component/VarDumper/Caster/LinkStub.php, line 94 
  1.                 return $root;
  2.             }
  3.         }
  5.         $parent = $dir;
  6.         while (!@file_exists($parent.'/composer.json')) {
    Adding "@" before file_exists($parent . '/composer.json') prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.             if (!@file_exists($parent)) {
  8.                 // open_basedir restriction in effect
  9.                 break;
  10.             }
  11.             if ($parent === \dirname($parent)) {
in src/Symfony/Component/VarDumper/Caster/LinkStub.php, line 95 
  1.             }
  2.         }
  4.         $parent = $dir;
  5.         while (!@file_exists($parent.'/composer.json')) {
  6.             if (!@file_exists($parent)) {
    Adding "@" before file_exists($parent) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                 // open_basedir restriction in effect
  8.                 break;
  9.             }
  10.             if ($parent === \dirname($parent)) {
  11.                 return self::$composerRoots[$dir] = false;
in src/Symfony/Component/VarDumper/Caster/ResourceCaster.php, line 55 
  1.         return $a;
  2.     }
  4.     public static function castStreamContext($stream, array $a, Stub $stub, bool $isNested)
  5.     {
  6.         return @stream_context_get_params($stream) ?: $a;
    Adding "@" before stream_context_get_params($stream) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     }
  9.     public static function castGd($gd, array $a, Stub $stub, $isNested)
  10.     {
  11.         $a['size'] = imagesx($gd).'x'.imagesy($gd);
in src/Symfony/Component/VarDumper/Dumper/CliDumper.php, line 584 
  1.             return true;
  2.         }
  4.         if (\DIRECTORY_SEPARATOR === '\\') {
  5.             return (\function_exists('sapi_windows_vt100_support')
  6.                 && @sapi_windows_vt100_support($stream))
    Adding "@" before sapi_windows_vt100_support($stream) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by johnstevenson
                    
  7.                 || false !== getenv('ANSICON')
  8.                 || 'ON' === getenv('ConEmuANSI')
  9.                 || 'xterm' === getenv('TERM');
  10.         }
in src/Symfony/Component/VarDumper/Server/DumpServer.php, line 55 
  1.         if (null === $this->socket) {
  2.             $this->start();
  3.         }
  5.         foreach ($this->getMessages() as $clientId => $message) {
  6.             $payload = @unserialize(base64_decode($message), ['allowed_classes' => [Data::class, Stub::class]]);
    Adding "@" before unserialize(base64_decode($message), ['allowed_classes' => [\Symfony\Component\VarDumper\Cloner\Data::class, \Symfony\Component\VarDumper\Cloner\Stub::class]]) prevents warning and errors during this function execution from being displayed.
    
If you need to do that, you should probably implement a better way to qualify and recover from errors, using Exceptions.
    Time to fix: about 4 hours
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  8.             // Impossible to decode the message, give up.
  9.             if (false === $payload) {
  10.                 if ($this->logger) {
  11.                     $this->logger->warning('Unable to decode a message from {clientId} client.', ['clientId' => $clientId]);

Object parameters should be type hinted 18

More information: https://insight.symfony.com/what-we-analyse/php.object_parameter_not_type_hinted

in src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php, line 274 
  2.     /**
  3.      * @param string[]      $groups
  4.      * @param Configuration $configuration
  5.      */
  6.     private function displayDeprecations($groups, $configuration)
    The parameter configuration, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Grégoire Paris
                    
  7.     {
  8.         $cmp = function ($a, $b) {
  9.             return $b['count'] - $a['count'];
  10.         };
in src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php, line 112 
  1.     {
  2.         self::$globallyEnabled = false;
  3.         $this->state = -1;
  4.     }
  6.     public function startTestSuite($suite)
    The parameter suite, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.     {
  8.         $suiteName = $suite->getName();
  9.         $this->testsWithWarnings = array();
  11.         foreach ($suite->tests() as $test) {
in src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php, line 336 
  1.     /**
  2.      * @param TestCase $test
  3.      *
  4.      * @return bool
  5.      */
  6.     private function willBeIsolated($test)
    The parameter test, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Paul Mitchum
                    
  7.     {
  8.         if ($test->isInIsolation()) {
  9.             return false;
  10.         }
in src/Symfony/Bundle/FrameworkBundle/Command/AbstractConfigCommand.php, line 40 
  1.         $title = 'Available registered bundles with their extension alias if available';
  2.         $headers = ['Bundle name', 'Extension alias'];
  3.         $rows = [];
  5.         $bundles = $this->getApplication()->getKernel()->getBundles();
  6.         usort($bundles, function ($bundleA, $bundleB) {
    The parameter bundleA, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             return strcmp($bundleA->getName(), $bundleB->getName());
  8.         });
  10.         foreach ($bundles as $bundle) {
  11.             $extension = $bundle->getContainerExtension();
in src/Symfony/Bundle/FrameworkBundle/Command/AbstractConfigCommand.php, line 40 
  1.         $title = 'Available registered bundles with their extension alias if available';
  2.         $headers = ['Bundle name', 'Extension alias'];
  3.         $rows = [];
  5.         $bundles = $this->getApplication()->getKernel()->getBundles();
  6.         usort($bundles, function ($bundleA, $bundleB) {
    The parameter bundleB, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.             return strcmp($bundleA->getName(), $bundleB->getName());
  8.         });
  10.         foreach ($bundles as $bundle) {
  11.             $extension = $bundle->getContainerExtension();
in src/Symfony/Component/Cache/Traits/RedisTrait.php, line 174 
  2.         if (is_a($class, \Redis::class, true)) {
  3.             $connect = $params['persistent'] || $params['persistent_id'] ? 'pconnect' : 'connect';
  4.             $redis = new $class();
  6.             $initializer = function ($redis) use ($connect, $params, $dsn, $auth, $hosts) {
    The parameter redis, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                 try {
  8.                     @$redis->{$connect}($hosts[0]['host'] ?? $hosts[0]['path'], $hosts[0]['port'] ?? null, $params['timeout'], (string) $params['persistent_id'], $params['retry_interval']);
  9.                 } catch (\RedisException $e) {
  10.                     throw new InvalidArgumentException(sprintf('Redis connection failed (%s): %s', $e->getMessage(), $dsn));
  11.                 }
in src/Symfony/Component/Cache/Traits/RedisTrait.php, line 451 
  1.             foreach ($generator() as $command => $args) {
  2.                 $results[] = $redis->{$command}(...$args);
  3.                 $ids[] = 'eval' === $command ? ($redis instanceof \Predis\ClientInterface ? $args[2] : $args[1][0]) : $args[0];
  4.             }
  5.         } elseif ($redis instanceof \Predis\ClientInterface) {
  6.             $results = $redis->pipeline(static function ($redis) use ($generator, &$ids) {
    The parameter redis, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by André R
                    
  7.                 foreach ($generator() as $command => $args) {
  8.                     $redis->{$command}(...$args);
  9.                     $ids[] = 'eval' === $command ? $args[2] : $args[0];
  10.                 }
  11.             });
in src/Symfony/Component/DependencyInjection/Definition.php, line 847 
  1.      *
  2.      * @param string|\Closure|self $error
  3.      *
  4.      * @return $this
  5.      */
  6.     public function addError($error)
    The parameter error, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Ryan Weaver
                    
  7.     {
  8.         if ($error instanceof self) {
  9.             $this->errors = array_merge($this->errors, $error->errors);
  10.         } else {
  11.             $this->errors[] = $error;
in src/Symfony/Component/Form/FormTypeGuesserChain.php, line 46 
  1.     /**
  2.      * {@inheritdoc}
  3.      */
  4.     public function guessType(string $class, string $property)
  5.     {
  6.         return $this->guess(function ($guesser) use ($class, $property) {
    The parameter guesser, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Bernhard Schussek
                    
  7.             return $guesser->guessType($class, $property);
  8.         });
  9.     }
  11.     /**
in src/Symfony/Component/Form/FormTypeGuesserChain.php, line 56 
  1.     /**
  2.      * {@inheritdoc}
  3.      */
  4.     public function guessRequired(string $class, string $property)
  5.     {
  6.         return $this->guess(function ($guesser) use ($class, $property) {
    The parameter guesser, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Bernhard Schussek
                    
  7.             return $guesser->guessRequired($class, $property);
  8.         });
  9.     }
  11.     /**
in src/Symfony/Component/Form/FormTypeGuesserChain.php, line 66 
  1.     /**
  2.      * {@inheritdoc}
  3.      */
  4.     public function guessMaxLength(string $class, string $property)
  5.     {
  6.         return $this->guess(function ($guesser) use ($class, $property) {
    The parameter guesser, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Bernhard Schussek
                    
  7.             return $guesser->guessMaxLength($class, $property);
  8.         });
  9.     }
  11.     /**
in src/Symfony/Component/Form/FormTypeGuesserChain.php, line 76 
  1.     /**
  2.      * {@inheritdoc}
  3.      */
  4.     public function guessPattern(string $class, string $property)
  5.     {
  6.         return $this->guess(function ($guesser) use ($class, $property) {
    The parameter guesser, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Michel Weimerskirch
                    
  7.             return $guesser->guessPattern($class, $property);
  8.         });
  9.     }
  11.     /**
in src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php, line 83 
  1.         }
  3.         $event->setResponse($response);
  5.         if ($this->debug && $eventDispatcher instanceof EventDispatcherInterface) {
  6.             $cspRemovalListener = function ($event) use (&$cspRemovalListener, $eventDispatcher) {
    The parameter event, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                 $event->getResponse()->headers->remove('Content-Security-Policy');
  8.                 $eventDispatcher->removeListener(KernelEvents::RESPONSE, $cspRemovalListener);
  9.             };
  10.             $eventDispatcher->addListener(KernelEvents::RESPONSE, $cspRemovalListener, -128);
  11.         }
in src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php, line 124 
  1.         }
  3.         static $setSession;
  5.         if (null === $setSession) {
  6.             $setSession = \Closure::bind(static function ($subRequest, $request) { $subRequest->session = $request->session; }, null, Request::class);
    The parameter request, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  8.         $setSession($subRequest, $request);
  10.         if ($request->get('_format')) {
  11.             $subRequest->attributes->set('_format', $request->get('_format'));
in src/Symfony/Component/Security/Http/HttpUtils.php, line 87 
  1.         $newRequest = Request::create($this->generateUri($request, $path), 'get', [], $request->cookies->all(), [], $request->server->all());
  3.         static $setSession;
  5.         if (null === $setSession) {
  6.             $setSession = \Closure::bind(static function ($newRequest, $request) { $newRequest->session = $request->session; }, null, Request::class);
    The parameter request, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.         }
  8.         $setSession($newRequest, $request);
  10.         if ($request->attributes->has(Security::AUTHENTICATION_ERROR)) {
  11.             $newRequest->attributes->set(Security::AUTHENTICATION_ERROR, $request->attributes->get(Security::AUTHENTICATION_ERROR));
in src/Symfony/Component/VarDumper/Caster/DOMCaster.php, line 76 
  1.         }
  3.         return $a;
  4.     }
  6.     public static function castLength($dom, array $a, Stub $stub, bool $isNested)
    The parameter dom, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Alexander M. Turek
                    
  7.     {
  8.         $a += [
  9.             'length' => $dom->length,
  10.         ];
in src/Symfony/Component/VarDumper/Caster/RedisCaster.php, line 108 
  1.     }
  3.     /**
  4.      * @param \Redis|\RedisArray|\RedisCluster $redis
  5.      */
  6.     private static function getRedisOptions($redis, array $options = []): EnumStub
    The parameter redis, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Fabien Potencier
                    
  7.     {
  8.         $serializer = $redis->getOption(\Redis::OPT_SERIALIZER);
  9.         if (\is_array($serializer)) {
  10.             foreach ($serializer as &$v) {
  11.                 if (isset(self::$serializer[$v])) {
in src/Symfony/Component/VarDumper/Caster/SymfonyCaster.php, line 58 
  1.         }
  3.         return $a;
  4.     }
  6.     public static function castHttpClientResponse($response, array $a, Stub $stub, bool $isNested)
    The parameter response, which is an object, should be typehinted.
    Time to fix: about 1 hour
    
                Open Issue
             Permalink
    
                                    Last edited  by Alexander M. Turek
                    
  7.     {
  8.         $stub->cut += \count($a);
  9.         $a = [];
  11.         foreach ($response->getInfo() as $k => $v) {

Booleans and null should be compared strictly

More information: https://insight.symfony.com/what-we-analyse/php.strict_boolean_comparison_should_be_used

in src/Symfony/Component/ErrorHandler/DebugClassLoader.php, line 493 
  1.                         if ($static ? $hasStaticCall : $hasCall) {
  2.                             continue;
  3.                         }
  4.                         $realName = substr($name, 0, strpos($name, '('));
  5.                         if (!$refl->hasMethod($realName) || !($methodRefl = $refl->getMethod($realName))->isPublic() || ($static && !$methodRefl->isStatic()) || (!$static && $methodRefl->isStatic())) {
  6.                             $deprecations[] = sprintf('Class "%s" should implement method "%s::%s"%s', $className, ($static ? 'static ' : '').$interface, $name, null == $description ? '.' : ': '.$description);
    With booleans and null, only strict comparison (with === operator) should be used to lower bug risks and to improve performances.
    Time to fix: about 15 minutes
    
                Open Issue
             Permalink
    
                                    Last edited  by Nicolas Grekas
                    
  7.                         }
  8.                     }
  9.                 }
  10.             }
  11.         }