Source code should not contain TODO comments 15

More information: https://insight.symfony.com/what-we-analyse/task_todo_comment

  1. * @codeCoverageIgnore
  2. */
  3. class ConfigFactory
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var string
  8. */
  9. private static $path = __DIR__ . '/../../../config/parameters.yml';
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:03:02 GMT
  1. use GuzzleHttp\ClientInterface;
  2. /**
  3. * Build client
  4. *
  5. * @todo simplify factory

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  6. *
  7. * @codeCoverageIgnore
  8. */
  9. class ClientFactory
  10. {
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:13 GMT
  1. * @codeCoverageIgnore
  2. */
  3. class ClientFactory
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var string
  8. */
  9. private static $configSection = 'http_client_place';
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:19 GMT
  1. * @codeCoverageIgnore
  2. */
  3. class ServiceProvider implements ServiceProviderInterface, BootableProviderInterface
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var string
  8. */
  9. private static $configPath = __DIR__ . '/../../../config/services.yml';
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:02:43 GMT
  1. * Crawler
  2. */
  3. class Crawler implements CrawlerInterface
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var string
  8. */
  9. private static $successStatus = 'OK';
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:28 GMT
  1. use Picamator\PlaceSearchApi\Model\Api\Service\SchemaCollectionFactoryInterface;
  2. /**
  3. * Create Schema collection
  4. *
  5. * @todo move schema to configuration

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  6. * @todo create abstraction for building collection
  7. */
  8. class SchemaCollectionFactory implements SchemaCollectionFactoryInterface
  9. {
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:32 GMT
  1. /**
  2. * Create Schema collection
  3. *
  4. * @todo move schema to configuration
  5. * @todo create abstraction for building collection

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  6. */
  7. class SchemaCollectionFactory implements SchemaCollectionFactoryInterface
  8. {
  9. /**
  10. * @todo use private constant ofter migration to PHP7.1
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:35 GMT
  1. * @todo create abstraction for building collection
  2. */
  3. class SchemaCollectionFactory implements SchemaCollectionFactoryInterface
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var array
  8. */
  9. static private $schema = [
  10. [
  11. 'source' => 'id',
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:38 GMT
in src/Model/Mapper.php, line 15
  1. use Picamator\PlaceSearchApi\Model\Exception\RuntimeException;
  2. class Mapper implements MapperInterface
  3. {
  4. /**
  5. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  6. * @var string
  7. */
  8. private static $sourceSeparator = '.';
  9. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:42 GMT
  1. * Builder for Location value object
  2. */
  3. class LocationBuilder implements LocationBuilderInterface
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var int
  8. */
  9. private static $scale = 6;
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:44 GMT
  1. * @codeCoverageIgnore
  2. */
  3. class PlaceCollectionBuilder implements PlaceCollectionBuilderInterface
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var string
  8. */
  9. private static $type = 'Picamator\PlaceSearchApi\Model\Api\Data\PlaceInterface';
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:47 GMT
  1. * @codeCoverageIgnore
  2. */
  3. class SchemaCollectionBuilder implements SchemaCollectionBuilderInterface
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var string
  8. */
  9. private static $type = 'Picamator\PlaceSearchApi\Model\Api\Data\SchemaInterface';
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:50 GMT
  1. * Empty handler as a default way to proceed query
  2. */
  3. class EmptyData extends AbstractHandler
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var string
  8. */
  9. private static $type = 'Picamator\PlaceSearchApi\Model\Api\Data\EmptyData';
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:53 GMT
  1. * @codeCoverageIgnore
  2. */
  3. class ErrorBuilder implements ErrorBuilderInterface
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var array
  8. */
  9. private static $defaultData = [
  10. 'msg' => 'Undefined Application Error',
  11. 'code' => 500
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:55 GMT
  1. * @codeCoverageIgnore
  2. */
  3. class ErrorCollectionBuilder implements ErrorCollectionBuilderInterface
  4. {
  5. /**
  6. * @todo use private constant ofter migration to PHP7.1

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. * @var string
  8. */
  9. private static $type = 'Picamator\PlaceSearchApi\Search\Api\Data\ErrorInterface';
  10. /**
  • picamator

    Ignored on Mon, 31 Oct 2016 22:07:58 GMT

User specific files should not appear in .gitignore 2

More information: https://insight.symfony.com/what-we-analyse/git.user_specific_ignored_file

in .gitignore, line 2
  1. vendor/
  2. .idea/

    .idea/ is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  3. nbproject/
  4. .settings/
  5. .buildpath
  6. .project
  7. *.*~
  • picamator

    Ignored on Mon, 31 Oct 2016 22:08:05 GMT
in .gitignore, line 3
  1. vendor/
  2. .idea/
  3. nbproject/

    nbproject/ is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  4. .settings/
  5. .buildpath
  6. .project
  7. *.*~
  • picamator

    Ignored on Mon, 31 Oct 2016 22:08:10 GMT

Unused method, property, variable or parameter 5

More information: https://insight.symfony.com/what-we-analyse/php.unused_local_variable_or_private_member

  1. * @param Request $request
  2. * @param Application $app
  3. *
  4. * @return JsonResponse
  5. */
  6. public function getNotImplemented(Request $request, Application $app)

    This request argument is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. {
  8. /** @var \Picamator\PlaceSearchApi\App\Service\Error\NotImplementedService $service */
  9. $service = $app['di']->get('app_error_not_implemented_service');
  10. $response = $service->execute();
  • picamator

    Ignored on Mon, 31 Oct 2016 22:08:27 GMT
  1. * @param Request $request
  2. * @param Application $app
  3. *
  4. * @return JsonResponse
  5. */
  6. public function getNotFound(Request $request, Application $app)

    This request argument is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. {
  8. /** @var \Picamator\PlaceSearchApi\App\Service\Error\NotFoundService $service */
  9. $service = $app['di']->get('app_error_not_found_service');
  10. $response = $service->execute();
  • picamator

    Ignored on Mon, 31 Oct 2016 22:08:39 GMT
  1. * @param Request $request
  2. * @param Application $app
  3. *
  4. * @return JsonResponse
  5. */
  6. public function getInternalServer(Request $request, Application $app)

    This request argument is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. {
  8. /** @var \Picamator\PlaceSearchApi\App\Service\Error\InternalServerService $service */
  9. $service = $app['di']->get('app_internal_server_service');
  10. $response = $service->execute();
  • picamator

    Ignored on Mon, 31 Oct 2016 22:08:45 GMT
  1. * @param Request $request
  2. * @param Application $app
  3. *
  4. * @return JsonResponse
  5. */
  6. public function index(Request $request, Application $app)

    This app argument is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. {
  8. $message = <<<'EOD'
  9. <!DOCTYPE html>
  10. <html>
  11. <head>
  • picamator

    Ignored on Mon, 31 Oct 2016 22:08:51 GMT
  1. * @param Request $request
  2. * @param Application $app
  3. *
  4. * @return JsonResponse
  5. */
  6. public function index(Request $request, Application $app)

    This request argument is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sergii Pryz
  7. {
  8. $message = <<<'EOD'
  9. <!DOCTYPE html>
  10. <html>
  11. <head>
  • picamator

    Ignored on Mon, 31 Oct 2016 22:08:54 GMT