The Symfony Dependency Injection Container should not be passed as an argument

More information: https://insight.symfony.com/what-we-analyse/symfony.dependency_injection.no_container_as_parameter

  1. class ParameterRetriever
  2. {
  3. private $container;
  4. private $parameterMap;
  5. public function __construct(ContainerInterface $container, array $parameterMap)

    A Symfony dependency injection container has been found as an argument.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Christophe Coevoet
  6. {
  7. $this->container = $container;
  8. $this->parameterMap = $parameterMap;
  9. }

Source code should not contain TODO comments 2

More information: https://insight.symfony.com/what-we-analyse/task_todo_comment

  1. foreach ($container->getParameter('incenteev_dynamic_parameters.parameters') as $name => $paramConfig) {
  2. $function = $paramConfig['yaml'] ? 'dynamic_yaml_parameter' : 'dynamic_parameter';
  3. $this->parameterExpressions[$name] = sprintf('%s(%s, %s)', $function, var_export($name, true), var_export($paramConfig['variable'], true));
  4. }
  5. // TODO handle parameters concatenating another parameter with something else

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Christophe Coevoet
  6. $this->visitedDefinitions = new \SplObjectStorage();
  7. foreach ($container->getDefinitions() as $definition) {
  8. $this->updateDefinitionArguments($definition);
  1. }
  2. continue;
  3. }
  4. // TODO handle arguments concatenating a parameter with something else

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Christophe Coevoet
  5. }
  6. return $values;
  7. }
  8. }

Version of dependencies should be fixed

More information: https://insight.symfony.com/what-we-analyse/composer.unfixed_dependency_version

Package symfony/dependency-injection#^2.6.2@dev is not fixed.

Time to fix: about 1 hour
Open Issue Permalink
Collective