Files should not be executable

More information: https://insight.symfony.com/what-we-analyse/php.too_permissive_file_permissions

Your project contains files with permissive permissions. In order to avoid opening a security breach, you should restrict execution rights on following files:

  • CHANGELOG.md
  • CONTRIBUTING.md

Time to fix: about 15 minutes
Open Issue Permalink
Collective
chmod a-x 'CHANGELOG.md' \
    'CONTRIBUTING.md'

Interfaces names should end with "Interface" 4

More information: https://insight.symfony.com/what-we-analyse/php.interface_has_no_interface_suffix

  1. <?php
  2. namespace NotificationChannels\HipChat;
  3. interface CardAttributeStyles

    Interface CardAttributeStyles should be named CardAttributeStylesInterface for better clarity.

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Peter Matseykanets
  4. {
  5. const SUCCESS = 'lozenge-success';
  6. const ERROR = 'lozenge-error';
  7. const CURRENT = 'lozenge-current';
  8. const COMPLETE = 'lozenge-complete';
in src/CardFormats.php, line 5
  1. <?php
  2. namespace NotificationChannels\HipChat;
  3. interface CardFormats

    Interface CardFormats should be named CardFormatsInterface for better clarity.

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Peter Matseykanets
  4. {
  5. const MEDIUM = 'medium';
  6. const COMPACT = 'compact';
  7. }
in src/CardStyles.php, line 5
  1. <?php
  2. namespace NotificationChannels\HipChat;
  3. interface CardStyles

    Interface CardStyles should be named CardStylesInterface for better clarity.

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Peter Matseykanets
  4. {
  5. const APPLICATION = 'application';
  6. const FILE = 'file';
  7. const IMAGE = 'image';
  8. const LINK = 'link';
  1. <?php
  2. namespace NotificationChannels\HipChat;
  3. interface MessageColors

    Interface MessageColors should be named MessageColorsInterface for better clarity.

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Peter Matseykanets
  4. {
  5. const YELLOW = 'yellow';
  6. const GREEN = 'green';
  7. const RED = 'red';
  8. const PURPLE = 'purple';